16:00:13 <achow101> #startmeeting 
16:00:13 <corebot> achow101: Meeting started at 2025-04-17T16:00+0000
16:00:14 <corebot> achow101: Current chairs: achow101
16:00:15 <corebot> achow101: Useful commands: #action #info #idea #link #topic #motion #vote #close #endmeeting
16:00:16 <corebot> achow101: See also: https://hcoop-meetbot.readthedocs.io/en/stable/
16:00:17 <corebot> achow101: Participants should now identify themselves with '#here' or with an alias like '#here FirstLast'
16:00:21 <rkrux> hi
16:00:28 <achow101> #bitcoin -core-dev Meeting: abubakarsadiq achow101 _aj_ ajonas b10c brunoerg cfields darosior dergoegge fanquake fjahr furszy gleb glozow hebasto instagibbs jarolrod jonatack josibake kanzure laanwj LarryRuane lightlike luke-jr maflcko marcofleon maxedw Murch pinheadmz provoostenator ryanofsky sdaftuar S3RK stickies-v sipa sr_gi tdb3 theStack TheCharlatan vasild willcl-ark
16:00:29 <darosior> hi
16:00:31 <instagibbs> hi
16:00:31 <hebasto> hi
16:00:32 <furszy> hi
16:00:32 <Murch[m]> Hi
16:00:33 <TheCharlatan> hi
16:00:34 <lightlike> hi
16:00:40 <abubakarsadiq> hi
16:00:41 <stickies-v> hi
16:00:42 <sipa> hi
16:00:52 <achow101> There are no pre-proposed meeting topics this week. Any last minute ones to add?
16:00:52 <glozow> hi
16:01:04 <jimhashhq> hi
16:02:03 <achow101> #topic Kernel WG Update (TheCharlatan)
16:02:19 <TheCharlatan> Still looking for review on #31382 and hunting Approach ACKs on #30595
16:02:21 <corebot> https://github.com/bitcoin/bitcoin/issues/31382 | kernel: Flush in ChainstateManager destructor by TheCharlatan · Pull Request #31382 · bitcoin/bitcoin · GitHub
16:02:23 <corebot> https://github.com/bitcoin/bitcoin/issues/30595 | kernel: Introduce initial C header API by TheCharlatan · Pull Request #30595 · bitcoin/bitcoin · GitHub
16:02:25 <TheCharlatan> That's all
16:02:38 <achow101> #topic Cluster Mempool WG Update (sdaftuar, sipa)
16:03:09 <sipa> Hi!
16:03:27 <sr_gi[m]> hi
16:03:47 <sipa> Not too much to report, #31444 remains next to review, which will also be next week's review club (thanks glozow)
16:03:51 <corebot> https://github.com/bitcoin/bitcoin/issues/31444 | cluster mempool: add txgraph diagrams/mining/eviction by sipa · Pull Request #31444 · bitcoin/bitcoin · GitHub
16:04:12 <glozow> pls come to review club!
16:04:32 <sipa> Suhas is running benchmarks on historical mempool replay data to see if the spanning-forest algorithm could reasonably be a drop-in replacement for the current code
16:05:32 <sipa> It seems very fast on realistic clusters (20-30 us for linearizing optimally anything up to 64 transactions, with some variance), though the worst case is likely a lot worse, but it can probably run just until time runs out and get something acceptable.
16:05:33 <instagibbs> cool!
16:06:34 <sipa> The min-cut algorithm (from the 1989) has a cubic worst-case complexity, but seems somewhat slower than spanning forest in practice (2-3x), and extrapolating suggests its worst-case runtime is in the 5-10ms range, which is too slow to run at relay time anyway.
16:06:55 <sipa> +paper
16:07:20 <glozow> very cool
16:07:21 <sipa> Also, it's less practical as it can't be bootstrapped from an existing linearization to improve, and it's harder to just stop arbitrarily and get something reasonable out.
16:07:38 <sipa> (which spanning-forest can)
16:08:12 <sipa> That's it for me.
16:08:33 <achow101> #topic Erlay WG Update (sr_gi, gleb, marcofleon)
16:08:51 <sr_gi[m]> I finished re-writing the functional tests for the full-erlay implementation and CI is green both for it (#30277) and also the current PR to review (#30116). Some additional functional tests may come later, but for now at least we can make sure the Erlay flow is working as expected.
16:08:53 <corebot> https://github.com/bitcoin/bitcoin/issues/30277 | [DO NOT MERGE] Erlay: bandwidth-efficient transaction relay protocol (Full implementation) by sr-gi · Pull Request #30277 · bitcoin/bitcoin · GitHub
16:08:54 <corebot> https://github.com/bitcoin/bitcoin/issues/30116 | p2p: Fill reconciliation sets (Erlay) attempt 2 by sr-gi · Pull Request #30116 · bitcoin/bitcoin · GitHub
16:09:20 <sr_gi[m]> I'm currently setting up Warnet to confirm the simulated results with real nodes. I’ll be reporting on the findings in the upcoming weeks. For people interested, you can take a look at the PR to review (#30116), which is taking care of selecting what peers to fanout or reconcile transactions with, and storing them in the right sets (no networking). You can also compile a full-erlay enabled node with the code in (#30277)) if you’re
16:09:20 <sr_gi[m]> curious or you’’d like to try running that in the wild, though that is missing more extensive review.
16:09:22 <corebot> https://github.com/bitcoin/bitcoin/issues/30116 | p2p: Fill reconciliation sets (Erlay) attempt 2 by sr-gi · Pull Request #30116 · bitcoin/bitcoin · GitHub
16:09:23 <corebot> https://github.com/bitcoin/bitcoin/issues/30277 | [DO NOT MERGE] Erlay: bandwidth-efficient transaction relay protocol (Full implementation) by sr-gi · Pull Request #30277 · bitcoin/bitcoin · GitHub
16:09:48 <sr_gi[m]> That’s it for me
16:10:01 <achow101> #topic MuSig2 WG Update (achow101, rkrux)
16:10:10 <achow101> PRs have been rebased and review comments addressed. The PRs to review are #31243 and #31622
16:10:16 <corebot> achow101: Error: That URL raised <Connection timed out.>
16:10:20 <corebot> https://github.com/bitcoin/bitcoin/issues/31622 | psbt: add non-default sighash types to PSBTs and unify sighash type match checking by achow101 · Pull Request #31622 · bitcoin/bitcoin · GitHub
16:10:27 <achow101> #topic Legacy Wallet Removal WG Update (achow101, furszy)
16:10:41 <achow101> PRs have been rebased and review comments addressed. The issue with accidentally creating legacy-sqlite wallets has been resolved.
16:11:07 <achow101> The current PR to review is #31250.
16:11:09 <corebot> https://github.com/bitcoin/bitcoin/issues/31250 | wallet: Disable creating and loading legacy wallets by achow101 · Pull Request #31250 · bitcoin/bitcoin · GitHub
16:11:23 <achow101> #topic orphan resolution WG Update (glozow)
16:11:59 <glozow> I'm just about done with TxOrphanage rewrite as multi index container + new eviction algorithm. I think it'll actually be more intuitive for reviewers than the current implementation, and my plan is to introduce txorphanage_impl.h, hook it up to all the existing txorphanage tests, and then change TxOrphanage to be a wrapper for TxOrphanageImpl. Still have more tests I want to write though. Hopefully something up soon.
16:12:45 <glozow> Also have a list of potential extra things and I'm not sure if they're worth doing immediately
16:12:54 <glozow> That's all
16:13:10 <sipa> So with that you'd be able to just replace the TxOrphanage implementation, and the tests keep working?
16:14:10 <glozow> Yeah pretty much, with a few modifications
16:14:40 <glozow> For example, current situation has some randomization, but it'll become deterministic with the new algo
16:15:05 <sipa> Right.
16:16:00 <glozow> I think this could be easier to review than requiring people to learn the old TxOrphanage (which is kind of convoluted) and then compare it with the new one
16:17:47 <stickies-v> very excited to see the rewrite, agreed that the old one was pretty tricky to review
16:17:55 <achow101> Any other topics to discuss?
16:18:17 <glozow> I figured out how to templatize boost unit tests, so I can run the same test on <TxOrphanage> and <TxOrphanageImpl>, it's kinda cool
16:18:24 <glozow> v29.0 is out!
16:19:08 <achow101> \o/
16:19:37 <glozow> must be time for 28.2
16:19:54 <achow101> #endmeeting