16:00:51 <achow101> #startmeeting 
16:00:51 <corebot> achow101: Meeting started at 2025-02-13T16:00+0000
16:00:52 <corebot> achow101: Current chairs: achow101
16:00:53 <corebot> achow101: Useful commands: #action #info #idea #link #topic #motion #vote #close #endmeeting
16:00:54 <corebot> achow101: See also: https://hcoop-meetbot.readthedocs.io/en/stable/
16:00:55 <darosior> hi
16:00:56 <corebot> achow101: Participants should now identify themselves with '#here' or with an alias like '#here FirstLast'
16:00:58 <glozow> hi
16:01:00 <pinheadmz> yo
16:01:00 <brunoerg> hi
16:01:06 <sr_gi[m]> hi
16:01:10 <b10c> hi
16:01:12 <jarolrod> hi
16:01:12 <achow101> #bitcoin -core-dev Meeting: abubakarsadiq achow101 _aj_ ajonas b10c brunoerg cfields darosior dergoegge fanquake fjahr furszy gleb glozow hebasto instagibbs jarolrod jonatack josibake kanzure laanwj LarryRuane lightlike luke-jr maflcko marcofleon maxedw Murch pinheadmz provoostenator ryanofsky sdaftuar S3RK stickies-v sipa sr_gi tdb3 theStack TheCharlatan vasild willcl-ark
16:01:14 <stickies-v> hi
16:01:15 <darosior> #here achow101
16:01:18 <TheCharlatan> hi
16:01:21 <furszy> hi
16:01:26 <sipa> hi
16:01:44 <achow101> There are 2 preproposed meeting topics this week. Any last minute ones to add?
16:01:45 <marcofleon> hi
16:02:19 <achow101> #topic Erlay WG Update (sr_gi, gleb, marcofleon)
16:02:38 <hebasto> hi
16:02:43 <sr_gi[m]> No meaningful update on my end, still reworking some parts of the simulator to run the last batch of planned experiments
16:03:10 <achow101> #topic Kernel WG Update (TheCharlatan)
16:03:29 <cfields> hi
16:03:36 <marcofleon> quick update from me is that Gleb rebased the full implementation, so I'm working with that and cleaning it up a bit and writing/improving fuzz tests for erlay
16:03:59 <lightlike> hi
16:04:10 <theStack> hi
16:04:31 <Murch[m]> hi
16:05:03 <TheCharlatan> we've been spending some time on API ergonomics, but no big chances to report back on yet.
16:05:34 <TheCharlatan> *changes :P
16:05:36 <TheCharlatan> that's all
16:05:39 <achow101> #topic Cluster Mempool WG Update (sdaftuar, sipa)
16:06:20 <sipa> getting some reviews on #31363, addressing it
16:06:24 <corebot> https://github.com/bitcoin/bitcoin/issues/31363 | cluster mempool: introduce TxGraph by sipa · Pull Request #31363 · bitcoin/bitcoin · GitHub
16:06:37 <sipa> not much else to report, i think
16:07:05 <sipa> it looks like an O(n^3) optimal linearization algorithm may be reasonable, needs experimenting
16:07:33 <sipa> but that's not for the short term
16:08:14 <achow101> #topic MuSig2 WG Update (achow101)
16:08:17 <sipa> i know sdaftuar is working on improving his #28676, by rebasing on the txgraph PRs are they get improved too, but unsure of the status there
16:08:19 <sipa> that's it for me
16:08:19 <corebot> https://github.com/bitcoin/bitcoin/issues/28676 | [WIP] Cluster mempool implementation by sdaftuar · Pull Request #28676 · bitcoin/bitcoin · GitHub
16:08:40 <achow101> I finally got around to writing test vectors for BIP 373. The test vectors are added to the bip in bips#1764, and I've updated #31247 with them as well.
16:08:42 <corebot> https://github.com/bitcoin/bitcoin/issues/31247 | psbt: MuSig2 Fields by achow101 · Pull Request #31247 · bitcoin/bitcoin · GitHub
16:08:43 <corebot> https://github.com/bitcoin/bips/issues/1764 | 373: test vectors and reference implementation by achow101 · Pull Request #1764 · bitcoin/bips · GitHub
16:08:55 <achow101> I've also rebased all of the PRs.
16:09:25 <achow101> #31622 has been getting lots of review as well
16:09:28 <corebot> https://github.com/bitcoin/bitcoin/issues/31622 | psbt: add non-default sighash types to PSBTs and unify sighash type match checking by achow101 · Pull Request #31622 · bitcoin/bitcoin · GitHub
16:09:45 <cfields> Is 28676 in a state to be tested/reviewed some? Or is that considered to be in major flux?
16:10:32 <sipa> cfields: i'd wait for the next push
16:10:42 <cfields> 👍
16:10:42 <achow101> #topic Legacy Wallet Removal WG Update (achow101)
16:10:50 <Sjors[m]> hi
16:10:59 <achow101> #31495 has been getting lots of review. It seems close to being rfm.
16:11:03 <corebot> https://github.com/bitcoin/bitcoin/issues/31495 | wallet: Utilize IsMine() and CanProvide() in migration to cover edge cases by achow101 · Pull Request #31495 · bitcoin/bitcoin · GitHub
16:11:08 <achow101> #31250 is also ready to be reviewed, and can be done in parallel to #31495. It disables and disallows legacy wallets but does not delete the code yet, so it would be nice to get this in for 29.0.
16:11:11 <corebot> https://github.com/bitcoin/bitcoin/issues/31250 | wallet: Disable creating and loading legacy wallets by achow101 · Pull Request #31250 · bitcoin/bitcoin · GitHub
16:11:12 <corebot> https://github.com/bitcoin/bitcoin/issues/31495 | wallet: Utilize IsMine() and CanProvide() in migration to cover edge cases by achow101 · Pull Request #31495 · bitcoin/bitcoin · GitHub
16:11:54 <achow101> #topic orphan resolution WG Update (glozow)
16:12:07 <glozow> I opened #31829 for improving the orphanage dos limits, gunning for v29. It's getting good review and tests (thank you!).
16:12:13 <corebot> https://github.com/bitcoin/bitcoin/issues/31829 | p2p: improve TxOrphanage denial of service bounds and increase -maxorphantxs by glozow · Pull Request #31829 · bitcoin/bitcoin · GitHub
16:13:17 <glozow> Hoping for 1-2 more reviewers, I think it's important to get these protections in
16:13:44 <glozow> That's all from me
16:14:00 <achow101> #topic Stratum v2 WG Update (sjors)
16:14:09 <Sjors[m]> #31283 and #31785 are hopefully the last remaining interface changes that are needed for the Template Provider. They're getting good review, but can use extra eyes to get them over the finish line.
16:14:14 <corebot> https://github.com/bitcoin/bitcoin/issues/31283 | Add waitNext() to BlockTemplate interface by Sjors · Pull Request #31283 · bitcoin/bitcoin · GitHub
16:14:16 <corebot> https://github.com/bitcoin/bitcoin/issues/31785 | Have createNewBlock() wait for tip, make rpc handle shutdown during long poll and wait methods by Sjors · Pull Request #31785 · bitcoin/bitcoin · GitHub
16:14:18 <Sjors[m]> On the multiprocess front, #31741 is the place to be I think.
16:14:21 <corebot> https://github.com/bitcoin/bitcoin/issues/31741 | multiprocess: Add libmultiprocess git subtree by ryanofsky · Pull Request #31741 · bitcoin/bitcoin · GitHub
16:14:47 <Sjors[m]> I recently shipped IPC-enabled binaries for the Template Provider
16:15:12 <Sjors[m]> https://github.com/Sjors/bitcoin/releases/tag/sv2-tp-0.1.14-ipc
16:15:49 <Sjors[m]> If you want to test those, see https://stratumprotocol.org/getting-started/ but use bitcoin-node and bitcoin-mine instead of bitcoind
16:16:40 <Sjors[m]> (or you could try a guix build and see if you get the same hashes)
16:16:46 <Sjors[m]> That's all from my end.
16:16:54 <achow101> #topic QML GUI Working Group (jarolrod)
16:17:02 <jarolrod> I announce it before here on IRC, but wanted to do it in the meeting for visibility
16:17:11 <achow101> jarolrod: would you like to be added to the list for weekly updates?
16:17:19 <jarolrod> ^ yes
16:17:23 <jarolrod> I want to announce the creation of a working group for the QML GUI to:
16:17:32 <jarolrod> - Broadcast status updates to core devs who are interested in the progress of the work.
16:17:41 <jarolrod> - Serve as a place to discuss adjacent work like, QT6 migration, an effective wallet interface for the GUI, what role the QML GUI can play within the multiprocess work, and a redesign for bitcoincore.org (https://youtu.be/e2m1iEWJplM)
16:17:53 <jarolrod> - Serve as a place where core devs can hear from and interface with the Bitcoin Design Community, who’s been at the heart of a lot of the work
16:18:16 <jarolrod> and again, if you’d like to be added to the group please DM me here on IRC, over Signal, Twitter, TikTok, wherever you can find me. I have a preference for TikTok reaction videos please
16:18:28 <achow101> lol
16:18:43 <jarolrod> also johnny9dev584508 is here, although he really needs to update his username
16:18:53 <achow101> do you have an initial update to give?
16:19:12 <jarolrod> no initial update this week, for the next one yes
16:19:35 <cfields> jarolrod: thanks for updating us here, that'll be really useful.
16:19:48 <achow101> ok
16:19:56 <jarolrod> 🫂
16:19:57 <glozow> thanks jarolrod
16:20:00 <achow101> #topic Kill-Shill-Merge for v29.0 Milestone, on a jitsi call right after the IRC meeting (glozow)
16:20:17 <glozow> We are 1 week away from feature freeze, 3 weeks from branch-off. We have 28 open PRs on the milestone https://github.com/bitcoin/bitcoin/milestone/69. It seems realistic, but I think we should try to coordinate review a litle bit.
16:20:26 <achow101> I guess we can talk 29.0 release priorities in this topic as well.
16:20:41 <glozow> I think the most efficient way to do this is get on a jitsi, I'll share screen, we go through the PRs + find volunteers to review them, similar to our kill-shill-merge sessions. This doesn't guarantee we'll get them all done but I don't want to just wait around hoping that review will come.
16:20:45 <glozow> Yeah
16:20:48 <Sjors[m]> By "kill" you just mean dropping off of the milestone?
16:20:50 <glozow> First, anything to add to the milestone?
16:20:51 <lightlike> looks like 90% build system PRs
16:20:52 <glozow> Sjors: yes
16:20:55 <fanquake> I don't think there's anything mergable, maybe a couple that can be dropped, but most of what's on there really need to go in
16:21:17 <fanquake> Lots of fixes for things post-cmake etc
16:21:30 <glozow> fanquake: right
16:21:37 <fanquake> coverage still needs to be overhauled from gcc to llvm, it'd be good to get that sorted
16:22:03 <fanquake> I guess some wallet bugs now too, not sure if they are blockers
16:22:11 <cfields> ok, so maybe more about getting people to commit to priority review?
16:22:20 <fanquake> + the newest orpahange changes
16:22:42 <hebasto> it will be useful if someone confirms llvm-based coverage correctness first
16:23:26 <achow101> glozow: immediately after the meeting ends or at the hour when it nominally ends?
16:23:35 <darosior> Would just basic testing of the build system PRs be helpful? I don't think i'm really able to do more than that.
16:23:43 <glozow> achow101: immediately after the meeting ends, no reason to delay imo
16:23:57 <darosior> hebasto: ok i can do that, i've had my manual setup for a while.
16:23:58 <cfields> kernel wg will shift to jitsi today instead 🫡
16:24:11 <glozow> I hope folks are available? I'll set up a call link rn
16:24:14 <hebasto> darosior: thanks
16:24:17 <sipa> happy to join
16:24:33 <achow101> me too
16:24:36 <glozow> everyone who's here please do join
16:24:56 <glozow> authors of milestone PRs list fanquake glozow darosior hebasto achow101 maflcko lightlike jimhashhq stickies-v theuni sipa
16:25:16 <willcl-ark> hi
16:25:33 <stickies-v> wait what i don't even have a PR open
16:25:37 <stickies-v> (but yes i'm joining)
16:25:39 <achow101> Any other topics to discuss right now
16:25:46 <sipa> stickies-v: better open one quickly!
16:26:05 <achow101> stickies-v: you have an issue open though
16:26:13 <cfields> lol, incoming python kernel api for v29
16:26:26 <stickies-v> now that i can get behind
16:26:43 <TheCharlatan> :D
16:26:51 <glozow> stickies-v: ah it's #31762
16:26:52 <corebot> https://github.com/bitcoin/bitcoin/issues/31762 | build: cmake installs empty manpages for non-configured targets · Issue #31762 · bitcoin/bitcoin · GitHub
16:27:33 <stickies-v> right, thank you!
16:27:36 <achow101> #endmeeting