14:00:20 <achow101> #startmeeting 14:00:23 <tdb3> hi 14:00:26 <abubakarsadiq> hi 14:00:26 <josie> hi 14:00:28 <achow101> #bitcoin -core-dev Meeting: abubakarsadiq achow101 _aj_ ajonas b10c brunoerg cfields darosior dergoegge fanquake fjahr furszy gleb glozow hebasto instagibbs jarolrod jonatack josibake kanzure laanwj LarryRuane lightlike luke-jr maflcko maxedw Murch pinheadmz provoostenator ryanofsky sdaftuar S3RK stickies-v sipa sr_gi tdb3 theStack TheCharlatan vasild willcl-ark 14:00:29 <sipa> hi 14:00:32 <sliv3r__> hi 14:00:32 <theStack> hi 14:00:33 <TheCharlatan> hi 14:00:36 <vasild> hi 14:00:40 <b10c> hi 14:00:43 <kevkevin> hi 14:00:46 <sdaftuar> hi 14:00:47 <willcl-ark> hi 14:00:53 <achow101> There are no pre-proposed meeting topics this week. Any last minute ones to add? 14:01:03 <gleb> Hi 14:01:03 <BlueMatt[m]> Is Sjors here? 14:01:07 <maxedw> hi 14:01:17 <kevkevin> hi 14:01:32 <achow101> BlueMatt[m]: doesn't seem like it yet 14:01:56 <brunoerg> hi 14:02:12 <achow101> #topic Erlay WG Update (sr_gi, gleb, marcofleon) 14:02:24 <stickies-v> hi 14:02:46 <gleb> On erlay side I guess thatâÂÂs me 14:03:24 <kanzure> hi 14:03:31 <gleb> WeâÂÂre having some productive discussions on moving forward in the WG chat, especially how to think of spy nodes; and how to think of the efficiency 14:04:09 <gleb> In-pr sergi is reviewing a lot of my comments. I know several contributors are waiting for that to resolve first 14:04:40 <gleb> IâÂÂm spinning up test nodes for others to connect to. Thinking Warnet or not 14:04:45 <gleb> ThatâÂÂs it! 14:05:01 <achow101> #topic Kernel WG Update (TheCharlatan) 14:05:05 <josie> gleb: feel free to reach out if you want a warnet onboarding / crash course 14:05:10 <TheCharlatan> Nothing new today, thank you for the quick reviews on #31269 14:05:14 <gribble> https://github.com/bitcoin/bitcoin/issues/31269 | validation: Remove RECENT_CONSENSUS_CHANGE validation result by TheCharlatan ÷ Pull Request #31269 ÷ bitcoin/bitcoin ÷ GitHub 14:05:29 <achow101> #topic Benchmarking WG Update (josie, l0rinc) 14:05:33 <josie> made progress on getting a mainnet assumeutxo bench running automatically when a PR is opened. the benchmark now automatically does benchcoin master vs PR branch (h/t willcl-ark) 14:05:40 <josie> the final results are published to a github page, with flamegraphs included (h/t davidgumberg) 14:05:45 <josie> Novo___ and i will be using the new setup this next week to investigate the batch validatoin PR 14:05:51 <josie> we are also at the stage where having extra dedicated runners would be helpful. was planning to purchase some more hetzner boxes and add them, but a few people mentioned having some resources that could be used for this, planning to follow up on that this week 14:06:01 <josie> thats all! 14:06:06 <achow101> #topic Silent Payments WG Update (josie, RubenSomsen) 14:06:09 <josie> slow and steady, working through all the feedback on the libsecp256k1 module 14:06:15 <josie> i do remember on the musig2 PR, there was a suggestion on how we type arrays of unsigned char where it is expected to be an exact size. it seemed doing this could be useful for languages like rust, when generating bindings automatically? 14:06:23 <josie> planning to follow up with the secp256k1 maintainers to see if this is worth doing for the silent payments module (perhaps a topic for the upcoming secp256k1 meeting this coming monday?) 14:06:39 <josie> thats all! 14:06:41 <sipa> josie: yeah, definitely worth bringing up 14:06:50 <achow101> #topic Cluster Mempool WG Update (sdaftuar, sipa) 14:07:14 <sdaftuar> hi, #31122 is still the PR to review. it seems to be getting close. 14:07:14 <josie> sipa: will do! 14:07:18 <gribble> https://github.com/bitcoin/bitcoin/issues/31122 | cluster mempool: Implement changeset interface for mempool by sdaftuar ÷ Pull Request #31122 ÷ bitcoin/bitcoin ÷ GitHub 14:07:48 <sdaftuar> i think pieter is getting closer with his txgraph implementation as well -- will let him add any additional info 14:08:00 <sipa> i'm close to opening the first txgraph PR (the middle layer between cluster linearization algorithms, and the mempool, which deals with dependencies/clusters/linearizations/proposed changes for the entire mempool) 14:08:44 <sipa> nothing else from me 14:09:31 <achow101> #topic MuSig2 WG Update (achow101) 14:09:48 <achow101> We had a discussion about breaking up #29675, so i've opened 2 refactors (#31242, #31243) and a PR for the PSBT fields (#31247) 14:09:51 <gribble> https://github.com/bitcoin/bitcoin/issues/29675 | wallet: Be able to receive and spend inputs involving MuSig2 aggregate keys by achow101 ÷ Pull Request #29675 ÷ bitcoin/bitcoin ÷ GitHub 14:09:55 <gribble> https://github.com/bitcoin/bitcoin/issues/31242 | wallet, desc spkm: Return SigningProvider only if we have the privkey by achow101 ÷ Pull Request #31242 ÷ bitcoin/bitcoin ÷ GitHub 14:09:56 <gribble> https://github.com/bitcoin/bitcoin/issues/31243 | descriptor: Move filling of keys from `DescriptorImpl::MakeScripts` to `PubkeyProvider::GetPubKey` by achow101 ÷ Pull Request #31243 ÷ bitcoin/bitcoin ÷ GitHub 14:10:00 <gribble> https://github.com/bitcoin/bitcoin/issues/31247 | psbt: MuSig2 Fields by achow101 ÷ Pull Request #31247 ÷ bitcoin/bitcoin ÷ GitHub 14:10:31 <achow101> The descriptors implementation is also in a separate draft PR ##31244, and 29675 is the final that require all of the above and adds signing 14:10:33 <gribble> https://github.com/bitcoin/bitcoin/issues/31244 | descriptors: MuSig2 by achow101 ÷ Pull Request #31244 ÷ bitcoin/bitcoin ÷ GitHub 14:10:51 <achow101> #topic Legacy Wallet Removal WG Update (achow101) 14:12:28 <achow101> Also had a discussion about breaking up #28710, so there's now the migration test rework in #31248, and #31250 has legacy wallets disabled but not removed 14:12:30 <gribble> https://github.com/bitcoin/bitcoin/issues/28710 | Remove the legacy wallet and BDB dependency by achow101 ÷ Pull Request #28710 ÷ bitcoin/bitcoin ÷ GitHub 14:12:33 <gribble> https://github.com/bitcoin/bitcoin/issues/31248 | test: Rework wallet_migration.py to use previous releases by achow101 ÷ Pull Request #31248 ÷ bitcoin/bitcoin ÷ GitHub 14:12:35 <gribble> https://github.com/bitcoin/bitcoin/issues/31250 | wallet: Disable creating and loading legacy wallets by achow101 ÷ Pull Request #31250 ÷ bitcoin/bitcoin ÷ GitHub 14:13:00 <achow101> furszy has opened #31241 as well 14:13:02 <gribble> https://github.com/bitcoin/bitcoin/issues/31241 | wallet: remove BDB dependency from wallet migration benchmark by furszy ÷ Pull Request #31241 ÷ bitcoin/bitcoin ÷ GitHub 14:13:39 <jonatack> hi 14:13:51 <achow101> that's all for working groups that i see here 14:14:04 <achow101> Anything else to discuss? 14:14:40 <instagibbs> shoutout to all the ephemeral dust review, not exactly a topic 14:15:14 <vasild> achow101: I guess that once legacy wallet is removed (in 29?) softwares that use Bitcoin Core's wallet but don't support descriptor wallets will have to stick to v28? 14:15:16 <josie> instagibbs: congrats on moving that forward! 14:15:28 <achow101> vasild: yes 14:15:39 <vasild> ok 14:16:16 <sipa> vasild, achow101: though there are some RPCs we could realistically implement for descriptor wallets which are legacy-only currently (see #30175 14:16:18 <gribble> https://github.com/bitcoin/bitcoin/issues/30175 | Enable `importprivkey`, `addmultisigaddress` in descriptor wallets ÷ Issue #30175 ÷ bitcoin/bitcoin ÷ GitHub 14:17:01 <jonatack> hi again (first one didn't seem to get through) 14:17:04 <vasild> https://github.com/JoinMarket-Org/joinmarket-clientserver/issues/1571#issuecomment-2102790757 "JoinMarket uses importmulti call, which is not available for descriptor wallets" 14:17:48 <sipa> translating importmulti is not impossible, but it'd be a nontrivial amount of work, and i don't think many things besides joinmarket use it? 14:18:03 <sipa> it'd be easier i expect to make joinmarket use importdescriptors instead 14:18:33 <achow101> presumably the problem is that they don't create descriptors 14:19:11 <vasild> I think it is possible to do custom gap limits 14:19:17 <vasild> with descriptor wallets 14:19:56 <achow101> yeah, they can do things manually with keypoolrefill 14:20:02 <achow101> i'll leave a comment on that issue 14:20:06 <laanwj> sipa: i don't think so either, joinmarket is the only common software that's stuck at pre-descriptor wallets, that i know of 14:21:28 <achow101> #endmeeting