14:00:47 <achow101> #startmeeting 14:00:53 <achow101> #bitcoin -core-dev Meeting: achow101 _aj_ amiti ariard aureleoules b10c BlueMatt brunoerg cfields darosior dergoegge dongcarl fanquake fjahr furszy gleb glozow hebasto instagibbs jamesob jarolrod jonatack josibake kallewoof kanzure kouloumos kvaciral laanwj LarryRuane lightlike luke-jr MacroFake Murch phantomcircuit pinheadmz promag provoostenator ryanofsky sdaftuar S3RK stickies-v sipa sr_gi theStack TheCharlatan vasild 14:00:57 <Sjors[m]> hi 14:00:58 <josie> hiya 14:00:59 <hebasto> hi 14:01:00 <sipa> o meeting time, hi 14:01:09 <achow101> There are no pre-proposed meeting topics this week. Any last minute ones to add? 14:01:12 <b10c> hi 14:01:17 <stickies-v> hi 14:01:18 <jonatack> hi 14:02:03 <glozow> hi 14:02:06 <emzy> hi 14:02:15 <kanzure> hi 14:02:26 <Sjors[m]> RPC gate topic? 14:02:30 <achow101> #topic Ad-hoc high priority for review 14:02:30 <achow101> Anything to add or remove from https://github.com/orgs/bitcoin/projects/1/views/4 14:03:57 <pinheadmz> Hi and 14:04:03 <achow101> Also 28.0 was tagged, please guix build 14:04:16 <pinheadmz> Shana tova 14:04:26 <sipa> guix build fails for me, something apparmor 14:04:58 <sipa> https://gist.github.com/laanwj/cddb2ec7d18e71066d21e5ee993fe971 does not help 14:04:59 <dergoegge> hi 14:05:06 <lightlike> Hi 14:05:46 <fjahr> hi 14:07:02 <achow101> #topic rpc (Sjors) 14:07:11 <Sjors[m]> sipa https://bugs.launchpad.net/ubuntu/+source/guix/+bug/2064115/comments/6 14:07:36 <Sjors[m]> (I think I did something very slighlyt different than the gist, but forgot, see that comment) 14:08:15 <sipa> i shall try 14:08:35 <Sjors[m]> From right before the meeting, we noticed that the bitcoin-rpc NPM package is broken: https://github.com/vansergen/rpc-bitcoin/pull/65 14:09:01 <abubakarsadiq> hi 14:09:11 <Sjors[m]> As an unintende side-effect of #27101 14:09:17 <gribble> https://github.com/bitcoin/bitcoin/issues/27101 | Support JSON-RPC 2.0 when requested by client by pinheadmz ÷ Pull Request #27101 ÷ bitcoin/bitcoin ÷ GitHub 14:09:36 <sipa> and apparently there are also issues due to the warnings field now being an array? 14:09:39 <Sjors[m]> The idea was the be strict about JSON RPC 2.0, but remain loose for earlier stuff. 14:10:38 <Sjors[m]> sipa: possibly, maybe that should also be 2.0 - only behavior? 14:11:02 <achow101> Since 28.0 is already tagged, any changes to these would be in a 28.1 14:11:24 <Sjors[m]> But the binaries are not release yet, so it could be 28.0.1 release. 14:12:01 <b10c> the warnings string -> array change was in #29845 14:12:04 <gribble> https://github.com/bitcoin/bitcoin/issues/29845 | rpc: return warnings as an array instead of just a single one by stickies-v ÷ Pull Request #29845 ÷ bitcoin/bitcoin ÷ GitHub 14:12:55 <achow101> Sjors[m]: x.0.1 releases have typically done for build issues and without release candidates. Fixing this problem seems like it might be involved enough to want to do at least one rc 14:12:56 <Sjors[m]> There's probably a limit to how much effort we should put into remaining backwards compatible with very old RPC clients, but these one or two things seem reasonable to fix imo. 14:13:34 <Sjors[m]> True, we could also ship 28.0 and warn people to be very careful about upgrading if they're using the RPC. 14:13:56 <achow101> the warnings string to array was done with a deprecation cycle 14:14:16 <Sjors[m]> Ok, in that case I think only the 1.0 thing should be fixed. 14:14:59 <sipa> it also means fewer things are affected? 14:15:27 <sipa> i guess we should proceed with releasing 28.0 normally, perhaps with a warning in the release notes about this issue, and then see if we get many reports 14:15:41 <achow101> We can add more to the release notes about the jsonrpc 2.0 issue 14:16:03 <Sjors[m]> So deprecatedrpc for the warning thing is now removed? 14:16:03 <achow101> actually, the warnings string to array is currently in the deprecation cycle. it's not gone yet. 14:16:05 <Chris_Stewart_5> hi 14:17:11 <jonatack> In current master I still see deprecatedrpc=warnings 14:17:14 <stickies-v> (the warnings string -> array change and -deprecatedrpc=warnings option is documented in the 28.0 release notes, btw) 14:17:17 <b10c> -deprecatedrpc=warnings should give the old behavior 14:17:28 <jonatack> so users have the option 14:18:18 <Sjors[m]> I'm trying to find out if people who run into the 1.0 issue also rely on -deprecatedrpc=warnings. 14:18:24 <achow101> we've followed our typical process for breaking rpc for that, so I think it's fine to leave alone 14:18:28 <sipa> agree 14:18:30 <Sjors[m]> Because they'll have to deal with both at some point in the near future. 14:18:33 <jonatack> Yes. It may be 14:18:46 <jonatack> good to give it a couple releases before removing, no hurry 14:18:55 <sipa> we could highlight it more in the release notes, perhaps a section in the very beginning mentioning both the jsonrpc version and warning field thing 14:20:36 <stickies-v> the warnings change is also documented in the rpc docs already, so that + existing docs in release notes probably feels like enough documentation to me? but of course no objection to mentioning it at the beginning of the release notes too 14:20:43 <achow101> sipa: ack 14:20:53 <stickies-v> the jsonrpc thing is probably a bit more obscure for users to figure out so i think highlighting that more seems sensible 14:22:16 <stickies-v> https://github.com/bitcoin/bitcoin/blob/cfb59da4b3bb34afae467691a3e901f2b5a186f3/src/rpc/net.cpp#L663-L664 14:23:20 <achow101> The release notes draft can still be edited: https://github.com/bitcoin-core/bitcoin-devwiki/wiki/28.0-Release-Notes-Draft 14:23:44 <achow101> i'll pull in any further changes to the announce pr after the binaries are uploaded (waiting for more guix builds though) 14:23:59 <achow101> and open a pr to update the in repo notes 14:24:25 <achow101> website pr: https://github.com/bitcoin-core/bitcoincore.org/pull/1067 14:25:16 <achow101> Any other topics to discuss? 14:25:26 <jonatack> achow101: wiki edits to the release notes during the day today worth making then? 14:25:36 <achow101> jonatack: yes 14:25:46 <Chris_Stewart_5> can someone merge #30982 ? we discussed last week and i've edited teh release notes to add the instructions in the PR 14:25:48 <gribble> https://github.com/bitcoin/bitcoin/issues/30982 | docs: Add instructions on how to self-sign bitcoin-core binaries for macOS by Christewart ÷ Pull Request #30982 ÷ bitcoin/bitcoin ÷ GitHub 14:25:55 <jonatack> also, i had these URLs pinned for the blockers: 14:25:58 <jonatack> https://github.com/orgs/bitcoin/projects/1/views/1 14:26:01 <jonatack> https://github.com/orgs/bitcoin/projects/5/views/1 14:26:10 <jonatack> iiuc the current URL is now 14:26:17 <jonatack> https://github.com/orgs/bitcoin/projects/1/views/4 14:26:19 <jonatack> ? 14:26:23 <achow101> Chris_Stewart_5: will look 14:26:42 <Chris_Stewart_5> :+1: 14:27:06 <achow101> jonatack: first and third links are the same project, just different views. see the tabs at the top 14:27:20 <achow101> I think the other project board (url 2) is not being used 14:27:39 <jonatack> achow101: ty 14:29:01 <achow101> #endmeeting