14:00:26 <achow101> #startmeeting 14:00:32 <TheCharlatan> hi 14:00:35 <theStack> hi 14:00:41 <fjahr> hi 14:00:45 <achow101> #bitcoin -core-dev Meeting: achow101 _aj_ amiti ariard aureleoules b10c BlueMatt brunoerg cfields darosior dergoegge dongcarl fanquake fjahr furszy gleb glozow hebasto instagibbs jamesob jarolrod jonatack josibake kallewoof kanzure kouloumos kvaciral laanwj LarryRuane lightlike luke-jr MacroFake Murch phantomcircuit pinheadmz promag provoostenator ryanofsky sdaftuar S3RK stickies-v sipa sr_gi theStack TheCharlatan vasild 14:00:50 <brunoerg> hi 14:00:50 <furszy> hi 14:01:00 <virtu> hi 14:01:07 <willcl-ark> hi 14:01:15 <lightlike> Hi 14:01:16 <achow101> There are no pre-proposed meeting topics this week. Any last minute ones to add? 14:01:21 <hebasto> hi 14:01:39 <instagibbs> hi 14:02:14 <achow101> #topic 28.0 release priorities 14:02:22 <achow101> 28.0rc1 was posted yesterday. please test 14:02:30 <achow101> any prs that should be backported yet? 14:02:57 <fanquake> #30743 14:02:58 <gribble> https://github.com/bitcoin/bitcoin/issues/30743 | depends: build libevent with `-D_GNU_SOURCE` by fanquake ÷ Pull Request #30743 ÷ bitcoin/bitcoin ÷ GitHub 14:03:10 <fanquake> building depends on alpine and similar is broken, so this'll need to go in 14:03:44 <theStack> #30714 , if anyone out there uses TestShell 14:03:46 <gribble> https://github.com/bitcoin/bitcoin/issues/30714 | test: fix `TestShell` initialization (late follow-up for #30463) by theStack ÷ Pull Request #30714 ÷ bitcoin/bitcoin ÷ GitHub 14:04:01 <fanquake> also need to fix #30751 in some way, otherwise builds with new clang and old boost are broken 14:04:01 <gribble> https://github.com/bitcoin/bitcoin/issues/30751 | build: Boost 1.74.0 incompatible with Clang 18 ÷ Issue #30751 ÷ bitcoin/bitcoin ÷ GitHub 14:04:21 <achow101> theStack: added to the milestone 14:04:28 <fanquake> looks like clang 18 with boost < 1.81.0, which is annoying, because debian stable and similar ships with 1.76 etc 14:04:42 <furszy> probably #30684. To v28 and previous releases. 14:04:44 <gribble> https://github.com/bitcoin/bitcoin/issues/30684 | init: fix init fatal error on invalid negated option value by furszy ÷ Pull Request #30684 ÷ bitcoin/bitcoin ÷ GitHub 14:05:22 <fanquake> not sure about that, given it's a real edgecase, and nobody has ever reported it 14:05:50 <achow101> fanquake: boost issues aren't really our problem? unless we're requiring clang 18? 14:06:06 <fanquake> achow101: they are if we claim to support 1.73+ 14:06:38 <fanquake> and if the boost libs shipped on the distro don't work with the default compiler 14:06:49 <fanquake> unless we are telling everyone to use depends 14:07:24 <achow101> hmm ok 14:07:53 <Sjors[m]11> hi 14:08:14 <achow101> furszy: since that is 14:08:20 <fanquake> https://github.com/bitcoin-core/bitcoin-devwiki/wiki/28.0-Release-Notes-Draft - please contribute anything missing to the release note 14:08:25 <hebasto> debian stable default clang is 14 14:08:34 <achow101> since that issue has existed for a while, I think it's fine to skip for this release 14:08:55 <achow101> (based entirely on looking at the title) 14:09:12 <furszy> sure, np there. 14:10:12 <achow101> #topic Ad-hoc high priority for review 14:10:18 <achow101> Anything to add or remove from https://github.com/orgs/bitcoin/projects/1/views/4 14:10:40 <achow101> i guess everything needs rebase now because of cmake 14:10:48 <jonatack> hi 14:10:54 <fjahr> #28792 for me, rebased already 14:10:55 <gribble> https://github.com/bitcoin/bitcoin/issues/28792 | Embed default ASMap as binary dump header file by fjahr ÷ Pull Request #28792 ÷ bitcoin/bitcoin ÷ GitHub 14:11:06 <fanquake> my suggestion during rebasing would be to drop any autotools changes, unless you just want to rebase again 14:11:23 <fanquake> or force everyone to review two sets of the same change 14:11:26 <fjahr> editing some stuff on the build system too so interested in feedback from competent reviewers ;) 14:12:03 <Sjors[m]11> What's the ETA for kill autotools? 14:12:16 <achow101> also, i guess if people don't rebase their stuff soon, those prs are gonna be closed 14:12:17 <Sjors[m]11> Or does it not matter if you merge something that doesn't work with it? 14:12:18 <cfields> hi 14:12:39 <fanquake> what do you mean not work with? Nothing like that will be merged 14:12:49 <fanquake> autotools is going to be entirely removed very soon 14:12:58 <fanquake> CI is only using cmake, guix is only using cmake etc 14:13:13 <fanquake> so anything doing stuff in autotools wont even be tested properly at this point 14:13:18 <fjahr> I kept the autotools stuff in so far, I felt like for me it would be easier to review both side by side but I am happy to remove it if that is the policy we want to follow generally 14:13:25 <Sjors[m]11> E.g. #30409 adds a header, so it touches Makefile.am. 14:13:27 <gribble> https://github.com/bitcoin/bitcoin/issues/30409 | Introduce waitTipChanged() mining interface, replace RPCNotifyBlockChange, drop CRPCSignals & g_best_block by Sjors ÷ Pull Request #30409 ÷ bitcoin/bitcoin ÷ GitHub 14:13:42 <Sjors[m]11> I can drop that, but then if it's merged before autotools goes away, it won't compile. 14:13:49 <fjahr> (easier to review as a cmake noob) 14:14:04 <Sjors[m]11> My other PRs are probably not getting merged before that time anyway, so I made them cmake-only. 14:14:13 <fanquake> Sjors I don't understand. Just make the change in cmake, and drop the autotools parts 14:14:27 <fanquake> everything will compile fine, regardless of if autotools exists or not 14:14:43 <fanquake> and then you don't have to worry about when it's removed 14:14:48 <fanquake> and your changes will be tested in the CI 14:15:11 <cfields> Any reason not to nuke autotools today? To moot this conversation entirely? 14:15:47 <fanquake> cfields: that would be my preference, so we don't waste time with all this, but cmake is still lacking working features, like coverage, so it's a little bit of a blocker 14:16:34 <cfields> We discussed exactly this issue for exactly this reason and came to the conclusion that (at the very least) configure.ac+Makefile.* should be removed asap. 14:16:46 <cfields> Seems we can live without coverage for a few days? 14:17:08 <maflcko> Can I plz haz 24 more hours? 14:17:12 <fanquake> I would have preferred to at least have a change ready for review / testing, but it's not clear who is working on it 14:17:28 <maflcko> fanquake: I think the change is there, but no current acks 14:17:48 <fanquake> is there a pr in bitcoin/bitcoin? 14:17:48 <maflcko> I'll try to review it later today or tomorrow 14:18:10 <cfields> maflcko: for coverage? or something else? 14:18:22 <maflcko> fanquake: it is #30664 14:18:24 <gribble> https://github.com/bitcoin/bitcoin/issues/30664 | build: Remove Autotools-based build system by hebasto ÷ Pull Request #30664 ÷ bitcoin/bitcoin ÷ GitHub 14:18:35 <fanquake> How does that fix coverage? 14:19:30 <maflcko> fanquake: I don't want to block something, based on missing coverage reports 14:19:51 <fanquake> Ok. I'm very happy to merge that by EOD tomorrow, if no other blockers come up 14:19:56 <maflcko> cfields: Just so that I can run some legacy scripts without having to modify them to pull an old commit 14:21:14 <jonatack> end of day tomorrow sgtm 14:21:39 <cfields> ok 14:22:51 <achow101> any other topics to discuss? 14:24:33 <achow101> #endmeeting