14:00:16 <achow101> #startmeeting 14:00:16 <core-meetingbot> Meeting started Thu Jun 20 14:00:16 2024 UTC. The chair is achow101. Information about MeetBot at https://bitcoin.jonasschnelli.ch/ircmeetings. 14:00:16 <core-meetingbot> Available commands: action commands idea info link nick 14:00:28 <bitcoin-git> [bitcoin] guilhermelinosp opened pull request #30313: Update README.md (master...master) https://github.com/bitcoin/bitcoin/pull/30313 14:00:29 <kevkevin> hi 14:00:30 <dergoegge> hi 14:00:32 <achow101> #bitcoin -core-dev Meeting: achow101 _aj_ amiti ariard aureleoules b10c BlueMatt brunoerg cfields darosior dergoegge dongcarl fanquake fjahr furszy gleb glozow hebasto instagibbs jamesob jarolrod jonatack josibake kallewoof kanzure kouloumos kvaciral laanwj LarryRuane lightlike luke-jr MacroFake Murch phantomcircuit pinheadmz promag provoostenator ryanofsky sdaftuar S3RK stickies-v sipa sr_gi theStack TheCharlatan vasild 14:00:39 <Murch[m]> Hi 14:00:41 <achow101> There are no pre-proposed meeting topics this week. Any last minute ones to add? 14:00:41 <furszy> hi 14:00:49 <vasild> hi 14:01:16 <sipa> hi 14:01:21 <achow101> #topic package relay updates (glozow) 14:01:21 <core-meetingbot> topic: package relay updates (glozow) 14:01:30 <dergoegge> I'm doing gloria's update today 14:01:32 <b10c> hi 14:01:38 <dergoegge> "I'm on holiday June 20-30. #28984 was merged. We have a couple followups (#30272 and #30295). The new priority PR is #30111." 14:01:40 <bitcoin-git> [bitcoin] achow101 closed pull request #30313: Update README.md (master...master) https://github.com/bitcoin/bitcoin/pull/30313 14:01:41 <hebasto> Hi 14:01:42 <gribble> https://github.com/bitcoin/bitcoin/issues/28984 | Cluster size 2 package rbf by instagibbs ÷ Pull Request #28984 ÷ bitcoin/bitcoin ÷ GitHub 14:01:43 <gribble> https://github.com/bitcoin/bitcoin/issues/30272 | doc: use TRUC instead of v3 and add release note by glozow ÷ Pull Request #30272 ÷ bitcoin/bitcoin ÷ GitHub 14:01:45 <gribble> https://github.com/bitcoin/bitcoin/issues/30295 | #28984 package rbf followups by instagibbs ÷ Pull Request #30295 ÷ bitcoin/bitcoin ÷ GitHub 14:01:47 <gribble> https://github.com/bitcoin/bitcoin/issues/30111 | locks: introduce mutex for tx download, flush rejection filters on UpdatedBlockTip by glozow ÷ Pull Request #30111 ÷ bitcoin/bitcoin ÷ GitHub 14:01:58 <fjahr> hi 14:02:00 <dergoegge> that's all 14:02:09 <instagibbs> \o/ 14:02:22 <maxedw> hi 14:02:36 <achow101> #topic cluster mempool updates (sdaftuar) 14:02:36 <core-meetingbot> topic: cluster mempool updates (sdaftuar) 14:02:59 <vasild> wrt #30111 I wonder if there are better than manual ways to review such threading changes 14:03:01 <gribble> https://github.com/bitcoin/bitcoin/issues/30111 | locks: introduce mutex for tx download, flush rejection filters on UpdatedBlockTip by glozow ÷ Pull Request #30111 ÷ bitcoin/bitcoin ÷ GitHub 14:03:07 <abubakarsadiq> hi 14:03:20 <jonatack> hi 14:03:36 <vasild> https://github.com/bitcoin/bitcoin/pull/30111#pullrequestreview-2122762881 specifically 14:04:26 <achow101> vasild: the thread safety annotations should help as clang will error 14:04:46 <tdb3_> hi 14:04:49 <vasild> no, they will not help with mutex order 14:05:09 <dergoegge> we have runtime lock order checks iirc 14:05:22 <dergoegge> TSan would also complain (i think) 14:05:25 <vasild> there is some partial order support in those annotations but we don't use that at all, it is like Mutex m WILL_LOCK_AFTER(another_mutex); 14:05:40 <achow101> there's debug_lockorder for runtime checks 14:05:40 <josie_> hi 14:05:45 <sipa> I don't see sdaftuar. Since last meeting I've split up #30126 (adding #30286 and #30285), and opened a tracking issue #30283. 14:05:47 <bitcoin-git> [bitcoin] Sjors opened pull request #30314: ci: clarify Cirrus self-hosted workers setup (master...2024/06/cirrus-docs) https://github.com/bitcoin/bitcoin/pull/30314 14:05:47 <gribble> https://github.com/bitcoin/bitcoin/issues/30283 | upnp: fix build with miniupnpc 2.2.8 by theuni ÷ Pull Request #30283 ÷ bitcoin/bitcoin ÷ GitHub 14:05:48 <gribble> https://github.com/bitcoin/bitcoin/issues/30285 | cluster mempool: merging & postprocessing of linearizations by sipa ÷ Pull Request #30285 ÷ bitcoin/bitcoin ÷ GitHub 14:05:49 <gribble> https://github.com/bitcoin/bitcoin/issues/30286 | cluster mempool: optimized candidate search by sipa ÷ Pull Request #30286 ÷ bitcoin/bitcoin ÷ GitHub 14:05:50 <gribble> https://github.com/bitcoin/bitcoin/issues/30126 | cluster mempool: cluster linearization algorithm by sipa ÷ Pull Request #30126 ÷ bitcoin/bitcoin ÷ GitHub 14:06:13 <sipa> I'm also working on another writeup with a gentler introduction to the linearization algorithms why and how 14:06:20 <vasild> yes, if the lock misorder happens during execution of testing, then yes, it will crash in a good way 14:06:56 <achow101> sipa: which one of those should we review first? 14:07:14 <instagibbs> 30126 14:07:15 <sipa> achow101: see the tracking issue! 30126 14:07:45 <instagibbs> sipa could you also do a tiny writeup on teh serialization/deser strategy in the fuzz test? 14:07:57 <instagibbs> mental model of what is happening 14:08:28 <sipa> instagibbs: on the serializer format itself, or on the "why use serialization.h instead of FuzzedDataProvider"? 14:09:10 <instagibbs> former mostly (I think I handled the latter) 14:09:28 <sipa> instagibbs: sure; i'll try to write a big comment explaining it in the code 14:09:37 <instagibbs> ð 14:10:34 <achow101> #topic legacy wallet removal updates (achow101) 14:10:34 <core-meetingbot> topic: legacy wallet removal updates (achow101) 14:10:59 <achow101> #26596 has been getting some review 14:11:02 <gribble> https://github.com/bitcoin/bitcoin/issues/26596 | wallet: Migrate legacy wallets to descriptor wallets without requiring BDB by achow101 ÷ Pull Request #26596 ÷ bitcoin/bitcoin ÷ GitHub 14:11:42 <achow101> gui#824 and #30265 are also open and easier to review 14:11:44 <gribble> https://github.com/bitcoin/bitcoin/issues/824 | Use of read_some in bitcoinrpc.cpp ÷ Issue #824 ÷ bitcoin/bitcoin ÷ GitHub 14:11:45 <gribble> https://github.com/bitcoin/bitcoin/issues/30265 | wallet: Fix listwalletdir listing of migrated default wallets and generated backup files by achow101 ÷ Pull Request #30265 ÷ bitcoin/bitcoin ÷ GitHub 14:12:24 <achow101> #topic Ad-hoc high priority for review 14:12:24 <core-meetingbot> topic: Ad-hoc high priority for review 14:12:29 <achow101> Anything to add or remove from https://github.com/orgs/bitcoin/projects/1/views/4 14:13:06 <sipa> i'd like to get some attention to #29625 (it's already on the list) 14:13:08 <gribble> https://github.com/bitcoin/bitcoin/issues/29625 | Several randomness improvements by sipa ÷ Pull Request #29625 ÷ bitcoin/bitcoin ÷ GitHub 14:13:39 <achow101> I started reviewing that and then got lost 14:14:12 <sipa> can I do something to help the lostness? 14:16:05 <achow101> looks like there's more smaller commits now, so I think that will help 14:16:33 <sipa> yeah, several things have been split up 14:17:44 <achow101> Any other topics to discuss? 14:19:58 <maxedw> Just a quick one to say that there is an open issue to discuss moving some more CI jobs from Cirrus to Github Actions. If anyone has thoughts on that please come to https://github.com/bitcoin/bitcoin/issues/30304#issuecomment-2180535361 14:20:23 <achow101> #endmeeting