14:00:21 <achow101> #startmeeting 14:00:33 <Murch[m]> Hi 14:00:34 <achow101> #bitcoin -core-dev Meeting: achow101 _aj_ amiti ariard aureleoules b10c BlueMatt brunoerg cfields darosior dergoegge dongcarl fanquake fjahr furszy gleb glozow hebasto instagibbs jamesob jarolrod jonatack josibake kallewoof kanzure kouloumos kvaciral laanwj LarryRuane lightlike luke-jr MacroFake Murch phantomcircuit pinheadmz promag provoostenator ryanofsky sdaftuar S3RK stickies-v sipa sr_gi theStack TheCharlatan vasild 14:00:41 <brunoerg> hi 14:00:45 <instagibbs> hi 14:00:49 <stickies-v> hi 14:00:59 <achow101> There are no pre-proposed meeting topics this week. Any last minute ones to add? 14:01:22 <abubakarsadiq> hi 14:01:38 <achow101> #topic package relay updates (glozow) 14:01:44 <glozow> #28984 is the priority and I think looking pretty close! 14:01:47 <gribble> https://github.com/bitcoin/bitcoin/issues/28984 | Cluster size 2 package rbf by instagibbs ÷ Pull Request #28984 ÷ bitcoin/bitcoin ÷ GitHub 14:02:10 <glozow> #29496 was merged, and I have a followup in draft but waiting for #28984 to be merged first 14:02:13 <gribble> https://github.com/bitcoin/bitcoin/issues/28984 | Cluster size 2 package rbf by instagibbs ÷ Pull Request #28984 ÷ bitcoin/bitcoin ÷ GitHub 14:02:15 <gribble> https://github.com/bitcoin/bitcoin/issues/29496 | policy: bump TX_MAX_STANDARD_VERSION to 3 by glozow ÷ Pull Request #29496 ÷ bitcoin/bitcoin ÷ GitHub 14:02:21 <dergoegge> hi 14:02:29 <bitcoin-git> [bitcoin] theuni opened pull request #30283: upnp: fix build with miniupnpc 2.1.8 (master...fix-upnp-228) https://github.com/bitcoin/bitcoin/pull/30283 14:02:36 <instagibbs> love to see it 14:02:45 <glozow> On the p2p side, I'm asking for some help reviewing #30111. It seems a bit stuck in rebase/reACK limbo and needs more eyes than instagibbs (thanks). 14:02:47 <gribble> https://github.com/bitcoin/bitcoin/issues/30111 | locks: introduce mutex for tx download, flush rejection filters on UpdatedBlockTip by glozow ÷ Pull Request #30111 ÷ bitcoin/bitcoin ÷ GitHub 14:02:55 <josie> hi 14:03:15 <tdb3_> hi 14:03:34 <glozow> That's it from me 14:04:23 <achow101> #topic cluster mempool updates (sdaftuar) 14:06:20 <achow101> I guess neither sdaftuar nor sipa are here? 14:06:22 <sipa> hi 14:07:12 <sipa> Good progress on the dependencies of #30126 (both merged), and I've been getting a bit of review which I've been addressing. 14:07:13 <gribble> https://github.com/bitcoin/bitcoin/issues/30126 | Low-level cluster linearization code by sipa ÷ Pull Request #30126 ÷ bitcoin/bitcoin ÷ GitHub 14:07:34 <sipa> #28676 is now also rebased on 30126 14:07:37 <gribble> https://github.com/bitcoin/bitcoin/issues/28676 | [WIP] Cluster mempool implementation by sdaftuar ÷ Pull Request #28676 ÷ bitcoin/bitcoin ÷ GitHub 14:07:46 <instagibbs> sipa q: the optimization commits are merely optimizations in efficiency sense? 14:08:02 <instagibbs> or do they materially change linearization results 14:08:24 <cfields> hi 14:08:37 <sipa> instagibbs: there are a few "feature" changes (e.g. randomization of search order, being able to pass in an existing linearization to Linearize) which I wouldn't describe as optimizations, though they could indirectly lead to better results too. 14:09:02 <glozow> currently reviewing #30126, slowly 14:09:04 <gribble> https://github.com/bitcoin/bitcoin/issues/30126 | Low-level cluster linearization code by sipa ÷ Pull Request #30126 ÷ bitcoin/bitcoin ÷ GitHub 14:09:12 <instagibbs> I think maybe the data types + unopt + benchmarks might be a good place to chop it up? 14:09:31 <instagibbs> I'm reviewing regardless 14:09:36 <glozow> after the 7th commit? 14:09:55 <cfields> sipa: could you recommend a good place for where to start with a conceptual understanding of 14:10:04 <sipa> so some optimizations change performance without affecting the outcome (by just making operations faster, but performing the same search steps) 14:10:24 <kanzure> hi 14:10:27 <sipa> while others change how many search steps are needed, by skipping unnecessary ones, or making better guesses 14:10:34 <cfields> the cluster mempool changes? There's lots to read spread out in many places. I'm unsure where to start with getting an understanding of what I'm about to review. 14:11:01 <sipa> cfields: at a low level, https://delvingbitcoin.org/t/how-to-linearize-your-cluster/303 14:11:16 <cfields> sipa: perfect, thanks. 14:11:20 <maxedw> hi 14:11:57 <sipa> cfields: at a higher level, https://delvingbitcoin.org/t/an-overview-of-the-cluster-mempool-proposal/393/1 14:12:36 <cfields> ð 14:13:03 <sipa> cfields: also always welcome for a whiteboard session :) 14:13:54 <cfields> sipa: thanks. Need to wrap my head around the high level first. 14:14:21 <cfields> I was going to suggest adding those to the PR description, but I see they're there now. Apologies if they've been there all along and I just missed them. 14:14:53 <sipa> i don't think i had them there when I opened the PR 14:16:01 <achow101> #topic legacy wallet removal updates (achow101) 14:16:25 <achow101> #26596 has been getting some review that I've been responding to 14:16:28 <gribble> https://github.com/bitcoin/bitcoin/issues/26596 | wallet: Migrate legacy wallets to descriptor wallets without requiring BDB by achow101 ÷ Pull Request #26596 ÷ bitcoin/bitcoin ÷ GitHub 14:17:00 <achow101> I've also opened gui#824 to tackle the last todo on the roadmap 14:17:01 <gribble> https://github.com/bitcoin/bitcoin/issues/824 | Use of read_some in bitcoinrpc.cpp ÷ Issue #824 ÷ bitcoin/bitcoin ÷ GitHub 14:17:22 <lojik90> hello, can someone point me to where LN devs hang out? i need help with some devving. 14:17:27 <achow101> as well as #30265 for some listwalletdir issues 14:17:29 <gribble> https://github.com/bitcoin/bitcoin/issues/30265 | wallet: Fix listwalletdir listing of migrated default wallets and generated backup files by achow101 ÷ Pull Request #30265 ÷ bitcoin/bitcoin ÷ GitHub 14:18:06 <achow101> https://github.com/bitcoin-core/gui/pull/824 for the gui thing (i guess gribble doesn't like gui prs) 14:19:07 <achow101> #topic Ad-hoc high priority for review 14:19:09 <achow101> Anything to add or remove from https://github.com/orgs/bitcoin/projects/1/views/4 14:19:16 <achow101> Or any other topics to discuss this week? 14:22:03 <achow101> #endmeeting