14:00:36 <achow101> #startmeeting 14:00:40 <glozow> hi 14:00:42 <achow101> #bitcoin -core-dev Meeting: achow101 _aj_ amiti ariard aureleoules b10c BlueMatt brunoerg cfields darosior dergoegge dongcarl fanquake fjahr furszy gleb glozow hebasto instagibbs jamesob jarolrod jonatack josibake kallewoof kanzure kouloumos kvaciral laanwj LarryRuane lightlike luke-jr MacroFake Murch phantomcircuit pinheadmz promag provoostenator ryanofsky sdaftuar S3RK stickies-v sipa sr_gi theStack TheCharlatan vasild 14:00:42 <dergoegge> hi 14:00:45 <stickies-v> hi 14:00:47 <hebasto> hi 14:00:50 <cfields> hi 14:00:57 <lightlike> hi 14:00:59 <willcl-ark> Hi 14:01:03 <furszy> hi 14:01:03 <TheCharlatan> hi 14:01:07 <achow101> There are no preproposed meeting topics this week. Any last minute ones to add? 14:01:07 <bitcoin-git> [bitcoin] achow101 pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/f15778536ad4...e163d864d380 14:01:08 <LarryRuane> hi 14:01:08 <bitcoin-git> bitcoin/master 6629d1d furszy: test: improve robustness of connect_nodes() 14:01:09 <pinheadmz> Hi 14:01:09 <bitcoin-git> bitcoin/master e163d86 Ava Chow: Merge bitcoin/bitcoin#30118: test: improve robustness of connect_nodes() 14:01:09 <virtu> hi 14:01:16 <bitcoin-git> [bitcoin] achow101 merged pull request #30118: test: improve robustness of connect_nodes() (master...2024_test_improve_connect_nodes) https://github.com/bitcoin/bitcoin/pull/30118 14:01:22 <instagibbs> achow101 meeting foul 14:01:23 <b10c> hi 14:01:29 <glozow> wow extreme multi-tasking 14:01:34 <sipa> hi 14:01:43 <ajonas> Hi 14:01:47 <sdaftuar> hi 14:01:58 <josie_> hi 14:02:00 <achow101> lol 14:02:06 <achow101> #topic package relay updates (glozow) 14:02:11 <fjahr> hi 14:02:18 <glozow> Things moving with TRUCs/BIP431/v3. #29873 looks really close. Just working on some comments on the BIP (which now has a number!) as well. 14:02:20 <gribble> https://github.com/bitcoin/bitcoin/issues/29873 | policy: restrict all TRUC (v3) transactions to 10kvB by glozow ÷ Pull Request #29873 ÷ bitcoin/bitcoin ÷ GitHub 14:02:25 <glozow> After that, we just do #29496 to flip the switch 14:02:27 <gribble> https://github.com/bitcoin/bitcoin/issues/29496 | policy: bump TX_MAX_STANDARD_VERSION to 3 by glozow ÷ Pull Request #29496 ÷ bitcoin/bitcoin ÷ GitHub 14:02:29 <marcofleon> hi 14:02:30 <instagibbs> \o/ 14:02:38 <abubakarsadiq> hi 14:02:42 <glozow> for package RBF, #30072 looks close, and #28984 is still the priority. 14:02:42 <glozow> On the p2p side, I'm still soliciting review on the locks PR #30111 14:02:44 <gribble> https://github.com/bitcoin/bitcoin/issues/30072 | refactor prep for package rbf by instagibbs ÷ Pull Request #30072 ÷ bitcoin/bitcoin ÷ GitHub 14:02:46 <gribble> https://github.com/bitcoin/bitcoin/issues/28984 | Cluster size 2 package rbf by instagibbs ÷ Pull Request #28984 ÷ bitcoin/bitcoin ÷ GitHub 14:02:48 <gribble> https://github.com/bitcoin/bitcoin/issues/30111 | locks: introduce mutex for tx download, flush rejection filters on UpdatedBlockTip by glozow ÷ Pull Request #30111 ÷ bitcoin/bitcoin ÷ GitHub 14:03:25 <glozow> That's all from me 14:04:04 <achow101> #topic cluster mempool updates (sdaftuar) 14:04:06 <sdaftuar> My cluster mempool update today is pretty short: last week, sipa opened PR #30126 which introduces the low-level cluster linearization code that the cluster mempool branch will ultimately build on. 14:04:07 <gribble> https://github.com/bitcoin/bitcoin/issues/30126 | Low-level cluster linearization code by sipa ÷ Pull Request #30126 ÷ bitcoin/bitcoin ÷ GitHub 14:04:13 <sdaftuar> \o/I plan to rebase my draft PR #28676 on sipa's branch soon to make sure everything works as part of my own review. In the meantime I'll encourage everyone interested in cluster mempool to review sipa's PR. 14:04:17 <gribble> https://github.com/bitcoin/bitcoin/issues/28676 | [WIP] Cluster mempool implementation by sdaftuar ÷ Pull Request #28676 ÷ bitcoin/bitcoin ÷ GitHub 14:04:23 <achow101> \o/ 14:04:41 <achow101> so #30126 is current priority to review? 14:04:44 <gribble> https://github.com/bitcoin/bitcoin/issues/30126 | Low-level cluster linearization code by sipa ÷ Pull Request #30126 ÷ bitcoin/bitcoin ÷ GitHub 14:04:45 <sdaftuar> yes! 14:04:48 <glozow> \o/ 14:05:14 <cfields> I started reviewing there. It's pretty dense ð¬ 14:05:14 <fanquake> not #29625, given that's the lowest common dep? 14:05:16 <gribble> https://github.com/bitcoin/bitcoin/issues/29625 | Several randomness improvements by sipa ÷ Pull Request #29625 ÷ bitcoin/bitcoin ÷ GitHub 14:05:27 <sipa> Regarding 30126, I'm aware it's heavy and non-trivial algorithmic code, and I've tried to explain a lot of what is going on in commits and comments, but I'm very happy to address comments of the form "this is not clear to me, please elaborate in comments". 14:05:41 <instagibbs> fanquake I was going to suggest splitting off the minimal randomness changes to its own PR if anything 14:06:02 <sipa> As for 29625, if it doesn't make progress quickly, I'll rebase 30126 to be independent (it can use chacha20 rng instead of xoroshiro128 for now). 14:06:14 <sdaftuar> fanquake: i think maybe we can get different reviewers to focus on #29625 than the people i expect will be reviewing #30126? 14:06:15 <gribble> https://github.com/bitcoin/bitcoin/issues/30126 | Low-level cluster linearization code by sipa ÷ Pull Request #30126 ÷ bitcoin/bitcoin ÷ GitHub 14:06:16 <gribble> https://github.com/bitcoin/bitcoin/issues/29625 | Several randomness improvements by sipa ÷ Pull Request #29625 ÷ bitcoin/bitcoin ÷ GitHub 14:06:24 <glozow> It seems like #29625 would knock off a good chunk, and already has an ack. I'm happy to start there? 14:06:24 <gribble> https://github.com/bitcoin/bitcoin/issues/29625 | Several randomness improvements by sipa ÷ Pull Request #29625 ÷ bitcoin/bitcoin ÷ GitHub 14:06:38 <sdaftuar> glozow: great :) 14:06:57 <sipa> I'd like to see 29625 make progress, because it's independently a pretty useful improvement I think (mostly for testing/fuzzing). 14:07:18 <sipa> But I don't think people who care about 30126 should treat it as a dependency; I can disentangle them. 14:07:43 <glozow> Does the choice of rng change much? 14:08:27 <sipa> It just felt that a cryptographic RNG feels like complete overkill for tweaking a search algorithm, but it's possible that it doesn't actually measurably change performance. 14:08:39 <sipa> Maybe I'll benchmark that, and if it doesn't matter, disentangle them. 14:09:01 <instagibbs> would be appreciated 14:09:04 <cfields> sipa: I wonder if some of the new structures in 30126 should be split into their own PRs for the sake of more targeted review? BitSet for ex. 14:09:20 <sipa> cfields: happy to do that; they're nicely self-contained 14:09:30 <glozow> thanks sipa 14:10:41 <achow101> #topic legacy wallet removal updates (achow101) 14:10:57 <achow101> #26606 was merged, so #26596 is the next priority pr 14:11:01 <gribble> https://github.com/bitcoin/bitcoin/issues/26606 | wallet: Implement independent BDB parser by achow101 ÷ Pull Request #26606 ÷ bitcoin/bitcoin ÷ GitHub 14:11:03 <gribble> https://github.com/bitcoin/bitcoin/issues/26596 | wallet: Migrate legacy wallets to descriptor wallets without requiring BDB by achow101 ÷ Pull Request #26596 ÷ bitcoin/bitcoin ÷ GitHub 14:11:38 <achow101> This is more of a wallet logic PR so understanding how BDB works is not required 14:12:24 <achow101> #topic Ad-hoc high priority for review 14:12:26 <achow101> Anything to add or remove from https://github.com/orgs/bitcoin/projects/1/views/4 14:13:24 <achow101> Or any other topics to discuss? 14:14:01 <brunoerg> hi 14:15:20 <glozow> Would still like a review on #29899 ð 14:15:22 <gribble> https://github.com/bitcoin/bitcoin/issues/29899 | [26.x] archive 26.1 release notes + backports by glozow ÷ Pull Request #29899 ÷ bitcoin/bitcoin ÷ GitHub 14:15:44 <stickies-v> will look at that now 14:15:49 <_aj_> #28417 would be good to get merged 14:15:52 <gribble> https://github.com/bitcoin/bitcoin/issues/28417 | contrib/signet/miner updates by ajtowns ÷ Pull Request #28417 ÷ bitcoin/bitcoin ÷ GitHub 14:16:19 <achow101> _aj_: will look 14:16:32 <achow101> #endmeeting