14:00:19 <achow101> #startmeeting 14:00:25 <TheCharlatan> hi 14:00:27 <achow101> #bitcoin -core-dev Meeting: achow101 _aj_ amiti ariard aureleoules b10c BlueMatt brunoerg cfields darosior dergoegge dongcarl fanquake fjahr furszy gleb glozow hebasto instagibbs jamesob jarolrod jonatack josibake kallewoof kanzure kouloumos kvaciral laanwj LarryRuane lightlike luke-jr MacroFake Murch phantomcircuit pinheadmz promag provoostenator ryanofsky sdaftuar S3RK stickies-v sipa theStack TheCharlatan vasild 14:00:32 <josie> hi 14:00:33 <kanzure> hi 14:00:34 <stickies-v> hello 14:00:35 <pinheadmz> hi 14:00:36 <sipa> hi 14:00:37 <darosior> hi 14:00:39 <brunoerg> hi 14:00:54 <furszy> hi 14:00:54 <fanquake> hi 14:00:58 <glozow> hi 14:01:00 <dergoegge> hi 14:01:01 <achow101> There are no pre-proposed meeting topics. Any last minute ones to add to the list? 14:01:27 <achow101> #topic package relay updates (glozow) 14:01:51 <glozow> PRs open for review are #28471, #28450, #28472, #28481 14:01:52 <gribble> https://github.com/bitcoin/bitcoin/issues/28471 | Fix virtual size limit enforcement in transaction package context by instagibbs ÷ Pull Request #28471 ÷ bitcoin/bitcoin ÷ GitHub 14:01:53 <Murch> Hi 14:01:54 <gribble> https://github.com/bitcoin/bitcoin/issues/28450 | Add package evaluation fuzzer by instagibbs ÷ Pull Request #28450 ÷ bitcoin/bitcoin ÷ GitHub 14:01:55 <gribble> https://github.com/bitcoin/bitcoin/issues/28472 | Make MemPoolAccept::m_limits const by instagibbs ÷ Pull Request #28472 ÷ bitcoin/bitcoin ÷ GitHub 14:01:56 <gribble> https://github.com/bitcoin/bitcoin/issues/28481 | txorphanage: add size accounting, use wtxids, support multiple announcers by glozow ÷ Pull Request #28481 ÷ bitcoin/bitcoin ÷ GitHub 14:01:59 <sdaftuar1> hi 14:02:17 <glozow> instagibbs' fuzzer has been turning up some bugs (yay) so most of these are small-ish bug fix PRs 14:02:54 <achow101> the fuzzer in 28450? 14:02:58 <glozow> yeah 14:03:14 <achow101> maybe we should get that in first so oss-fuzz can get to work 14:03:18 <glozow> I'd like to get that in before we try to do #26711 14:03:20 <gribble> https://github.com/bitcoin/bitcoin/issues/26711 | validate package transactions with their in-package ancestor sets by glozow ÷ Pull Request #26711 ÷ bitcoin/bitcoin ÷ GitHub 14:03:51 <instagibbs> need to add tests to bugfixes, on it 14:04:46 <achow101> #topic BIP 324 updates (sipa) 14:04:48 <glozow> yeah, and we can also work on some more targeted targets for looking at behaviors around size limiting, fee assessment, package limits 14:04:49 <sipa> hi 14:05:26 <sipa> things are moving along nicely, getting some review on #28331 14:05:29 <gribble> https://github.com/bitcoin/bitcoin/issues/28331 | BIP324 integration by sipa ÷ Pull Request #28331 ÷ bitcoin/bitcoin ÷ GitHub 14:06:38 <sipa> a few people have reached out to me to experiment 14:07:01 <achow101> 28331 is the end of the project? 14:07:33 <sipa> also #24748 14:07:36 <gribble> https://github.com/bitcoin/bitcoin/issues/24748 | test/BIP324: functional tests for v2 P2P encryption by stratospher ÷ Pull Request #24748 ÷ bitcoin/bitcoin ÷ GitHub 14:08:29 <achow101> we could plausibly get it all in before feature freeze. that'd be cool 14:08:46 <josie> when is the feature freeze? 14:08:52 <sipa> my thinking is getting 28331 in, default off, then increase testing (like through 24748, and whatever else people think of), and then later enable v2transport by default 14:09:12 <achow101> josie: oct 1 14:09:29 <instagibbs> sipa would be great to get that in for 26 14:09:43 <instagibbs> (first part) 14:09:53 <sipa> instagibbs: agreed 14:09:55 <sipa> that's my aim 14:10:19 <glozow> ð 14:10:43 <achow101> #topic libbitcoinkernel updates (TheCharlatan) 14:10:52 <TheCharlatan> Some good progress towards pruning platform-specific headers with #28428 and #28423 getting merged. 14:10:54 <gribble> https://github.com/bitcoin/bitcoin/issues/28428 | Hard-code version number value for CBlockLocator and CDiskBlockIndex by theuni ÷ Pull Request #28428 ÷ bitcoin/bitcoin ÷ GitHub 14:10:57 <gribble> https://github.com/bitcoin/bitcoin/issues/28423 | kernel: Remove protocol.h/netaddress.h/compat.h from kernel headers by TheCharlatan ÷ Pull Request #28423 ÷ bitcoin/bitcoin ÷ GitHub 14:11:01 <TheCharlatan> Nice to see these helping other serialization related refactors along. 14:11:08 <TheCharlatan> Also some interesting discussions about calculating memory usage in glozow's #28385. 14:11:14 <gribble> https://github.com/bitcoin/bitcoin/issues/28385 | [refactor] rewrite DisconnectedBlockTransactions to not use boost by glozow ÷ Pull Request #28385 ÷ bitcoin/bitcoin ÷ GitHub 14:11:27 <abubakarsadiq> hi 14:11:39 <TheCharlatan> Other PRs waiting for review can be found on https://github.com/orgs/bitcoin/projects/3. 14:12:24 <TheCharlatan> that's all 14:13:00 <achow101> #topic assumeutxo updates (jamesob) 14:13:23 <jamesob> oh hi 14:13:56 <jamesob> lots of good feedback from ryanofsky which I'll be addressing in the next day or two (in the middle of working on an OP_VAULT demo...). But I think things are looking pretty good, pretty close? 14:14:12 <achow101> review has been happening, looking close 14:14:19 <instagibbs> \o/ 14:14:43 <jamesob> Russ' comments were good, but don't change the fundamental approach of anything, so I think we're in good shape. The substance of that PR's approach has gone unchanged for a while. 14:15:38 <achow101> cool, hopefully we can also get that in before feature freeze 14:15:51 <jamesob> I'm not going to be at the upcoming coredev (on babywatch!) so Russ will be presenting on the state of the project in my absence 14:16:04 <vincenzopalazzo> hi 14:16:07 <jamesob> but hopefully by then or not too shortly after we'll have phase 1 in the bag... 14:16:51 <achow101> #topic Ad-hoc high priority for review 14:17:02 <achow101> Anything to add or remove from https://github.com/orgs/bitcoin/projects/1/views/4 14:17:39 <Murch> I have three ACKs on #26152 and two stale ACKS, I think itâÂÂs very close to RFM 14:17:41 <gribble> https://github.com/bitcoin/bitcoin/issues/26152 | Bump unconfirmed ancestor transactions to target feerate by murchandamus ÷ Pull Request #26152 ÷ bitcoin/bitcoin ÷ GitHub 14:17:52 <fanquake> I'll add #27897. Would like to get that over the line for 26.x 14:17:55 <gribble> https://github.com/bitcoin/bitcoin/issues/27897 | guix: use GCC 12.3.0 to build releases by fanquake ÷ Pull Request #27897 ÷ bitcoin/bitcoin ÷ GitHub 14:18:40 <Murch> Not sure it needs to be on High Priority, but IâÂÂd love to get another look from anyone with a concept ACK or the issuers of the stale ACKs if they want to chime in before the merge :) 14:18:42 <achow101> Murch: will look. fanquake: added 14:18:47 <Murch> Thanks! 14:18:47 <pinheadmz> #27850 also just adds test, been through a lot, finally got ACKs 14:18:51 <gribble> https://github.com/bitcoin/bitcoin/issues/27850 | test: Add unit & functional test coverage for blockstore by pinheadmz ÷ Pull Request #27850 ÷ bitcoin/bitcoin ÷ GitHub 14:19:08 <Murch> The other reviewer with the stale ACK also wanted to take another look today 14:19:44 <achow101> Any other topics to discuss? 14:20:45 <Murch> Does determining whether we create change belong to the stage of funding a transaction or to the stage of assembling the transaction? ^^ 14:20:47 <vasild> hi 14:20:55 <vincenzopalazzo> I can review by the end of the next week #27101 and #27375 I am pretty familiar with this area 14:20:58 <gribble> https://github.com/bitcoin/bitcoin/issues/27101 | Support JSON-RPC 2.0 when requested by client by pinheadmz ÷ Pull Request #27101 ÷ bitcoin/bitcoin ÷ GitHub 14:21:01 <gribble> https://github.com/bitcoin/bitcoin/issues/27375 | net: support unix domain sockets for -proxy and -onion by pinheadmz ÷ Pull Request #27375 ÷ bitcoin/bitcoin ÷ GitHub 14:21:09 <pinheadmz> vincenzopalazzo thanks cheers! 14:21:14 <achow101> Murch: I promise we can have that discussion at coredev 14:22:05 <josie> Murch: spicy 14:22:28 <Murch> furszy and I have already been warming up debate points ;) 14:23:01 <achow101> #endmeeting