14:00:36 <achow101> #startmeeting 14:00:55 <achow101> #bitcoin -core-dev Meeting: achow101 _aj_ amiti ariard aureleoules b10c BlueMatt brunoerg cfields darosior dergoegge dongcarl fanquake fjahr furszy gleb glozow hebasto instagibbs jamesob jarolrod jonatack josibake kallewoof kanzure kouloumos kvaciral laanwj LarryRuane lightlike luke-jr MacroFake Murch phantomcircuit pinheadmz promag provoostenator ryanofsky sdaftuar S3RK stickies-v sipa theStack TheCharlatan vasild 14:01:04 <kanzure> hi 14:01:06 <brunoerg> hi 14:01:07 <pinheadmz> hi 14:01:08 <Murch> Hi 14:01:08 <PaperSword> hi 14:01:11 <sipa> hi 14:01:14 <dergoegge> hi 14:01:21 <hebasto> hi 14:01:26 <furszy> hi 14:01:29 <glozow> hi 14:01:29 <achow101> There are no pre-proposed meeting topics this week. any last minute ones to add to the list? 14:02:03 <achow101> #topic package relay updates (glozow) 14:02:35 <glozow> #28251 is the high-prio PR. it fixes a fun bug and has some of the commits from #26711 14:02:37 <gribble`> https://github.com/bitcoin/bitcoin/issues/28251 | validation: fix coins disappearing mid-package evaluation by glozow ÷ Pull Request #28251 ÷ bitcoin/bitcoin ÷ GitHub 14:02:40 <gribble`> https://github.com/bitcoin/bitcoin/issues/26711 | validate package transactions with their in-package ancestor sets by glozow ÷ Pull Request #26711 ÷ bitcoin/bitcoin ÷ GitHub 14:03:20 <achow101> sounds like a fun bug 14:03:44 <achow101> #topic BIP 324 updates (sipa) 14:04:45 <sipa> hi! 14:04:56 <sipa> one more down! 14:05:04 <instagibbs> nice 14:05:35 <sipa> next one to review is #28196 14:05:37 <gribble`> https://github.com/bitcoin/bitcoin/issues/28196 | BIP324 connection support by sipa ÷ Pull Request #28196 ÷ bitcoin/bitcoin ÷ GitHub 14:05:52 <_aj_> hi 14:06:17 <sipa> which has now been updated to have no observable changes; it only adds the V2Transport class, and reuses the transport-can-talk-to-transport fuzz test from the previous PR 14:06:39 <achow101> this is everything in bip324 but without actually using it? 14:06:59 <sipa> almost everything, yes 14:07:22 <sipa> except service flags, connection/reconnection logic, rpc stuff, ... 14:07:40 <sipa> and more high-level tests 14:07:56 <PaperSword> Is there any way I could help with this? Testing? 14:08:00 <achow101> is there a way to turn it on to test with it? 14:08:05 <sipa> for some of that, i just opened #28331, which is functionally complete and testavle 14:08:07 <gribble`> https://github.com/bitcoin/bitcoin/issues/28331 | BIP324 integration by sipa ÷ Pull Request #28331 ÷ bitcoin/bitcoin ÷ GitHub 14:08:12 <instagibbs> 28331 seems like that 14:08:13 <sipa> *testable 14:08:50 <achow101> would that be considered the last pr in this project? 14:09:27 <sipa> there is also stratospher's bip324 implementation in test framework, and tests using it 14:10:07 <sipa> which i plan to leave out of 28331, but my plan is to work now on adding unit and functional tests (which don't require bip324 in python) to 28331 14:10:38 <lightlike> so it might be realistic that it could make it into v26 ? at least optionally? 14:10:43 <achow101> cool to see that we're nearing completion 14:10:48 <sipa> so i think 28331 will probably be my last big PR relating to bip324 14:11:37 <sipa> i'm probably going to start running 28331 on my own nodes, so others can test with 14:11:55 <sipa> lightlike: maybe it could be default off in v26 14:12:06 <lightlike> that would be great! 14:12:07 <sipa> but otherwise complete 14:12:32 <fanquake> 5 weeks left to get changes in to make that happen 14:12:46 <luke-jr> off = won't be used even if the peer insists? 14:12:49 <sipa> fanquake: 2 Weeks(tm) for PR, doable right? 14:13:05 <fanquake> doable 14:13:15 <sipa> luke-jr: what 28331 implements is a -v2transport option; without it, no v2 is used ever 14:13:37 <luke-jr> would be nice to have a mode where it's used if the peer requests it 14:13:38 <sipa> with it, it's used on inbound when the peer seems to be using it, and on outbound when service flag present 14:13:47 <sipa> luke-jr: that's doable 14:13:55 <sipa> just use it on inbound 14:14:38 <sipa> ok, i think details can be discussed on the PRs 14:14:47 <sipa> any other questions? otherwise end of my topic 14:14:56 <furszy> so the node connects to bip324 peers because of a change in the desirable services flags? 14:15:04 <furszy> or well, I should go to the PR.. 14:15:22 <achow101> #topic libbitcoinkernel updates (TheCharlatan) 14:15:27 <sipa> (afk) 14:16:17 <fjahr> hi 14:17:04 <achow101> seems to just still be waiting on review of #27866 14:17:07 <gribble`> https://github.com/bitcoin/bitcoin/issues/27866 | blockstorage: Return on fatal flush errors by TheCharlatan ÷ Pull Request #27866 ÷ bitcoin/bitcoin ÷ GitHub 14:18:03 <achow101> #topic assumeutxo updates (jamesob) 14:18:29 <jamesob> Still #27596. I've got some rebasing todo (on it today) and need to incorporate feedback from ryanofsky (thanks for the review) 14:18:32 <gribble`> https://github.com/bitcoin/bitcoin/issues/27596 | assumeutxo (2) by jamesob ÷ Pull Request #27596 ÷ bitcoin/bitcoin ÷ GitHub 14:19:01 <achow101> i'm partway through my review of it but so far all of my comments are things that other reviewers have noticed 14:20:05 <jamesob> yeah I think I'm going to take ryanofsky's commit in lieu of sdaftuar's first commit and make sure it behaves the same 14:21:34 <achow101> #topic Ad-hoc high priority for review 14:21:50 <achow101> anything to add or remove from https://github.com/orgs/bitcoin/projects/1/views/4 14:22:39 <achow101> or any other topics to discuss? 14:23:00 <fjahr> pinheadmz: where you able to test your bot yet? 14:23:18 <pinheadmz> sorry no :-( 14:23:32 <fjahr> Ok, then maybe next week :) 14:23:40 <dergoegge> I think #27897 would be nice to get in so maybe #28328 as high-prio? 14:23:41 <gribble`> https://github.com/bitcoin/bitcoin/issues/27897 | guix: use GCC 12.3.0 to build releases by fanquake ÷ Pull Request #27897 ÷ bitcoin/bitcoin ÷ GitHub 14:23:42 <gribble`> https://github.com/bitcoin/bitcoin/issues/28328 | guix: update time-machine by fanquake ÷ Pull Request #28328 ÷ bitcoin/bitcoin ÷ GitHub 14:23:59 <pinheadmz> #27101 is also ready for review again 14:24:01 <fanquake> I have the guix bump in there already, which is a dependant 14:24:02 <gribble`> https://github.com/bitcoin/bitcoin/issues/27101 | Support JSON-RPC 2.0 when requested by client by pinheadmz ÷ Pull Request #27101 ÷ bitcoin/bitcoin ÷ GitHub 14:24:18 <pinheadmz> it has a pretty mean scripted diff for JSON RPC response codes, which keep requiring rebase on master 14:25:21 <achow101> #endmeeting