14:00:13 <achow101> #startmeeting 14:00:15 <glozow> hi 14:00:17 <achow101> #bitcoin -core-dev Meeting: achow101 _aj_ amiti ariard aureleoules b10c BlueMatt brunoerg cfields darosior dergoegge dongcarl fanquake fjahr furszy gleb glozow hebasto instagibbs jamesob jarolrod jonatack josibake kallewoof kanzure kouloumos kvaciral laanwj LarryRuane lightlike luke-jr MacroFake Murch phantomcircuit pinheadmz promag provoostenator ryanofsky sdaftuar S3RK stickies-v sipa theStack TheCharlatan vasild 14:00:18 <jamesob5> hi 14:00:22 <brunoerg> hi 14:00:23 <sipa> hi 14:00:24 <hebasto> hi 14:00:26 <stickies-v> hi 14:00:27 <lightlike> Hi 14:00:32 <abubakarsadiq> hi 14:00:34 <darosior> hi 14:00:35 <furszy> hi 14:00:36 <TheCharlatan> hi 14:00:37 <kanzure> hi 14:00:41 <dergoegge> hi 14:00:44 <LarryRuane> hi 14:00:54 <achow101> #topic package relay updates (glozow) 14:00:57 <cfields> hi 14:01:01 <_aj_> hi 14:01:30 <glozow> I have updated #26711 with a new approach (linearization to help group txns, then submit ancestor subpackages, abort all if there are non-fee failures). No more O(n^2) validation. Though there's a CI failure I need to fix. 14:01:33 <gribble> https://github.com/bitcoin/bitcoin/issues/26711 | validate package transactions with their in-package ancestor sets by glozow ÷ Pull Request #26711 ÷ bitcoin/bitcoin ÷ GitHub 14:02:03 <sipa> cool 14:02:32 <Murch> hi 14:02:34 <achow101> #topic BIP 324 updates (sipa) 14:03:14 <josie> hi 14:03:25 <sipa> About to jump on subway, be back in a few min. 14:03:46 <achow101> lol ok 14:03:52 <achow101> #topic libbitcoinkernel updates (TheCharlatan) 14:03:56 <instagibbs> glozow can you drop some pseudo-code on the PR comment :) 14:03:58 <instagibbs> on the new algo 14:04:41 <TheCharlatan> no updates this week 14:04:45 <glozow> instagibbs: will do ð and will take out of draft after I make ci green 14:05:47 <achow101> TheCharlatan: #28048 was merged this week, so #27866 is priority now? 14:05:51 <gribble> https://github.com/bitcoin/bitcoin/issues/28048 | kernel: Remove StartShutdown calls from validation code by ryanofsky ÷ Pull Request #28048 ÷ bitcoin/bitcoin ÷ GitHub 14:05:52 <gribble> https://github.com/bitcoin/bitcoin/issues/27866 | blockstorage: Return on fatal flush errors by TheCharlatan ÷ Pull Request #27866 ÷ bitcoin/bitcoin ÷ GitHub 14:06:12 <TheCharlatan> Still need to rework that one 14:06:28 <bitcoin-git> [bitcoin] TheCharlatan opened pull request #28113: kernel: Remove UniValue from kernel library (master...kernelRmUnivalue) https://github.com/bitcoin/bitcoin/pull/28113 14:06:36 <achow101> ah ok 14:06:38 <stickies-v> I don't think we have any reviewable PRs atm then, right? given that #28051 needs rebase 14:06:38 <TheCharlatan> Take this one instead ^ 14:06:39 <gribble> https://github.com/bitcoin/bitcoin/issues/28051 | Get rid of shutdown.cpp/shutdown.h, use SignalInterrupt directly by ryanofsky ÷ Pull Request #28051 ÷ bitcoin/bitcoin ÷ GitHub 14:07:00 <stickies-v> (and also draft) 14:07:08 <josie> oh thank goodness. had to work with univalue this week and never want to touch it again 14:07:12 <luke-jr> lol 14:07:18 <ryanofsky> I'm happy to update 28051, but I think it is more of a code cleanup, and not directly related to kernel stuff 14:08:07 <achow101> updated the board 14:08:19 <achow101> #topic assumeutxo updates (jamesob) 14:08:40 <jamesob> same ol', waiting on review/merge of #27746 and then will rebase the big guy on top of resulting master 14:08:41 <luke-jr> extra space at the start there 14:08:44 <gribble> https://github.com/bitcoin/bitcoin/issues/27746 | Rework validation logic for assumeutxo by sdaftuar ÷ Pull Request #27746 ÷ bitcoin/bitcoin ÷ GitHub 14:09:07 <achow101> 27746 is back on the top of my list since it just got rebased 14:09:43 <jamesob> hopefully after that's in, we can get some review/testing effort around the big guy and be done with this thing 14:10:45 <achow101> #topic BIP 324 updates take 2 (sipa) 14:10:51 <sipa> (am back) 14:11:43 <achow101> #27985 was merged, so #28008 is next, yes? 14:11:45 <gribble> https://github.com/bitcoin/bitcoin/issues/27985 | Add support for RFC8439 variant of ChaCha20 by sipa ÷ Pull Request #27985 ÷ bitcoin/bitcoin ÷ GitHub 14:11:46 <gribble> https://github.com/bitcoin/bitcoin/issues/28008 | BIP324 ciphersuite by sipa ÷ Pull Request #28008 ÷ bitcoin/bitcoin ÷ GitHub 14:12:04 <sipa> Yeah, dependencies for 28008 are in, so next one is 28008. 14:12:25 <jamesob> (as an aside, been reviewing 28008 for the last few days) 14:12:50 <sipa> Since we ended up converting a bunch of code to Spans/std::bytes in the process, I also opened #28100, though that's more a refactor, and could go in before or after 28008, or not at all. 14:12:51 <gribble> https://github.com/bitcoin/bitcoin/issues/28100 | crypto: more `Span ` modernization & follow-ups by sipa ÷ Pull Request #28100 ÷ bitcoin/bitcoin ÷ GitHub 14:13:31 <sipa> I've been spending time thinking about next steps, which is the integration into net code, where I'm beginning to feel some restructuring of the code would be better too. 14:14:31 <achow101> cool 14:14:31 <sipa> In particular, currently all the packet checksumming happens inside the net_processing thread, while the packet checksum verification happens in the net thread. It'd be both cleaner, and I think more desirable from a resource allocation perspective, to do both in the net thread (which is generally low computationally). 14:15:00 <sipa> So I'm looking into seeing how big of a change that'd be, and if it's not too much, that's probably the next PR I'll open. 14:15:44 <achow101> looking forward to it 14:15:49 <achow101> #topic Ad-hoc high priority for review 14:16:08 <achow101> anything to add or remove from https://github.com/orgs/bitcoin/projects/1/views/4 14:16:34 <achow101> darosior: #27255 needs rebasing 14:16:37 <gribble> https://github.com/bitcoin/bitcoin/issues/27255 | MiniTapscript: port Miniscript to Tapscript by darosior ÷ Pull Request #27255 ÷ bitcoin/bitcoin ÷ GitHub 14:16:42 <darosior> achow101: i'm on it 14:17:28 <sipa> I did start reviewing 27255, but want to get through a few more commits before posting. 14:17:39 <darosior> Cool! 14:18:00 <hebasto> achow101: mind adding #26762 for hi prio for me? 14:18:04 <gribble> https://github.com/bitcoin/bitcoin/issues/26762 | bugfix: Make `CCheckQueue` RAII-styled (attempt 2) by hebasto ÷ Pull Request #26762 ÷ bitcoin/bitcoin ÷ GitHub 14:18:33 <achow101> hebasto: added 14:18:45 <hebasto> ty :) 14:18:57 <achow101> any other topics to dicsuss today? 14:20:47 <achow101> #endmeeting