19:00:10 <achow101> #startmeeting 19:00:11 <core-meetingbot> Meeting started Thu Apr 13 19:00:10 2023 UTC. The chair is achow101. Information about MeetBot at https://bitcoin.jonasschnelli.ch/ircmeetings. 19:00:11 <core-meetingbot> Available commands: action commands idea info link nick 19:00:27 <achow101> #bitcoin -core-dev Meeting: achow101 _aj_ amiti ariard aureleoules b10c BlueMatt brunoerg cfields darosior dergoegge dongcarl fanquake fjahr furszy gleb glozow hebasto instagibbs jamesob jarolrod jonatack josibake kallewoof kanzure kouloumos kvaciral laanwj LarryRuane lightlike luke-jr MacroFake Murch phantomcircuit pinheadmz promag provoostenator ryanofsky sdaftuar S3RK stickies-v sipa theStack vasild 19:00:29 <hebasto> hi 19:00:56 <achow101> There are no pre-proposed meeting topics this week. Does anyone have any last minutes topics to discuss? 19:01:00 <jonatack> hi 19:01:10 <lightlike> hi 19:01:15 <kouloumos> hi 19:01:35 <brunoerg> hi 19:02:01 <achow101> #topic 25.0 milestone 19:02:02 <core-meetingbot> topic: 25.0 milestone 19:02:13 <achow101> We're in feature freeze for 25.0, with branching scheduled for tomorrow 19:02:14 <sipa> hi 19:02:21 <achow101> anything to add or remove from the milestone? 19:02:27 <achow101> https://github.com/bitcoin/bitcoin/milestone/56 19:03:36 <achow101> istm we should be able to keep the schedule, there don't seem to be any major issues that would warrant delaying it 19:04:41 <fanquake> aside from infra. which should be sorted shortly 19:04:43 <kanzure> hi 19:04:59 <hebasto> all is done in GUI -- https://github.com/bitcoin-core/gui/milestone/9 19:05:26 <achow101> the prs in the milestone are #27231 #27374 #27253 #27145 and #25968. it's not clear to me that these are all bug fixes that should be inclued in the milestone 19:05:29 <gribble> https://github.com/bitcoin/bitcoin/issues/27374 | p2p: skip netgroup diversity of new connections for tor/i2p/cjdns by stratospher ÷ Pull Request #27374 ÷ bitcoin/bitcoin ÷ GitHub 19:05:31 <gribble> https://github.com/bitcoin/bitcoin/issues/27231 | Fix logging RPC and -debugexclude with 0/none values, add test coverage, improve docs by jonatack ÷ Pull Request #27231 ÷ bitcoin/bitcoin ÷ GitHub 19:05:33 <gribble> https://github.com/bitcoin/bitcoin/issues/27253 | httpserver, rest: fix segmentation fault on evhttp_uri_get_query by pablomartin4btc ÷ Pull Request #27253 ÷ bitcoin/bitcoin ÷ GitHub 19:05:34 <gribble> https://github.com/bitcoin/bitcoin/issues/25968 | Optimizations & simplifications following #25717 by sipa ÷ Pull Request #25968 ÷ bitcoin/bitcoin ÷ GitHub 19:05:36 <gribble> https://github.com/bitcoin/bitcoin/issues/27145 | wallet: when a block is disconnected, update transactions that are no longer conflicted by ishaanam ÷ Pull Request #27145 ÷ bitcoin/bitcoin ÷ GitHub 19:06:03 <sipa> #25968 can be dropped from the milestone, I think 19:06:05 <gribble> https://github.com/bitcoin/bitcoin/issues/25968 | Optimizations & simplifications following #25717 by sipa ÷ Pull Request #25968 ÷ bitcoin/bitcoin ÷ GitHub 19:06:12 <sipa> I don't know what its state is right now. 19:06:28 <sipa> But it's certainly not required. 19:06:32 <achow101> removed it 19:06:36 <sipa> cool 19:08:02 <achow101> I'm not sure if #27374 is a bug fix, but the rest seem to be bug fixes of relatively long-standing issues, so aren't critical/blockers for this release 19:08:05 <gribble> https://github.com/bitcoin/bitcoin/issues/27374 | p2p: skip netgroup diversity of new connections for tor/i2p/cjdns by stratospher ÷ Pull Request #27374 ÷ bitcoin/bitcoin ÷ GitHub 19:09:08 <fanquake> iirc that should go in 19:09:28 <lightlike> if #27374 doesn't make it in, we should instead temporarily revert https://github.com/bitcoin/bitcoin/commit/72e8ffd7f8dbf908e65da6d012ede914596737ab as I explained in https://github.com/bitcoin/bitcoin/issues/27369#issuecomment-1490395263. But doing nothing would introduce a bug IMO. 19:09:30 <gribble> https://github.com/bitcoin/bitcoin/issues/27374 | p2p: skip netgroup diversity of new connections for tor/i2p/cjdns by stratospher ÷ Pull Request #27374 ÷ bitcoin/bitcoin ÷ GitHub 19:09:49 <achow101> ok, so it is a critical bug fix 19:09:57 <jonatack> It looks like 27374 addresses some issues, see https://github.com/bitcoin/bitcoin/pull/27264#issuecomment-1481322628 19:09:59 <achow101> seems close to merging anyways 19:10:25 <Murch> Hi 19:11:40 <Murch> I think #27145 can be dropped from the milestone as well 19:11:42 <gribble> https://github.com/bitcoin/bitcoin/issues/27145 | wallet: when a block is disconnected, update transactions that are no longer conflicted by ishaanam ÷ Pull Request #27145 ÷ bitcoin/bitcoin ÷ GitHub 19:11:53 <Murch> ItâÂÂs also a long standing issue 19:13:13 <achow101> yes, removed it 19:14:15 <achow101> #27231 and #27253 seem fine to keep but shouldn't be blockers. we can drop them if they aren't in by rc2 or something 19:14:17 <gribble> https://github.com/bitcoin/bitcoin/issues/27253 | httpserver, rest: fix segmentation fault on evhttp_uri_get_query by pablomartin4btc ÷ Pull Request #27253 ÷ bitcoin/bitcoin ÷ GitHub 19:14:19 <gribble> https://github.com/bitcoin/bitcoin/issues/27231 | Fix logging RPC and -debugexclude with 0/none values, add test coverage, improve docs by jonatack ÷ Pull Request #27231 ÷ bitcoin/bitcoin ÷ GitHub 19:14:47 <fanquake> I mean they should be in before branch off, or they just go to 26.x 19:15:21 <jonatack> agree. i've iterated a few times on the latter one and it's probably done/ready, but indeed not critical 19:16:45 <achow101> anything else to discuss? 19:18:50 <achow101> #endmeeting