19:02:15 <achow101> #startmeeting 
19:02:15 <core-meetingbot> Meeting started Fri Oct  7 19:02:14 2022 UTC.  The chair is achow101. Information about MeetBot at https://bitcoin.jonasschnelli.ch/ircmeetings.
19:02:15 <core-meetingbot> Available commands: action commands idea info link nick
19:02:25 <achow101> #bitcoin -core-dev Wallet Meeting: achow101 _aj_ amiti ariard BlueMatt cfields Chris_Stewart_5 darosior digi_james dongcarl elichai2 emilengler fanquake fjahr furszy gleb glozow gmaxwell gwillen hebasto instagibbs jamesob jarolrod jb55 jeremyrubin jl2012 jnewbery jonasschnelli jonatack josibake jtimon kallewoof kanzure kvaciral laanwj larryruane lightlike luke-jr maaku marcofalke meshcollider michagogo moneyball morcos Murch nehan NicolasDorier
19:02:25 <achow101> paveljanik petertodd phantomcircuit promag provoostenator ryanofsky sdaftuar S3RK sipa vasild
19:02:57 <achow101> Haven't had a wallet meeting in a while. Does anyone have anything to discuss?
19:03:24 <furszy> hi
19:03:39 <brunoerg> hi
19:05:12 <furszy> just one small thing
19:05:32 <furszy> was thinking about #25269 yesterday
19:05:33 <gribble> https://github.com/bitcoin/bitcoin/issues/25269 | wallet: re-activate the not triggered "AmountWithFeeExceedsBalance" error by furszy · Pull Request #25269 · bitcoin/bitcoin · GitHub
19:07:31 <furszy> the topic would be whether someone would care about that behavior change or not.
19:09:06 <achow101> it seems like the kind of error that would be returned out of coin selection rather than transaction creation?
19:09:42 <achow101> I do think it would be a useful error as it can be confusing when the balance is enough for the recipient amount but not for the fee
19:13:05 <furszy> yeah, could be there too. The thing is do we want to include it for v24.0?
19:13:13 <achow101> No, not for 24.0
19:13:17 <achow101> it's not a regression, nor a bug
19:13:40 <achow101> Improving these error messages is basically a feature
19:13:51 <furszy> we were throwing it before actually
19:14:09 <furszy> it was removed in #20640 by mistake
19:14:11 <gribble> https://github.com/bitcoin/bitcoin/issues/20640 | wallet, refactor: return out-params of CreateTransaction() as optional struct by theStack · Pull Request #20640 · bitcoin/bitcoin · GitHub
19:14:38 <furszy> thus why the wallet model had this stuff
19:14:41 <furszy> https://github.com/bitcoin/bitcoin/pull/25269/commits/aa2b2172106fbd89812efb0c7010c9a400e7dd0f
19:15:59 <achow101> oh, I'll have to take a closer look into it
19:16:24 <achow101> if we've accidentally removed it for this release, then I think we should try to put it back
19:16:37 <achow101> but if doing that is too involved, we can just add a "known issue" in the release notes
19:16:52 <achow101> I don't think it's critical
19:17:38 <furszy> yeah for sure, not critical at all. Just something that came up to my head yesterday.
19:18:18 <bitcoin-git> [bitcoin] jamesob opened pull request #26282: wallet: have prune error take precedence over assumedvalid (master...2022-10-fix-au-wallet) https://github.com/bitcoin/bitcoin/pull/26282
19:19:39 <achow101> anything else to discuss?
19:22:12 <achow101> seems not
19:22:14 <achow101> #endmeeting