19:04:04 <laanwj> #startmeeting 19:04:05 <core-meetingbot> Meeting started Thu Sep 15 19:04:04 2022 UTC. The chair is laanwj. Information about MeetBot at https://bitcoin.jonasschnelli.ch/ircmeetings. 19:04:05 <core-meetingbot> Available commands: action commands idea info link nick 19:04:20 <achow101> hi 19:04:24 <fanquake> hi 19:04:29 <laanwj> #bitcoin -core-dev Meeting: achow101 _aj_ amiti ariard b10c BlueMatt cfields Chris_Stewart_5 darosior digi_james dongcarl elichai2 emilengler fanquake fjahr gleb glozow gmaxwell gwillen hebasto instagibbs jamesob jarolrod jb55 jeremyrubin jl2012 jnewbery jonasschnelli jonatack jtimon kallewoof kanzure kvaciral laanwj larryruane lightlike luke-jr maaku marcofalke meshcollider michagogo 19:04:30 <laanwj> moneyball morcos nehan NicolasDorier paveljanik petertodd phantomcircuit promag provoostenator ryanofsky sdaftuar sipa vasild 19:04:37 <laanwj> welcome to the weekly bitcoin-core-dev meeting 19:04:38 <jarolrod> hi 19:04:42 <kouloumos> hi 19:04:58 <laanwj> one proposed meeting topic this week: important changes in 24.0 to cover in the new RC Testing Guide (kouloumos) 19:05:05 <ajonas> hi 19:05:05 <lightlike> hi 19:05:18 <kanzure> hi 19:05:32 <achow101> will we be branching today too? 19:05:40 <furszy> hi 19:05:48 <cfields> hi 19:06:17 <sipa> hi 19:06:18 <laanwj> achow101: that's another topic to discuss 19:06:42 <kouloumos> should I go first or we are discussing high-priority first? 19:07:40 <hebasto> hi 19:07:41 <laanwj> we don't do high priority at the moment, though we could go over the milesteone 19:08:05 <fanquake> https://github.com/bitcoin/bitcoin/milestone/54 19:08:26 <laanwj> it seems that there's still some PRs open that need to go in before the split-off- anyhow 19:08:49 <MacroFake> Yeah, backporting one or two things is fine, but 5 seems too much 19:08:53 <laanwj> fanquake: ah im glad you noticed the release fragments in doc/release-notes, in #26093 19:08:54 <gribble> https://github.com/bitcoin/bitcoin/issues/26093 | doc: consolidate release-note fragments pre-wiki by fanquake ÷ Pull Request #26093 ÷ bitcoin/bitcoin ÷ GitHub 19:09:19 <laanwj> i noticed those a few days ago then forgot to comment 19:09:56 <fanquake> A couple PRs on the milestone almost ready for merge. The few others likely be resolved / mergable in the next day or so I think. 19:10:12 <laanwj> MacroFake: right, backports makes sense for things that come as a surprise, not what has been open already for a while 19:11:43 <MacroFake> Maybe #26005 can be merged an someone picks up the feedback in a follow-up? 19:11:45 <gribble> https://github.com/bitcoin/bitcoin/issues/26005 | Wallet: Fix error handling (copy_file failure in RestoreWallet, and in general via interfaces) by luke-jr ÷ Pull Request #26005 ÷ bitcoin/bitcoin ÷ GitHub 19:11:54 <laanwj> ok, so i think the answer is no, no branch-off today, there are still some things that need to go in 19:12:19 <lightlike> #26068 doesn't look likely to be resolved in the near future (at least I don't know why it happens / couldn't reproduce) 19:12:21 <gribble> https://github.com/bitcoin/bitcoin/issues/26068 | Segmentation fault in the scheduler thread when an index fails to commit to the db ÷ Issue #26068 ÷ bitcoin/bitcoin ÷ GitHub 19:12:23 <achow101> MacroFake: I think that's reasonable 19:13:18 <MacroFake> lightlike: Did you try to force the failed commit, or just run the unit test as is? 19:14:27 <MacroFake> Locally I can't reproduce almost no issue seen in the CI and usually I have to modify the source code to force a sleep in the right place or so. 19:15:44 <lightlike> MacroFake: ran the test as it, and tried to change order of subtests in the src file to see if that could have been the reason, because in the failed CI runs the second subtest was run before the first one 19:16:17 <MacroFake> ok, I might take another look tomorrow, but otherwise it shouldn't block rc1 for now 19:17:28 <MacroFake> #25985 is just a performance thing, and not even a regression, so shouldn't block rc1 either 19:17:29 <gribble> https://github.com/bitcoin/bitcoin/issues/25985 | Revert "build: Use Homebrews sqlite package if it is available" by fanquake ÷ Pull Request #25985 ÷ bitcoin/bitcoin ÷ GitHub 19:17:42 <fanquake> I somewhat disagree 19:18:29 <fanquake> It's causing continual confusion downstream, a new report overnight of devs becoming confused over terrible performance, this time in BDK: https://github.com/bitcoindevkit/bdk/issues/749 19:19:59 <fanquake> Although this is also easy to backport, so doesn't matter too much 19:20:16 <achow101> It also doesn't have any effect on our release binaries 19:20:17 <laanwj> doesn't seem too risky to merge an OSX specific build system revert? 19:21:46 <fanquake> Yea, any risk is limited to compiling on macOS, which is why it's mostly devs posting issues 19:23:27 <laanwj> #topic important changes in 24.0 to cover in the new RC Testing Guide (kouloumos) 19:23:27 <core-meetingbot> topic: important changes in 24.0 to cover in the new RC Testing Guide (kouloumos) 19:23:39 <kouloumos> I'm working on the 24.0 RC Testing Guide and I'd like to get some feedback on which changes are considered important and useful to test. 19:23:46 <kouloumos> The current version is available here: https://gist.github.com/kouloumos/fc112640a533e522d435c0995dcaaaf4 19:23:53 <kouloumos> From the release notes ( https://github.com/bitcoin-core/bitcoin-devwiki/wiki/24.0-Release-Notes-draft ), I've already included testing guidance for 4 changes that I think most worthwhile to test and I have 1 pending. I'd appreciate feedback on if you think anything else should be included, and if maybe something can be omitted. 19:24:05 <kouloumos> The changes I've included are: 19:24:10 <kouloumos> 1) Using the GUI to restore a wallet from a backup file (#471) 19:24:11 <gribble> https://github.com/bitcoin/bitcoin/issues/471 | DbException after Ctrl+C on bitcoind.exe (Windows) ÷ Issue #471 ÷ bitcoin/bitcoin ÷ GitHub 19:24:15 <kouloumos> 2) Peristent settings are now unified between bitcoind and the GUI. (#15936,#602) 19:24:19 <gribble> https://github.com/bitcoin/bitcoin/issues/15936 | interfaces: Expose settings.json methods to GUI by ryanofsky ÷ Pull Request #15936 ÷ bitcoin/bitcoin ÷ GitHub 19:24:20 <gribble> https://github.com/bitcoin/bitcoin/issues/602 | Cleaned up critical section code. by cgaebel ÷ Pull Request #602 ÷ bitcoin/bitcoin ÷ GitHub 19:24:21 <kouloumos> 3) Using the new migratewallet RPC to migrate legacy wallets to descriptor wallets. (#19602) 19:24:23 <gribble> https://github.com/bitcoin/bitcoin/issues/19602 | wallet: Migrate legacy wallets to descriptor wallets by achow101 ÷ Pull Request #19602 ÷ bitcoin/bitcoin ÷ GitHub 19:24:28 <kouloumos> 4) Wallet support for watchonly Miniscript descriptors. (#24148) 19:24:31 <gribble> https://github.com/bitcoin/bitcoin/issues/24148 | Miniscript support in Output Descriptors by darosior ÷ Pull Request #24148 ÷ bitcoin/bitcoin ÷ GitHub 19:24:38 <kouloumos> The additional change that I am planning to add is: 19:24:41 <kouloumos> 5) The new `sendall` RPC, useful to empty wallets or to create a changeless payment from select UTXOs. (#24118) 19:24:44 <gribble> https://github.com/bitcoin/bitcoin/issues/24118 | Add sendall RPC née sweep by Xekyo ÷ Pull Request #24118 ÷ bitcoin/bitcoin ÷ GitHub 19:24:54 <kouloumos> Also, glozow suggested, and I am currently looking at: 19:24:58 <kouloumos> 6) Observe pre-syncing step during IBD (#25717) 19:25:05 <gribble> https://github.com/bitcoin/bitcoin/issues/25717 | p2p: Implement anti-DoS headers sync by sdaftuar ÷ Pull Request #25717 ÷ bitcoin/bitcoin ÷ GitHub 19:25:11 <kouloumos> 7) Try new RPC gettxspendingprevout (#25874) 8) Try -mempoolfullrbf option (#25353) 19:25:12 <gribble> https://github.com/bitcoin/bitcoin/issues/25874 | BIP155 CJDNS address with length 187 (should be 16) ÷ Issue #25874 ÷ bitcoin/bitcoin ÷ GitHub 19:25:14 <gribble> https://github.com/bitcoin/bitcoin/issues/25353 | Add a `-mempoolfullrbf` node setting by ariard ÷ Pull Request #25353 ÷ bitcoin/bitcoin ÷ GitHub 19:25:28 <sipa> Cool 19:25:55 <lightlike> +1 for #25717 - can be tested by syncing headers on mainnet, testnet etc. with -stopatheight=1000 or so, with or without gui 19:25:59 <gribble> https://github.com/bitcoin/bitcoin/issues/25717 | p2p: Implement anti-DoS headers sync by sdaftuar ÷ Pull Request #25717 ÷ bitcoin/bitcoin ÷ GitHub 19:26:53 <kouloumos> lightlike: appreciate the suggestion! 19:28:01 <sipa> For 25717 observing the pre-syncing phase is one thing (it should be there), but arguably the more interesting property is that syncing still works at all. It's only triggered when syncing a new node from scratch, or one that is ~months or more behind. 19:29:24 <lightlike> yes, the test guide should recommend to use an empty datadir for that. 19:30:02 <kouloumos> Yes, that's already suggested on every test. 19:32:15 <bitcoin-git> [bitcoin] stickies-v opened pull request #26103: refactor: mempool: use CTxMemPool::Limits (master...mempool-simplify-fn-signatures) https://github.com/bitcoin/bitcoin/pull/26103 19:32:39 <kouloumos> Great! thank you everyone, I'll look into including 25717 and give progress updates in https://github.com/bitcoin/bitcoin/issues/26092 . Please reach out with ideas and feedback. Thanks! 19:32:57 <kouloumos> Note: I'll also need write access to bitcoindev-wiki to add the guide. 19:32:59 <sipa> Feel free to ping me here if you have questions. 19:34:25 <kouloumos> I'll do! thanks 19:36:29 <laanwj> ok let's give you write access to the wiki 19:37:50 <laanwj> any other topics? 19:38:54 <laanwj> appparently not, let's close the meeting 19:38:56 <laanwj> #endmeeting