19:00:40 <achow101> #startmeeting 19:00:43 <achow101> #bitcoin -core-dev Wallet Meeting: achow101 _aj_ amiti ariard BlueMatt cfields Chris_Stewart_5 darosior digi_james dongcarl elichai2 emilengler fanquake fjahr gleb glozow gmaxwell gwillen hebasto instagibbs jamesob jarolrod jb55 jeremyrubin jl2012 jnewbery jonasschnelli jonatack josibake jtimon kallewoof kanzure kvaciral laanwj larryruane lightlike luke-jr maaku marcofalke meshcollider michagogo moneyball morcos Murch nehan NicolasDorier 19:00:43 <achow101> paveljanik petertodd phantomcircuit promag provoostenator ryanofsky sdaftuar S3RK sipa vasild 19:01:16 <achow101> There are no pre-proposed wallet meeting topics. does anyone have anything to discuss? 19:03:59 <furszy> hello, I have #25272. 19:04:00 <gribble> https://github.com/bitcoin/bitcoin/issues/25272 | wallet: guard and alert about a wallet invalid state during chain sync by furszy ÷ Pull Request #25272 ÷ bitcoin/bitcoin ÷ GitHub 19:04:37 <S3RK> hi 19:05:34 <achow101> furszy: anything specific about that you want to discuss? 19:05:44 <furszy> yeah, was writing hehe 19:06:21 <furszy> was thinking about whether we should abort if db write fails or we shall continue and try to store the transactions later 19:08:03 <achow101> our pattern in the wallet is generally to throw an error if db writes fail 19:08:20 <achow101> so I think it's fine to abort 19:09:42 <furszy> yeah, I think so as well. Was thinking about whether is any temporal cause that could make write fail 19:10:16 <furszy> but guess that not. As you told me in a DM, if the write failed is surely because the user made something nasty 19:10:26 <achow101> yeah 19:10:37 <achow101> I don't think there's really any situation where we expect a db write to fail 19:11:40 <furszy> yeah, then all good there 19:11:51 <achow101> ok 19:11:58 <achow101> anyone have anything else to discuss? 19:13:28 <achow101> seems not 19:13:30 <achow101> #endmeeting