19:01:15 <laanwj> #startmeeting 19:01:15 <core-meetingbot> Meeting started Thu May 12 19:01:15 2022 UTC. The chair is laanwj. Information about MeetBot at https://bitcoin.jonasschnelli.ch/ircmeetings. 19:01:15 <core-meetingbot> Available commands: action commands idea info link nick 19:01:24 <Murch> hi 19:01:25 <sipsorcery> hi 19:01:28 <_aj_> hiii 19:01:31 <fanquake> hi 19:01:43 <laanwj> hii 19:01:57 <ariard> hi 19:02:05 <laanwj> #bitcoin -core-dev Meeting: achow101 _aj_ amiti ariard BlueMatt cfields Chris_Stewart_5 darosior digi_james dongcarl elichai2 emilengler fanquake fjahr gleb glozow gmaxwell gwillen hebasto instagibbs jamesob jarolrod jb55 jeremyrubin jl2012 jnewbery jonasschnelli jonatack jtimon kallewoof kanzure kvaciral laanwj larryruane lightlike luke-jr maaku marcofalke meshcollider michagogo moneyball 19:02:07 <laanwj> morcos nehan NicolasDorier paveljanik petertodd phantomcircuit promag provoostenator ryanofsky sdaftuar sipa vasild 19:02:19 <jonatack> hallo 19:02:39 <laanwj> it looks like no topics have been proposed in advance this week 19:02:57 <sipa> hi 19:03:17 <laanwj> it could be that glozow would like to talk about package relay updates again 19:03:33 <laanwj> any last minute topics? 19:04:06 <kvaciral> hi! 19:04:20 <jeremyrubin> sup 19:04:32 <_aj_> glozow said "another week" not "next week" last week 19:04:45 <laanwj> _aj_: oh, right 19:05:07 <laanwj> i wasn't sure 19:05:23 <_aj_> laanwj: me either, but irc logs don't lie right 19:05:30 <laanwj> #topic High priority for review 19:05:30 <core-meetingbot> topic: High priority for review 19:06:03 <_aj_> review beg for #24032 and #25109 19:06:06 <gribble> https://github.com/bitcoin/bitcoin/issues/24032 | Add defaults to vDeployments to avoid uninitialized variables by ajtowns ÷ Pull Request #24032 ÷ bitcoin/bitcoin ÷ GitHub 19:06:06 <gribble> https://github.com/bitcoin/bitcoin/issues/25109 | Strengthen AssertLockNotHeld assertions by ajtowns ÷ Pull Request #25109 ÷ bitcoin/bitcoin ÷ GitHub 19:06:52 <laanwj> https://github.com/bitcoin/bitcoin/projects/8 has: 13 blockers, 1 chasing conept ACK 19:07:40 <laanwj> anything to add, remove, or that is on the list and (almost) ready for merge? 19:08:04 <jeremyrubin> Would be good to get more conceptual review on #22876, which is a precursor for my high prio. has conceptual ack that this is a bit of an issue in how our script flag system is set up, is an issue that affects any and all R&D on things that happen in script wrt discouraging (e.g. CTV, APO, etc). 19:08:05 <gribble> https://github.com/bitcoin/bitcoin/issues/22876 | [TESTS] Update Transaction Tests to permit setting a flag as always on and disabling the exhaustive failure test by JeremyRubin ÷ Pull Request #22876 ÷ bitcoin/bitcoin ÷ GitHub 19:08:32 <jeremyrubin> but it seems that theres some sentiment there might be a 'purer' way to handle it... i dont have any other ideas other than what i did 19:10:08 <laanwj> should i add it to chasing concept ACK? 19:11:08 <jeremyrubin> i'm not sure 19:11:22 <jeremyrubin> maybe _aj_ should have a look since he's maintaining the APO branch? 19:11:39 <jeremyrubin> How would you write test vectors for APO without these patches? 19:11:47 <laanwj> oh, just added it 19:12:31 <jeremyrubin> seems fine 19:13:06 <jeremyrubin> i just want to underscore this isn't a ctv specific precursor, impacts anyone working on any opcode stuff if you want to write test vectors. so please review if you're doing that at all 19:13:50 <laanwj> yes it seems like a pretty general tests change, judging from the title 19:14:55 <laanwj> anything else to add/remove? any other topics people would like to discuss? 19:14:56 <_aj_> jeremyrubin: will look 19:16:09 <jeremyrubin> ah also #22954 is related to the earlier one for any following along, equivalent for tx_valid/tx_invalid 19:16:11 <gribble> https://github.com/bitcoin/bitcoin/issues/22954 | [TESTS] Allow tx_invalid.json tests to include flag rules for if_unset: [A,B,C] then_unset: [D] by JeremyRubin ÷ Pull Request #22954 ÷ bitcoin/bitcoin ÷ GitHub 19:16:40 <jeremyrubin> probably getting the first one looked over would be sufficient for now though 19:17:09 <laanwj> better to focus on one at a time probably 19:18:03 <laanwj> seems no other topics! well, another short meeting then, hope you can use the rest of the time for reviewing :) 19:18:12 <laanwj> #endmeeting