19:00:52 <laanwj> #startmeeting 19:00:52 <core-meetingbot> Meeting started Thu Apr 28 19:00:52 2022 UTC. The chair is laanwj. Information about MeetBot at https://bitcoin.jonasschnelli.ch/ircmeetings. 19:00:52 <core-meetingbot> Available commands: action commands idea info link nick 19:01:03 <hebasto> hi 19:01:19 <laanwj> #bitcoin -core-dev Meeting: achow101 _aj_ amiti ariard BlueMatt cfields Chris_Stewart_5 darosior digi_james dongcarl elichai2 emilengler fanquake fjahr gleb glozow gmaxwell gwillen hebasto instagibbs jamesob jarolrod jb55 jeremyrubin jl2012 jnewbery jonasschnelli jonatack jtimon kallewoof kanzure kvaciral laanwj larryruane lightlike luke-jr maaku marcofalke meshcollider michagogo moneyball 19:01:20 <laanwj> morcos nehan NicolasDorier paveljanik petertodd phantomcircuit promag provoostenator ryanofsky sdaftuar sipa vasild 19:01:24 <glozow> hi 19:01:31 <sipsorcery> hi 19:01:48 <sipa> hi 19:01:49 <laanwj> welcome to the weekly general bitcoin-core-dev meeting! 19:02:07 <laanwj> there have been no topics proposed in advance using #proposedmeetingtopic, any last minute ones people would like to discuss today? 19:02:49 <cfields> hi 19:02:55 <jonatack> 10 print "hi" 20 goto 10 19:03:10 <dongcarl> I can give a very quick update/announcement on libbitcoinkernel if no other topics are there 19:03:33 <lightlike> hi 19:03:50 <laanwj> dongcarl: sounds good to me, let's have that as topic after high prio for review 19:03:57 <dongcarl> cool 19:04:09 <jonatack> dongcarl: post-merge ack modulo the clang build chatter ;) 19:04:11 <kanzure> hi 19:04:12 <jeremyrubin> Hi 19:04:38 <laanwj> #topic High priority for review 19:04:38 <core-meetingbot> topic: High priority for review 19:05:02 <laanwj> currently 11 blockers 1 chasing concept ACK https://github.com/bitcoin/bitcoin/projects/8 19:05:32 <laanwj> anything to add/remove? 19:05:45 <achow101> hi 19:05:49 <laanwj> or that's on the list and (almost) ready for merge 19:06:38 <lightlike> #24322 was merged and can be removed 19:06:40 <gribble> https://github.com/bitcoin/bitcoin/issues/24322 | [kernel 1/n] Introduce initial `libbitcoinkernel` by dongcarl ÷ Pull Request #24322 ÷ bitcoin/bitcoin ÷ GitHub 19:06:54 <glozow> #23443 seems close, though needs rebase 19:06:58 <gribble> https://github.com/bitcoin/bitcoin/issues/23443 | p2p: Erlay support signaling by naumenkogs ÷ Pull Request #23443 ÷ bitcoin/bitcoin ÷ GitHub 19:07:30 <jonatack> #24757 for me, please 19:07:31 <gribble> https://github.com/bitcoin/bitcoin/issues/24757 | build, ci: add `DEBUG_LOCKCONTENTION` to --enable-debug and CI by jonatack ÷ Pull Request #24757 ÷ bitcoin/bitcoin ÷ GitHub 19:07:57 <laanwj> lightlike: even better! should we add the next one dongcarl? 19:08:05 <laanwj> glozow: thanks! 19:08:14 <dongcarl> Yes! #24410 it is 19:08:15 <gribble> https://github.com/bitcoin/bitcoin/issues/24410 | [kernel 2a/n] Split hashing/index `GetUTXOStats` codepaths, decouple from `coinstatsindex` by dongcarl ÷ Pull Request #24410 ÷ bitcoin/bitcoin ÷ GitHub 19:08:40 <laanwj> jonatack: added 19:08:40 <sipa> kernel 2a is written in c++2a? 19:09:02 <dongcarl> Hahaha I wish! 19:09:10 <laanwj> dongcarl: added 19:09:15 <dongcarl> laanwj: Thanks! 19:10:45 <laanwj> #topic Quick update on libbitcoinkernel (dongcarl) 19:10:45 <core-meetingbot> topic: Quick update on libbitcoinkernel (dongcarl) 19:10:53 <dongcarl> Hi all, after the merge of #24322, the initial build systems changes of libbitcoinkernel are done. 19:10:55 <gribble> https://github.com/bitcoin/bitcoin/issues/24322 | [kernel 1/n] Introduce initial `libbitcoinkernel` by dongcarl ÷ Pull Request #24322 ÷ bitcoin/bitcoin ÷ GitHub 19:11:03 <dongcarl> We will now be doing the more meaningful part of decoupling consensus from other modules. I hope that these PRs will have a wider review base, since it doesnâÂÂt require any knowledge of build system minutiae. 19:11:15 <dongcarl> The first PR ready for review is #24410, which is fairly straightforward. 19:11:16 <gribble> https://github.com/bitcoin/bitcoin/issues/24410 | [kernel 2a/n] Split hashing/index `GetUTXOStats` codepaths, decouple from `coinstatsindex` by dongcarl ÷ Pull Request #24410 ÷ bitcoin/bitcoin ÷ GitHub 19:11:24 <dongcarl> A lot of these PRs are not dependent on each other, so at times we will have multiple PRs that are ready for review and not based on one another. ThereâÂÂs no need to wait for a PR to be merged to review the other one! 19:11:32 <jonatack> laanwj: ty! 19:11:37 <dongcarl> One last note: IâÂÂm happy to chat about any of these PRs to get people up to speed. It also helps me know what parts are unclear so I can improve my docs/commit messages. 19:11:56 <dongcarl> Hit me up on any communication channel, and I'm also more than happy to do a video/audio call for better bandwidth 19:12:27 <dongcarl> is done, but can answer questions if people have any 19:12:46 <sipa> Cool. 19:12:47 <laanwj> dongcarl: thanks for the update 19:13:17 <dongcarl> :) 19:13:32 <laanwj> sounds clear to me, there's a lot to review but hopefully we can make quite some progress before 24.0 19:14:09 <dongcarl> Yup that is my hope too. If anyone spots anything that I could be doing to make things easier to review, let me know! 19:14:30 <hebasto> dongcarl: thanks! 19:14:41 <jonatack> dongcarl: do you recommend we developers build with --enable-experimental-util-chainstate or --with-experimental-kernel-lib? (for the moment i have both in my bash alias) 19:15:21 <dongcarl> jonatack: setting --enable-experimental-util-chainstate will automatically turn on --with-experimental-kernel-lib, unless you set --without-experimental-kernel-lib, in which case configure will fail 19:16:08 <laanwj> heh 19:16:30 <jonatack> ok, thanks, so --enable-experimental-util-chainstate sgtm then (and [kernel 2a/n] looks straightforward to review) 19:16:47 <dongcarl> jonatack: :-) 19:17:03 <cfields> atm the results are intended to be not very usable, but the kernel lib and bitcoin-chainstate (excluding some windows weirdness) should at least build successfully. Please report if that's not the case anywhere. 19:18:00 <dongcarl> Many thanks to cfields who got me through various tough situations in kernel 1/n and in upcoming PRs 19:19:16 <cfields> thanks ryanofsky for great review as well. 19:19:49 <dongcarl> ryan truly is of the sky 19:21:24 <laanwj> i guess that concludes the meeting, or does anyone have any last last minute topic 19:21:34 <jonatack> following the review feedback by both of you on [kernel 1a] was enlightening, as were the excellent commit messages 19:23:09 <laanwj> thanks everyone for attending, see you next week 19:23:11 <laanwj> #endmeeting