{
  "founder": "meshcollider",
  "channel": "#bitcoin-core-dev",
  "network": "libera",
  "id": "ec528cb63dea46a1801ac01b23b8c12f",
  "name": "#bitcoin-core-dev",
  "chair": "meshcollider",
  "chairs": [
    "meshcollider"
  ],
  "nicks": {
    "meshcollider": 28,
    "core-meetingbot": 2,
    "achow101": 7,
    "michaelfolkson": 17,
    "gribble": 1,
    "jonatack": 1
  },
  "start_time": "2021-09-10T19:01:49+00:00",
  "end_time": "2021-09-10T19:25:09+00:00",
  "active": false,
  "original_topic": "Bitcoin Core development discussion and commit log | Feel free to watch, but please take commentary and usage questions to #bitcoin | Channel logs: http://www.erisian.com.au/bitcoin-core-dev/, http://gnusha.org/bitcoin-core-dev/ | Meeting topics http://gnusha.org/bitcoin-core-dev/proposedmeetingtopics.txt / http://gnusha.org/bitcoin-core-dev/proposedwalletmeetingtopics.txt",
  "current_topic": null,
  "messages": [
    {
      "id": "6116dc4afe8948f0bc0b7dac9a9cb5e3",
      "sender": "meshcollider",
      "payload": "#startmeeting",
      "action": false,
      "timestamp": "2021-09-10T19:01:49+00:00"
    },
    {
      "id": "c770695209704bb991736b56fc6819d9",
      "sender": "core-meetingbot",
      "payload": "Meeting started Fri Sep 10 19:01:49 2021 UTC.  The chair is meshcollider. Information about MeetBot at https://bitcoin.jonasschnelli.ch/ircmeetings.",
      "action": false,
      "timestamp": "2021-09-10T19:01:49+00:00"
    },
    {
      "id": "3bae7d474bef4f52a54530d64a9e31e6",
      "sender": "core-meetingbot",
      "payload": "Available commands: action commands idea info link nick",
      "action": false,
      "timestamp": "2021-09-10T19:01:49+00:00"
    },
    {
      "id": "e8855245faf247db99adaebdaebe750a",
      "sender": "meshcollider",
      "payload": "#bitcoin-core-dev Wallet Meeting: achow101 aj amiti ariard bluematt cfields Chris_Stewart_5 digi_james dongcarl elichai2 emilengler fanquake fjahr gleb glozow gmaxwell gwillen hebasto instagibbs jamesob jb55 jeremyrubin jl2012 jnewbery jonasschnelli jonatack jtimon kallewoof kanzure kvaciral lightlike luke-jr maaku marcofalke meshcollider michagogo moneyball morcos nehan NicolasDorier paveljanik petertodd phantomcircuit promag",
      "action": false,
      "timestamp": "2021-09-10T19:01:56+00:00"
    },
    {
      "id": "e65b1522e2f84dfaa2d1748714f7be99",
      "sender": "meshcollider",
      "payload": "provoostenator ryanofsky sdaftuar sipa vasild wumpus",
      "action": false,
      "timestamp": "2021-09-10T19:01:56+00:00"
    },
    {
      "id": "3200850464604354b22f9b6447ef05a5",
      "sender": "achow101",
      "payload": "hi",
      "action": false,
      "timestamp": "2021-09-10T19:02:08+00:00"
    },
    {
      "id": "70a66990e21a45c59918eb454c4eca8c",
      "sender": "michaelfolkson",
      "payload": "hi",
      "action": false,
      "timestamp": "2021-09-10T19:02:24+00:00"
    },
    {
      "id": "d0b50797f2264be0a6e9295213465bc9",
      "sender": "meshcollider",
      "payload": "I don't think there have been any proposed topics",
      "action": false,
      "timestamp": "2021-09-10T19:03:02+00:00"
    },
    {
      "id": "b2d024107a4a4856ba06dba3666227b9",
      "sender": "meshcollider",
      "payload": "Any last minute topics to discuss?",
      "action": false,
      "timestamp": "2021-09-10T19:03:13+00:00"
    },
    {
      "id": "a27618c74faf4820893e288a5ca7f7ec",
      "sender": "michaelfolkson",
      "payload": "Do you want to give a brief update on your recent work with Miniscript meshcollider?",
      "action": false,
      "timestamp": "2021-09-10T19:03:46+00:00"
    },
    {
      "id": "568bd55448a04772a6c3f1189b9439d6",
      "sender": "michaelfolkson",
      "payload": ":)",
      "action": false,
      "timestamp": "2021-09-10T19:03:49+00:00"
    },
    {
      "id": "857a8171682e445cb216fe0efa88f2c5",
      "sender": "michaelfolkson",
      "payload": "I saw some activity on the Miniscript repo but haven't looked into it closely",
      "action": false,
      "timestamp": "2021-09-10T19:04:36+00:00"
    },
    {
      "id": "df1a7910ce0f41f0a044780efa49eb42",
      "sender": "meshcollider",
      "payload": "Sure",
      "action": false,
      "timestamp": "2021-09-10T19:04:37+00:00"
    },
    {
      "id": "8deb1ebcf4c745e8a7212dc07ed91b31",
      "sender": "michaelfolkson",
      "payload": "Cool",
      "action": false,
      "timestamp": "2021-09-10T19:04:41+00:00"
    },
    {
      "id": "5c0b28b1043f46ceb121bbee086b6d8e",
      "sender": "meshcollider",
      "payload": "Basically the miniscript repo just has a few open PRs that need to be merged before we can rebase #16800",
      "action": false,
      "timestamp": "2021-09-10T19:05:09+00:00"
    },
    {
      "id": "f5832c02639f44eb972e233b8a2b4b8e",
      "sender": "gribble",
      "payload": "https://github.com/bitcoin/bitcoin/issues/16800 | Basic Miniscript support in output descriptors by sipa \u00c3\u0082\u00c2\u00b7 Pull Request #16800 \u00c3\u0082\u00c2\u00b7 bitcoin/bitcoin \u00c3\u0082\u00c2\u00b7 GitHub",
      "action": false,
      "timestamp": "2021-09-10T19:05:11+00:00"
    },
    {
      "id": "95f80a495b004f84aca0420040da58d9",
      "sender": "michaelfolkson",
      "payload": "Small things?",
      "action": false,
      "timestamp": "2021-09-10T19:05:54+00:00"
    },
    {
      "id": "51e9a07915a345429707a449c69f7325",
      "sender": "achow101",
      "payload": "is it necessary to get those into the miniscript repo in order to rebase?",
      "action": false,
      "timestamp": "2021-09-10T19:05:54+00:00"
    },
    {
      "id": "d656972ab51f47cab4721cd6ae14e702",
      "sender": "meshcollider",
      "payload": "The main thing I've been working on there is to make miniscript parsing from strings and decoding from scripts non-recursive",
      "action": false,
      "timestamp": "2021-09-10T19:05:58+00:00"
    },
    {
      "id": "2cb25c4ff35a44da9e3dad1ad912a4ba",
      "sender": "meshcollider",
      "payload": "achow101: of course I could just merge them in myself and rebase but I think it's better if the PR reflects the miniscript repo so everyone can compare the two",
      "action": false,
      "timestamp": "2021-09-10T19:06:42+00:00"
    },
    {
      "id": "cd24c4de33494f12b5377ca9740b6f6c",
      "sender": "achow101",
      "payload": "i guess so",
      "action": false,
      "timestamp": "2021-09-10T19:07:22+00:00"
    },
    {
      "id": "40a5ab2a853c4d6e9ece53ba45c8dc08",
      "sender": "meshcollider",
      "payload": "They aren't huge changes but obviously there are a lot fewer people reviewing changes over there than in core",
      "action": false,
      "timestamp": "2021-09-10T19:07:26+00:00"
    },
    {
      "id": "5eb27dfc134a4dce952449de2b1b1056",
      "sender": "achow101",
      "payload": "it's likely they will diverge once review actually gets going",
      "action": false,
      "timestamp": "2021-09-10T19:07:29+00:00"
    },
    {
      "id": "92063b30fe3a403d874591058241c2ff",
      "sender": "michaelfolkson",
      "payload": "In what ways were they recursive?",
      "action": false,
      "timestamp": "2021-09-10T19:07:47+00:00"
    },
    {
      "id": "0a88a96b00f6431eb13ecd33d5590ad3",
      "sender": "meshcollider",
      "payload": "So mainly things are just waiting for sipa to have some time",
      "action": false,
      "timestamp": "2021-09-10T19:07:49+00:00"
    },
    {
      "id": "26eaaf292b3f41a3a480e58d3195b32c",
      "sender": "meshcollider",
      "payload": "michaelfolkson: the current Parse() implementation recurses on every miniscript expression basically",
      "action": false,
      "timestamp": "2021-09-10T19:08:38+00:00"
    },
    {
      "id": "140b9d08f41f4b5c8539e438eee7dc3d",
      "sender": "achow101",
      "payload": "is the miniscript repo being updated/up-to-date with rust-miniscript?",
      "action": false,
      "timestamp": "2021-09-10T19:08:52+00:00"
    },
    {
      "id": "b849bf81f3474dd4875d1e458ad5f0b8",
      "sender": "jonatack",
      "payload": "hi",
      "action": false,
      "timestamp": "2021-09-10T19:08:56+00:00"
    },
    {
      "id": "da5176601bbb46a292a7f26425311aac",
      "sender": "achow101",
      "payload": "(w.r.t miniscript semantics)",
      "action": false,
      "timestamp": "2021-09-10T19:09:24+00:00"
    },
    {
      "id": "b03769288196465c9c7f91c393bbec62",
      "sender": "michaelfolkson",
      "payload": "meshcollider: Oh interesting. Found your PR https://github.com/sipa/miniscript/pull/66",
      "action": false,
      "timestamp": "2021-09-10T19:09:36+00:00"
    },
    {
      "id": "4f06c78d86394d70975658820957f874",
      "sender": "meshcollider",
      "payload": "achow101: yes, both are \"current\" w.r.t semantics to the best of my knowledge",
      "action": false,
      "timestamp": "2021-09-10T19:09:53+00:00"
    },
    {
      "id": "8fb39cf627b5453f80ea11362d382956",
      "sender": "meshcollider",
      "payload": "I haven't compared closely with the rust version",
      "action": false,
      "timestamp": "2021-09-10T19:10:03+00:00"
    },
    {
      "id": "3889f26d249747d28046c4e997de53e6",
      "sender": "achow101",
      "payload": "cool. so the prs you're doing are mostly just cleanups",
      "action": false,
      "timestamp": "2021-09-10T19:11:03+00:00"
    },
    {
      "id": "d74e4f347d0a4be08c53dfc74ad03325",
      "sender": "meshcollider",
      "payload": "Yeah",
      "action": false,
      "timestamp": "2021-09-10T19:11:09+00:00"
    },
    {
      "id": "3b0083c7d24345e6b57faf0918f6dd8f",
      "sender": "michaelfolkson",
      "payload": "Nice work though, I didn't know you'd followed Miniscript particularly closely",
      "action": false,
      "timestamp": "2021-09-10T19:11:48+00:00"
    },
    {
      "id": "f1cebb9dd0fc49c5892ed1ee3f7461ef",
      "sender": "meshcollider",
      "payload": "I hope to rebase the PR to core as soon as the PRs to miniscript are merged",
      "action": false,
      "timestamp": "2021-09-10T19:11:48+00:00"
    },
    {
      "id": "8feea11c437b4364a408571ef29b361a",
      "sender": "meshcollider",
      "payload": "If anyone wants to help review it then it might help sipa out and get it merged faster",
      "action": false,
      "timestamp": "2021-09-10T19:13:02+00:00"
    },
    {
      "id": "580f5b21e69b4ba6a22ee00a0fc2200a",
      "sender": "meshcollider",
      "payload": "(although I suspect sipa will want to review it properly himself anyway)",
      "action": false,
      "timestamp": "2021-09-10T19:13:26+00:00"
    },
    {
      "id": "8db87675ff5c4283808cf7b98c93855e",
      "sender": "michaelfolkson",
      "payload": "I've seen practicalswift find a bunch of (possibly small) issues presumably through fuzzing",
      "action": false,
      "timestamp": "2021-09-10T19:13:49+00:00"
    },
    {
      "id": "9590835afecc41c0a93955d4946dcd91",
      "sender": "meshcollider",
      "payload": "Yep, most of the issues he found will be fixed through my PR",
      "action": false,
      "timestamp": "2021-09-10T19:14:20+00:00"
    },
    {
      "id": "d24c93d359984dd685da77a3a04d8171",
      "sender": "michaelfolkson",
      "payload": "How have you found your edge cases meshcollider? Just experimentation?",
      "action": false,
      "timestamp": "2021-09-10T19:14:29+00:00"
    },
    {
      "id": "914a6529724a4774b38296b5ae52200f",
      "sender": "meshcollider",
      "payload": "michaelfolkson: miniscript_tests.cpp has randomised miniscript tests which help, plus practicalswift's open github issues",
      "action": false,
      "timestamp": "2021-09-10T19:15:44+00:00"
    },
    {
      "id": "bf04fa038dbd455ea0436adcd95e1797",
      "sender": "michaelfolkson",
      "payload": "Cool, I'll look at the tests. Thanks",
      "action": false,
      "timestamp": "2021-09-10T19:16:19+00:00"
    },
    {
      "id": "a6b32daf75294847964ddaf5b7a0f10f",
      "sender": "meshcollider",
      "payload": "You'll need to merge  https://github.com/sipa/miniscript/pull/58 locally for them to work btw",
      "action": false,
      "timestamp": "2021-09-10T19:17:09+00:00"
    },
    {
      "id": "37ec639ccfe94110be8da67a037c145b",
      "sender": "meshcollider",
      "payload": "Because the tests in master haven't been updated for the new symantics",
      "action": false,
      "timestamp": "2021-09-10T19:17:30+00:00"
    },
    {
      "id": "6a9ebbb1284d41eebc3c0b2f0dc491ae",
      "sender": "michaelfolkson",
      "payload": "That PR is \"Update miniscript to bitcoin core....\"",
      "action": false,
      "timestamp": "2021-09-10T19:18:43+00:00"
    },
    {
      "id": "92f7d7a1bc4345acba6ffe2a1e914851",
      "sender": "michaelfolkson",
      "payload": "There's not any new semantics in Core is there?",
      "action": false,
      "timestamp": "2021-09-10T19:18:52+00:00"
    },
    {
      "id": "bbd4e65c0df2409aa61c8b174e3f94f2",
      "sender": "meshcollider",
      "payload": "michaelfolkson: there are a few other compatibility changes needed to work with the latest core, not in terms of miniscript, but in terms of script.cpp etc.",
      "action": false,
      "timestamp": "2021-09-10T19:19:34+00:00"
    },
    {
      "id": "578bfc843db748b3895695a88224cade",
      "sender": "michaelfolkson",
      "payload": "Hmm ok",
      "action": false,
      "timestamp": "2021-09-10T19:20:08+00:00"
    },
    {
      "id": "0988e7afd2934601898c7185e2b748c0",
      "sender": "meshcollider",
      "payload": "IIRC the hex decoding functions and stuff",
      "action": false,
      "timestamp": "2021-09-10T19:20:11+00:00"
    },
    {
      "id": "025d26129e334fe88f4a54b868744ef9",
      "sender": "meshcollider",
      "payload": "Minor changes but it won't build otherwise",
      "action": false,
      "timestamp": "2021-09-10T19:20:27+00:00"
    },
    {
      "id": "66627faf705942f6bec90666af0fa266",
      "sender": "michaelfolkson",
      "payload": "But better to ignore Core for now and just look at the Miniscript repo with that 58 PR",
      "action": false,
      "timestamp": "2021-09-10T19:20:37+00:00"
    },
    {
      "id": "0de9e4114d4e4dd59bc66b44d47d50a3",
      "sender": "michaelfolkson",
      "payload": "(merged)",
      "action": false,
      "timestamp": "2021-09-10T19:20:52+00:00"
    },
    {
      "id": "0ed3568a561d428a91d78da301e960ab",
      "sender": "meshcollider",
      "payload": "You'll need core to build and run miniscript_tests",
      "action": false,
      "timestamp": "2021-09-10T19:22:26+00:00"
    },
    {
      "id": "cea8a5063ba24646b626cb66c7c0aa72",
      "sender": "meshcollider",
      "payload": "Any other topics btw?",
      "action": false,
      "timestamp": "2021-09-10T19:22:45+00:00"
    },
    {
      "id": "b1cb04de44f84c7e92be177dc72049e7",
      "sender": "meshcollider",
      "payload": "#endmeeting",
      "action": false,
      "timestamp": "2021-09-10T19:25:09+00:00"
    }
  ],
  "events": [
    {
      "event_type": "START_MEETING",
      "message": {
        "id": "6116dc4afe8948f0bc0b7dac9a9cb5e3",
        "sender": "meshcollider",
        "payload": "#startmeeting",
        "action": false,
        "timestamp": "2021-09-10T19:01:49+00:00"
      },
      "operand": null,
      "id": "6116dc4afe8948f0bc0b7dac9a9cb5e3",
      "timestamp": "2021-09-10T19:01:49+00:00"
    },
    {
      "event_type": "LINK",
      "message": {
        "id": "f5832c02639f44eb972e233b8a2b4b8e",
        "sender": "gribble",
        "payload": "https://github.com/bitcoin/bitcoin/issues/16800 | Basic Miniscript support in output descriptors by sipa \u00c3\u0082\u00c2\u00b7 Pull Request #16800 \u00c3\u0082\u00c2\u00b7 bitcoin/bitcoin \u00c3\u0082\u00c2\u00b7 GitHub",
        "action": false,
        "timestamp": "2021-09-10T19:05:11+00:00"
      },
      "operand": "https://github.com/bitcoin/bitcoin/issues/16800",
      "id": "f5832c02639f44eb972e233b8a2b4b8e",
      "timestamp": "2021-09-10T19:05:11+00:00"
    },
    {
      "event_type": "END_MEETING",
      "message": {
        "id": "b1cb04de44f84c7e92be177dc72049e7",
        "sender": "meshcollider",
        "payload": "#endmeeting",
        "action": false,
        "timestamp": "2021-09-10T19:25:09+00:00"
      },
      "operand": null,
      "id": "b1cb04de44f84c7e92be177dc72049e7",
      "timestamp": "2021-09-10T19:25:09+00:00"
    }
  ],
  "aliases": {},
  "vote_in_progress": false,
  "motion_index": null
}