19:01:49 <meshcollider> #startmeeting 
19:01:49 <core-meetingbot> Meeting started Fri Sep 10 19:01:49 2021 UTC.  The chair is meshcollider. Information about MeetBot at https://bitcoin.jonasschnelli.ch/ircmeetings.
19:01:49 <core-meetingbot> Available commands: action commands idea info link nick
19:01:56 <meshcollider> #bitcoin -core-dev Wallet Meeting: achow101 aj amiti ariard bluematt cfields Chris_Stewart_5 digi_james dongcarl elichai2 emilengler fanquake fjahr gleb glozow gmaxwell gwillen hebasto instagibbs jamesob jb55 jeremyrubin jl2012 jnewbery jonasschnelli jonatack jtimon kallewoof kanzure kvaciral lightlike luke-jr maaku marcofalke meshcollider michagogo moneyball morcos nehan NicolasDorier paveljanik petertodd phantomcircuit promag
19:01:56 <meshcollider> provoostenator ryanofsky sdaftuar sipa vasild wumpus
19:02:08 <achow101> hi
19:02:24 <michaelfolkson> hi
19:03:02 <meshcollider> I don't think there have been any proposed topics
19:03:13 <meshcollider> Any last minute topics to discuss?
19:03:46 <michaelfolkson> Do you want to give a brief update on your recent work with Miniscript meshcollider?
19:03:49 <michaelfolkson> :)
19:04:36 <michaelfolkson> I saw some activity on the Miniscript repo but haven't looked into it closely
19:04:37 <meshcollider> Sure
19:04:41 <michaelfolkson> Cool
19:05:09 <meshcollider> Basically the miniscript repo just has a few open PRs that need to be merged before we can rebase #16800
19:05:11 <gribble> https://github.com/bitcoin/bitcoin/issues/16800 | Basic Miniscript support in output descriptors by sipa · Pull Request #16800 · bitcoin/bitcoin · GitHub
19:05:54 <michaelfolkson> Small things?
19:05:54 <achow101> is it necessary to get those into the miniscript repo in order to rebase?
19:05:58 <meshcollider> The main thing I've been working on there is to make miniscript parsing from strings and decoding from scripts non-recursive
19:06:42 <meshcollider> achow101: of course I could just merge them in myself and rebase but I think it's better if the PR reflects the miniscript repo so everyone can compare the two
19:07:22 <achow101> i guess so
19:07:26 <meshcollider> They aren't huge changes but obviously there are a lot fewer people reviewing changes over there than in core
19:07:29 <achow101> it's likely they will diverge once review actually gets going
19:07:47 <michaelfolkson> In what ways were they recursive?
19:07:49 <meshcollider> So mainly things are just waiting for sipa to have some time
19:08:38 <meshcollider> michaelfolkson: the current Parse() implementation recurses on every miniscript expression basically
19:08:52 <achow101> is the miniscript repo being updated/up-to-date with rust-miniscript?
19:08:56 <jonatack> hi
19:09:24 <achow101> (w.r.t miniscript semantics)
19:09:36 <michaelfolkson> meshcollider: Oh interesting. Found your PR https://github.com/sipa/miniscript/pull/66
19:09:53 <meshcollider> achow101: yes, both are "current" w.r.t semantics to the best of my knowledge
19:10:03 <meshcollider> I haven't compared closely with the rust version
19:11:03 <achow101> cool. so the prs you're doing are mostly just cleanups
19:11:09 <meshcollider> Yeah
19:11:48 <michaelfolkson> Nice work though, I didn't know you'd followed Miniscript particularly closely
19:11:48 <meshcollider> I hope to rebase the PR to core as soon as the PRs to miniscript are merged
19:13:02 <meshcollider> If anyone wants to help review it then it might help sipa out and get it merged faster
19:13:26 <meshcollider> (although I suspect sipa will want to review it properly himself anyway)
19:13:49 <michaelfolkson> I've seen practicalswift find a bunch of (possibly small) issues presumably through fuzzing
19:14:20 <meshcollider> Yep, most of the issues he found will be fixed through my PR
19:14:29 <michaelfolkson> How have you found your edge cases meshcollider? Just experimentation?
19:15:44 <meshcollider> michaelfolkson: miniscript_tests.cpp has randomised miniscript tests which help, plus practicalswift's open github issues
19:16:19 <michaelfolkson> Cool, I'll look at the tests. Thanks
19:17:09 <meshcollider> You'll need to merge  https://github.com/sipa/miniscript/pull/58 locally for them to work btw
19:17:30 <meshcollider> Because the tests in master haven't been updated for the new symantics
19:18:43 <michaelfolkson> That PR is "Update miniscript to bitcoin core...."
19:18:52 <michaelfolkson> There's not any new semantics in Core is there?
19:19:34 <meshcollider> michaelfolkson: there are a few other compatibility changes needed to work with the latest core, not in terms of miniscript, but in terms of script.cpp etc.
19:20:08 <michaelfolkson> Hmm ok
19:20:11 <meshcollider> IIRC the hex decoding functions and stuff
19:20:27 <meshcollider> Minor changes but it won't build otherwise
19:20:37 <michaelfolkson> But better to ignore Core for now and just look at the Miniscript repo with that 58 PR
19:20:52 <michaelfolkson> (merged)
19:22:26 <meshcollider> You'll need core to build and run miniscript_tests
19:22:45 <meshcollider> Any other topics btw?
19:25:09 <meshcollider> #endmeeting