19:00:22 <laanwj> #startmeeting 19:00:23 <core-meetingbot> Meeting started Thu Aug 5 19:00:22 2021 UTC. The chair is laanwj. Information about MeetBot at https://bitcoin.jonasschnelli.ch/ircmeetings. 19:00:23 <core-meetingbot> Available commands: action commands idea info link nick 19:00:50 <michaelfolkson> hi 19:00:55 <achow101> hi 19:01:13 <larryruane> hi 19:01:26 <laanwj> #bitcoin -core-dev Meeting: achow101 _aj_ amiti ariard BlueMatt cfields Chris_Stewart_5 darosior digi_james dongcarl elichai2 emilengler fanquake fjahr gleb glozow gmaxwell gwillen hebasto instagibbs jamesob jarolrod jb55 jeremyrubin jl2012 jnewbery jonasschnelli jonatack jtimon kallewoof kanzure kvaciral laanwj lightlike luke-jr maaku marcofalke meshcollider michagogo moneyball morcos 19:01:27 <laanwj> nehan NicolasDorier paveljanik petertodd phantomcircuit promag provoostenator ryanofsky sdaftuar sipa vasild 19:01:28 <jamesob> hi 19:01:31 <_aj_> hey 19:01:38 <jarolrod> Hi 19:01:42 <kvaciral[m]> hi 19:01:48 <laanwj> welcome to the weekly bitcoin-core-dev meeting 19:02:22 <laanwj> it looks like there are no pre-proposed topics (which you can propose any time during the week with #proposedmeetingtopic) 19:02:23 <luke-jr> hi 19:02:23 <sipa> hi 19:02:32 <laanwj> any last minute topic proposals? 19:03:07 <laanwj> the 22.0rc2 announcement went out today, hopefully we'll get some testing 19:03:11 <gene> hi 19:03:44 <jonatack> hi 19:03:59 <laanwj> #topic High priority for review 19:03:59 <core-meetingbot> topic: High priority for review 19:04:22 <laanwj> 7 blockers in https://github.com/bitcoin/bitcoin/projects/8, no bugfixes, nothing chasing concept ACK 19:04:44 <laanwj> anything to add/remove/replace or that is ready for merge? 19:05:10 <hebasto> hi 19:05:35 <gene> maybe a dumb question, what is blocking on the issues? just a need for more review/testing? 19:05:41 <laanwj> gene: yes 19:05:47 <gene> s/issues/prs 19:06:10 <gene> laanwj: ok, thanks 19:06:35 <laanwj> it's high priority for review, so it needs more review, though manual testing can also be useful if you can test specific things not covered by the test suite 19:07:24 <laanwj> it's blocking in the sense that it blocks further work by the author (or someone else) 19:08:32 <gene> is it helpful to ask for the specific areas in the PRs that the author would like more review? 19:08:48 <gene> the few I've reviewed so far seem to have a lot of discussion already 19:09:27 <laanwj> that depends, it is probably better to ask out of band (say, on IRC) than in the PR itself 19:09:49 <michaelfolkson> I haven't seen much direction from PR authors on parts of the PR that need particular focus. Sometimes there is guidance on what could be tested, suggestions for new reviewers 19:10:16 <michaelfolkson> Perhaps for good reason. You don't want everyone just doing the same thinig 19:10:25 <laanwj> in general the idea is to review the entire code change not only specific areas, but if there are say, consensus changes, then those are the most important (but also tests, in the sense that they really test what they're supposed to check) 19:11:47 <laanwj> but in general the entire change is important, what you are best able to review are the parts that you understand best (or want to learn about) 19:12:43 <laanwj> anyhow, apparently there are no proposed changes to high priority for review, and no other topics, so we should probably close the meeting 19:12:51 <michaelfolkson> I have a quick topic 19:13:07 <jonatack> gene: maybe helpful if you haven't seen it https://jonatack.github.io/articles/how-to-review-pull-requests-in-bitcoin-core 19:13:21 <kanzure> i don't mean to discuss particular locations or times, but the travel plans are still not finalized right? 19:13:48 <michaelfolkson> In process of attempting to arrange a IRC meeting or two to discuss the BIP process and possible improvements to it. Kalle and Luke seem up for it 19:14:22 <michaelfolkson> It has been a while since the BIP process was reviewed and amended and a few people have suggestions for editing it 19:14:26 <laanwj> #topic proposed IRC meeting about BIP process 19:14:27 <core-meetingbot> topic: proposed IRC meeting about BIP process 19:14:33 <gene> jonatack: thanks, will read 19:14:54 <michaelfolkson> Aiming for September probably (IRC channel to be worked out) 19:15:29 <sipa> michaelfolkson: please discuss this on the ML, of you haven't already 19:15:30 <michaelfolkson> BIP process wishlist with some people's thoughts here https://github.com/bitcoin/bips/wiki/BIP-Process-wishlist 19:15:40 <michaelfolkson> sipa: Right 19:15:41 <laanwj> kanzure: i think so, not sure if ariard is here he'll know best 19:15:54 <jamesob> kanzure laanwj: not finalized yet; close? 19:16:59 <jamesob> it's down to two locations, at any rate 19:17:24 <michaelfolkson> Will send to the ML once details are sorted 19:17:55 <laanwj> ok 19:18:01 <laanwj> any other topics? 19:18:11 <larryruane> Just want to mention that I'm available for review, please ping me, I'm on IRC 24x7, but I'm only able to spend about 20% time (have an 80% "real" other job) 19:18:40 <larryruane> I'll keep an eye on high priority for review list 19:18:59 <laanwj> larryruane: any specific area you're interested in reviewing? 19:19:30 <larryruane> utils (logging), performance, want to learn about P2P especially mempool 19:20:21 <laanwj> re: mempool you might want to look at #21800 that one should be pretty close 19:20:24 <gribble> https://github.com/bitcoin/bitcoin/issues/21800 | mempool/validation: mempool ancestor/descendant limits for packages by glozow ÷ Pull Request #21800 ÷ bitcoin/bitcoin ÷ GitHub 19:20:30 <ajonas> Also want to mention that josibake created a testing guide for 22.0 to go along with #22634 and it's now posted on the dev-wiki. 19:20:31 <gribble> https://github.com/bitcoin/bitcoin/issues/22634 | v22.0 testing ÷ Issue #22634 ÷ bitcoin/bitcoin ÷ GitHub 19:20:38 <larryruane> ð 19:20:54 <laanwj> ajonas: will add the link to the issue, thanks! 19:22:28 <laanwj> #endmeeting