19:00:04 <laanwj> #startmeeting 19:00:05 <core-meetingbot> Meeting started Thu Jun 10 19:00:04 2021 UTC. The chair is laanwj. Information about MeetBot at https://bitcoin.jonasschnelli.ch/ircmeetings. 19:00:05 <core-meetingbot> Available commands: action commands idea info link nick 19:00:11 <laanwj> #bitcoin -core-dev Meeting: achow101 _aj_ amiti ariard BlueMatt cfields Chris_Stewart_5 darosior digi_james dongcarl elichai2 emilengler fanquake fjahr gleb glozow gmaxwell gwillen hebasto instagibbs jamesob jarolrod jb55 jeremyrubin jl2012 jnewbery jonasschnelli jonatack jtimon kallewoof kanzure kvaciral laanwj lightlike luke-jr maaku marcofalke meshcollider michagogo moneyball morcos 19:00:13 <laanwj> nehan NicolasDorier paveljanik petertodd phantomcircuit promag provoostenator ryanofsky sdaftuar sipa vasild 19:00:13 <hebasto> hi 19:00:14 <achow101> hi 19:00:15 <jonatack> hi 19:00:17 <sipsorcery> hi 19:00:33 <meshcollider> hi 19:00:34 <laanwj> no proposed meeting topics this week 19:00:52 <sipa> hi 19:01:02 <laanwj> i guess it makes sense to discuss what would be good to focus review on for the 22.0 feature freeze 19:01:22 <laanwj> which is june 15th 19:02:29 <sipa> lots of things tagged for 22.0 19:02:30 <laanwj> any last minute topics? 19:02:31 <sipa> https://github.com/bitcoin/bitcoin/pulls?q=is%3Aopen+is%3Apr+sort%3Aupdated-desc+milestone%3A22.0 19:02:54 <meshcollider> There's a few taproot alley PRs that would be very nice to have in 19:02:55 <dongcarl> My personal hope is that we can finish the last g_chainman deglobalization bundle and the guix.sigs layout change PR 19:02:59 <meshcollider> Wallet* 19:03:02 <laanwj> yes, might make sense to untag some 19:03:59 <michaelfolkson> hi 19:04:24 <sipa> #18722 seems RFM 19:04:27 <gribble> https://github.com/bitcoin/bitcoin/issues/18722 | addrman: improve performance by using more suitable containers by vasild ÷ Pull Request #18722 ÷ bitcoin/bitcoin ÷ GitHub 19:05:26 <laanwj> dongcarl: tagged both 19:05:30 <jeremyrubin> hallo 19:05:35 <sipa> #22156 is pretty important to have in i think to avoid footguns 19:05:36 <gribble> https://github.com/bitcoin/bitcoin/issues/22156 | Allow tr() import to privkey wallets only when Taproot is active by achow101 ÷ Pull Request #22156 ÷ bitcoin/bitcoin ÷ GitHub 19:05:38 <dongcarl> laanwj: Thanks! 19:05:50 <jonatack> Am about to push an update to the inbound eviction protection one. I was hoping to get back to the BTC/kvB-to-sat/vB transition in time for the release but that's unfeasible so just concentrating on finishing up https://github.com/bitcoin/bitcoin/pull/21261 19:05:58 <laanwj> sipa: seems more like a bugfix than a feature anyhow 19:06:31 <jonatack> and then reviewing the other PRs tagged for v22 19:06:37 <achow101> I would consider #22156 and #22154 to be bug fixes rather than features, especially if #21365 is merged 19:06:38 <gribble> https://github.com/bitcoin/bitcoin/issues/22156 | Allow tr() import to privkey wallets only when Taproot is active by achow101 ÷ Pull Request #22156 ÷ bitcoin/bitcoin ÷ GitHub 19:06:39 <gribble> https://github.com/bitcoin/bitcoin/issues/22154 | Add OutputType::BECH32M and related wallet support for fetching bech32m addresses by achow101 ÷ Pull Request #22154 ÷ bitcoin/bitcoin ÷ GitHub 19:06:41 <gribble> https://github.com/bitcoin/bitcoin/issues/21365 | Basic Taproot signing support for descriptor wallets by sipa ÷ Pull Request #21365 ÷ bitcoin/bitcoin ÷ GitHub 19:08:20 <jonatack> Planning to revew the two PRs fixing the I2P ports issue after FF 19:08:35 <sipa> yeah i will also try to go through the 22.0 tag list 19:08:54 <laanwj> great! 19:10:06 <achow101> #21935 and #18964 are both still drafts, should they still be tagged for 22.0? 19:10:08 <gribble> https://github.com/bitcoin/bitcoin/issues/21935 | Enable external signer support for GUI builds, reduce #ifdef by Sjors ÷ Pull Request #21935 ÷ bitcoin/bitcoin ÷ GitHub 19:10:09 <gribble> https://github.com/bitcoin/bitcoin/issues/18964 | rpc, wallet: Scan mempool after import* by promag ÷ Pull Request #18964 ÷ bitcoin/bitcoin ÷ GitHub 19:10:21 <laanwj> achow101: no, probably not, good point 19:10:31 <hebasto> hope 21935 will be in 22.0 19:11:09 <laanwj> ah yes sjors' gui PR would be nice to have ein 19:11:47 <hebasto> sjors gui4 is already in master 19:12:06 <laanwj> oh, good 19:13:09 <meshcollider> Yep :) 19:14:15 <jonatack> meshcollider: taproot alley sounded good too 19:15:04 <sipa> right up my alley 19:15:42 <michaelfolkson> With the Taproot descriptor stuff I'm assuming that it is only a standard that could be updated/changed post being included in 22.0 19:16:10 <michaelfolkson> The discussion on notation/syntax was interesting 19:16:26 <michaelfolkson> It isn't final for 22.0 basically 19:16:32 <sipa> ? 19:16:42 <achow101> michaelfolkson: I expect it will be mostly final 19:16:58 <achow101> as soon as someone includes a tr() descriptor in a wallet, we have to support it ~forever 19:16:59 <sipa> features can be added, but if we include it in 22.0, it will be very hard to back out 19:17:49 <michaelfolkson> Ok so you are convinced the current notation is preferable sipa? You were convinced by roconnor arguments 19:18:05 <sipa> well i changed the PR in response to them! 19:18:08 <sipa> so yes 19:18:37 <michaelfolkson> Ok just checking that *that* is final ;) Thanks 19:19:06 <sipa> it's also already merged, fwiw 19:19:33 <michaelfolkson> #21365 isn't? 19:19:35 <gribble> https://github.com/bitcoin/bitcoin/issues/21365 | Basic Taproot signing support for descriptor wallets by sipa ÷ Pull Request #21365 ÷ bitcoin/bitcoin ÷ GitHub 19:19:52 <sipa> yes but that doesn't change anything w.r.t. the descripotrs 19:19:58 <sipa> *descriptors 19:20:04 <achow101> michaelfolkson: #22051 implemented the descriptors 19:20:07 <gribble> https://github.com/bitcoin/bitcoin/issues/22051 | Basic Taproot derivation support for descriptors by sipa ÷ Pull Request #22051 ÷ bitcoin/bitcoin ÷ GitHub 19:20:30 <michaelfolkson> Hmm I'm confused. roconnor's argument was on #22051 19:20:33 <gribble> https://github.com/bitcoin/bitcoin/issues/22051 | Basic Taproot derivation support for descriptors by sipa ÷ Pull Request #22051 ÷ bitcoin/bitcoin ÷ GitHub 19:20:34 <michaelfolkson> Doesn't matter 19:21:11 <michaelfolkson> *on #21365 19:21:13 <gribble> https://github.com/bitcoin/bitcoin/issues/21365 | Basic Taproot signing support for descriptor wallets by sipa ÷ Pull Request #21365 ÷ bitcoin/bitcoin ÷ GitHub 19:21:50 <meshcollider> michaelfolkson: 22051 was split out of 21365 19:22:40 <michaelfolkson> Ah ok, thanks 19:23:01 <laanwj> any other topics for today? 19:23:48 <laanwj> #endmeeting