19:02:57 <achow101> #startmeeting 
19:02:57 <core-meetingbot> Meeting started Fri May 21 19:02:57 2021 UTC.  The chair is achow101. Information about MeetBot at https://bitcoin.jonasschnelli.ch/ircmeetings.
19:02:57 <core-meetingbot> Available commands: action commands idea info link nick
19:03:13 <achow101> #bitcoin -core-dev Wallet Meeting: achow101 aj amiti ariard bluematt cfields Chris_Stewart_5 digi_james dongcarl elichai2 emilengler fanquake fjahr gleb glozow gmaxwell gwillen hebasto instagibbs jamesob jb55 jeremyrubin jl2012 jnewbery jonasschnelli jonatack jtimon kallewoof kanzure kvaciral lightlike luke-jr maaku marcofalke meshcollider michagogo moneyball morcos nehan NicolasDorier paveljanik petertodd phantomcircuit promag
19:03:14 <achow101> provoostenator ryanofsky sdaftuar sipa vasild wumpus
19:03:44 <provoostenator> briefly hi
19:03:53 <achow101> anyone have anything wallet to talk about?
19:04:51 <provoostenator> Mmm, maybe 1 topic: RBF
19:04:58 <provoostenator> Not related to the recent isseu
19:05:22 <provoostenator> I couild use feedback on #21576
19:05:23 <gribble> https://github.com/bitcoin/bitcoin/issues/21576 | rpc: bumpfee signer support by Sjors · Pull Request #21576 · bitcoin/bitcoin · GitHub
19:05:39 <provoostenator> And #22007
19:05:40 <gribble> https://github.com/bitcoin/bitcoin/issues/22007 | wallet: add destination (output) and bump fee · Issue #22007 · bitcoin/bitcoin · GitHub
19:06:00 <achow101> interesting
19:06:17 <provoostenator> And we still need to figure out how to allow fee bumping without change address.
19:06:27 <achow101> I thought we already did that?
19:07:14 <provoostenator> https://bitcoincore.org/en/doc/0.21.0/rpc/wallet/bumpfee/
19:07:25 <provoostenator> I don't believe so, there's no subtract_fee_from_output like option
19:07:59 <achow101> oh, you mean when the transaction used subtract fee from outputs
19:08:18 <provoostenator> Yes, e.g. when sending a single UTXO to another wallet or exchange.
19:08:25 <achow101> yeah, it assumes that the recipient amounts remain unchanged
19:08:52 <provoostenator> I guess that would be a simple matter of adding such an option
19:09:02 <achow101> right
19:09:19 <achow101> perhaps the wallet should also track this information so it doesn't require the user to provide it all the time?
19:09:38 <provoostenator> The only ambiguity is whether to inlcude the change output in the count.
19:09:47 <provoostenator> And I think we shuffle outputs?
19:09:56 <achow101> no, outputs aren't shuffled
19:10:10 <provoostenator> I also think tracking which output is intended as change helps.
19:10:14 <provoostenator> But we can also just tell
19:10:27 <achow101> we need better tx metadata in general
19:10:44 <provoostenator> The descriptor tells us which address is inside the wallet.
19:10:51 <jonatack> hi
19:11:40 <achow101> we would need to track that for the gui bumpfee to work
19:12:29 <provoostenator> The GUI bumpfee can also use the dscriptors to figure out which output is change?
19:12:45 <achow101> we already figure out which output is change
19:12:48 <provoostenator> (probably hidden away by the wallet interface)
19:12:58 <achow101> There's an IsChange function somewhere that works ok
19:13:10 <achow101> but I meant subtract fee from outputs
19:13:17 <provoostenator> Right, which we can't know for sure.
19:13:24 <provoostenator> So indeed would have to track.
19:13:45 <achow101> yeah, we're oging to need some tx tracking changes, so this could be a larger project
19:14:09 <provoostenator> Meh.... but yeah
19:14:34 <achow101> any other topics?
19:14:38 <provoostenator> Regarding #21576
19:14:39 <gribble> https://github.com/bitcoin/bitcoin/issues/21576 | rpc: bumpfee signer support by Sjors · Pull Request #21576 · bitcoin/bitcoin · GitHub
19:15:02 <provoostenator> I find the distinction between bumpfee and psbtbumpfee not ideal for external signers
19:15:11 <provoostenator> But maybe someone can suggest something int he comments.
19:16:07 <achow101> the idea of external signer support is that all of the normal wallet things should work as if normal
19:16:17 <achow101> so it makes sense to me that it would be part of bumpfee
19:17:05 <achow101> and bumpfee should just be calling the signer directly, like send
19:17:36 <provoostenator> Ok, well that's what the PR does
19:17:53 <provoostenator> Code reuse could be improved perhaps, but that's another matter.
19:18:11 <achow101> sure
19:18:26 <provoostenator> Alright, other topic
19:18:30 <provoostenator> (I don't have one)
19:18:59 <achow101> only thing I've got is that I opened up a few PRs yesterday for more coin selection changes
19:19:28 <achow101> I'm almost done with my coin selection overhaul
19:20:00 <achow101> but we first need #17331 since everything depends on that. if people could review it, that would be great
19:20:05 <gribble> https://github.com/bitcoin/bitcoin/issues/17331 | Use effective values throughout coin selection by achow101 · Pull Request #17331 · bitcoin/bitcoin · GitHub
19:21:00 <jonatack> achow101: nice. i'm sorry to have been remiss in reviewing, am in week three of five weeks of chaincode study groups.
19:21:28 <jonatack> provoostenator: achow101: feature freeze in 3 weeks. what are your targets for inclusion?
19:21:31 <provoostenator> I'll see if I can bring up the courage and mental energy to review coin selection PR's again :-)
19:22:10 <achow101> jonatack: my current target is 17331
19:22:36 <jonatack> that one will be in v22 it seems, but after?
19:23:06 <provoostenator> I'd like to see HWW GUI support make it in,  but we'll see.
19:23:19 <achow101> I'd like to close out the coin selection project and move back to descriptor wallet migration
19:24:23 <jonatack> good to know
19:24:42 <provoostenator> sipa: when taproot wallet rebase?
19:26:12 <achow101> any other topics?
19:26:41 <sipa> provoostenator: right now!
19:26:43 <sipa> i just noticed
19:27:12 <achow101> it'd be nice to get taproot wallet for 22.0, do you think we can get it before feature freeze?
19:27:32 <provoostenator> At least on signet it would be nice
19:27:54 <provoostenator> We should probably mark those descriptors as experimental though.
19:28:10 <provoostenator> Or maybe not, it's simple enough.
19:28:34 <provoostenator> I'll give it a review soon(tm).
19:28:39 <achow101> same
19:29:11 <luke-jr> isn't 22.0 before Taproot activates?
19:29:18 <provoostenator> Just needs musig(2) and add_sig support
19:29:26 <achow101> luke-jr: yes
19:29:27 <provoostenator> luke-jr: it's active on signet
19:29:41 <fjahr> hi (spam made me ignore notifications)
19:29:44 <provoostenator> Which is a nice place to test wallets
19:30:11 <achow101> luke-jr: I think we discussed at the last meeting that tr() descriptors can only be imported, and only after activation
19:30:13 <provoostenator> Might need a footgun shield on testnet and mainnet.
19:31:43 <achow101> anything else?
19:32:02 <jonatack> http://www.erisian.com.au/bitcoin-core-dev/log-2021-05-07.html#l-293
19:32:29 <jonatack> link to the discussion conclusion ^
19:33:26 <achow101> #endmeeting