19:00:07 <wumpus> #startmeeting 19:00:07 <core-meetingbot> Meeting started Thu May 13 19:00:07 2021 UTC. The chair is wumpus. Information about MeetBot at https://bitcoin.jonasschnelli.ch/ircmeetings. 19:00:08 <core-meetingbot> Available commands: action commands idea info link nick 19:00:12 <jonasschnelli> hi 19:00:14 <provoostenator> hi 19:00:14 <hebasto> hi 19:00:19 <wumpus> let's just try, it can be a short meeting i guess 19:00:20 <achow101> hi 19:00:22 <fjahr> hi 19:00:33 <wumpus> #bitcoin -core-dev Meeting: achow101 aj amiti ariard bluematt cfields Chris_Stewart_5 digi_james dongcarl elichai2 emilengler fanquake fjahr gleb glozow gmaxwell gwillen hebasto instagibbs jamesob jb55 jeremyrubin jl2012 jnewbery jonasschnelli jonatack jtimon kallewoof kanzure kvaciral lightlike luke-jr maaku marcofalke meshcollider michagogo moneyball morcos nehan NicolasDorier paveljanik 19:00:35 <wumpus> petertodd phantomcircuit promag provoostenator ryanofsky sdaftuar sipa vasild wumpus 19:00:44 <jonatack> hi 19:00:46 <michaelfolkson> hi 19:00:51 <ariard> hi 19:01:03 <meshcollider> hi 19:01:03 <wumpus> no proposed topics in http://gnusha.org/bitcoin-core-dev/proposedmeetingtopics.txt (fwiw, you can propose a topic at any time in the week with #proposedmeetingtopic <topic>) 19:01:09 <wumpus> any last minute topics? 19:01:47 <wumpus> #topic High priority for review 19:01:47 <core-meetingbot> topic: High priority for review 19:01:49 <jnewbery> hi 19:02:20 <wumpus> 9 blockers in https://github.com/bitcoin/bitcoin/projects/8 , no bugfixes, no PRs chasing concept ACK 19:02:29 <dongcarl> #topic If possible: Guix dress rehearsal 19:02:46 <sipa> hi 19:02:49 <wumpus> anything that should be added/removed, or is ready for merge? 19:02:52 <midnight> hi 19:03:22 <fjahr> #21726 please for me, I am resolving the conflict at the moment 19:03:24 <gribble> https://github.com/bitcoin/bitcoin/issues/21726 | Add prune blockers to BlockManager by fjahr ÷ Pull Request #21726 ÷ bitcoin/bitcoin ÷ GitHub 19:04:05 <fanquake> hi 19:04:11 <wumpus> fjahr: added (please do take it out of draft) 19:04:51 <fjahr> wumpus: thanks, done 19:04:59 <michaelfolkson> fjahr: Does this still apply? "This is only a VERY rough draft currently, as I am interested in concept/approach feedback." 19:05:23 <kanzure> hi 19:05:23 <wumpus> anything else to add/remove? 19:05:41 <fjahr> michaelfolkson: no, I will change the message in a moment, was just surprised by the conflict 19:07:02 <wumpus> #topic Guix dress rehearsal (dongcarl) 19:07:02 <core-meetingbot> topic: Guix dress rehearsal (dongcarl) 19:07:09 <dongcarl> WeâÂÂre nearing the start of the contingency buffer period for Guix, in fact, #21239 should be the last piece needed before we reach feature-parity with Gitian. 19:07:11 <gribble> https://github.com/bitcoin/bitcoin/issues/21239 | guix: Add codesignature attachment support for osx+win by dongcarl ÷ Pull Request #21239 ÷ bitcoin/bitcoin ÷ GitHub 19:07:18 <dongcarl> IâÂÂd like to do a full dress-rehearsal (with codesigning) of some commit (perhaps just a version of #21239) this week or the next. IâÂÂve already tried with my personal developer certs with win/osx to make sure there arenâÂÂt any glaring issues, but perhaps having others try it out will reveal some UX hiccups that can be addressed somewhat easily. 19:07:18 <gribble> https://github.com/bitcoin/bitcoin/issues/21239 | guix: Add codesignature attachment support for osx+win by dongcarl ÷ Pull Request #21239 ÷ bitcoin/bitcoin ÷ GitHub 19:07:59 <wumpus> sounds good to me! 19:08:03 <sipa> ack 19:08:05 <achow101> ack 19:08:12 <dongcarl> I'd be curious if there'd be problems with codesigning an intermediary commit with our certs? I'm guessing that might lead to problems if people get a hold of the resulting binary? 19:08:29 <wumpus> dongcarl: why would that lead to problems? 19:08:46 <achow101> dongcarl: considering the current cert is expired, I don't see why not. the only problem might be in making the signature 19:08:58 <achow101> still working on getting a new cert 19:09:13 <dongcarl> Oh! Signing with expired certs should be fine then... 19:09:25 <wumpus> i mean, we're not going to upload it to bitcoincoreorg, but even if so, it'd be like a pre-rc 19:09:34 <dongcarl> I'm just worried people might try to pass it off as a new release of core or something... 19:09:43 <wumpus> nah, doubtful 19:09:47 <dongcarl> Okay :-) 19:10:07 <dongcarl> Once we have enough review on the codesigning PR 19:10:16 <dongcarl> We can decide on a commit and do the dress rehearsal 19:10:25 <wumpus> i don't think it is code signing that makes the difference in people's minds there 19:10:49 <dongcarl> wumpus: Heh that's true 19:10:49 <wumpus> things like announcements, articles, release notes, etc are 19:11:11 <wumpus> right, let's try to review and merge 21239 soon 19:11:16 <dongcarl> Incidentally, does it matter that osslsign defaults to using sha1 as the digest? 19:11:17 <wumpus> then pick a commit 19:11:26 <dongcarl> I noticed when checking my self-signed binary... 19:11:28 <wumpus> isn't sha1 very broken? 19:11:51 <dongcarl> Right, that's why I was curious... We can supply a flag and choose another digest easily tho 19:12:06 <achow101> If the default is sha1, then that's what we've been using 19:12:08 <dongcarl> Just wanted to make sure if there were any justifications or if it was just overlooked 19:12:39 <wumpus> maybe some old version of windows supports only sha1? i don't know what is the minimum we support nowadays 19:12:55 <dongcarl> I think the codesigning scheme in windows supports having multiple digests 19:13:05 <dongcarl> So we can also just do sha1+sha256 19:13:19 <wumpus> does that complicate the attachment? 19:14:02 <dongcarl> Hmmm, unsure. We can check if the older versions that only support sha1 are too old for us. Anyway, I can open an issue abt this :-) 19:14:25 <wumpus> I think we should initially try with a modern, non-broken digest 19:14:34 <wumpus> if any problems come up i'm sure we'll hear about it 19:14:42 <dongcarl> That too :-) 19:15:16 <dongcarl> That's it from me! 19:15:23 <wumpus> thank you! 19:15:25 <jnewbery> wumpus: I have a couple of requests/announcements. 19:15:25 <wumpus> any other topics? 19:15:39 <wumpus> #topic Requests/announcements (jnewbery) 19:15:39 <core-meetingbot> topic: Requests/announcements (jnewbery) 19:15:47 <jnewbery> 1. I think it's probably time to merge https://github.com/bitcoin/bips/pull/1116 (adding Kalle as BIP editor). It was proposed three weeks ago, has 15 ACKs, and no substantive opposition. 19:15:58 <jnewbery> Luke is still backlogged on BIP PR maintaining, so it'd be nice if he could get a bit of help: http://www.erisian.com.au/bitcoin-core-dev/log-2021-05-13.html#l-37. 19:16:29 <jnewbery> Is there anything else required before we can go ahead and merge that PR? 19:16:50 <luke-jr> not sure how to handle the NACK(s?) on it 19:17:02 <luke-jr> :/ 19:17:08 <jnewbery> There are no serious NACKs 19:17:21 <luke-jr> gmaxwell withdrew his? 19:17:24 <jnewbery> yes 19:17:29 <luke-jr> great 19:17:37 <jnewbery> https://lists.linuxfoundation.org/pipermail/bitcoin-dev/2021-April/018869.html 19:17:50 <jnewbery> "I endorse Harding's recommendations." 19:18:30 <michaelfolkson> Is there an argument to wait until Taproot has activated (hopefully soon) in case drama on that starts up again? Unfair on Kalle to drop him in it otherwise 19:18:42 <michaelfolkson> Whatever Kalle's preference I guess 19:18:51 <jnewbery> Kalle has ACKed 19:20:19 <jnewbery> luke-jr: are you going to merge this PR? 19:21:13 <michaelfolkson> luke-jr can chat to Kalle and work out whatever is best. I think everyone is happy with Kalle 19:22:01 <jnewbery> luke-jr: if you're not prepared to merge it, does it make sense for someone else with commit access to the repo to merge the PR? 19:23:58 <luke-jr> I'm sorry I am behind, but I don't think breaking process or merging without looking at it properly is an appropriate route to take 19:24:22 <jnewbery> The process has been followed. This has achieved community consensus 19:24:44 <michaelfolkson> If Kalle is happy to sort it out with Luke I don't see the problem. Kalle can flag if he's uncomfortable with his discussions with Luke or how fast it is going 19:24:55 <wumpus> after you've merged it, kallewoof can help you, so it makes sense to prioritize it maybe 19:25:03 <luke-jr> wumpus: yes 19:25:07 <jnewbery> If you're unwilling to merge, then I propose that someone else with merge access go ahead and add kallewoof 19:26:06 <wumpus> ok, anything else? 19:26:16 <jnewbery> wumpus: what's the plan here? 19:26:48 <jnewbery> luke-jr is very clearly blocking something that has overwhelming support 19:26:54 <wumpus> i don't know, please don't ask too much from me now 19:26:55 <fjahr> michaelfolkson: not sure what needs to be sorted out, as jnewbery said, kalle has acked :) 19:27:06 <luke-jr> jnewbery: I propose you stop trolling 19:27:07 <michaelfolkson> Kalle flags if he's uncomfortable with anything. We' re all happy with Kalle and he can discuss with Luke 19:27:39 <jnewbery> wumpus: I'm not asking very much at all. Just that what has overwhelming support gets done 19:27:44 <michaelfolkson> If Kalle comes here and says Luke is blocking the progress then we have a problem. If he doesn't and he's happy with how discussions are going with Luke I don't think we have a problem 19:27:57 <michaelfolkson> Up to Kalle 19:28:12 <ariard> jnewbery: what's the worst-case scenario if this PR isn't merged and things stay as they are? anyone is free to fork and start maintaining a bip repo if they don't like current editorship 19:28:50 <jnewbery> ariard: luke-jr doesn't own the bips repo. He's the steward of a shared resource. He's abusing that stewardship 19:29:00 <luke-jr> no, I am not, liar 19:29:04 <luke-jr> you are acting maliciously now 19:29:19 <ariard> jnewbery: a shared resource which is super easy to fork :) 19:30:14 <luke-jr> I have better things to do than put up with this abuse, ttyl 19:30:16 <michaelfolkson> We doing this again? Just leave it to Kalle. If he's uncomfortable with anything he can raise it. Everyone has agreed to give responsibility to Kalle, trust his judgement 19:30:17 <wumpus> i don't think this is going anywhere like this, any other topics? 19:30:57 <jnewbery> wumpus: I'm still curious what's required to get this merged 19:31:00 <wumpus> there is really not that much hurry to make it heated like this 19:31:44 <michaelfolkson> You should have proposed yourself as a BIP editor if you don't trust Kalle to move this along jnewbery 19:32:11 <jnewbery> michaelfolkson: stop playing games. It's 4:30am in Japan right now. Kalle isn't here. 19:32:23 <wumpus> why does it have to happen here and now 19:32:23 <jnewbery> he's ACKed the PR and is ready to be editor 19:32:38 <michaelfolkson> Games? For trusting Kalle? Rather than imposing my judgement on him? SUre 19:32:44 <jnewbery> wumpus: I'm just asking what needs to happen to get the PR merged 19:33:00 <wumpus> luke-jr already said he's going to merge it 19:33:47 <michaelfolkson> I think we're done 19:34:03 <wumpus> #endmeeting