19:00:46 <achow101> #startmeeting 19:00:47 <core-meetingbot> Meeting started Fri Jan 15 19:00:46 2021 UTC. The chair is achow101. Information about MeetBot at https://bitcoin.jonasschnelli.ch/ircmeetings. 19:00:47 <core-meetingbot> Available commands: action commands idea info link nick 19:00:53 <achow101> #bitcoin -core-dev Wallet Meeting: achow101 aj amiti ariard bluematt cfields Chris_Stewart_5 digi_james dongcarl elichai2 emilengler fanquake fjahr gleb gmaxwell gwillen hebasto instagibbs jamesob jb55 jeremyrubin jl2012 jnewbery jonasschnelli jonatack jtimon kallewoof kanzure kvaciral lightlike luke-jr maaku marcofalke meshcollider michagogo moneyball morcos nehan NicolasDorier paveljanik petertodd phantomcircuit promag provoostenator 19:00:53 <achow101> ryanofsky sdaftuar sipa vasild wumpus 19:01:00 <jonatack> hi 19:01:06 <emzy> hi 19:01:12 <achow101> any topics? 19:02:21 <achow101> With 0.21 out now, are there any big things we want to get in for 22.0? 19:03:03 <jonatack> i'd like to finish up the migration from btc/kb to sat/b feerates 19:03:12 <jonatack> and refactor CFeeRate 19:03:19 <jonatack> the plan is to 19:03:20 <luke-jr> achow101: I was thinking the other day, that it'd be nice to get wallet backup reminders 19:04:08 <jonatack> add setfeerate and estimatefeerate RPCs in sat/b and then we can deprecate the feeRate btc/kb params 19:04:14 <achow101> jonatack: that's mostly within the rpcs, right? 19:04:30 <luke-jr> also, according to puchu in #bitcoin, the GUI has gotten less responsive in 0.21; not sure if wallet-related or not 19:04:35 <jonatack> achow101: also a bit of CFeeRate refactoring in #20546 19:04:37 <gribble> https://github.com/bitcoin/bitcoin/issues/20546 | policy, wallet, refactor: check for non-representable CFeeRates by jonatack ÷ Pull Request #20546 ÷ bitcoin/bitcoin ÷ GitHub 19:04:58 <jonatack> and a new AmountFromValue-like method that understands feerates 19:05:11 <achow101> cool 19:05:27 <achow101> luke-jr: wallet backup reminders in what way? 19:05:29 <jonatack> then we could start migrating the config options if people want 19:06:31 <achow101> jonatack: having all feerate things be the same units would be ideal 19:06:43 <jonatack> achow101: yes! 19:06:54 <jonatack> achow101: remind me of the xpub export plans plz 19:07:00 <jonatack> istm there was a PR to review 19:07:23 <jonatack> i'd also like to see fjahr's coinstats work get in and your coinselection work 19:07:29 <luke-jr> achow101: seems users forget to backup their wallet 19:07:38 <achow101> jonatack: #20226 I think was the pr 19:07:40 <gribble> https://github.com/bitcoin/bitcoin/issues/20226 | wallet, rpc: add listdescriptors command by S3RK ÷ Pull Request #20226 ÷ bitcoin/bitcoin ÷ GitHub 19:08:00 <luke-jr> achow101: even just a one-time reminder after creation might help, but something to keep track of backup outdatedness and warn the user regularly would also be nice 19:09:05 <achow101> luke-jr: outdatedness may be hard to determine 19:09:22 <luke-jr> could just increment a counter per change, and reset to 0 on backup? 19:09:53 <jonatack> luke-jr: that does seem a good idea, if workable 19:10:07 <jonatack> (the concept) 19:10:15 <achow101> I think a lot of people backup by copying the wallet.dat file rather than using the explicit backup wallet stuff 19:10:23 <achow101> which in that case we wouldn't know when a backup was made 19:10:26 <luke-jr> that can lead to corruption 19:10:29 <luke-jr> bad idea regardless 19:10:35 <luke-jr> they need the reminder too :P 19:10:48 <achow101> an idea being bad hasn't stopped people from doing it :/ 19:11:07 <achow101> but reminders would be nice. I guess it would also help to push people to do it the right way 19:11:14 <luke-jr> but at least this way they would investigate why they got a notice ;) 19:11:18 <luke-jr> and fix their backups 19:11:21 <sipa> the application explicitly telling you "You should make a backup, click here to do so!" likely encourages them to do it the right way 19:11:31 <luke-jr> yes 19:11:49 <jonatack> +1 19:12:09 <achow101> luke-jr: can you open a brainstorming issue for this? 19:14:15 <achow101> in terms of other stuff for 22.0, I'd like the coin selection changes to go in 19:14:38 <luke-jr> https://github.com/bitcoin-core/gui/issues/185 19:15:13 <achow101> i have a stack of branches and prs that do a ton of coin selection improvements 19:15:43 <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/0a1cf6c34734...32e59fc37108 19:15:44 <bitcoin-git> bitcoin/master fa0aa87 MarcoFalke: rpc: Return wtxid from testmempoolaccept 19:15:44 <bitcoin-git> bitcoin/master 32e59fc MarcoFalke: Merge #20916: rpc: Return wtxid from testmempoolaccept 19:16:03 <bitcoin-git> [bitcoin] MarcoFalke merged pull request #20916: rpc: Return wtxid from testmempoolaccept (master...2101-wtxidTestmempool) https://github.com/bitcoin/bitcoin/pull/20916 19:16:51 <jonatack> achow101: it would be good to move those forward. FWIW is meshcollider still on honeymoon? 19:17:30 <achow101> meshcollider told me he was back at the start of december 19:17:37 <achow101> but I think he dropped off the face of the earth 19:17:41 <luke-jr> x.x 19:18:06 <achow101> maybe NZ's border closing also affected the internet 19:19:08 <achow101> anything else to discuss? 19:20:24 <jonatack> pls ack #20391 i think it's rtm 19:20:27 <gribble> https://github.com/bitcoin/bitcoin/issues/20391 | wallet: introduce setfeerate (an improved settxfee, in sat/vB) by jonatack ÷ Pull Request #20391 ÷ bitcoin/bitcoin ÷ GitHub 19:21:03 <achow101> will look 19:21:25 <achow101> #endmeeting