19:03:20 <wumpus> #startmeeting 19:03:21 <core-meetingbot> Meeting started Thu Jan 14 19:03:20 2021 UTC. The chair is wumpus. Information about MeetBot at https://bitcoin.jonasschnelli.ch/ircmeetings. 19:03:21 <core-meetingbot> Available commands: action commands idea info link nick 19:03:21 <jnewbery> woah don't be so hasty there sipa 19:03:25 <kanzure> hi 19:03:27 <jonatack> hi 19:03:28 <emzy> hi 19:03:31 <jnewbery> hi 19:03:33 <jonasschnelli> hi 19:03:36 <fjahr> hi 19:03:39 <hebasto> hi 19:03:42 <sipa> hi 19:03:43 <wumpus> #bitcoin -core-dev Meeting: achow101 aj amiti ariard bluematt cfields Chris_Stewart_5 digi_james dongcarl elichai2 emilengler fanquake fjahr gleb gmaxwell gwillen hebasto instagibbs jamesob jb55 jeremyrubin jl2012 jnewbery jonasschnelli jonatack jtimon kallewoof kanzure kvaciral lightlike luke-jr maaku marcofalke meshcollider michagogo moneyball morcos nehan NicolasDorier paveljanik 19:03:45 <wumpus> petertodd phantomcircuit promag provoostenator ryanofsky sdaftuar sipa vasild wumpus 19:03:52 <achow101> hi 19:03:57 <sipa> congrats on 0.21 everyone! 19:04:07 <wumpus> yes, congrats on the release 19:04:24 <jnewbery> congrats everyone! 19:04:28 <emzy> \o/ 19:04:28 <wumpus> no proposed meeting topics in http://gnusha.org/bitcoin-core-dev/proposedmeetingtopics.txt 19:04:34 <MarcoFalke> \o/ 19:04:44 <fjahr> \o/ 19:04:49 <wumpus> any last-minute topics ? 19:05:18 <MarcoFalke> I'd like to add #20715 to high prio :) 19:05:20 <gribble> https://github.com/bitcoin/bitcoin/issues/20715 | util: Add ArgsManager::GetCommand() and use it in bitcoin-wallet by MarcoFalke ÷ Pull Request #20715 ÷ bitcoin/bitcoin ÷ GitHub 19:06:07 <jonatack> #20391 for me, please 19:06:09 <gribble> https://github.com/bitcoin/bitcoin/issues/20391 | wallet: introduce setfeerate (an improved settxfee, in sat/vB) by jonatack ÷ Pull Request #20391 ÷ bitcoin/bitcoin ÷ GitHub 19:06:19 <wumpus> #topic High priority for review 19:06:19 <core-meetingbot> topic: High priority for review 19:06:24 <fjahr> #19145 for me please 19:06:26 <wumpus> we weren't there yet :) 19:06:27 <gribble> https://github.com/bitcoin/bitcoin/issues/19145 | Add hash_type MUHASH for gettxoutsetinfo by fjahr ÷ Pull Request #19145 ÷ bitcoin/bitcoin ÷ GitHub 19:06:52 <wumpus> MarcoFalke: replacing #20362? 19:06:55 <gribble> https://github.com/bitcoin/bitcoin/issues/20362 | test: Implicitly sync after generate* to preempt races and intermittent test failures by MarcoFalke ÷ Pull Request #20362 ÷ bitcoin/bitcoin ÷ GitHub 19:07:03 <jnewbery> wumpus: can we move #20557 to high priority bug fixes? PR #16702 broke some aspects of addrman deserialization and it'd be nice to fix them 19:07:05 <gribble> https://github.com/bitcoin/bitcoin/issues/20557 | addrman: Fix new table bucketing during unserialization by jnewbery ÷ Pull Request #20557 ÷ bitcoin/bitcoin ÷ GitHub 19:07:09 <gribble> https://github.com/bitcoin/bitcoin/issues/16702 | p2p: supplying and using asmap to improve IP bucketing in addrman by naumenkogs ÷ Pull Request #16702 ÷ bitcoin/bitcoin ÷ GitHub 19:07:17 <MarcoFalke> wumpus: Jup 19:09:29 <jamesob> hi 19:09:47 <wumpus> MarcoFalke jonatack fjahr jnewbery: done 19:09:57 <fjahr> wumpus: thank you! 19:10:25 <jonatack> thanks! (i'd like to either finish up the ongoing feerate sat/B migration and CFeeRate refactoring, or close it out as up for grabs) 19:10:42 <wumpus> at last, something new to review again! 19:11:07 <luke-jr> >implying there was ever a shortage 19:11:32 <wumpus> heh 19:11:46 <jonatack> jnewbery: agree, good choice 19:11:48 <wumpus> any other PRs to add/remove or that are almost ready for merge? 19:11:54 <jamesob> I think #19806 is pretty close to ready. More generally I'm kind of curious with how the g_chainman work is going to interface with the assumeutxo work; the two are going to step on each others' toes I think 19:11:57 <gribble> https://github.com/bitcoin/bitcoin/issues/19806 | validation: UTXO snapshot activation by jamesob ÷ Pull Request #19806 ÷ bitcoin/bitcoin ÷ GitHub 19:12:08 <jamesob> (referring to #20749) 19:12:10 <gribble> https://github.com/bitcoin/bitcoin/issues/20749 | [Bundle 1/n] Prune g_chainman usage related to ::LookupBlockIndex by dongcarl ÷ Pull Request #20749 ÷ bitcoin/bitcoin ÷ GitHub 19:13:02 <dongcarl> hi 19:13:11 <wumpus> the g_chainman work is necessary for factoring out the consensus code (libbitcoin_kernel) so fairly important 19:13:38 <dongcarl> jamesob: What parts are you most concerned about? Happy to talk through it and see how we can work it out 19:14:01 <sipa> jamesob, dongcarl: ideally you two figure out how to order things 19:14:14 <jamesob> there are some parts of assumeutxo that add chainstate-related calls to, say, net_processing so we probably need to sequence the changes somehow 19:14:33 <jamesob> I'm pretty flexible but also want to know whether to steel myself for rebase hell :) 19:14:39 <wumpus> maybe that can get rid of the circular dependency as well :) 19:14:49 <jamesob> let's hope 19:14:55 <wumpus> it's really a blemish 19:15:09 <dongcarl> jamesob: I think we can do it in an order or in a way that makes rebase easier, happy to chat offline and plan this out 19:15:11 <jamesob> that's the trouble with validation though - it's pretty challenging to yank parts out of it 19:15:30 <jamesob> dongcarl: sure, sounds good 19:16:02 <wumpus> i wish the utxo load/store stuff was not part of validation but a module in itself but yes it's not easy design 19:16:33 <jamesob> agreed, but it's not trivial to untangle in my experience 19:17:53 <wumpus> right 19:18:11 <wumpus> anyone with another topic suggestion for today? 19:19:30 <wumpus> that's a short meeting then, this time! 19:19:39 <wumpus> #endmeeting