19:01:29 <achow101> #startmeeting 
19:01:30 <core-meetingbot> Meeting started Fri Dec  4 19:01:29 2020 UTC.  The chair is achow101. Information about MeetBot at https://bitcoin.jonasschnelli.ch/ircmeetings.
19:01:30 <core-meetingbot> Available commands: action commands idea info link nick
19:01:51 <emzy> hi
19:01:56 <fjahr> hi
19:01:57 <jonatack> hi
19:01:59 <achow101> #bitcoin -core-dev Wallet Meeting: wumpus sipa gmaxwell jonasschnelli morcos luke-jr sdaftuar jtimon cfields petertodd kanzure bluematt instagibbs phantomcircuit codeshark michagogo marcofalke paveljanik NicolasDorier jl2012 achow101 meshcollider jnewbery maaku fanquake promag provoostenator aj Chris_Stewart_5 dongcarl gwillen jamesob ken281221 ryanofsky gleb moneyball ariard digi_james amiti fjahr jeremyrubin emilengler jonatack hebasto
19:02:00 <achow101> jb55 kvaciral ariard digi_james amiti fjahr jeremyrubin lightlike emilengler jonatack hebasto jb55 elichai
19:02:15 <achow101> any topics?
19:03:47 <achow101> #topic wallet high priority for review
19:03:47 <core-meetingbot> topic: wallet high priority for review
19:04:09 <achow101> any wallet prs for high priority to add/remove/discuss?
19:04:15 <jonatack> pls review minor bugfix #20546
19:04:18 <gribble> https://github.com/bitcoin/bitcoin/issues/20546 | wallet: check for non-representable CFeeRates (0-0.0009 sat/vB) by jonatack · Pull Request #20546 · bitcoin/bitcoin · GitHub
19:05:03 <achow101> jonatack: is that for 0.21?
19:05:05 <jonatack> also found another bug in the send rpc; unlike the other rpcs, the fee rate cannot be passed as a string, only a number. Opening a fix today.
19:05:31 <jonatack> achow101: idk if it's a backport-worthy bug, up to others i guess
19:06:19 <provoostenator> (hi)
19:06:34 <provoostenator> It's marked experimental
19:06:49 <provoostenator> So I guess it depends on how annoyhing it is in practice
19:06:56 <jonatack> achow101: the fix in both cases is simple, the work is mostly writing good test coverage
19:08:17 <achow101> doesn't seem backport worthy, but no strong opinion on that
19:08:28 <jonatack> provoostenator: the help says it's an amount (string or number), and the fix is one line, but not up to me
19:08:29 <achow101> not the first time we've had a known issues section in the release notes
19:08:45 <kanzure> andytoshi: you can use import importlib; importlib.find_spec("somethingwindowsonly") and another function i forget.
19:09:35 <provoostenator> Well we probalby get another RC regardless because of a sendaddrv2 compatiblity issue with btcd
19:10:02 <jonatack> yess i'll just PR it and let ppl decide
19:10:06 <luke-jr> need another RC for the already merged stuff anyway
19:11:42 <jonatack> fjahr: i plan to review #19055 when i'm done with all the fee rate things
19:11:46 <gribble> https://github.com/bitcoin/bitcoin/issues/19055 | Add MuHash3072 implementation by fjahr · Pull Request #19055 · bitcoin/bitcoin · GitHub
19:11:48 <jonatack> as you've updated it
19:11:55 <fjahr> thanks
19:12:46 <provoostenator> I'm currently writing a PR for Specter to use descriptor wallets, so hopefully I don't encounter anything shocking on the core side.
19:13:01 <provoostenator> So far it works really well
19:13:02 <Murch> Hi
19:13:39 <provoostenator> It's annoying that getwalletinfo returns 3000 for keypool size
19:13:49 <achow101> it's not wrong though
19:13:52 <provoostenator> Although it's true,
19:14:00 <provoostenator> No, but it would be nice get 1000 somewhere as well
19:14:13 <provoostenator> Because I don't want to rely on having 3 types of addresses
19:14:32 <provoostenator> Need that number in order to pick a sane "range" param for importdescriptors
19:14:40 <provoostenator> Which doesn't have a default afaik
19:14:53 <achow101> just only support one address type then
19:15:14 <luke-jr> yeah, descriptor wallets don't need to have all the other types do they?
19:15:28 <provoostenator> That's not the issue.  It's just that you can't know -keypoolsize
19:15:34 <provoostenator> Unless you parse bitcoin.conf
19:16:04 <achow101> since each spkm reports its own keypoolsize, getwalletinfo could be more granular there
19:16:07 <provoostenator> The range param for importdescriptors isn't super useful anyway
19:16:10 <achow101> just some output stuff, not particularly hard
19:17:02 <provoostenator> Would be nice if the range param defaulted to -keypoolsize so you can omit it.
19:17:47 <achow101> i think it does?
19:20:03 <achow101> anything else?
19:23:24 <achow101> #endmeeting