{ "founder": "wumpus", "channel": "#bitcoin-core-dev", "network": "freenode", "id": "383d15ca069c40e0b047b0811abef6eb", "name": "#bitcoin-core-dev", "chair": "wumpus", "chairs": [ "wumpus" ], "nicks": { "wumpus": 144, "lightningbot": 6, "achow101": 34, "hebasto": 11, "meshcollider": 42, "jonasschnelli": 42, "sipa": 79, "jonatack": 70, "MarcoFalke": 42, "promag": 1, "luke-jr": 105, "emzy": 9, "gribble": 39, "dongcarl": 1, "jnewbery": 41, "aj": 5, "kanzure": 5, "bitcoin-git": 147, "fanquake": 10, "andytoshi": 39, "real_or_random": 1, "az0re": 47, "darosior": 2, "phantomcircuit": 2, "queip": 8, "nanotube": 2, "stevenroose": 4, "ariard": 1, "core-meetingbot": 9, "DeanWeen": 1, "brianddk": 2, "vasild": 38, "shesek": 7, "Kiminuo": 1, "pinheadmz": 3, "warren": 3, "ja": 14, "provoostenator": 14, "amiti": 1, "fjahr": 1, "michaelfolkson": 10 }, "start_time": "2020-11-05T19:00:12+00:00", "end_time": "2020-11-12T20:09:00+00:00", "active": false, "original_topic": "Bitcoin Core development discussion and commit log | Feel free to watch, but please take commentary and usage questions to #bitcoin | Channel logs: http://www.erisian.com.au/bitcoin-core-dev/, http://gnusha.org/bitcoin-core-dev/ | Meeting topics http://gnusha.org/bitcoin-core-dev/proposedmeetingtopics.txt / http://gnusha.org/bitcoin-core-dev/proposedwalletmeetingtopics.txt", "current_topic": "limiting C++17 feature usage (jnewbery)", "messages": [ { "id": "f59b3bb95514471c9e3a00524d99ea34", "sender": "wumpus", "payload": "#startmeeting", "action": false, "timestamp": "2020-11-05T19:00:12+00:00" }, { "id": "89d0f375b7cd4a8eb88a61089c19abf1", "sender": "lightningbot", "payload": "Meeting started Thu Nov 5 19:00:12 2020 UTC. The chair is wumpus. Information about MeetBot at http://wiki.debian.org/MeetBot.", "action": false, "timestamp": "2020-11-05T19:00:12+00:00" }, { "id": "146d91d807644c05a0c4ee9d79678940", "sender": "lightningbot", "payload": "Useful Commands: #action #agreed #help #info #idea #link #topic.", "action": false, "timestamp": "2020-11-05T19:00:12+00:00" }, { "id": "baed4de3489c4c12b40eae8cbc196f47", "sender": "achow101", "payload": "hi", "action": false, "timestamp": "2020-11-05T19:00:16+00:00" }, { "id": "45cab5d4fee44b90ae40d29329148a40", "sender": "hebasto", "payload": "hi", "action": false, "timestamp": "2020-11-05T19:00:24+00:00" }, { "id": "1564878fa1124a138ecc7a8af86ff15a", "sender": "wumpus", "payload": "#bitcoin-core-dev Meeting: achow101 aj amiti ariard bluematt cfields Chris_Stewart_5 digi_james dongcarl elichai2 emilengler fanquake fjahr gleb gmaxwell gwillen hebasto instagibbs jamesob jb55 jeremyrubin jl2012 jnewbery jonasschnelli jonatack jtimon kallewoof kanzure kvaciral lightlike luke-jr maaku marcofalke meshcollider michagogo moneyball morcos nehan NicolasDorier paveljanik", "action": false, "timestamp": "2020-11-05T19:00:26+00:00" }, { "id": "4bfc163223424860810b9ce8da1d64f6", "sender": "wumpus", "payload": "petertodd phantomcircuit promag provoostenator ryanofsky sdaftuar sipa vasild wumpus", "action": false, "timestamp": "2020-11-05T19:00:27+00:00" }, { "id": "bd469d7e91d848be81fe299d356a4d67", "sender": "meshcollider", "payload": "hi", "action": false, "timestamp": "2020-11-05T19:00:29+00:00" }, { "id": "0664c8c5b0364d3d90f4bc8216504e0d", "sender": "jonasschnelli", "payload": "hi", "action": false, "timestamp": "2020-11-05T19:00:30+00:00" }, { "id": "75725a10778348bfa072d8290348e6ca", "sender": "wumpus", "payload": "still bot-less i see", "action": false, "timestamp": "2020-11-05T19:00:33+00:00" }, { "id": "7f1ab93388174baeb4f2e1fdd03304d4", "sender": "sipa", "payload": "hi", "action": false, "timestamp": "2020-11-05T19:00:37+00:00" }, { "id": "67803875cd8540f490857713700d82b4", "sender": "jonatack", "payload": "hi", "action": false, "timestamp": "2020-11-05T19:00:39+00:00" }, { "id": "a2397ed8d36d43efb54f9c0375432d82", "sender": "MarcoFalke", "payload": "ahoy", "action": false, "timestamp": "2020-11-05T19:00:39+00:00" }, { "id": "8b39262f79a7402cabae8de94023b1fa", "sender": "promag", "payload": "hello", "action": false, "timestamp": "2020-11-05T19:00:47+00:00" }, { "id": "7dc219df2b2e4b0c803c981b3f5710a6", "sender": "luke-jr", "payload": "who runs the bot?", "action": false, "timestamp": "2020-11-05T19:01:02+00:00" }, { "id": "17512ace44204d0690fa7610a2c2e610", "sender": "wumpus", "payload": "aj i think?", "action": false, "timestamp": "2020-11-05T19:01:28+00:00" }, { "id": "b6b30a1aebdb4e74ac2a37d9a4d9ff1a", "sender": "wumpus", "payload": "it looks like there are no proposed meeting topics for this week, any last minute topic proposals?", "action": false, "timestamp": "2020-11-05T19:02:17+00:00" }, { "id": "723a532563bf495e881cfd88394d8e4e", "sender": "emzy", "payload": "hi", "action": false, "timestamp": "2020-11-05T19:02:27+00:00" }, { "id": "6e424ff5d824429580570679adcafa49", "sender": "sipa", "payload": "what's left before 0.21 fork off?", "action": false, "timestamp": "2020-11-05T19:02:38+00:00" }, { "id": "102b14bfc5ce48529d7206f3eb22e6c5", "sender": "MarcoFalke", "payload": "sipa: review", "action": false, "timestamp": "2020-11-05T19:02:42+00:00" }, { "id": "5415e9b9eb024744bc286f8bbd4f59a3", "sender": "luke-jr", "payload": "whether to do #20250", "action": false, "timestamp": "2020-11-05T19:02:45+00:00" }, { "id": "d5bbb45008ca40bbb5e26683d0d39d9d", "sender": "gribble", "payload": "https://github.com/bitcoin/bitcoin/issues/20250 | Bugfix: RPC/Wallet: Make BTC/kB and sat/B fee modes work sanely by luke-jr \u00c3\u0082\u00c2\u00b7 Pull Request #20250 \u00c3\u0082\u00c2\u00b7 bitcoin/bitcoin \u00c3\u0082\u00c2\u00b7 GitHub", "action": false, "timestamp": "2020-11-05T19:02:49+00:00" }, { "id": "9d01e919fd19497eae5f75044abf209a", "sender": "wumpus", "payload": "https://github.com/bitcoin/bitcoin/issues?q=is%3Aopen+is%3Aissue+milestone%3A0.21.0", "action": false, "timestamp": "2020-11-05T19:02:59+00:00" }, { "id": "8532cdb091024014b969e7cac35c5f23", "sender": "MarcoFalke", "payload": "https://github.com/bitcoin/bitcoin/milestone/45 has 16 items", "action": false, "timestamp": "2020-11-05T19:03:26+00:00" }, { "id": "a7c94d00d3f846578b893d8c7cb8f7c5", "sender": "luke-jr", "payload": "I can rebase (and retitle) it, but I'm not sure it's worth the effort if we don't consider it worth doing", "action": false, "timestamp": "2020-11-05T19:03:37+00:00" }, { "id": "9708a572d0054705a40b689b06bc8805", "sender": "wumpus", "payload": "MarcoFalke: eh yes, that link is better, i alrady wondered how it ended up with so little items suddenly", "action": false, "timestamp": "2020-11-05T19:04:02+00:00" }, { "id": "3606f3af5dc74270a33795afcd3229ab", "sender": "wumpus", "payload": "we need to go over the list and decide what is necessary to include in 0.21.0 and what can wait", "action": false, "timestamp": "2020-11-05T19:04:22+00:00" }, { "id": "7b4aec313ea2438aa9837958cb162f70", "sender": "luke-jr", "payload": "wumpus: your link excluded PRs :p", "action": false, "timestamp": "2020-11-05T19:04:22+00:00" }, { "id": "1a77401849254b3689d56f9fcbfca85a", "sender": "dongcarl", "payload": "Random observation: Cirrus is so much better about starting CI tasks on time compared to Travis. Thanks MarcoFalke!", "action": false, "timestamp": "2020-11-05T19:04:47+00:00" }, { "id": "d74b65337bf04f9691ae8f26db40c988", "sender": "MarcoFalke", "payload": "luke-jr: I still think we should do *something*. Whether that is #20250 or #20305", "action": false, "timestamp": "2020-11-05T19:05:11+00:00" }, { "id": "ee94d8123aa5447cb2edc93d229cf077", "sender": "gribble", "payload": "https://github.com/bitcoin/bitcoin/issues/20250 | Bugfix: RPC/Wallet: Make BTC/kB and sat/B fee modes work sanely by luke-jr \u00c3\u0082\u00c2\u00b7 Pull Request #20250 \u00c3\u0082\u00c2\u00b7 bitcoin/bitcoin \u00c3\u0082\u00c2\u00b7 GitHub", "action": false, "timestamp": "2020-11-05T19:05:13+00:00" }, { "id": "9865a4957a7245f586bab3ffbae9df94", "sender": "gribble", "payload": "https://github.com/bitcoin/bitcoin/issues/20305 | wallet: introduce fee_rate_sat_vb param/option by jonatack \u00c3\u0082\u00c2\u00b7 Pull Request #20305 \u00c3\u0082\u00c2\u00b7 bitcoin/bitcoin \u00c3\u0082\u00c2\u00b7 GitHub", "action": false, "timestamp": "2020-11-05T19:05:14+00:00" }, { "id": "d63ebbe0275b4b10ba007abda2e65bea", "sender": "MarcoFalke", "payload": "forcing user to use named args with conf_target=0.0003 seems broken", "action": false, "timestamp": "2020-11-05T19:05:41+00:00" }, { "id": "622570a18fb049658cece6ed844b59d9", "sender": "wumpus", "payload": "#20234 seems to be controverial and is still in the discussion phase", "action": false, "timestamp": "2020-11-05T19:05:41+00:00" }, { "id": "8d28cbd3bd9e4081bf777c9521540549", "sender": "gribble", "payload": "https://github.com/bitcoin/bitcoin/issues/20234 | net: dont extra bind for Tor if binds are restricted by vasild \u00c3\u0082\u00c2\u00b7 Pull Request #20234 \u00c3\u0082\u00c2\u00b7 bitcoin/bitcoin \u00c3\u0082\u00c2\u00b7 GitHub", "action": false, "timestamp": "2020-11-05T19:05:44+00:00" }, { "id": "c5ae77e32cb84055b16442568399536d", "sender": "wumpus", "payload": "so I think removing the milestone there makes sense", "action": false, "timestamp": "2020-11-05T19:06:03+00:00" }, { "id": "ab5de918513e43eea6151eb843c3591b", "sender": "MarcoFalke", "payload": "wumpus: Agree", "action": false, "timestamp": "2020-11-05T19:06:17+00:00" }, { "id": "872c9a91b711438a9533bb81b51b3064", "sender": "jnewbery", "payload": "hi", "action": false, "timestamp": "2020-11-05T19:06:50+00:00" }, { "id": "4a21b546bf694f769b5d8d15ca7b9fc3", "sender": "hebasto", "payload": "agree too", "action": false, "timestamp": "2020-11-05T19:06:51+00:00" }, { "id": "4e2d117c4173408c99f8a4d8e07ae989", "sender": "aj", "payload": "hi", "action": false, "timestamp": "2020-11-05T19:07:08+00:00" }, { "id": "0a3ada87d2494e6ab86f7930c3d0380b", "sender": "luke-jr", "payload": "aj: where bot", "action": false, "timestamp": "2020-11-05T19:07:13+00:00" }, { "id": "162053680c93467ba1c98dc0767137f6", "sender": "wumpus", "payload": "#20284 was discussed in the P2P meeting, *something* like it needs to go in to make sure that previous versions don't parse the peers.dat as garbage and insert gerbage addresses", "action": false, "timestamp": "2020-11-05T19:07:20+00:00" }, { "id": "4d0400a5f5b04319b03d9afd51827fed", "sender": "gribble", "payload": "https://github.com/bitcoin/bitcoin/issues/20284 | addrman: ensure old versions dont parse peers.dat by vasild \u00c3\u0082\u00c2\u00b7 Pull Request #20284 \u00c3\u0082\u00c2\u00b7 bitcoin/bitcoin \u00c3\u0082\u00c2\u00b7 GitHub", "action": false, "timestamp": "2020-11-05T19:07:22+00:00" }, { "id": "4bb69f1e51d943fdbf180e68d582960f", "sender": "sipa", "payload": "will review that one soon", "action": false, "timestamp": "2020-11-05T19:07:46+00:00" }, { "id": "241e906e73894b92b927ec18f6dabf0b", "sender": "wumpus", "payload": "I had removed #20205 from the 0.21.0 milestone but jonaschnelli re-added it", "action": false, "timestamp": "2020-11-05T19:08:33+00:00" }, { "id": "9678e329ddbe4287b0d00e1e32e8c8dd", "sender": "gribble", "payload": "https://github.com/bitcoin/bitcoin/issues/20205 | wallet: Properly support a wallet id by achow101 \u00c3\u0082\u00c2\u00b7 Pull Request #20205 \u00c3\u0082\u00c2\u00b7 bitcoin/bitcoin \u00c3\u0082\u00c2\u00b7 GitHub", "action": false, "timestamp": "2020-11-05T19:08:36+00:00" }, { "id": "966db308ee334457a4ff3934155479d2", "sender": "luke-jr", "payload": "20205 is needed", "action": false, "timestamp": "2020-11-05T19:08:41+00:00" }, { "id": "1900556a57e842ad8e7b6ce9536b29f3", "sender": "wumpus", "payload": "I think it's also contoversial", "action": false, "timestamp": "2020-11-05T19:08:43+00:00" }, { "id": "ce80bfc1d0e343209f748ab81ca383bc", "sender": "luke-jr", "payload": "wumpus: absolute worst case we'd just not use it", "action": false, "timestamp": "2020-11-05T19:08:57+00:00" }, { "id": "049256f684e746d88e2191370fb9f28e", "sender": "wumpus", "payload": "there seems to be no hurry and people differ in opinion whther it's needed at all", "action": false, "timestamp": "2020-11-05T19:08:59+00:00" }, { "id": "aa6fba6a3fca4f9a8213b626cefeedeb", "sender": "jonasschnelli", "payload": "wumpus: I didn't know that you have removed it.", "action": false, "timestamp": "2020-11-05T19:09:07+00:00" }, { "id": "0df79736648941bfab6e8002a97f2760", "sender": "luke-jr", "payload": "the hurry is to not create wallets with a regression", "action": false, "timestamp": "2020-11-05T19:09:13+00:00" }, { "id": "ff914d0fbcac445485c9e10b532c30fa", "sender": "luke-jr", "payload": "all wallets today have a unique id", "action": false, "timestamp": "2020-11-05T19:09:25+00:00" }, { "id": "71ba32e9215c4cbb97811467eeafc25c", "sender": "wumpus", "payload": "jonasschnelli: https://github.com/bitcoin/bitcoin/pull/20205#issuecomment-718632332", "action": false, "timestamp": "2020-11-05T19:09:28+00:00" }, { "id": "50bed982d355454db6c82ab33bbcebd7", "sender": "jonasschnelli", "payload": "Adding a UUID later leads probably to a number of wallets without unique ids.", "action": false, "timestamp": "2020-11-05T19:09:31+00:00" }, { "id": "05085bca0c4541c4a98e49ce7c4325f6", "sender": "wumpus", "payload": "luke-jr: yes, but it is only necessary for bdb, it's unclear if it's necessary in general", "action": false, "timestamp": "2020-11-05T19:09:41+00:00" }, { "id": "76e352f1d5014efd9029cdcac953128e", "sender": "luke-jr", "payload": "wumpus: even in doubt (which I don't have anyway), it would still make sense to keep it", "action": false, "timestamp": "2020-11-05T19:10:06+00:00" }, { "id": "43f02f03991a4fa59a7349bdda5d30aa", "sender": "wumpus", "payload": "in any case it is delaying the split-off", "action": false, "timestamp": "2020-11-05T19:10:07+00:00" }, { "id": "008686db2e294964907a15dfee792a7d", "sender": "luke-jr", "payload": "it doesn't have to be, it's trivial to review", "action": false, "timestamp": "2020-11-05T19:10:21+00:00" }, { "id": "f1b2c400039c4e2a96fa4e1b7d766a8c", "sender": "luke-jr", "payload": "it's not like we're ready to split off anyway", "action": false, "timestamp": "2020-11-05T19:10:43+00:00" }, { "id": "f4d65425a5e64141af49219adcdfe2c9", "sender": "wumpus", "payload": "#20318 (thanks for catching this last minute) and #20292 are no-brainers", "action": false, "timestamp": "2020-11-05T19:10:52+00:00" }, { "id": "3e12d88f9f7b463090cb0d8497653207", "sender": "gribble", "payload": "https://github.com/bitcoin/bitcoin/issues/20318 | build: Ensure source tarball has leading directory name by MarcoFalke \u00c3\u0082\u00c2\u00b7 Pull Request #20318 \u00c3\u0082\u00c2\u00b7 bitcoin/bitcoin \u00c3\u0082\u00c2\u00b7 GitHub", "action": false, "timestamp": "2020-11-05T19:10:53+00:00" }, { "id": "12c071d6579f42e183a16f7a4361c949", "sender": "gribble", "payload": "https://github.com/bitcoin/bitcoin/issues/20292 | test: Fix intermittent feature_taproot issue by MarcoFalke \u00c3\u0082\u00c2\u00b7 Pull Request #20292 \u00c3\u0082\u00c2\u00b7 bitcoin/bitcoin \u00c3\u0082\u00c2\u00b7 GitHub", "action": false, "timestamp": "2020-11-05T19:10:54+00:00" }, { "id": "25282a0018bf4ebebf724cad642098ba", "sender": "meshcollider", "payload": "#19502 has needed rebase for a few days now, that needs to be rebased or removed from the milestone", "action": false, "timestamp": "2020-11-05T19:11:29+00:00" }, { "id": "7c1ad76f2bd74e669f1be50db68e189b", "sender": "gribble", "payload": "https://github.com/bitcoin/bitcoin/issues/19502 | Bugfix: Wallet: Soft-fail exceptions within ListWalletDir file checks by luke-jr \u00c3\u0082\u00c2\u00b7 Pull Request #19502 \u00c3\u0082\u00c2\u00b7 bitcoin/bitcoin \u00c3\u0082\u00c2\u00b7 GitHub", "action": false, "timestamp": "2020-11-05T19:11:32+00:00" }, { "id": "e853a05c05b247d7b1fc582c9a2f6672", "sender": "luke-jr", "payload": "I can reopen my simpler wallet-id PR if 20205 if we want something even easier to review - achow101 didn't like the layer stuff though", "action": false, "timestamp": "2020-11-05T19:11:42+00:00" }, { "id": "217807e57c1c4d93a857e27ecb580ce9", "sender": "wumpus", "payload": "#20120 seems mostly test related", "action": false, "timestamp": "2020-11-05T19:11:47+00:00" }, { "id": "fe691f26598247c38a668975170219f2", "sender": "gribble", "payload": "https://github.com/bitcoin/bitcoin/issues/20120 | net, rpc, test, bugfix: update GetNetworkName, GetNetworksInfo, regression tests by jonatack \u00c3\u0082\u00c2\u00b7 Pull Request #20120 \u00c3\u0082\u00c2\u00b7 bitcoin/bitcoin \u00c3\u0082\u00c2\u00b7 GitHub", "action": false, "timestamp": "2020-11-05T19:11:49+00:00" }, { "id": "0fc6c4d96e4845258fc0b3f1e0edc678", "sender": "luke-jr", "payload": "meshcollider: I can do that", "action": false, "timestamp": "2020-11-05T19:12:10+00:00" }, { "id": "3d3ac1e6558d4915a58388b57250c804", "sender": "achow101", "payload": "luke-jr: your pr would have introduced garbage that we would have to keep around forever. it may be simpler, but it definitely is no the correct way", "action": false, "timestamp": "2020-11-05T19:12:13+00:00" }, { "id": "bd4b34e091d343ac82c5c34d897592c0", "sender": "jnewbery", "payload": "I don't think we should be adding controversial features last minute to accommodate knots, which appears to be the main motivation for 20205", "action": false, "timestamp": "2020-11-05T19:12:16+00:00" }, { "id": "a7f131a25f6947e5a2f2d7632d0916da", "sender": "wumpus", "payload": "if there's principal issues with the idea of having a unique id, I don't think opening another PR will resolve that", "action": false, "timestamp": "2020-11-05T19:12:23+00:00" }, { "id": "6fcfede3703d4fc782ae135d6347a492", "sender": "jonatack", "payload": "20120 is a bugfix with 3-4 acks", "action": false, "timestamp": "2020-11-05T19:12:44+00:00" }, { "id": "919cd9a0350545c7833ab29b6c0cb17d", "sender": "sipa", "payload": "#20120", "action": false, "timestamp": "2020-11-05T19:13:08+00:00" }, { "id": "cb567e48075e4bdea2abe8602bf58e49", "sender": "luke-jr", "payload": "jnewbery: this isn't adding features, it's NOT removign existing feature", "action": false, "timestamp": "2020-11-05T19:13:09+00:00" }, { "id": "08f129505d85419ea84dc869b9b0108d", "sender": "gribble", "payload": "https://github.com/bitcoin/bitcoin/issues/20120 | net, rpc, test, bugfix: update GetNetworkName, GetNetworksInfo, regression tests by jonatack \u00c3\u0082\u00c2\u00b7 Pull Request #20120 \u00c3\u0082\u00c2\u00b7 bitcoin/bitcoin \u00c3\u0082\u00c2\u00b7 GitHub", "action": false, "timestamp": "2020-11-05T19:13:09+00:00" }, { "id": "3f15ca2668c14355a3ff1c95ae261e41", "sender": "wumpus", "payload": "#19502 seems to have reviews and ACKs but needs rebase", "action": false, "timestamp": "2020-11-05T19:13:21+00:00" }, { "id": "eb2ec084dc674cd6ad4ce4f26c899282", "sender": "gribble", "payload": "https://github.com/bitcoin/bitcoin/issues/19502 | Bugfix: Wallet: Soft-fail exceptions within ListWalletDir file checks by luke-jr \u00c3\u0082\u00c2\u00b7 Pull Request #19502 \u00c3\u0082\u00c2\u00b7 bitcoin/bitcoin \u00c3\u0082\u00c2\u00b7 GitHub", "action": false, "timestamp": "2020-11-05T19:13:23+00:00" }, { "id": "2cfa52f3aecc4c0092d37f963fb29105", "sender": "wumpus", "payload": "jonatack: yep", "action": false, "timestamp": "2020-11-05T19:13:35+00:00" }, { "id": "a3f38997a2a94e1ab1c316f94a14c592", "sender": "luke-jr", "payload": "jnewbery: and Core can absolutely make use of it as well, even if review is slower", "action": false, "timestamp": "2020-11-05T19:14:12+00:00" }, { "id": "40d0673c046244758cb21b13d3b0ec93", "sender": "wumpus", "payload": "#20266 is a straightforward bug fix", "action": false, "timestamp": "2020-11-05T19:15:21+00:00" }, { "id": "211b4382de8b4ffeaa8a0aeaa3e5d5c1", "sender": "gribble", "payload": "https://github.com/bitcoin/bitcoin/issues/20266 | wallet: fix change detection of imported internal descriptors by achow101 \u00c3\u0082\u00c2\u00b7 Pull Request #20266 \u00c3\u0082\u00c2\u00b7 bitcoin/bitcoin \u00c3\u0082\u00c2\u00b7 GitHub", "action": false, "timestamp": "2020-11-05T19:15:23+00:00" }, { "id": "add844557e7a47d99237cee6b64918b6", "sender": "wumpus", "payload": "and also ACKed", "action": false, "timestamp": "2020-11-05T19:15:32+00:00" }, { "id": "fce99b56fa7c4311820058115be98549", "sender": "wumpus", "payload": "#18836 has many changes and only an approach ACK yet", "action": false, "timestamp": "2020-11-05T19:16:09+00:00" }, { "id": "a7c63da553334a5db9bf6b225f5d318e", "sender": "gribble", "payload": "https://github.com/bitcoin/bitcoin/issues/18836 | wallet: upgradewallet fixes and additional tests by achow101 \u00c3\u0082\u00c2\u00b7 Pull Request #18836 \u00c3\u0082\u00c2\u00b7 bitcoin/bitcoin \u00c3\u0082\u00c2\u00b7 GitHub", "action": false, "timestamp": "2020-11-05T19:16:11+00:00" }, { "id": "10dd50ae0fc14d35ae25049ff8954126", "sender": "aj", "payload": "ugh, apparently some upgrade broke poor lightningbot", "action": false, "timestamp": "2020-11-05T19:16:34+00:00" }, { "id": "8c21f7dfe692422ab28e1d4a6e9704c8", "sender": "meshcollider", "payload": "wumpus: it has an ACK too", "action": false, "timestamp": "2020-11-05T19:17:05+00:00" }, { "id": "f5e02418e25b4c439da6bcb5c59499cc", "sender": "meshcollider", "payload": "And I am very nearly finished reviewing it", "action": false, "timestamp": "2020-11-05T19:17:16+00:00" }, { "id": "e475a9c52e184510ae0f6be8ac320a64", "sender": "wumpus", "payload": "ah no it has two normal ACKs as well", "action": false, "timestamp": "2020-11-05T19:17:18+00:00" }, { "id": "2a1a15192b2044c984fc4bf68bfaf1ed", "sender": "wumpus", "payload": "thanks github", "action": false, "timestamp": "2020-11-05T19:17:23+00:00" }, { "id": "60da3423d8cd4741a2137a2543a5fb22", "sender": "luke-jr", "payload": "descriptor wallets should never have been merged without unique ids, it's a bug that they're missing", "action": false, "timestamp": "2020-11-05T19:17:40+00:00" }, { "id": "7b718e7c61f04018893db332ee95381d", "sender": "jonatack", "payload": "heh github the ack hacker", "action": false, "timestamp": "2020-11-05T19:17:57+00:00" }, { "id": "d18cccb162ec4eb08e24f44f96d4beb7", "sender": "wumpus", "payload": "\"hidden items\" are for games not SCM interfaces", "action": false, "timestamp": "2020-11-05T19:18:07+00:00" }, { "id": "7bf0d9aa4cba4d698627ca9215c9f958", "sender": "wumpus", "payload": "#20153 is a bugfix and has two ACKs", "action": false, "timestamp": "2020-11-05T19:19:06+00:00" }, { "id": "0b2d006eb3ec406ea5b6ef74a655e366", "sender": "gribble", "payload": "https://github.com/bitcoin/bitcoin/issues/20153 | wallet: do not import a descriptor with hardened derivations into a watch-only wallet by S3RK \u00c3\u0082\u00c2\u00b7 Pull Request #20153 \u00c3\u0082\u00c2\u00b7 bitcoin/bitcoin \u00c3\u0082\u00c2\u00b7 GitHub", "action": false, "timestamp": "2020-11-05T19:19:08+00:00" }, { "id": "f73dad1783744287ae8da53667bf18be", "sender": "MarcoFalke", "payload": "18836 doesn't fix a regression I think, so it is fine to merge or not to merge, depending on review", "action": false, "timestamp": "2020-11-05T19:19:42+00:00" }, { "id": "07f5f9eeef10482fb6db8dec6f03c7df", "sender": "wumpus", "payload": "then there's #18818, which is unnecessary in my opinion, there hasn't been much review otherwise", "action": false, "timestamp": "2020-11-05T19:20:30+00:00" }, { "id": "e22249129aa94622b9db105d55a0b7ab", "sender": "gribble", "payload": "https://github.com/bitcoin/bitcoin/issues/18818 | Fix release tarball generated by gitian by luke-jr \u00c3\u0082\u00c2\u00b7 Pull Request #18818 \u00c3\u0082\u00c2\u00b7 bitcoin/bitcoin \u00c3\u0082\u00c2\u00b7 GitHub", "action": false, "timestamp": "2020-11-05T19:20:33+00:00" }, { "id": "726af41398684b94ac505e3366ef92fb", "sender": "wumpus", "payload": "so the biggest thing left for 0.21.0 seems to be the RPC unit discussion", "action": false, "timestamp": "2020-11-05T19:21:13+00:00" }, { "id": "2ce1602f05154d53a69221d9a931e2a8", "sender": "luke-jr", "payload": "18818 is part of 0.20 already", "action": false, "timestamp": "2020-11-05T19:21:33+00:00" }, { "id": "ff9da637411d462cb7ac692954555b26", "sender": "wumpus", "payload": "#20305 #20250", "action": false, "timestamp": "2020-11-05T19:21:41+00:00" }, { "id": "09f12461131f46afa27778c04337745e", "sender": "gribble", "payload": "https://github.com/bitcoin/bitcoin/issues/20305 | wallet: introduce fee_rate_sat_vb param/option by jonatack \u00c3\u0082\u00c2\u00b7 Pull Request #20305 \u00c3\u0082\u00c2\u00b7 bitcoin/bitcoin \u00c3\u0082\u00c2\u00b7 GitHub", "action": false, "timestamp": "2020-11-05T19:21:42+00:00" }, { "id": "516c286817084c0f987ba43a439df4d1", "sender": "gribble", "payload": "https://github.com/bitcoin/bitcoin/issues/20250 | Bugfix: RPC/Wallet: Make BTC/kB and sat/B fee modes work sanely by luke-jr \u00c3\u0082\u00c2\u00b7 Pull Request #20250 \u00c3\u0082\u00c2\u00b7 bitcoin/bitcoin \u00c3\u0082\u00c2\u00b7 GitHub", "action": false, "timestamp": "2020-11-05T19:21:44+00:00" }, { "id": "1ac446dd2cc14275861ae0b646576c34", "sender": "luke-jr", "payload": "partially", "action": false, "timestamp": "2020-11-05T19:21:50+00:00" }, { "id": "f1a8bdfd8d0242f49543a1d83cf092bb", "sender": "wumpus", "payload": "luke-jr: no, #20318 is", "action": false, "timestamp": "2020-11-05T19:21:54+00:00" }, { "id": "c2be7eb4306145b2a53c7260402e61ea", "sender": "gribble", "payload": "https://github.com/bitcoin/bitcoin/issues/20318 | build: Ensure source tarball has leading directory name by MarcoFalke \u00c3\u0082\u00c2\u00b7 Pull Request #20318 \u00c3\u0082\u00c2\u00b7 bitcoin/bitcoin \u00c3\u0082\u00c2\u00b7 GitHub", "action": false, "timestamp": "2020-11-05T19:21:55+00:00" }, { "id": "eda4d4ac942e4c7a83452becd24dfeab", "sender": "wumpus", "payload": "yes, it is part of it, true", "action": false, "timestamp": "2020-11-05T19:22:21+00:00" }, { "id": "3a177a5a965b449db2221becee895c5b", "sender": "jonatack", "payload": "20305 contains a bugfix for the send rpc that can be moved to its own pull, if needed. The rest is really easier to do pre-release. Afterward, it would have to be overhauled a bit to support both the overloading and the new param.", "action": false, "timestamp": "2020-11-05T19:23:14+00:00" }, { "id": "ae3932c1e3a14d33a67ffa8bd52f0e5d", "sender": "MarcoFalke", "payload": "The autogen.sh part was controversial and is not a regression-bugfix, so I've removed the milestone", "action": false, "timestamp": "2020-11-05T19:23:15+00:00" }, { "id": "11fb49441d02448e87067870f404a162", "sender": "wumpus", "payload": "regarding the RPC units it's good not to introduce a RPC inconsistency for a release, so I agree we need to do something there", "action": false, "timestamp": "2020-11-05T19:23:45+00:00" }, { "id": "6d34123d00974a6c906363c60dc5d531", "sender": "wumpus", "payload": "MarcoFalke: +1", "action": false, "timestamp": "2020-11-05T19:24:10+00:00" }, { "id": "3330d229d9224113a6692eb9492c42c6", "sender": "jonatack", "payload": "If we don't want to overload conf_target and estimate_mode in these 6 RPCs, better to not release them", "action": false, "timestamp": "2020-11-05T19:24:14+00:00" }, { "id": "3798c354c0914baba40cb28d562632a2", "sender": "jonatack", "payload": "than to have to support them and then deprecate them", "action": false, "timestamp": "2020-11-05T19:24:31+00:00" }, { "id": "9c2d65cb838e46769f416dc8812bfab7", "sender": "wumpus", "payload": "yes", "action": false, "timestamp": "2020-11-05T19:24:37+00:00" }, { "id": "4e2e4666bf194d27b3925ed07cda0ee1", "sender": "wumpus", "payload": "that would be silly", "action": false, "timestamp": "2020-11-05T19:25:10+00:00" }, { "id": "b301f9325c584559ace300b3d341e053", "sender": "jonatack", "payload": "so that was the motivation, sorry for doing it so late, but the merge yesterday of the PR 11413 follow-ups motivated me to spike on it", "action": false, "timestamp": "2020-11-05T19:25:59+00:00" }, { "id": "7d613df5c90b44fb9d63589b30486308", "sender": "luke-jr", "payload": "MarcoFalke: it is a bugfix for a regression in 0.20, but whatever", "action": false, "timestamp": "2020-11-05T19:26:44+00:00" }, { "id": "b059bfcf2867423dbc206a5d1dcbeb1b", "sender": "MarcoFalke", "payload": "luke-jr: Yes, so it is not a regression in 0.21", "action": false, "timestamp": "2020-11-05T19:27:05+00:00" }, { "id": "638f8fab37bc4644a607997a5910f155", "sender": "wumpus", "payload": "you're always very quick to call things bugfixes", "action": false, "timestamp": "2020-11-05T19:27:49+00:00" }, { "id": "68b35ef167204b2a9cc400f9c2aa5ce1", "sender": "luke-jr", "payload": "wumpus: when they actually are, yes", "action": false, "timestamp": "2020-11-05T19:28:05+00:00" }, { "id": "9247e18d79b6402c9ef47615528a9f03", "sender": "sipa", "payload": "what is the bug here?", "action": false, "timestamp": "2020-11-05T19:29:06+00:00" }, { "id": "93eb7dd5b11f4e41ae76be767742ab57", "sender": "wumpus", "payload": "in any case we've been over the entire list now--that concludes this topic, happy reviewing", "action": false, "timestamp": "2020-11-05T19:29:07+00:00" }, { "id": "b32d3ac104794a33abf60407430829e4", "sender": "luke-jr", "payload": "sipa: building goes looking for .git outside of the source tree and uses whatever it finds", "action": false, "timestamp": "2020-11-05T19:29:27+00:00" }, { "id": "663caeb44fac4917a3de34651cc32794", "sender": "sipa", "payload": "ah", "action": false, "timestamp": "2020-11-05T19:29:39+00:00" }, { "id": "7672239ee78944688155c46940c74d4d", "sender": "luke-jr", "payload": "lightningbot: ping", "action": false, "timestamp": "2020-11-05T19:41:00+00:00" }, { "id": "2f6bda2464c64598b3f39a46c284d4aa", "sender": "lightningbot", "payload": "pong", "action": false, "timestamp": "2020-11-05T19:41:00+00:00" }, { "id": "1876ed1ad63f4d8bbad7ec5a04e33fd3", "sender": "luke-jr", "payload": "aj: thanks", "action": false, "timestamp": "2020-11-05T19:41:44+00:00" }, { "id": "befc9dc98edd48d6904bf20d14307271", "sender": "aj", "payload": "i don't think it actually supports meetings again yet", "action": false, "timestamp": "2020-11-05T19:42:46+00:00" }, { "id": "3197a07be3a846f1a138dc7bf843d763", "sender": "kanzure", "payload": "timezones.", "action": false, "timestamp": "2020-11-05T20:00:27+00:00" }, { "id": "54089d36cc494db4ab9d27307979c36b", "sender": "luke-jr", "payload": "kanzure: don't use them", "action": false, "timestamp": "2020-11-05T20:04:20+00:00" }, { "id": "052bd834e21b437f8cbae7a2af4a980a", "sender": "bitcoin-git", "payload": "[gui] jarolrod opened pull request #129: qt: Fix Shortcut Ambiguities, Clean up text (master...optionsMenuCleanup) https://github.com/bitcoin-core/gui/pull/129", "action": false, "timestamp": "2020-11-05T22:23:37+00:00" }, { "id": "0eafb583edaf46b8ac0af9c6074767bd", "sender": "bitcoin-git", "payload": "[bitcoin] stepansnigirev opened pull request #20326: tests: Fix ecdsa_verify in test framework (master...fix-test-ecdsa-verification) https://github.com/bitcoin/bitcoin/pull/20326", "action": false, "timestamp": "2020-11-05T22:27:48+00:00" }, { "id": "02b54fec1f664063b16e98f13bfdd923", "sender": "fanquake", "payload": "Received a response from GitHub in regards to our \"load more\" issues: https://0bin.net/paste/ox1MH8xR#Kn-kr5erlHeeOnBXYiloYLuikSrO03S+46FEGxLO+Ki.", "action": false, "timestamp": "2020-11-06T00:38:28+00:00" }, { "id": "9aa19bb858004998bebd5887bd3bb753", "sender": "fanquake", "payload": "The email they are responding to I sent on the 12 October. Still haven't received any response to issues opened in the maintainer group in regards to our \"load more\" or \"show/hide\" issues.", "action": false, "timestamp": "2020-11-06T00:39:12+00:00" }, { "id": "18e87a7477c24a12bffc50ed54197e2f", "sender": "fanquake", "payload": "Actually, we have got a response in regards to the show/hide issue. It's that they cannot reproduce. I assume that's because they waited 5 days to look, and it's since been merged / something has changed.", "action": false, "timestamp": "2020-11-06T00:57:45+00:00" }, { "id": "ecea4496b15c46ed9d43ef84f1e63881", "sender": "wumpus", "payload": "fanquake: thanks for the update", "action": false, "timestamp": "2020-11-06T03:47:50+00:00" }, { "id": "27125878fa7543c592d13af4afe2ef1b", "sender": "luke-jr", "payload": "#19502 rebased", "action": false, "timestamp": "2020-11-06T04:35:51+00:00" }, { "id": "240cc5ee73c44ec59f5e658bf6533914", "sender": "gribble", "payload": "https://github.com/bitcoin/bitcoin/issues/19502 | Bugfix: Wallet: Soft-fail exceptions within ListWalletDir file checks by luke-jr \u00c3\u0082\u00c2\u00b7 Pull Request #19502 \u00c3\u0082\u00c2\u00b7 bitcoin/bitcoin \u00c3\u0082\u00c2\u00b7 GitHub", "action": false, "timestamp": "2020-11-06T04:35:53+00:00" }, { "id": "d5ca5e3867274cc4945e98b4bf9d478b", "sender": "wumpus", "payload": "luke-jr: thanks", "action": false, "timestamp": "2020-11-06T05:32:08+00:00" }, { "id": "acb413677d7f4825bfd657d5b7790045", "sender": "wumpus", "payload": "fanquake: ideally we could disable hiding of items completely for the entire repository, but i guess that would bring back the unicorns", "action": false, "timestamp": "2020-11-06T05:33:07+00:00" }, { "id": "c3f00fc610a5441682b47018522d47d5", "sender": "wumpus", "payload": "surprising how fast computers and internet connections are nowadays but showing a moderate number of items of text is still problematic", "action": false, "timestamp": "2020-11-06T05:34:16+00:00" }, { "id": "b9a1daa1f05b4d80a7f8cd2a3ad6c52f", "sender": "fanquake", "payload": "wumpus: I\u00c3\u00a2\u00c2\u0080\u00c2\u0099ll ask, but yea probably. My understanding is that the hiding was introduced to fix the fact that they can\u00c3\u00a2\u00c2\u0080\u00c2\u0099t load enough page content at once.", "action": false, "timestamp": "2020-11-06T06:00:36+00:00" }, { "id": "133f1814180c4cd4a0c16939b35fcf31", "sender": "wumpus", "payload": "yes, exactly", "action": false, "timestamp": "2020-11-06T06:48:20+00:00" }, { "id": "183c172f76104465ac200d0603e975ed", "sender": "bitcoin-git", "payload": "[bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/f5cdc290d5a4...65460c207c0b", "action": false, "timestamp": "2020-11-06T07:04:51+00:00" }, { "id": "299f1ab192394edd833407cfe14f300d", "sender": "bitcoin-git", "payload": "bitcoin/master faf5fa7 MarcoFalke: wallet: Set DatabaseStatus::SUCCESS in MakeSQLiteDatabase", "action": false, "timestamp": "2020-11-06T07:04:52+00:00" }, { "id": "64f79c77e68e4cc79d3034513268cd2c", "sender": "bitcoin-git", "payload": "bitcoin/master 65460c2 MarcoFalke: Merge #20324: wallet: Set DatabaseStatus::SUCCESS in MakeSQLiteDatabase", "action": false, "timestamp": "2020-11-06T07:04:52+00:00" }, { "id": "b926e06605ef4e8cbacc52e43a215461", "sender": "bitcoin-git", "payload": "[bitcoin] MarcoFalke merged pull request #20324: wallet: Set DatabaseStatus::SUCCESS in MakeSQLiteDatabase (master...2011-walletSqliteSuccess) https://github.com/bitcoin/bitcoin/pull/20324", "action": false, "timestamp": "2020-11-06T07:05:11+00:00" }, { "id": "adc326e0f40e4a819ff92a0e2a52bc63", "sender": "bitcoin-git", "payload": "[bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/65460c207c0b...c51c2753a4ff", "action": false, "timestamp": "2020-11-06T07:11:16+00:00" }, { "id": "66236f45521546109c74a8d904ba2b14", "sender": "bitcoin-git", "payload": "bitcoin/master 568a1d7 Stepan Snigirev: fix ecdsa verify in test framework", "action": false, "timestamp": "2020-11-06T07:11:16+00:00" }, { "id": "504fff10e2ae4a06aadf0cbbca5387cc", "sender": "bitcoin-git", "payload": "bitcoin/master c51c275 MarcoFalke: Merge #20326: tests: Fix ecdsa_verify in test framework", "action": false, "timestamp": "2020-11-06T07:11:17+00:00" }, { "id": "8f6d70a464e34a2f870199adaf3cc54f", "sender": "bitcoin-git", "payload": "[bitcoin] MarcoFalke merged pull request #20326: tests: Fix ecdsa_verify in test framework (master...fix-test-ecdsa-verification) https://github.com/bitcoin/bitcoin/pull/20326", "action": false, "timestamp": "2020-11-06T07:11:36+00:00" }, { "id": "c0afbb6e9dec41d6ac466770ed2b340d", "sender": "bitcoin-git", "payload": "[bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/c51c2753a4ff...a0c00ff7c045", "action": false, "timestamp": "2020-11-06T07:35:32+00:00" }, { "id": "bc813f80c66146108b89919c7ceda064", "sender": "bitcoin-git", "payload": "bitcoin/master 04a69c2 Jonas Schnelli: macOS deploy: use the new plistlib API", "action": false, "timestamp": "2020-11-06T07:35:32+00:00" }, { "id": "8624240a42ca4eb69d0e6c44d9cc5e3c", "sender": "bitcoin-git", "payload": "bitcoin/master a0c00ff fanquake: Merge #20298: macOS deploy: use the new plistlib API", "action": false, "timestamp": "2020-11-06T07:35:33+00:00" }, { "id": "2075bd7279d44259a13b4e707eb311e1", "sender": "bitcoin-git", "payload": "[bitcoin] fanquake merged pull request #20298: macOS deploy: use the new plistlib API (master...2020/11/macdeployfix) https://github.com/bitcoin/bitcoin/pull/20298", "action": false, "timestamp": "2020-11-06T07:35:51+00:00" }, { "id": "f5772d4ccdce4c96999f02a2aa402010", "sender": "meshcollider", "payload": "wumpus: it would be nice and fast if there was a plaintext mode without their fancy formatting", "action": false, "timestamp": "2020-11-06T07:54:43+00:00" }, { "id": "13cbc9d2fc734d3a9523fc1b3d0aaa9a", "sender": "fanquake", "payload": "meshcollider: Could you chuck out an opinion in regards to #20305 & #20250. Not sure if they are necessarily in conflict?", "action": false, "timestamp": "2020-11-06T08:00:59+00:00" }, { "id": "d916ea9867224df58f1da999d3ec6751", "sender": "gribble", "payload": "https://github.com/bitcoin/bitcoin/issues/20305 | wallet: introduce fee_rate_sat_vb param/option by jonatack \u00c3\u0082\u00c2\u00b7 Pull Request #20305 \u00c3\u0082\u00c2\u00b7 bitcoin/bitcoin \u00c3\u0082\u00c2\u00b7 GitHub", "action": false, "timestamp": "2020-11-06T08:01:01+00:00" }, { "id": "31a34e0a726345bf83c5ba60357d79b2", "sender": "gribble", "payload": "https://github.com/bitcoin/bitcoin/issues/20250 | Bugfix: RPC/Wallet: Make BTC/kB and sat/B fee modes work sanely by luke-jr \u00c3\u0082\u00c2\u00b7 Pull Request #20250 \u00c3\u0082\u00c2\u00b7 bitcoin/bitcoin \u00c3\u0082\u00c2\u00b7 GitHub", "action": false, "timestamp": "2020-11-06T08:01:03+00:00" }, { "id": "5a2ed89f367e4e608b1ddae6c6960224", "sender": "meshcollider", "payload": "fanquake: will do soon, thanks", "action": false, "timestamp": "2020-11-06T08:01:44+00:00" }, { "id": "e02d49f0a8d74383ad714d9c5df518a7", "sender": "bitcoin-git", "payload": "[bitcoin] MarcoFalke opened pull request #20328: cirrus: Skip tasks on the gui repo main branch (master...2011-cirrusSkip) https://github.com/bitcoin/bitcoin/pull/20328", "action": false, "timestamp": "2020-11-06T09:15:10+00:00" }, { "id": "44846116d821498fbb6b537acf72e336", "sender": "bitcoin-git", "payload": "[bitcoin] dgpv opened pull request #20329: docs/descriptors.md: Remove hardened marker in the path after xpub (master...fix-descriptors-md-hardened-after-xpub) https://github.com/bitcoin/bitcoin/pull/20329", "action": false, "timestamp": "2020-11-06T09:20:51+00:00" }, { "id": "085a72f1cb84406394b710210accc8f5", "sender": "wumpus", "payload": "meshcollider: agree!", "action": false, "timestamp": "2020-11-06T10:28:29+00:00" }, { "id": "1c7675bd833841a6b632716e878b9477", "sender": "bitcoin-git", "payload": "[bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/a0c00ff7c045...4727c1ca2493", "action": false, "timestamp": "2020-11-06T17:08:23+00:00" }, { "id": "95047a5040dc470bb9c8691e6214cb48", "sender": "bitcoin-git", "payload": "bitcoin/master 66667ac MarcoFalke: cirrus: Skip tasks on the gui repo main branch", "action": false, "timestamp": "2020-11-06T17:08:24+00:00" }, { "id": "420a689146c446f28295ad646a24bbd8", "sender": "bitcoin-git", "payload": "bitcoin/master 4727c1c MarcoFalke: Merge #20328: cirrus: Skip tasks on the gui repo main branch", "action": false, "timestamp": "2020-11-06T17:08:24+00:00" }, { "id": "4ef96cac20eb4b8286d6413f94726f99", "sender": "bitcoin-git", "payload": "[bitcoin] MarcoFalke merged pull request #20328: cirrus: Skip tasks on the gui repo main branch (master...2011-cirrusSkip) https://github.com/bitcoin/bitcoin/pull/20328", "action": false, "timestamp": "2020-11-06T17:08:43+00:00" }, { "id": "1510b856b7d34e8dbe4d72c8c440cea6", "sender": "bitcoin-git", "payload": "[bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/4727c1ca2493...7e373294a5ae", "action": false, "timestamp": "2020-11-06T17:10:10+00:00" }, { "id": "4dba63eec75f4eaf8e34b1104df9d62b", "sender": "bitcoin-git", "payload": "bitcoin/master fac0517 MarcoFalke: travis: Remove s390x build", "action": false, "timestamp": "2020-11-06T17:10:10+00:00" }, { "id": "52aa3c811740478cab0233e6d8d9ee4f", "sender": "bitcoin-git", "payload": "bitcoin/master fa2c3c0 MarcoFalke: ci: Set LC_ALL=C to allow running the s390x tests in qemu", "action": false, "timestamp": "2020-11-06T17:10:11+00:00" }, { "id": "32eabe573220431797d963f227eacda1", "sender": "bitcoin-git", "payload": "bitcoin/master 7e37329 MarcoFalke: Merge #20315: travis: Remove s390x build", "action": false, "timestamp": "2020-11-06T17:10:12+00:00" }, { "id": "328c7707d28249fbbd4007fb2b15a8c0", "sender": "bitcoin-git", "payload": "[bitcoin] MarcoFalke merged pull request #20315: travis: Remove s390x build (master...2010-ciS390x) https://github.com/bitcoin/bitcoin/pull/20315", "action": false, "timestamp": "2020-11-06T17:10:30+00:00" }, { "id": "2d739f2948a740bba4d290ee8ec236fa", "sender": "achow101", "payload": "wallet meeting?", "action": false, "timestamp": "2020-11-06T19:00:10+00:00" }, { "id": "09aa4089e8c14af1a9b46e142a89ac6a", "sender": "meshcollider", "payload": "#startmeeting", "action": false, "timestamp": "2020-11-06T19:00:11+00:00" }, { "id": "c314d49b13c84572b3e16cde03f70e76", "sender": "meshcollider", "payload": "#bitcoin-core-dev Wallet Meeting: wumpus sipa gmaxwell jonasschnelli morcos luke-jr sdaftuar jtimon cfields petertodd kanzure bluematt instagibbs phantomcircuit codeshark michagogo marcofalke paveljanik NicolasDorier jl2012 achow101 meshcollider jnewbery maaku fanquake promag provoostenator aj Chris_Stewart_5 dongcarl gwillen jamesob ken281221 ryanofsky gleb moneyball ariard digi_james amiti fjahr", "action": false, "timestamp": "2020-11-06T19:00:18+00:00" }, { "id": "6174c7779793404eb51f25843f8a47c1", "sender": "meshcollider", "payload": "jeremyrubin emilengler jonatack hebasto jb55 kvaciral ariard digi_james amiti fjahr jeremyrubin lightlike emilengler jonatack hebasto jb55 elichai2", "action": false, "timestamp": "2020-11-06T19:00:18+00:00" }, { "id": "4809f97afba542b5a2f501883bc6bea2", "sender": "meshcollider", "payload": "Topics?", "action": false, "timestamp": "2020-11-06T19:00:28+00:00" }, { "id": "3e2cd7f034364500b77e862c692da278", "sender": "meshcollider", "payload": "I guess we should discuss the PRs left on the milestone", "action": false, "timestamp": "2020-11-06T19:01:23+00:00" }, { "id": "0a40461b151a457aa7c1df8b6d164438", "sender": "achow101", "payload": "are we going to talk about wallet ids for the 5th meeting in a row?", "action": false, "timestamp": "2020-11-06T19:01:43+00:00" }, { "id": "32173a0884af4647a4569b13654e8cc8", "sender": "meshcollider", "payload": "I don't think talking about wallet IDs is going to go anywhere...", "action": false, "timestamp": "2020-11-06T19:02:11+00:00" }, { "id": "2d1214879edc456fafc99bb33cc6391b", "sender": "jonatack", "payload": "hi", "action": false, "timestamp": "2020-11-06T19:02:20+00:00" }, { "id": "0ba3322eb4314ef69c63ab892b311910", "sender": "meshcollider", "payload": "I'm more interested in #20250 and #20305", "action": false, "timestamp": "2020-11-06T19:02:38+00:00" }, { "id": "2458f889ca2243d9a0237dcae3c89b98", "sender": "gribble", "payload": "https://github.com/bitcoin/bitcoin/issues/20250 | Bugfix: RPC/Wallet: Make BTC/kB and sat/B fee modes work sanely by luke-jr \u00c3\u0082\u00c2\u00b7 Pull Request #20250 \u00c3\u0082\u00c2\u00b7 bitcoin/bitcoin \u00c3\u0082\u00c2\u00b7 GitHub", "action": false, "timestamp": "2020-11-06T19:02:40+00:00" }, { "id": "4ea7577d826b4bff99dea1637560c664", "sender": "gribble", "payload": "https://github.com/bitcoin/bitcoin/issues/20305 | wallet: introduce fee_rate_sat_vb param/option by jonatack \u00c3\u0082\u00c2\u00b7 Pull Request #20305 \u00c3\u0082\u00c2\u00b7 bitcoin/bitcoin \u00c3\u0082\u00c2\u00b7 GitHub", "action": false, "timestamp": "2020-11-06T19:02:41+00:00" }, { "id": "560f6e9e6b5c45d2bb049e9ad98bd28e", "sender": "jonatack", "payload": "just pushed an update after re-reviewing and re-testing each commit", "action": false, "timestamp": "2020-11-06T19:03:15+00:00" }, { "id": "ccd96524381d47f59eccfaef5e6c95fd", "sender": "jonatack", "payload": "(to 20305)", "action": false, "timestamp": "2020-11-06T19:03:26+00:00" }, { "id": "8ff6eef67fe7497a9f3f50811234d7f1", "sender": "achow101", "payload": "I will review those eventually", "action": false, "timestamp": "2020-11-06T19:04:36+00:00" }, { "id": "5afabf2603184399b1915bf9f2ad43c1", "sender": "meshcollider", "payload": "I guess the key topic is 1) which of the two (fairly similar) directions do we want to take, and 2) which of the side changes in each PR do we also want in 0.21", "action": false, "timestamp": "2020-11-06T19:05:23+00:00" }, { "id": "b701103393a240728164b0eb66e79092", "sender": "achow101", "payload": "are they mutually exclusive?", "action": false, "timestamp": "2020-11-06T19:06:13+00:00" }, { "id": "c9f78c21297e4b40816aff2b2bcf3385", "sender": "jonatack", "payload": "i think the directions are fundamentally different, apart from the feeRate -> fee_rate alias in 20250 that is orthogonal", "action": false, "timestamp": "2020-11-06T19:06:24+00:00" }, { "id": "8eca110b48e24cfc8d5d63374546f1e6", "sender": "jonatack", "payload": "achow101:: if merged before the release, yes", "action": false, "timestamp": "2020-11-06T19:06:42+00:00" }, { "id": "4b1027c4bf344004b2109bafc7de9e96", "sender": "jonatack", "payload": "achow101:: if merged after, then 20305 doesn't work and would need to be overhauled", "action": false, "timestamp": "2020-11-06T19:07:17+00:00" }, { "id": "e93f42835c7e4a0e8f0229803ef3415e", "sender": "jonatack", "payload": "as it replaces the overloading with the new fixed-unit fee rate param", "action": false, "timestamp": "2020-11-06T19:07:45+00:00" }, { "id": "d9a8fc3e402246868117504a1323a033", "sender": "achow101", "payload": "hmm ok. i'll try to get to them today", "action": false, "timestamp": "2020-11-06T19:07:47+00:00" }, { "id": "edb5a72e3a5c47a1b26369f477e96a42", "sender": "achow101", "payload": "I haven't looked at them yet, so no opinion", "action": false, "timestamp": "2020-11-06T19:07:55+00:00" }, { "id": "fd1510c630a9429296af3771e167f683", "sender": "jonatack", "payload": "and if the overloading is released in 0.21, then we'll have to support it and then deprecate it", "action": false, "timestamp": "2020-11-06T19:08:19+00:00" }, { "id": "8c8c230d2efa4b77b66d19409b605857", "sender": "achow101", "payload": "ngl it feels like we should make an rpc api v2 and just overhaul everything", "action": false, "timestamp": "2020-11-06T19:08:44+00:00" }, { "id": "7a1109f2ab6a49f1a84d1f624626016d", "sender": "jonatack", "payload": "i think it's workable to improve the current one", "action": false, "timestamp": "2020-11-06T19:09:15+00:00" }, { "id": "c2d5d21629044d22a19ca442a866f7a8", "sender": "luke-jr", "payload": "I'm in the middle of rebasing 20250", "action": false, "timestamp": "2020-11-06T19:09:17+00:00" }, { "id": "888ddd5477884709a9a79f8ddedd8a04", "sender": "achow101", "payload": "but maybe i'm just in the \"blow up everything\" mindset", "action": false, "timestamp": "2020-11-06T19:09:17+00:00" }, { "id": "192e842742244a1b8753f995bad918bb", "sender": "jonatack", "payload": "i sort of detail the steps in the PR description", "action": false, "timestamp": "2020-11-06T19:09:34+00:00" }, { "id": "67cadbd09a954b9b958a980526bc2fa2", "sender": "meshcollider", "payload": "achow101: I think both are true ;)", "action": false, "timestamp": "2020-11-06T19:09:37+00:00" }, { "id": "1d8ac13f72e7494abbce97b26c8bca8b", "sender": "jonatack", "payload": "luke-jr: ping me when you're ready and i'll review. even if 20305 is merged, i think the commit that does feeRate -> fee_rate is good", "action": false, "timestamp": "2020-11-06T19:10:24+00:00" }, { "id": "1abe56de935e4d339e93215c3c2fcb87", "sender": "jonatack", "payload": "i didn't do that since i saw that you proposed it", "action": false, "timestamp": "2020-11-06T19:10:38+00:00" }, { "id": "6f23245703784eafa101ca1ffcfabb7d", "sender": "meshcollider", "payload": "I am slightly more in favour of the fixed-unit param, but don't have a big preference", "action": false, "timestamp": "2020-11-06T19:11:02+00:00" }, { "id": "1982ce5a93c54cb7bb7bc1b3cb2a9886", "sender": "meshcollider", "payload": "And yes it's definitely good to have fee_rate consistent", "action": false, "timestamp": "2020-11-06T19:11:27+00:00" }, { "id": "dd6f5e8069584928af5a9bd5167b9229", "sender": "jonatack", "payload": "same, per discussion on in #19543", "action": false, "timestamp": "2020-11-06T19:11:36+00:00" }, { "id": "0c5d2b66fae54b208bbf1c73d4846b2e", "sender": "gribble", "payload": "https://github.com/bitcoin/bitcoin/issues/19543 | Normalize fee units for RPC (\"BTC/kB\" and \"sat/B) \u00c3\u0082\u00c2\u00b7 Issue #19543 \u00c3\u0082\u00c2\u00b7 bitcoin/bitcoin \u00c3\u0082\u00c2\u00b7 GitHub", "action": false, "timestamp": "2020-11-06T19:11:38+00:00" }, { "id": "fd2d0b1d68f446dfabff4052086098a0", "sender": "luke-jr", "payload": "I disliked EXPLICIT ever got split into BTC/kB and sat/B", "action": false, "timestamp": "2020-11-06T19:12:33+00:00" }, { "id": "5d71fae840684b5f9c5928233b8b5f9c", "sender": "jonatack", "payload": "20305 implements the conclusion by wumpus at https://github.com/bitcoin/bitcoin/pull/20220#discussion_r513789526", "action": false, "timestamp": "2020-11-06T19:12:36+00:00" }, { "id": "209aff430b25446499be4e56e14edc54", "sender": "jonatack", "payload": "luke-jr: did you see the twitter poll; people prefer sat/vB over btc/kvB by 10 to 1", "action": false, "timestamp": "2020-11-06T19:13:24+00:00" }, { "id": "9585b656e6984f6a82691687c0ec4617", "sender": "meshcollider", "payload": "Yeah I think sat/vB is definitely the way to go IMO", "action": false, "timestamp": "2020-11-06T19:13:53+00:00" }, { "id": "c3930234ff4445008934afeaa03acd25", "sender": "meshcollider", "payload": "it doesn't seem like there are many others here to discuss so let's just leave it as an #action to review and weigh in on the two alternatives", "action": false, "timestamp": "2020-11-06T19:13:57+00:00" }, { "id": "4441e7552fcb475b9c803860fe498095", "sender": "luke-jr", "payload": "jonatack: I didn't", "action": false, "timestamp": "2020-11-06T19:14:08+00:00" }, { "id": "946f8e5f1761479c91239c703997a260", "sender": "jonatack", "payload": "https://twitter.com/jonatack/status/1318890833131823104?s=20", "action": false, "timestamp": "2020-11-06T19:14:42+00:00" }, { "id": "94957acdce1c4aa7af7d518b9916ee09", "sender": "meshcollider", "payload": "There's a couple of easy wallet PRs left, but the main one on the milestone is #18836", "action": false, "timestamp": "2020-11-06T19:14:55+00:00" }, { "id": "3d36c7e8687444d1887de4c270f7f5de", "sender": "gribble", "payload": "https://github.com/bitcoin/bitcoin/issues/18836 | wallet: upgradewallet fixes and additional tests by achow101 \u00c3\u0082\u00c2\u00b7 Pull Request #18836 \u00c3\u0082\u00c2\u00b7 bitcoin/bitcoin \u00c3\u0082\u00c2\u00b7 GitHub", "action": false, "timestamp": "2020-11-06T19:14:57+00:00" }, { "id": "b15486eed9c54fc9a053ab519255b615", "sender": "meshcollider", "payload": "So please review that", "action": false, "timestamp": "2020-11-06T19:14:59+00:00" }, { "id": "ff7708c7f9a24df590b7fec68e840650", "sender": "luke-jr", "payload": "can we just drop BTC/kB entirely? :x", "action": false, "timestamp": "2020-11-06T19:15:01+00:00" }, { "id": "68a1879c566e4eef977ce554934cafd7", "sender": "jonatack", "payload": "oh, not 10:1, the ratio is much higher", "action": false, "timestamp": "2020-11-06T19:15:09+00:00" }, { "id": "c901fcfedca74fd392365a97d227bb08", "sender": "meshcollider", "payload": "luke-jr: fee_rate_sat_vb does that :p", "action": false, "timestamp": "2020-11-06T19:15:20+00:00" }, { "id": "5ffe054cc5ec41db83e24d1cf932e282", "sender": "jonatack", "payload": "luke-jr: agreed!", "action": false, "timestamp": "2020-11-06T19:15:26+00:00" }, { "id": "88ceb8d2fd4548bdb4a3bc5063bfb0f4", "sender": "achow101", "payload": "I might go through 18836 on stream on Monday. The hard part is figuring out the BDB format", "action": false, "timestamp": "2020-11-06T19:15:54+00:00" }, { "id": "b0e530fb9dfb4855b66fbd66ee9a0c8f", "sender": "luke-jr", "payload": "meshcollider: but with an ugly name", "action": false, "timestamp": "2020-11-06T19:16:09+00:00" }, { "id": "cf1c8b62cdee498398cf74e83d5accd7", "sender": "luke-jr", "payload": "looks like bumpfee is the only thing in 0.20 with \"fee_rate\"", "action": false, "timestamp": "2020-11-06T19:16:24+00:00" }, { "id": "2a6349adc5d44a2daf2b863e6bdf26c7", "sender": "luke-jr", "payload": "hrm", "action": false, "timestamp": "2020-11-06T19:16:27+00:00" }, { "id": "ccddeb3063754e17bd8404003f68caf8", "sender": "jonatack", "payload": "achow101: is 18836 ready for review? if yes, on it tomorrow", "action": false, "timestamp": "2020-11-06T19:16:54+00:00" }, { "id": "0f38769a85a8466cb0d7f2835d0b5019", "sender": "meshcollider", "payload": "jonatack: yes it's been ready for weeks :p", "action": false, "timestamp": "2020-11-06T19:17:08+00:00" }, { "id": "12f4d1d2280543cc9adff811bfd157c0", "sender": "achow101", "payload": "jonatack: yes. it has been for a while", "action": false, "timestamp": "2020-11-06T19:17:10+00:00" }, { "id": "c3a4dcbd334b435ab9e21eca0550ffc7", "sender": "jonatack", "payload": "ok ty", "action": false, "timestamp": "2020-11-06T19:17:20+00:00" }, { "id": "c9be52c45dc046b3b655e67a0c36eeed", "sender": "meshcollider", "payload": "I have been slack personally", "action": false, "timestamp": "2020-11-06T19:17:21+00:00" }, { "id": "ad37eda90c4a445d88fef0795fe19101", "sender": "jonatack", "payload": "luke-jr: yep; i'm thinking we add the ugly named one (at least you won't call it by mistake), then deprecate the btc/kB ones, then alias the ugly one to fee_rate", "action": false, "timestamp": "2020-11-06T19:18:14+00:00" }, { "id": "931395f198574cb1928c828a27354df8", "sender": "jonatack", "payload": "over a couple releases", "action": false, "timestamp": "2020-11-06T19:18:28+00:00" }, { "id": "3cd34583a61341dab561a4057efc946e", "sender": "jonatack", "payload": "maybe with a config option to opt in to the new fee_rate param in sat/vB", "action": false, "timestamp": "2020-11-06T19:18:50+00:00" }, { "id": "9752b9b980e24e3a9d7482bf2e1519cd", "sender": "luke-jr", "payload": "jonatack: that still has a risk", "action": false, "timestamp": "2020-11-06T19:19:27+00:00" }, { "id": "333a64c438784c9394974f76095a7a6b", "sender": "luke-jr", "payload": "the only clean solution I see is to use BTC/kB everywhere", "action": false, "timestamp": "2020-11-06T19:19:44+00:00" }, { "id": "512dcb677ce64b4abe448a48a1a13518", "sender": "luke-jr", "payload": ":/", "action": false, "timestamp": "2020-11-06T19:19:51+00:00" }, { "id": "ec1c5b2417a04afc921878fe9a6f550a", "sender": "jonatack", "payload": "it seems users really want sat/vb", "action": false, "timestamp": "2020-11-06T19:20:08+00:00" }, { "id": "89fb079ccec0445fa093ef6545692399", "sender": "luke-jr", "payload": "well, we've really wanted satoshis for amounts since like 0.3 too", "action": false, "timestamp": "2020-11-06T19:20:21+00:00" }, { "id": "61e9e5013c824f428d8db32d9ad66915", "sender": "jonatack", "payload": "and the risk is a too-low feerate, not a too-high one, and if we put it behind an opt-in config option...", "action": false, "timestamp": "2020-11-06T19:20:38+00:00" }, { "id": "5fce4f5be8084c41a3f53bc1fabbf48f", "sender": "jonatack", "payload": "idk seems manageable", "action": false, "timestamp": "2020-11-06T19:20:59+00:00" }, { "id": "f0725df509484dca87add55cdd16ba3c", "sender": "luke-jr", "payload": "true, and it only affects bumpfee", "action": false, "timestamp": "2020-11-06T19:21:01+00:00" }, { "id": "306db29d32c447cb9a4e028e4c2db9e1", "sender": "luke-jr", "payload": "so too-low is presumably rejected, and if not you can always replace it with the right one", "action": false, "timestamp": "2020-11-06T19:21:16+00:00" }, { "id": "4027675e8e44467b926bfe8ff52aeed7", "sender": "jonatack", "payload": "and fundraw and", "action": false, "timestamp": "2020-11-06T19:21:18+00:00" }, { "id": "30f6ecd33f754b91b9ac6fbc92c103c3", "sender": "luke-jr", "payload": "no, fundraw uses feeRate", "action": false, "timestamp": "2020-11-06T19:21:26+00:00" }, { "id": "2281179234d6426199f4d3c09ae8736e", "sender": "jonatack", "payload": "funded psbt", "action": false, "timestamp": "2020-11-06T19:21:29+00:00" }, { "id": "d4882b014d704d1397cb191f0844d76e", "sender": "jonatack", "payload": "anyway, it's a limited risk", "action": false, "timestamp": "2020-11-06T19:21:42+00:00" }, { "id": "53ccf2083f62420ab7f065eab2e432d5", "sender": "luke-jr", "payload": "only bumpfee uses fee_rate in 0.20 afaict", "action": false, "timestamp": "2020-11-06T19:21:56+00:00" }, { "id": "d4d64ceba5f3438f80a28786db0a88dc", "sender": "luke-jr", "payload": "I'm going to abandon my rebase and close 20250 then, ok?", "action": false, "timestamp": "2020-11-06T19:22:18+00:00" }, { "id": "a998b3ca11664b958d35034b4dbec2fa", "sender": "luke-jr", "payload": "IMO fee_rate_sat_vb should just get renamed to fee_rate", "action": false, "timestamp": "2020-11-06T19:22:39+00:00" }, { "id": "ea04eef7f03547489de00dba56aacbbf", "sender": "jonatack", "payload": "luke-jr: no deprecation process? config option opt-in?", "action": false, "timestamp": "2020-11-06T19:23:26+00:00" }, { "id": "57522e8529bb4b3c9bda2f53b0264b4f", "sender": "luke-jr", "payload": "jonatack: no, not needed considering", "action": false, "timestamp": "2020-11-06T19:23:36+00:00" }, { "id": "f52a6ecab9584a839807bd2e05b0358e", "sender": "luke-jr", "payload": "maybe support -deprecatedrpc=fee_rate or something, but meh", "action": false, "timestamp": "2020-11-06T19:23:54+00:00" }, { "id": "9d7179eb0d344783aea2db7886d2d3a1", "sender": "jonatack", "payload": "i'm ok with remaning if reviewers are", "action": false, "timestamp": "2020-11-06T19:24:12+00:00" }, { "id": "8925f6ac01bd426db05ebf6cb810cab1", "sender": "bitcoin-git", "payload": "[bitcoin] luke-jr closed pull request #20250: Bugfix: RPC/Wallet: Make BTC/kB and sat/B fee modes work sanely (master...rpcwallet_explicit_fixups) https://github.com/bitcoin/bitcoin/pull/20250", "action": false, "timestamp": "2020-11-06T19:24:24+00:00" }, { "id": "32fc3cd7b8c04e8986c0b8af7353bd23", "sender": "meshcollider", "payload": "we should take a bit from 20250 as previously discussed, like the feeRate -> fee_rate though", "action": false, "timestamp": "2020-11-06T19:25:00+00:00" }, { "id": "502ee9fbc02a4e06897b90a94a6ed3db", "sender": "jonatack", "payload": "luke-jr: if 20305 doesn't get in for 0.21 then I think we need 20250, so keep it around", "action": false, "timestamp": "2020-11-06T19:25:15+00:00" }, { "id": "8d0a334c8dcf4030860fbfb0643c5e5c", "sender": "jonatack", "payload": "meshcollider: if we don't rename to fee_rate, agreed", "action": false, "timestamp": "2020-11-06T19:25:26+00:00" }, { "id": "7a09096f875443a5b3a1d4c3b87b0bb0", "sender": "meshcollider", "payload": "I think with the right \"too low\" errors in place, just using fee_rate is fine, but I am not going to speak on behalf of all reviewers :p", "action": false, "timestamp": "2020-11-06T19:26:30+00:00" }, { "id": "0b0b016b82d8463e9abb4d54c2006f82", "sender": "luke-jr", "payload": "meshcollider: that's part of 20305 with my suggestion", "action": false, "timestamp": "2020-11-06T19:26:37+00:00" }, { "id": "2d2bac2813d8428b8f4dfdfa25d70bee", "sender": "luke-jr", "payload": "feeRate would continue to be BTC/kB (deprecated) until we remove it entirely", "action": false, "timestamp": "2020-11-06T19:26:58+00:00" }, { "id": "a330a56977af4519a6ee21bf5f5afcde", "sender": "luke-jr", "payload": "(though I don't really care if we just remove it right now too)", "action": false, "timestamp": "2020-11-06T19:27:14+00:00" }, { "id": "cf48cf6baa7843eba2d4823c1febc75c", "sender": "jonatack", "payload": "ok let me know, i'll be active on updating as time is short", "action": false, "timestamp": "2020-11-06T19:27:42+00:00" }, { "id": "744fa3d4c4cf45e08216a86dc5d07df5", "sender": "meshcollider", "payload": "achow101 can weigh in when he reviews", "action": false, "timestamp": "2020-11-06T19:28:13+00:00" }, { "id": "d65126026239415c80a6e8f040ef9bca", "sender": "meshcollider", "payload": "Alright anything else to discuss today?", "action": false, "timestamp": "2020-11-06T19:28:24+00:00" }, { "id": "660fd69b9ab84cd998f1339e3cb98831", "sender": "jonatack", "payload": "feeRate in walletcreatefundedpsbt and bumpfee iirc", "action": false, "timestamp": "2020-11-06T19:28:24+00:00" }, { "id": "0e86e86f5af840ffad65106d89c788d1", "sender": "meshcollider", "payload": "#endmeeting", "action": false, "timestamp": "2020-11-06T19:30:22+00:00" }, { "id": "fde3c4b2920d4d37b6ba4f1b3eab4d04", "sender": "achow101", "payload": "lightningbot still dead :(", "action": false, "timestamp": "2020-11-06T19:30:35+00:00" }, { "id": "39f4d8f77c9f4b53ad55527694ee117b", "sender": "lightningbot", "payload": "achow101: Error: \"still\" is not a valid command.", "action": false, "timestamp": "2020-11-06T19:30:35+00:00" }, { "id": "1ff6486241e345e48db1f75ef1d1d488", "sender": "jonatack", "payload": "meshcollider: congrats on the john pfeffer support! (just seeing it now) \u00c3\u00b0\u00c2\u009f\u00c2\u008e\u00c2\u0089", "action": false, "timestamp": "2020-11-06T19:31:28+00:00" }, { "id": "f6eca19e1f90476ea5f1a51c10fc84d4", "sender": "luke-jr", "payload": "aj", "action": false, "timestamp": "2020-11-06T19:31:51+00:00" }, { "id": "412a0d45f8914656a1e3ff7a4f072486", "sender": "meshcollider", "payload": "jonatack: yeah it's super nice of him!", "action": false, "timestamp": "2020-11-06T19:35:08+00:00" }, { "id": "5c0ecdfe88cc4c02bc3a82cfc9de184b", "sender": "meshcollider", "payload": "achow101: lol the bot doesn't like being called dead", "action": false, "timestamp": "2020-11-06T19:35:25+00:00" }, { "id": "74afa09907f64d46b020381ca5a7d7eb", "sender": "meshcollider", "payload": "Unlike usual, when I started the meeting today, I got an automatic list of commands send to me by core-meetingbot", "action": false, "timestamp": "2020-11-06T19:36:22+00:00" }, { "id": "19024134f53649ee9b045f0ce9536482", "sender": "meshcollider", "payload": "Maybe that's a WIP", "action": false, "timestamp": "2020-11-06T19:36:29+00:00" }, { "id": "4a6764289d1e4846858eb42a030b7b74", "sender": "achow101", "payload": "ooh", "action": false, "timestamp": "2020-11-06T19:36:39+00:00" }, { "id": "db6f72c67f08447a975e0f6eeab3c4f5", "sender": "achow101", "payload": "maybe we can delegate the pinging to the bot too", "action": false, "timestamp": "2020-11-06T19:37:00+00:00" }, { "id": "e10c8d0b575f4e699af6d76185890b97", "sender": "meshcollider", "payload": "That would be super handy", "action": false, "timestamp": "2020-11-06T19:40:11+00:00" }, { "id": "c063a90361684e0aaac81c449fed360b", "sender": "jonatack", "payload": "meshcollider: with you and luke-jr voting for fee_rate_sat_vb -> fee_rate, LMK if I should start updating. Meanwhile, queuing up and building 18836", "action": false, "timestamp": "2020-11-06T19:40:14+00:00" }, { "id": "b38c81b868ac46048c8aee72d63f08af", "sender": "meshcollider", "payload": "achow101: what do you think ^", "action": false, "timestamp": "2020-11-06T19:40:38+00:00" }, { "id": "e6ee1c951b85419bae7f4bdb0a90ded7", "sender": "meshcollider", "payload": "kallewoof might also like to weigh in?", "action": false, "timestamp": "2020-11-06T19:40:51+00:00" }, { "id": "7b7ebb4c57f04b969741c74fa32e4f56", "sender": "jonasschnelli", "payload": "the wallet meeting was logged by my just created meetingbot (core-meetingbot) https://bitcoin.jonasschnelli.ch/ircmeetings/logs/bitcoin-core-dev/2020/bitcoin-core-dev.2020-11-06-19.00.moin.txt", "action": false, "timestamp": "2020-11-06T20:59:29+00:00" }, { "id": "5f5c60e193ad4d52b885c6e29b86fe96", "sender": "jonasschnelli", "payload": "probably lightningbot are also recoding the meetings...", "action": false, "timestamp": "2020-11-06T20:59:47+00:00" }, { "id": "3163f93f0ff545c3ac057094f16b0368", "sender": "jonasschnelli", "payload": "I guess those bots just have no right to post in this channel", "action": false, "timestamp": "2020-11-06T21:01:57+00:00" }, { "id": "eb5e7b66ba034dbfa656b8f487b02bb6", "sender": "jonasschnelli", "payload": "Indeed. Lightning bot also recorded the last meeting: http://www.erisian.com.au/meetbot/bitcoin-core-dev/2020/bitcoin-core-dev.2020-11-05-19.00.log.txt (the one from yesterday).", "action": false, "timestamp": "2020-11-06T21:04:04+00:00" }, { "id": "19bcfe1d807a4094933130f026f47184", "sender": "luke-jr", "payload": "weird", "action": false, "timestamp": "2020-11-06T21:04:37+00:00" }, { "id": "5585f4ea3e524670837bade703b913a0", "sender": "jonasschnelli", "payload": "I tested the meetingbot (core-meetingbot) in ##bitcoin-core-gui and it works there...", "action": false, "timestamp": "2020-11-06T21:05:03+00:00" }, { "id": "ef161d7ed15748bca5aa7c162e88dfc9", "sender": "jonasschnelli", "payload": "so maybe its the channel mode or so or some sort of bot protection.", "action": false, "timestamp": "2020-11-06T21:05:18+00:00" }, { "id": "053cb8dd73bc4b73812173643a893a35", "sender": "achow101", "payload": "jonasschnelli: but lightning bot responded to pings", "action": false, "timestamp": "2020-11-06T21:32:29+00:00" }, { "id": "5b7d51e4f54349ed984c9a4f80ec4be3", "sender": "achow101", "payload": "lightningbot: ping", "action": false, "timestamp": "2020-11-06T21:32:44+00:00" }, { "id": "d64236c78f2a4d5188738de5bf5815b4", "sender": "lightningbot", "payload": "pong", "action": false, "timestamp": "2020-11-06T21:32:44+00:00" }, { "id": "c80f92c85b9d4ebf9de0690c38a9dfc2", "sender": "luke-jr", "payload": "jonasschnelli: why is the gui channel invite-only?", "action": false, "timestamp": "2020-11-07T00:45:42+00:00" }, { "id": "45fca85275f54bf7a353778445f60fe7", "sender": "bitcoin-git", "payload": "[bitcoin] LarryRuane opened pull request #20331: allow -loadblock blocks to be unsorted (master...loadblock-unsorted) https://github.com/bitcoin/bitcoin/pull/20331", "action": false, "timestamp": "2020-11-07T05:24:26+00:00" }, { "id": "cb5e21c94adc4c2eba652bd80d202231", "sender": "jonasschnelli", "payload": "Luke-jr: it should no longer be invite only", "action": false, "timestamp": "2020-11-07T06:12:11+00:00" }, { "id": "4c1436aee0f64c1098061e14efb1772b", "sender": "jonasschnelli", "payload": "achow101: yeah. Wired. Maybe the startmeeting and endmeeting messages are suppressed by the channel/freenode? Some anti spam thing maybe.", "action": false, "timestamp": "2020-11-07T06:13:23+00:00" }, { "id": "d22c76f678454c23a3c97c9745573db2", "sender": "bitcoin-git", "payload": "[bitcoin] MarcoFalke opened pull request #20332: test: Mock IBD in net_processing fuzzers (master...2011-fuzzNet) https://github.com/bitcoin/bitcoin/pull/20332", "action": false, "timestamp": "2020-11-07T06:56:32+00:00" }, { "id": "79c9b980438140a086adb588a06f511f", "sender": "bitcoin-git", "payload": "[bitcoin] promag closed pull request #19917: Yet another change to reduce recursive mempool locking (master...2020-09-removeunbroadcasttx) https://github.com/bitcoin/bitcoin/pull/19917", "action": false, "timestamp": "2020-11-07T11:47:17+00:00" }, { "id": "f6b2c7597b994b95aafb18029f1bb5e8", "sender": "bitcoin-git", "payload": "[bitcoin] fanquake opened pull request #20333: build: remove native_biplist dependency (master...no_more_biplist) https://github.com/bitcoin/bitcoin/pull/20333", "action": false, "timestamp": "2020-11-07T13:12:18+00:00" }, { "id": "7034d805a1fb4724805ff51bf71cc8df", "sender": "jonasschnelli", "payload": "core-meetingbot ping", "action": false, "timestamp": "2020-11-07T14:24:24+00:00" }, { "id": "56e0be53556a414abb9c9772b9a58514", "sender": "jonasschnelli", "payload": "lightningbot ping", "action": false, "timestamp": "2020-11-07T14:25:00+00:00" }, { "id": "0a4ba649cf474a87b1510b09c67cfae1", "sender": "lightningbot", "payload": "pong", "action": false, "timestamp": "2020-11-07T14:25:00+00:00" }, { "id": "f345f523ae13435498002a4f6c9c1c34", "sender": "sipa", "payload": "d/query gwillen", "action": false, "timestamp": "2020-11-08T05:35:29+00:00" }, { "id": "48e7ea7529184459bb5478154a79e739", "sender": "sipa", "payload": "oops", "action": false, "timestamp": "2020-11-08T05:35:33+00:00" }, { "id": "e502a5c69017423483eb03590ce906e2", "sender": "bitcoin-git", "payload": "[bitcoin] fanquake opened pull request #20336: build: automatically determine macOS base translations (master...auto_find_translations) https://github.com/bitcoin/bitcoin/pull/20336", "action": false, "timestamp": "2020-11-08T07:22:54+00:00" }, { "id": "73474ee8ae1d4601b590bce0363b9390", "sender": "bitcoin-git", "payload": "[bitcoin] MarcoFalke opened pull request #20339: ci: Run macos ci config on cirrus (master...2011-moreCirrus) https://github.com/bitcoin/bitcoin/pull/20339", "action": false, "timestamp": "2020-11-08T12:15:43+00:00" }, { "id": "3987bbcb7c06402999c501aa803c5748", "sender": "bitcoin-git", "payload": "[bitcoin] fanliao1989 opened pull request #20343: Update README.md (master...master) https://github.com/bitcoin/bitcoin/pull/20343", "action": false, "timestamp": "2020-11-08T18:17:29+00:00" }, { "id": "3ec63f12875e49d1ad2d713ba1860430", "sender": "bitcoin-git", "payload": "[bitcoin] MarcoFalke closed pull request #20343: Update README.md (master...master) https://github.com/bitcoin/bitcoin/pull/20343", "action": false, "timestamp": "2020-11-08T18:33:00+00:00" }, { "id": "660e968d9da34511b29a8c6b859fe154", "sender": "bitcoin-git", "payload": "[bitcoin] theStack opened pull request #20344: wallet: fix scanning progress calculation for single block range (master...20201108-wallet-avoid_div_by_zero_on_single_block_rescan) https://github.com/bitcoin/bitcoin/pull/20344", "action": false, "timestamp": "2020-11-08T19:00:06+00:00" }, { "id": "3c92135faf38498ea946800dc204f03e", "sender": "bitcoin-git", "payload": "[bitcoin] SatoshiBitcoin opened pull request #20345: Update README.md (master...Version1) https://github.com/bitcoin/bitcoin/pull/20345", "action": false, "timestamp": "2020-11-08T19:58:28+00:00" }, { "id": "9b955c5b02fb4940a73e6c1870d363f9", "sender": "bitcoin-git", "payload": "[bitcoin] SatoshiBitcoin closed pull request #20345: Update README.md (master...Version1) https://github.com/bitcoin/bitcoin/pull/20345", "action": false, "timestamp": "2020-11-08T19:59:18+00:00" }, { "id": "c9db2850396f489aa80f39ce7ce32787", "sender": "andytoshi", "payload": "achow101: i think there is a bug in CreateTransaction related to bnb .. can you sanity check me before i file a bug", "action": false, "timestamp": "2020-11-08T20:21:22+00:00" }, { "id": "fb824e70225f43048cf895ef8d1bf0e4", "sender": "achow101", "payload": "andytoshi: what's the bug?", "action": false, "timestamp": "2020-11-08T20:21:51+00:00" }, { "id": "ecc43c3a931c4c6583cc6d2573d49fd8", "sender": "andytoshi", "payload": "one sec, typing", "action": false, "timestamp": "2020-11-08T20:21:56+00:00" }, { "id": "1fc2285db95548bba532aa00db9f6eff", "sender": "andytoshi", "payload": "the problem is that when we create txNew for the purpose of getting a tx size to estimate the fee required, in this line https://github.com/bitcoin/bitcoin/blob/master/src/wallet/wallet.cpp#L2940 we selectively add a change output based on whether bnb was used by SelectCoins", "action": false, "timestamp": "2020-11-08T20:22:19+00:00" }, { "id": "b4f338fe40dd4ce59f1ab00b234cf652", "sender": "andytoshi", "payload": "so far so good", "action": false, "timestamp": "2020-11-08T20:22:25+00:00" }, { "id": "f02350ade1414b41a67c3c1f8a4e1f01", "sender": "andytoshi", "payload": "but .. if we use bnb, but we don't get enough fees, and we have subtractfeefromeamount on, we hit this line https://github.com/bitcoin/bitcoin/blob/master/src/wallet/wallet.cpp#L3038", "action": false, "timestamp": "2020-11-08T20:23:07+00:00" }, { "id": "61ecd8026bbd4ea798236bfae17e2085", "sender": "andytoshi", "payload": "which says \"SelectCoins succeeded, we didn't hit the fee we needed, but that's fine, we can increase the fee by subtracting from outputs. turn off pick_new_inputs and loop again\"", "action": false, "timestamp": "2020-11-08T20:23:52+00:00" }, { "id": "98bab318f57f416caeebc867569cabc0", "sender": "andytoshi", "payload": "but then, when we do the next loop iteration, we skip SelectCoins and just set bnb_used to false https://github.com/bitcoin/bitcoin/blob/master/src/wallet/wallet.cpp#L2928", "action": false, "timestamp": "2020-11-08T20:24:22+00:00" }, { "id": "cd5bf167dd9247e8bfb7504253e2ae0d", "sender": "andytoshi", "payload": "which means that when we recalculate nFeeRequired, we'll get a higher number than we did before. we set nFeeRet to nFeeRequired at the end of the previous iteration. so now this check will fail https://github.com/bitcoin/bitcoin/blob/master/src/wallet/wallet.cpp#L2984", "action": false, "timestamp": "2020-11-08T20:25:23+00:00" }, { "id": "522e8311f38d4bb696814c161442fcfc", "sender": "andytoshi", "payload": "..and the whole loop will fail, because we say \"well, we didn't hit our fee target, and pick_new_inputs was off, so we must be screwed\"", "action": false, "timestamp": "2020-11-08T20:25:50+00:00" }, { "id": "90ff9ebb468340b485e3e577bbc01916", "sender": "andytoshi", "payload": "but actually the problem is just that we didn't compute nFeeRequired consistently from one iteration to the next", "action": false, "timestamp": "2020-11-08T20:26:15+00:00" }, { "id": "e7afb137d9a0467290296e003d23b6a8", "sender": "andytoshi", "payload": "(end of description)", "action": false, "timestamp": "2020-11-08T20:26:22+00:00" }, { "id": "c68ac1727b9c4256ae35f38a10e3be26", "sender": "achow101", "payload": "how is bnb used but not enough fees?", "action": false, "timestamp": "2020-11-08T20:26:23+00:00" }, { "id": "64a8220d5d3e49c28867108e93235aae", "sender": "luke-jr", "payload": "ARGH, google has decided \"dnsseed.bitcoin.dashjr.org\" has deceptive content is now blacklisting all of dashjr.org -.-", "action": false, "timestamp": "2020-11-08T20:26:41+00:00" }, { "id": "bfddc26f64bc40d388c339257793f641", "sender": "achow101", "payload": "with subtractfeefromamount, unless the amount is less than the fees?", "action": false, "timestamp": "2020-11-08T20:26:57+00:00" }, { "id": "9d461fac237044c1a482113eddb87c7f", "sender": "andytoshi", "payload": "lemme take a look", "action": false, "timestamp": "2020-11-08T20:27:09+00:00" }, { "id": "04d1dbcbd4324d74a7048f732e2b9728", "sender": "luke-jr", "payload": "sipa: bluematt: cdecker: jonasschnelli: petertodd: sjors: emzy: this will probably hit you soon too", "action": false, "timestamp": "2020-11-08T20:27:59+00:00" }, { "id": "d25144cffb3d47188b1546ef686b5d7b", "sender": "jonatack", "payload": "luke-jr: confirmed", "action": false, "timestamp": "2020-11-08T20:31:06+00:00" }, { "id": "0240f25b9f9c4d0288e1a5f2caed9183", "sender": "jonatack", "payload": "\"Deceptive site ahead. Firefox blocked this page because it may trick you into doing something dangerous like installing software or revealing personal information like passwords or credit cards. Advisory provided by Google Safe Browsing.\"", "action": false, "timestamp": "2020-11-08T20:31:26+00:00" }, { "id": "996928362115406fb79e74140a8f2211", "sender": "emzy", "payload": "luke-jr: benause of the dnsseed. It has nothing to do with http...", "action": false, "timestamp": "2020-11-08T20:31:30+00:00" }, { "id": "8da2f03ed82346a1993f67342afe3609", "sender": "emzy", "payload": "https://dashjr.org/ works vor me in Firefox.", "action": false, "timestamp": "2020-11-08T20:32:24+00:00" }, { "id": "8f10bb716ead478ba2099aa9c3105ac7", "sender": "jonatack", "payload": "dnsseed.bitcoin.dashjr.org has been reported as a deceptive site. You can report a detection problem -> I filed an report", "action": false, "timestamp": "2020-11-08T20:33:08+00:00" }, { "id": "83ca52423b7e4c09ae607a0a8e642925", "sender": "achow101", "payload": "andytoshi: regardless, i'm trying to get at least the effective value pr for the next release so there won't be any such bug as the loop is removed", "action": false, "timestamp": "2020-11-08T20:33:25+00:00" }, { "id": "ecc54d5a9c72487c94baef78d18ad6fd", "sender": "emzy", "payload": "luke-jr: you are sure that they will blacklist all of dashjr.org? I think the http(s) blacklist of dnsseed.bitcoin.dashjr.org is right.", "action": false, "timestamp": "2020-11-08T20:36:14+00:00" }, { "id": "ccfc76a435f143a9af1f32c478bca12a", "sender": "achow101", "payload": "luke-jr: is the warning part of chrome or is it some dns thing?", "action": false, "timestamp": "2020-11-08T20:36:24+00:00" }, { "id": "54478e996b73437786edfcc3422120d8", "sender": "achow101", "payload": "or something else?", "action": false, "timestamp": "2020-11-08T20:36:34+00:00" }, { "id": "c6ea10fe406c414a86f57d79cea9adad", "sender": "jonasschnelli", "payload": "My DNS seed runs no http site (I guess).", "action": false, "timestamp": "2020-11-08T20:37:01+00:00" }, { "id": "90987ba561924ad68b647aaaf7619776", "sender": "andytoshi", "payload": "achow101: cool, thanks", "action": false, "timestamp": "2020-11-08T20:37:01+00:00" }, { "id": "c5935903598d4058a6c4e5856e0fda8e", "sender": "jonasschnelli", "payload": "Or does it even matter what runs on the seed machine?", "action": false, "timestamp": "2020-11-08T20:37:14+00:00" }, { "id": "c42e5308bf874fdeb63883d26c03ce72", "sender": "andytoshi", "payload": "though there's maybe an 80% chance this is actually some elements weirdness related to how we account for change in coin selection", "action": false, "timestamp": "2020-11-08T20:37:49+00:00" }, { "id": "8fd16323601e4fa7b74fb5505be17d76", "sender": "emzy", "payload": "jonasschnelli: the A records you deliver are not your IP addresses anyways.", "action": false, "timestamp": "2020-11-08T20:38:27+00:00" }, { "id": "a958ff9b9cd942138f6fde9acfea3748", "sender": "emzy", "payload": "As long as only the whole domain is blacklisted for browsing it is totaly fine.", "action": false, "timestamp": "2020-11-08T20:40:22+00:00" }, { "id": "1fe05e1d8cc14354b383e1aef885a731", "sender": "emzy", "payload": "I would argue it is right to do it. Because it could lead to a malicious site.", "action": false, "timestamp": "2020-11-08T20:42:01+00:00" }, { "id": "cda8f8bfdfdb4a3a97b620c01690347a", "sender": "andytoshi", "payload": "achow101: oh i think my issue may have been resolved in https://github.com/bitcoin/bitcoin/pull/17458", "action": false, "timestamp": "2020-11-08T20:45:19+00:00" }, { "id": "d41929940d8b470b89a140e952a8dae0", "sender": "andytoshi", "payload": "certainly the logic before that PR is way harder to understand", "action": false, "timestamp": "2020-11-08T20:45:33+00:00" }, { "id": "f93fafc6a3cf4b039b2016008f35908d", "sender": "luke-jr", "payload": "jonatack: well, the dnsseed domain probably should get flagged - the problem is they're extending it to my entire domain :/", "action": false, "timestamp": "2020-11-08T20:46:52+00:00" }, { "id": "53f794cb20474b158ff85de4cfd91ba8", "sender": "luke-jr", "payload": "achow101: I assume it's part of Google's existing censorship framework", "action": false, "timestamp": "2020-11-08T20:47:11+00:00" }, { "id": "4984dbe4e56240e4a8b32ec26cc28cdb", "sender": "luke-jr", "payload": "jonasschnelli: it points at random IPs, which may be running malicious webservers..", "action": false, "timestamp": "2020-11-08T20:47:38+00:00" }, { "id": "b41a0a2ea7f64174af7b14a026dfd8b9", "sender": "jonasschnelli", "payload": "Yes. That. But it has always been that way.", "action": false, "timestamp": "2020-11-08T20:59:08+00:00" }, { "id": "dfc772c566684d77b5da9813b833b43b", "sender": "andytoshi", "payload": "achow101: i think i'm right, this is a core thing not an elements thing ... https://github.com/bitcoin/bitcoin/blob/7e373294a5ae819099c39d9d03d1f5a311d63cfc/src/wallet/wallet.cpp#L3016-L3019 this comment says \"nFeeNeeded should not have changed\"", "action": false, "timestamp": "2020-11-08T21:37:11+00:00" }, { "id": "8bd55e724fbd4eaaaec47fcdbdef1e47", "sender": "andytoshi", "payload": "20:26 < achow101> how is bnb used but not enough fees?", "action": false, "timestamp": "2020-11-08T21:37:20+00:00" }, { "id": "0e155c5342f0458581cef14e32b35715", "sender": "andytoshi", "payload": "what's happening here is that bnb is used and it gives us -some- fees, but if we're subtracting fees from outputs it doesn't bother trying to give us enough", "action": false, "timestamp": "2020-11-08T21:37:44+00:00" }, { "id": "ab776231bca7499e8c1276000ebf593b", "sender": "achow101", "payload": "I suppose bnb assumes that the output is enough to cover the fees", "action": false, "timestamp": "2020-11-08T21:38:10+00:00" }, { "id": "f6f6d06bcd8146088b0bbfb336a60775", "sender": "achow101", "payload": "but that may not be the case", "action": false, "timestamp": "2020-11-08T21:38:17+00:00" }, { "id": "4bbcff72189941f7a9d5ff887da9cddd", "sender": "andytoshi", "payload": "the logic is that we'll fail the nFeesRet >= nFeesNeeded check, but then we'll go around the loop again", "action": false, "timestamp": "2020-11-08T21:38:18+00:00" }, { "id": "056d556cb10a40e28caef84889f9324b", "sender": "andytoshi", "payload": "it is the case", "action": false, "timestamp": "2020-11-08T21:38:22+00:00" }, { "id": "de7bbd97fca54bcf8dbe170ff9aed33f", "sender": "andytoshi", "payload": "but the code is still wrong", "action": false, "timestamp": "2020-11-08T21:38:27+00:00" }, { "id": "44f05081a4f34dca993f0f9214c79f26", "sender": "andytoshi", "payload": "in my code the output is more than enough to cover the fees, the problem is that we don't subtract enough (or rather, we subtract enough but then incorrectly think we should've subtracted more)", "action": false, "timestamp": "2020-11-08T21:39:13+00:00" }, { "id": "be8e324198854814abc3828e7666472a", "sender": "achow101", "payload": "do you have a particular test case I can try?", "action": false, "timestamp": "2020-11-08T21:39:17+00:00" }, { "id": "9471a7ff2b3147519db2dfc8d5209f17", "sender": "andytoshi", "payload": "sorta, i can give you an elements functional test from before #17458", "action": false, "timestamp": "2020-11-08T21:39:51+00:00" }, { "id": "a6a14ac1bc5a4ccf89ce1b5d01025958", "sender": "gribble", "payload": "https://github.com/bitcoin/bitcoin/issues/17458 | Refactor OutputGroup effective value calculations and filtering to occur within the struct by achow101 \u00c3\u0082\u00c2\u00b7 Pull Request #17458 \u00c3\u0082\u00c2\u00b7 bitcoin/bitcoin \u00c3\u0082\u00c2\u00b7 GitHub", "action": false, "timestamp": "2020-11-08T21:39:54+00:00" }, { "id": "bf8de12f5b7141b5a770fd2343c23e3e", "sender": "andytoshi", "payload": "let me try to extract a bitcoin example", "action": false, "timestamp": "2020-11-08T21:39:59+00:00" }, { "id": "73187f633431432fb54ada2167984ecf", "sender": "andytoshi", "payload": "because i'm pretty confident that the issue has nothingh to do with elements", "action": false, "timestamp": "2020-11-08T21:40:12+00:00" }, { "id": "158259cdf3a84b068527bd27c065a41b", "sender": "achow101", "payload": "Are you hitting the \"Transaction fee and change calculation failed\" error?", "action": false, "timestamp": "2020-11-08T21:42:14+00:00" }, { "id": "89cf3e9f66f940d3b3dceac77b1de72b", "sender": "andytoshi", "payload": "yep", "action": false, "timestamp": "2020-11-08T21:42:37+00:00" }, { "id": "69626c0437874af0a7723672f949a079", "sender": "bitcoin-git", "payload": "[bitcoin] tylerchambers opened pull request #20346: script: modify security-check.py to use \"==\" instead of \"is\" for literal comparison (master...literal-comparison-update) https://github.com/bitcoin/bitcoin/pull/20346", "action": false, "timestamp": "2020-11-08T21:43:01+00:00" }, { "id": "08a778ebf61d45739e1733011e4f9c47", "sender": "andytoshi", "payload": "i think, if you have a wallet where bnb can solve exactly (say you have two 10btc inputs and want a 20btc output) and you put subtractfeesfromoutput on, you'll trigger this", "action": false, "timestamp": "2020-11-08T21:43:37+00:00" }, { "id": "1e5f2a4def564b9c888ed2d4e53afe65", "sender": "achow101", "payload": "andytoshi: just tried, and nope", "action": false, "timestamp": "2020-11-08T21:51:50+00:00" }, { "id": "78a0248eb23a4c878aac1dea50fa84cb", "sender": "andytoshi", "payload": "hmmmm, i don't understand. i'll have to run it myself with a pile of logging added", "action": false, "timestamp": "2020-11-08T21:54:05+00:00" }, { "id": "720ac20699d549a4ab114df4c9dc04eb", "sender": "andytoshi", "payload": "can you push a diff somewhere to add a test case?", "action": false, "timestamp": "2020-11-08T21:55:28+00:00" }, { "id": "3394576683514c2492b04ae5a43f45dd", "sender": "andytoshi", "payload": "since you have one", "action": false, "timestamp": "2020-11-08T21:55:36+00:00" }, { "id": "9273d44958fa41c2ac47a4bc3998ddb0", "sender": "andytoshi", "payload": "can i get log output from unit tests?", "action": false, "timestamp": "2020-11-08T22:01:26+00:00" }, { "id": "319077b70161485a8d286b827db0c8b8", "sender": "achow101", "payload": "unit tests make a dir in /tmp that should have logs", "action": false, "timestamp": "2020-11-08T22:01:59+00:00" }, { "id": "c0f504e517034ec489b1d0c8d341ddc2", "sender": "achow101", "payload": "andytoshi: https://github.com/achow101/bitcoin/commit/2c08a27ea062e4247b3f53bcd296429a4ca9b4a3", "action": false, "timestamp": "2020-11-08T22:20:40+00:00" }, { "id": "52e6decf2a25401db7f8ead7b319f2b1", "sender": "andytoshi", "payload": "thanks!", "action": false, "timestamp": "2020-11-08T22:29:17+00:00" }, { "id": "80095b9aac9646258e1cfe8dda9a883f", "sender": "andytoshi", "payload": "i almost have a unit test, i am just trying to set a non-zero feerate without segfaulting..", "action": false, "timestamp": "2020-11-08T22:29:43+00:00" }, { "id": "03615b794a9f41e99f73a91f08821162", "sender": "andytoshi", "payload": "achow101: https://github.com/bitcoin/bitcoin/issues/20347 i'm not crazy :P", "action": false, "timestamp": "2020-11-09T00:49:21+00:00" }, { "id": "588e2573466048898e95d41b58cd7f75", "sender": "andytoshi", "payload": "lol what a waste of a sunday", "action": false, "timestamp": "2020-11-09T00:49:24+00:00" }, { "id": "678239d92006462ea055e9284a16b690", "sender": "sipa", "payload": "sounds like a very useful sunday", "action": false, "timestamp": "2020-11-09T00:50:10+00:00" }, { "id": "aaa02b4685e54fa8bf2e3a04a15f4909", "sender": "andytoshi", "payload": "hehe, i did actually learn a lot about core", "action": false, "timestamp": "2020-11-09T00:53:07+00:00" }, { "id": "3c22af9a458f42d4a86b254e2e3434f6", "sender": "achow101", "payload": "I think you've run into why everyone is afraid of changing coin selection. the logic is too hard to follow", "action": false, "timestamp": "2020-11-09T01:02:16+00:00" }, { "id": "3b86041d8f4848e38cd12a17c07ab63d", "sender": "sipa", "payload": "it's probably a good reason to justify changes", "action": false, "timestamp": "2020-11-09T01:03:06+00:00" }, { "id": "20d942c947ed42038c8212fe5b0802bc", "sender": "sipa", "payload": "the existing logic is a painful mess, but at least my impression was that it was very unlikely to actually fuck up", "action": false, "timestamp": "2020-11-09T01:03:36+00:00" }, { "id": "96d83c7a0eb34784a25508fbbbc9dba6", "sender": "andytoshi", "payload": "i mean, this is a real corner case, achow and i weren't sure if we could make it trigger without simulating weird fee behavior, and even then", "action": false, "timestamp": "2020-11-09T01:04:59+00:00" }, { "id": "9cfe9c732b23435a9b2ca752c3244fab", "sender": "andytoshi", "payload": "what's surprising is that it is a \"coin selection\" bug which is entirely outside of SelectCoins, it's the retry-loop in CreateTransaction", "action": false, "timestamp": "2020-11-09T01:05:49+00:00" }, { "id": "8049a2593a14408a9591609b7969663f", "sender": "achow101", "payload": "unfortunately CreateTransaction is considered part of coin selection behavior because of the loop", "action": false, "timestamp": "2020-11-09T01:06:13+00:00" }, { "id": "8afbde8777fd49c58e2d411f1ccd6bb1", "sender": "fanquake", "payload": "wumpus / sipa: may just want to block kengendron251", "action": false, "timestamp": "2020-11-09T05:33:47+00:00" }, { "id": "88af2e1f3bba41aeaa8e2ce07f1e88fd", "sender": "sipa", "payload": "fanquake: going to wait", "action": false, "timestamp": "2020-11-09T05:42:08+00:00" }, { "id": "cbf5ff8fb6e54a1889d4e83c2cbcccfe", "sender": "sipa", "payload": "his last message made it sound like a mistake", "action": false, "timestamp": "2020-11-09T05:42:19+00:00" }, { "id": "860ee37d54af425eb2317ddfef0a1287", "sender": "wumpus", "payload": "what did they do? looking at the profile it's either a spammer or a 12 year old :)", "action": false, "timestamp": "2020-11-09T08:16:36+00:00" }, { "id": "dd480198dc074f91802bb0e0e3eb0b76", "sender": "fanquake", "payload": "Posted a bit of spammy crap, but now it also seems like they've managed to subscribe to the repo, and can't figure out how to unsubscribe.", "action": false, "timestamp": "2020-11-09T08:17:58+00:00" }, { "id": "f2605b7ecac94a6b8fe98ab02c10a996", "sender": "aj", "payload": "deleted comment from 20317 says \"I was on this planet well before the computer\" so rules out the 12yo theory? :)", "action": false, "timestamp": "2020-11-09T08:18:59+00:00" }, { "id": "51e672cbcec3433f9c8091884b1f4e42", "sender": "bitcoin-git", "payload": "[bitcoin] ajtowns opened pull request #20353: configure: Support -fdebug-prefix-map (master...202011-ccache-debug-prefix) https://github.com/bitcoin/bitcoin/pull/20353", "action": false, "timestamp": "2020-11-09T08:25:35+00:00" }, { "id": "a049c7eb73064d58a563cb2e4e281b2f", "sender": "bitcoin-git", "payload": "[bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/7e373294a5ae...f70eb51b05de", "action": false, "timestamp": "2020-11-09T14:07:07+00:00" }, { "id": "270010ff3460457191ce4b69f8e93705", "sender": "bitcoin-git", "payload": "bitcoin/master faa2f06 MarcoFalke: scripted-diff: [build] Ensure source tarball has leading directory name", "action": false, "timestamp": "2020-11-09T14:07:07+00:00" }, { "id": "8530e15354c14e8da598c70d5c5249db", "sender": "bitcoin-git", "payload": "bitcoin/master f70eb51 Wladimir J. van der Laan: Merge #20318: build: Ensure source tarball has leading directory name", "action": false, "timestamp": "2020-11-09T14:07:08+00:00" }, { "id": "4db509236c3e42bdaedd64e7bf6c977e", "sender": "bitcoin-git", "payload": "[bitcoin] laanwj merged pull request #20318: build: Ensure source tarball has leading directory name (master...2011-buildTar) https://github.com/bitcoin/bitcoin/pull/20318", "action": false, "timestamp": "2020-11-09T14:07:36+00:00" }, { "id": "2cba7d1edcaa4aef906187bf0268c7a0", "sender": "bitcoin-git", "payload": "[bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/f70eb51b05de...663fd92b28c3", "action": false, "timestamp": "2020-11-09T14:15:26+00:00" }, { "id": "fae081cfd1f04119bc7d6cce68834f71", "sender": "bitcoin-git", "payload": "bitcoin/master bd93fc9 Andrew Chow: Fix change detection of imported internal descriptors", "action": false, "timestamp": "2020-11-09T14:15:26+00:00" }, { "id": "20d91bfaddfa409388044834b185335d", "sender": "bitcoin-git", "payload": "bitcoin/master 663fd92 Wladimir J. van der Laan: Merge #20266: wallet: fix change detection of imported internal descriptor...", "action": false, "timestamp": "2020-11-09T14:15:27+00:00" }, { "id": "ed8b53e4a0f84bdeb38310d9f303d13e", "sender": "bitcoin-git", "payload": "[bitcoin] laanwj merged pull request #20266: wallet: fix change detection of imported internal descriptors (master...fix-desc-change) https://github.com/bitcoin/bitcoin/pull/20266", "action": false, "timestamp": "2020-11-09T14:15:46+00:00" }, { "id": "713d7425bdd4427284650a008a266c74", "sender": "bitcoin-git", "payload": "[bitcoin] MarcoFalke pushed 6 commits to master: https://github.com/bitcoin/bitcoin/compare/663fd92b28c3...05aeeee34f15", "action": false, "timestamp": "2020-11-09T14:33:29+00:00" }, { "id": "0b9213cb47f84ebbbd7b30726ffc0b49", "sender": "bitcoin-git", "payload": "bitcoin/master fafce1a MarcoFalke: ci: Move documentation to correct config file", "action": false, "timestamp": "2020-11-09T14:33:29+00:00" }, { "id": "e05d85d6e92f458d8f159f804c6cc89e", "sender": "bitcoin-git", "payload": "bitcoin/master fa0795f MarcoFalke: ci: Replace TRAVIS_OS_NAME with CI_OS_NAME", "action": false, "timestamp": "2020-11-09T14:33:30+00:00" }, { "id": "33f49312cd66475397037ac2489c3f48", "sender": "bitcoin-git", "payload": "bitcoin/master fa8b111 MarcoFalke: ci: Run arm ci config on cirrus", "action": false, "timestamp": "2020-11-09T14:33:31+00:00" }, { "id": "f932e33ed7454a268936fdeb25f7405a", "sender": "bitcoin-git", "payload": "[bitcoin] MarcoFalke merged pull request #20339: ci: Run more ci configs on cirrus (master...2011-moreCirrus) https://github.com/bitcoin/bitcoin/pull/20339", "action": false, "timestamp": "2020-11-09T14:33:48+00:00" }, { "id": "68f4a9452a66483ba5ddae7ca9dc1c0f", "sender": "bitcoin-git", "payload": "[bitcoin] laanwj pushed 6 commits to master: https://github.com/bitcoin/bitcoin/compare/05aeeee34f15...4fd37d0a104f", "action": false, "timestamp": "2020-11-09T14:47:40+00:00" }, { "id": "c4309701186d4e9d9020a8f9ce7aa68c", "sender": "bitcoin-git", "payload": "bitcoin/master fa762a3 MarcoFalke: test: Remove unused unnamed parameter from block.serialize call", "action": false, "timestamp": "2020-11-09T14:47:40+00:00" }, { "id": "594c45c643264a69b9ec5db5094aa413", "sender": "bitcoin-git", "payload": "bitcoin/master fa1dea1 MarcoFalke: test: Fix deser issue in create_block", "action": false, "timestamp": "2020-11-09T14:47:41+00:00" }, { "id": "4ab7062f21224240a62c1bb4b8245f12", "sender": "bitcoin-git", "payload": "bitcoin/master fac865b MarcoFalke: test: Fix intermittent feature_taproot issue", "action": false, "timestamp": "2020-11-09T14:47:42+00:00" }, { "id": "a2649f42013e4d579c0f99c6893aa8d7", "sender": "bitcoin-git", "payload": "[bitcoin] laanwj merged pull request #20292: test: Fix intermittent feature_taproot issue (master...2011-testFixes) https://github.com/bitcoin/bitcoin/pull/20292", "action": false, "timestamp": "2020-11-09T14:47:58+00:00" }, { "id": "c31b0b463a8d41f5a142e477eca2393d", "sender": "bitcoin-git", "payload": "[bitcoin] MarcoFalke opened pull request #20354: test: Add feature_taproot.py --previous_release (master...2010-testFeatureTaprootPreviousVersion) https://github.com/bitcoin/bitcoin/pull/20354", "action": false, "timestamp": "2020-11-09T14:59:13+00:00" }, { "id": "de98c4dd40e74e009c3cb772fbea81dc", "sender": "bitcoin-git", "payload": "[bitcoin] practicalswift opened pull request #20355: fuzz: Check for addrv1 compatibility before using addrv1 serializer/deserializer on CSubNet (master...fix-sub_net_deserialize) https://github.com/bitcoin/bitcoin/pull/20355", "action": false, "timestamp": "2020-11-09T15:36:21+00:00" }, { "id": "0f51d43328d541e88d5c3026a1bd1c7c", "sender": "bitcoin-git", "payload": "[bitcoin] laanwj pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/4fd37d0a104f...79a3b59cc706", "action": false, "timestamp": "2020-11-09T16:08:04+00:00" }, { "id": "a4cd31084a7a42c1ba7ea54dca8adbfb", "sender": "bitcoin-git", "payload": "bitcoin/master ba8997f Jon Atack: net: update GetNetworkName() with all enum Network cases", "action": false, "timestamp": "2020-11-09T16:08:05+00:00" }, { "id": "d2038b2ce63a47f1862c63ddbc6b6817", "sender": "bitcoin-git", "payload": "bitcoin/master 9a75e1e Jon Atack: rpc: update GetNetworksInfo() to not return unsupported networks", "action": false, "timestamp": "2020-11-09T16:08:05+00:00" }, { "id": "848055035844419583eb00872b97a1e9", "sender": "bitcoin-git", "payload": "bitcoin/master 7b5bd31 Jon Atack: test: add getnetworkinfo network name regression tests", "action": false, "timestamp": "2020-11-09T16:08:05+00:00" }, { "id": "86a5486f1e194b83a9a55dffa8168a24", "sender": "bitcoin-git", "payload": "[bitcoin] laanwj merged pull request #20120: net, rpc, test, bugfix: update GetNetworkName, GetNetworksInfo, regression tests (master...fix-getnetworkinfo-empty-networks) https://github.com/bitcoin/bitcoin/pull/20120", "action": false, "timestamp": "2020-11-09T16:08:24+00:00" }, { "id": "a47b12218be8412eb38584b2f9c8ce52", "sender": "real_or_random", "payload": "can we reopen https://github.com/bitcoin/bitcoin/issues/17802 ? I think this needs action before the end of the year.", "action": false, "timestamp": "2020-11-09T17:54:46+00:00" }, { "id": "63934128b3db41b78cbdd16e178c6dac", "sender": "sipa", "payload": "MarcoFalke: ping ^", "action": false, "timestamp": "2020-11-09T17:55:27+00:00" }, { "id": "30a82df703da412e84b43ccabc98c9fb", "sender": "az0re", "payload": "Hey all, just want to point out the totally broken fee estimator", "action": false, "timestamp": "2020-11-09T18:12:09+00:00" }, { "id": "9a316d238f9441e18df563c10437691c", "sender": "az0re", "payload": "!mempool", "action": false, "timestamp": "2020-11-09T18:12:12+00:00" }, { "id": "700f2685f2364eacb6e85696fca353de", "sender": "gribble", "payload": "Mempool info: [txcount: 3127, vsize (MB): 7.3364238739, totalfee (BTC): 1.01938529] | Next block 0: [max fee: 12773.8128079, min fee: 1.00305810398] | Next block 1: [max fee: 1.00303951368, min fee: 1.0013713851] | Next block 2: [max fee: 1.00137059849, min fee: 1.001347601]", "action": false, "timestamp": "2020-11-09T18:12:12+00:00" }, { "id": "a527a4f2dd404ccd9178c17a62bb0d98", "sender": "az0re", "payload": "My current mempool histogram shows:", "action": false, "timestamp": "2020-11-09T18:12:37+00:00" }, { "id": "47e6f65b8bcb4afc8906ec2e48b85c95", "sender": "az0re", "payload": "[[236, 101197], [205, 109178], [15, 123943], [8, 135543], [1, 7467948]]", "action": false, "timestamp": "2020-11-09T18:12:39+00:00" }, { "id": "70d10adc203e4965a069b7cf7d83347d", "sender": "az0re", "payload": "This is while the mempool has deflated from ~40MB 12 hours ago to ~8MB now", "action": false, "timestamp": "2020-11-09T18:13:10+00:00" }, { "id": "393fe52379284cd581f5e820d75e509c", "sender": "sipa", "payload": "who runs gribble these days?", "action": false, "timestamp": "2020-11-09T18:13:14+00:00" }, { "id": "cbc02ab5d0254113be8d8fa0da319b11", "sender": "sipa", "payload": "nanotube?", "action": false, "timestamp": "2020-11-09T18:13:18+00:00" }, { "id": "8debb80407cf48ddae69c4ac34dbd4f2", "sender": "az0re", "payload": "Not sure", "action": false, "timestamp": "2020-11-09T18:14:01+00:00" }, { "id": "f2331405fd0c43338fb5ae2b1433d6aa", "sender": "az0re", "payload": "Here's what estimatesmartfee gives me:", "action": false, "timestamp": "2020-11-09T18:14:09+00:00" }, { "id": "c0e2f33c661d43beacdce2b4730ba184", "sender": "az0re", "payload": "user@host:~$ ./bitcoin-0.20.1/bin/bitcoin-cli -rpcuser=user --rpcpassword=... estimatesmartfee 1 CONSERVATIVE", "action": false, "timestamp": "2020-11-09T18:14:11+00:00" }, { "id": "c84a73c7ea3a44839586295d497c4014", "sender": "az0re", "payload": "{", "action": false, "timestamp": "2020-11-09T18:14:12+00:00" }, { "id": "5a8d8bf991c946dd8f467b9893ab34b7", "sender": "az0re", "payload": "\"feerate\": 0.00231653,", "action": false, "timestamp": "2020-11-09T18:14:12+00:00" }, { "id": "c2fe8cc7d9084e378b7d8c27b979913d", "sender": "az0re", "payload": "\"blocks\": 2", "action": false, "timestamp": "2020-11-09T18:14:12+00:00" }, { "id": "bbd2693972b4443eb4a452383c14f18d", "sender": "az0re", "payload": "}", "action": false, "timestamp": "2020-11-09T18:14:12+00:00" }, { "id": "171c69820d5440e4aa231accd7d569d3", "sender": "az0re", "payload": "user@host:~$ ./bitcoin-0.20.1/bin/bitcoin-cli -rpcuser=user --rpcpassword=... estimatesmartfee 10 CONSERVATIVE", "action": false, "timestamp": "2020-11-09T18:14:13+00:00" }, { "id": "696768461b9c483290ce16fc541fc73f", "sender": "az0re", "payload": "{", "action": false, "timestamp": "2020-11-09T18:14:18+00:00" }, { "id": "3ae959b450b34d5e8bf7d0c249b4dfd0", "sender": "az0re", "payload": "\"feerate\": 0.00231653,", "action": false, "timestamp": "2020-11-09T18:14:21+00:00" }, { "id": "9d1f2bffb6b34d9cb740c1d9fa555389", "sender": "az0re", "payload": "\"blocks\": 10", "action": false, "timestamp": "2020-11-09T18:14:22+00:00" }, { "id": "2f25abf5b6e347a0824656437ed11230", "sender": "az0re", "payload": "}", "action": false, "timestamp": "2020-11-09T18:14:24+00:00" }, { "id": "f66a4b1c6e2541e9956ee5749ee2dafc", "sender": "az0re", "payload": "user@host:~$ ./bitcoin-0.20.1/bin/bitcoin-cli -rpcuser=user --rpcpassword=... estimatesmartfee 10 ECONOMICAL", "action": false, "timestamp": "2020-11-09T18:14:26+00:00" }, { "id": "720632edff3b44fdaf888f84b05293c0", "sender": "az0re", "payload": "{", "action": false, "timestamp": "2020-11-09T18:14:29+00:00" }, { "id": "29b13c6187924879acf8b88e15f674ad", "sender": "az0re", "payload": "\"feerate\": 0.00013714,", "action": false, "timestamp": "2020-11-09T18:14:31+00:00" }, { "id": "fe65970d3fd442c196cc51d6dbfef4ee", "sender": "az0re", "payload": "\"blocks\": 10", "action": false, "timestamp": "2020-11-09T18:14:33+00:00" }, { "id": "eb2a633f11b54f8b9629d8c0bc247c09", "sender": "az0re", "payload": "}", "action": false, "timestamp": "2020-11-09T18:14:35+00:00" }, { "id": "792cab6885e84cd5bc9b0e88f0e3bf16", "sender": "az0re", "payload": "user@host:~$ ./bitcoin-0.20.1/bin/bitcoin-cli -rpcuser=user --rpcpassword=... estimatesmartfee 1 ECONOMICAL", "action": false, "timestamp": "2020-11-09T18:14:37+00:00" }, { "id": "f1afec4cc5994ea2abe10dfdf0d9a880", "sender": "az0re", "payload": "{", "action": false, "timestamp": "2020-11-09T18:14:41+00:00" }, { "id": "c3d73e9377fa4e899e961eb1a28cb1ec", "sender": "az0re", "payload": "\"feerate\": 0.00199988,", "action": false, "timestamp": "2020-11-09T18:14:42+00:00" }, { "id": "741c7ca8f0ff448d9d0225fe9ced1533", "sender": "az0re", "payload": "\"blocks\": 2", "action": false, "timestamp": "2020-11-09T18:14:45+00:00" }, { "id": "3a59fd0e09cb463f90217d4af97c713a", "sender": "az0re", "payload": "}", "action": false, "timestamp": "2020-11-09T18:14:49+00:00" }, { "id": "f55f5fbe464041e991467f420266d46c", "sender": "az0re", "payload": "both ECONOMICAL and CONSERVATIVE suggest *way* too high fees, and I suspect that estimatesmartfee is creating its own reality here: It's suggesting high fees, and so the mempool gets a bunch of really high fee txes, and so the estimator keeps suggesting really high fees", "action": false, "timestamp": "2020-11-09T18:15:08+00:00" }, { "id": "f6a35c0ab4f64a4283b74afd9394c762", "sender": "az0re", "payload": "However, txes are clearing at way, way lower feerates", "action": false, "timestamp": "2020-11-09T18:15:20+00:00" }, { "id": "2a29952ff65d429882f41cc3c149ac75", "sender": "sipa", "payload": "az0re: that's kind of expected; the estimator does not look at the mempool, but only at the rates of which feerates confirm", "action": false, "timestamp": "2020-11-09T18:15:50+00:00" }, { "id": "e3ca94b703a84ec5ac0a47df6b010278", "sender": "az0re", "payload": "And if all installed estimators suddenly cut their suggested feerates 10x I suspect nothing would change but people saving a TON on tx fees", "action": false, "timestamp": "2020-11-09T18:15:51+00:00" }, { "id": "4faa4054c380469dbfded8b1821afb7e", "sender": "sipa", "payload": "so it's inherently delayed", "action": false, "timestamp": "2020-11-09T18:16:06+00:00" }, { "id": "fe5dcd61f8824ea8931c7606cecbd672", "sender": "az0re", "payload": "sipa: Looking at the rates of which feerates confirm should *also* result in a much lower suggested fee", "action": false, "timestamp": "2020-11-09T18:16:23+00:00" }, { "id": "aa7023e473bc4f188fe1b0192aae96ed", "sender": "az0re", "payload": "In the last 12h I've cleared--in one block--some txes with feerates as low as 3 sat/vbyte", "action": false, "timestamp": "2020-11-09T18:16:57+00:00" }, { "id": "634622dd4c784c85b4517bda915eae55", "sender": "sipa", "payload": "interesting", "action": false, "timestamp": "2020-11-09T18:18:41+00:00" }, { "id": "48e903c7f2594f4a933c2d7ac2a59223", "sender": "az0re", "payload": "There is more historical mempool/feerate estimate data available here: https://github.com/0e319b6/feerate-estimate-data", "action": false, "timestamp": "2020-11-09T18:19:40+00:00" }, { "id": "96d6415a24bf4cb8a4417f5dd5ec7a30", "sender": "az0re", "payload": "This is far from the only time I've noticed wildly excessive estimated fees", "action": false, "timestamp": "2020-11-09T18:19:51+00:00" }, { "id": "df1132ebab474e66b7184c297a41fcbe", "sender": "az0re", "payload": "!fees", "action": false, "timestamp": "2020-11-09T18:20:56+00:00" }, { "id": "6fcfcbbbb06f4d38a4973b37ac7cc270", "sender": "gribble", "payload": "Fee estimates (blocks: fee): (2: 68.414),(4: 8.898), (6: 3.319), (10: 1.138), (20: 1.138), (144: 1.138)", "action": false, "timestamp": "2020-11-09T18:20:57+00:00" }, { "id": "d2ffd409a29a48cc9065a3902095629b", "sender": "az0re", "payload": "OK, no idea how these estimates are calculated, but the super sharp drop off is a red flag", "action": false, "timestamp": "2020-11-09T18:21:36+00:00" }, { "id": "2d2e2f7634874bb3a6b273384f825db5", "sender": "sipa", "payload": "may be worth opening an issue for", "action": false, "timestamp": "2020-11-09T18:22:44+00:00" }, { "id": "b49c5a94d58547d99a8470de2ad04971", "sender": "darosior", "payload": "az0re: it's expected. It's possible, but there are not historically enough of them for the estimator to choose this bucket.", "action": false, "timestamp": "2020-11-09T18:37:00+00:00" }, { "id": "bcdd328a4c2e4984a0ce3325fa4cd4b2", "sender": "darosior", "payload": "For example, if you had a new mode -say RECKLESS- with far less probability than ECONOMICAL, then it'd probably give you these estimations.", "action": false, "timestamp": "2020-11-09T18:38:06+00:00" }, { "id": "69b574f1ac40486592fba96456c7e587", "sender": "az0re", "payload": "darosior: \"not historically enough of them\" -- of what?", "action": false, "timestamp": "2020-11-09T18:53:22+00:00" }, { "id": "5890f3dcdcf5477daa5540e7853fd4b8", "sender": "phantomcircuit", "payload": "az0re, the problem is that setting the fee rate too high is a known cost, setting it too low tends to result in people with transactions that are stuck", "action": false, "timestamp": "2020-11-09T18:59:51+00:00" }, { "id": "8b4e0a81ff6c495d90e0f68917fecfbf", "sender": "phantomcircuit", "payload": "the latter being much worse for 90% of people", "action": false, "timestamp": "2020-11-09T19:00:00+00:00" }, { "id": "fd561a9660c042a69e911837feb92ac3", "sender": "az0re", "payload": "phantomcircuit: I totally understand that, and I totally understand being conservative. However:", "action": false, "timestamp": "2020-11-09T19:00:36+00:00" }, { "id": "8c755e39a9e648fd937219332e742641", "sender": "az0re", "payload": "1. Isn't this why there is CONSERVATIVE and ECONOMICAL? `1 ECONOMICAL` in this case really should not be giving me 200 sat/vbyte!", "action": false, "timestamp": "2020-11-09T19:00:55+00:00" }, { "id": "fa67110e10a14f02b485c0fb86482e9a", "sender": "az0re", "payload": "2. We should still see a smooth drop off. But `1 CONSERVATIVE` and `10 CONSERVATIVE` are identical.", "action": false, "timestamp": "2020-11-09T19:01:24+00:00" }, { "id": "63dfee859db14896996ab6a61b443692", "sender": "az0re", "payload": "And it extends beyond 1 and 10; very frequently I see huge swathes of the estimates sitting at exactly the same feerate", "action": false, "timestamp": "2020-11-09T19:01:48+00:00" }, { "id": "50a5785be71249a787d46ad6eee8f1c6", "sender": "az0re", "payload": "If `1 CONSERVATIVE` gave 200, `10 CONSERVATIVE` gave 40, and `1 ECONOMICAL` gave 20 I would have nothing to complain about", "action": false, "timestamp": "2020-11-09T19:02:32+00:00" }, { "id": "e2323dc6b4d9480b8d9793cc26113fba", "sender": "az0re", "payload": " [...] result in people with transactions that are stuck", "action": false, "timestamp": "2020-11-09T19:04:35+00:00" }, { "id": "379e679645af43729bdeca8ad46793ea", "sender": "az0re", "payload": "Also, isn't this why RBF is a thing? :)", "action": false, "timestamp": "2020-11-09T19:04:43+00:00" }, { "id": "0c768f3322d74dd9adb6f77c5b310f03", "sender": "az0re", "payload": "I understand that doesn't necessarily solve the problem in all cases, but it should reduce the caution for suggesting too-low feerates, especially for ECONOMICAL", "action": false, "timestamp": "2020-11-09T19:05:29+00:00" }, { "id": "40fe3e9113ba4652ad0241b025cb8b1b", "sender": "az0re", "payload": "Finally, I will stop spamming after this I swear, but the bimodal distribution of the mempool seems fundamentally broken to me. In my idealized vision of the world, there would be monotonically increasing mempool pressure with decreasing feerate.", "action": false, "timestamp": "2020-11-09T19:07:09+00:00" }, { "id": "e2f585b0a5d94cc99ea600925ab18224", "sender": "az0re", "payload": "The current structure suggests to me that the auction mechanics of the mempool are not really working correctly", "action": false, "timestamp": "2020-11-09T19:07:42+00:00" }, { "id": "01a3c51e8082455193836c9bc4c5358a", "sender": "queip", "payload": "long term, would bitcoind start with 1s/vb and then in background keep slowly RBFing it until it works? In transaction you would specify how much you want to wait, how much you can wait, and absolute limit (so before it it sets very max fee) and the max fee", "action": false, "timestamp": "2020-11-09T19:14:04+00:00" }, { "id": "17ab29b6313742c083e6a639ed4bb290", "sender": "queip", "payload": "e.g. dust consolidations would be like 144,1440,6000, 100[s/vb] while regular onchain shopping could be 3,6,24,1000 for example", "action": false, "timestamp": "2020-11-09T19:15:34+00:00" }, { "id": "9ab101a81b06459c8560faea882d921a", "sender": "bitcoin-git", "payload": "[bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/79a3b59cc706...1dfe19e2840b", "action": false, "timestamp": "2020-11-09T19:19:42+00:00" }, { "id": "b0d25f80c2d4425da409ac5906cb2717", "sender": "bitcoin-git", "payload": "bitcoin/master 538be42 Ivan Metlushko: wallet: fix importdescriptor silent fail", "action": false, "timestamp": "2020-11-09T19:19:42+00:00" }, { "id": "ffb41e32605b4b7da88e4d24a15e5a66", "sender": "bitcoin-git", "payload": "bitcoin/master 1dfe19e Wladimir J. van der Laan: Merge #20153: wallet: do not import a descriptor with hardened derivations...", "action": false, "timestamp": "2020-11-09T19:19:43+00:00" }, { "id": "1c09eb0ca81d487291145846b37ccb64", "sender": "bitcoin-git", "payload": "[bitcoin] laanwj merged pull request #20153: wallet: do not import a descriptor with hardened derivations into a watch-only wallet (master...importdesc_silent_fail) https://github.com/bitcoin/bitcoin/pull/20153", "action": false, "timestamp": "2020-11-09T19:19:57+00:00" }, { "id": "3164ea9e690a47a09fa66e7dafeb1d18", "sender": "nanotube", "payload": "sipa: yes, i still run gribble. mempool command fetches data from mempool.space", "action": false, "timestamp": "2020-11-09T19:20:42+00:00" }, { "id": "92b7196fc2e74a41ac761320e17544a4", "sender": "nanotube", "payload": "az0re: fees command pulls from blockstream.info api", "action": false, "timestamp": "2020-11-09T19:22:17+00:00" }, { "id": "d506cdb4cfb8423d870978daed3f0e29", "sender": "bitcoin-git", "payload": "[bitcoin] hebasto opened pull request #20357: ci: Use travis_fold on Travis CI only (master...201109-travis) https://github.com/bitcoin/bitcoin/pull/20357", "action": false, "timestamp": "2020-11-09T20:13:51+00:00" }, { "id": "9230de60604c41ddaa4ce43b0f7f3083", "sender": "kanzure", "payload": "are we using git read-tree or subtree for libsecp256k1?", "action": false, "timestamp": "2020-11-09T20:29:32+00:00" }, { "id": "909583a6ca7d41408443379c393c33f3", "sender": "sipa", "payload": "git subtree; i don't know what git read-tree is", "action": false, "timestamp": "2020-11-09T20:30:30+00:00" }, { "id": "3f228e37d8974e519718066161ecc055", "sender": "kanzure", "payload": "is the usage of subtree documented? i'm thinking about extracting test_framework into a python package.", "action": false, "timestamp": "2020-11-09T20:30:48+00:00" }, { "id": "8dd11d8682c44e2e8c5e82e3d4d569cb", "sender": "kanzure", "payload": "and i would like to preserve commit history if possible", "action": false, "timestamp": "2020-11-09T20:30:58+00:00" }, { "id": "9004bf12c5d34d178bb89ce4638ab57e", "sender": "luke-jr", "payload": "that's the opposite direction..", "action": false, "timestamp": "2020-11-09T20:32:21+00:00" }, { "id": "0a35f2287a7b402d8cb668408e838e39", "sender": "sipa", "payload": "subtree can preserve history afaik", "action": false, "timestamp": "2020-11-09T20:33:10+00:00" }, { "id": "1c9331ebb5624702b9869f94feba3ddc", "sender": "sipa", "payload": "when splitting off a tree", "action": false, "timestamp": "2020-11-09T20:33:14+00:00" }, { "id": "139cd3752c04450b9a337e3c80ec1022", "sender": "kanzure", "payload": "opposite direction should be ok", "action": false, "timestamp": "2020-11-09T20:35:19+00:00" }, { "id": "1dc0df2427a243c68568cd48c9903e67", "sender": "sipa", "payload": "git subtree split may do what you want", "action": false, "timestamp": "2020-11-09T20:36:21+00:00" }, { "id": "74c1cd6d1d1d493b8b9ca86db7c4f7fc", "sender": "bitcoin-git", "payload": "[bitcoin] ffontaine opened pull request #20358: src/randomenv.cpp: fix build on uclibc (master...master) https://github.com/bitcoin/bitcoin/pull/20358", "action": false, "timestamp": "2020-11-09T20:39:33+00:00" }, { "id": "32ca603a09094646b2d5c5180a86a7bf", "sender": "bitcoin-git", "payload": "[bitcoin] dongcarl opened pull request #20359: depends: Various config.site.in improvements and linting (master...2020-11-config-site-cleanup) https://github.com/bitcoin/bitcoin/pull/20359", "action": false, "timestamp": "2020-11-09T22:01:30+00:00" }, { "id": "c3a9b8e6a8cd427ab8bdd80b28406239", "sender": "stevenroose", "payload": "I'm reading \"A heap is used so that not all items need sorting if only a few are being sent.\" in net_processing.cpp.", "action": false, "timestamp": "2020-11-09T23:30:44+00:00" }, { "id": "1b9736c376264e19b44be985728f43e1", "sender": "stevenroose", "payload": "I don't understand how the C++ heap implementation works I think, does it order lazily?", "action": false, "timestamp": "2020-11-09T23:31:05+00:00" }, { "id": "f796b81a667b40dab40800d7e183b3e7", "sender": "sipa", "payload": "stevenroose: the STL implementation shouldn't matter", "action": false, "timestamp": "2020-11-09T23:31:54+00:00" }, { "id": "fef2bf92d4064a51ad58fbe3f28e541d", "sender": "sipa", "payload": "it constructs a heap in O(n) time from the input elements", "action": false, "timestamp": "2020-11-09T23:32:22+00:00" }, { "id": "4c28e8da851f41a1a5dfc0c8d596a863", "sender": "sipa", "payload": "then you can extract the top element from it in O(log n) time", "action": false, "timestamp": "2020-11-09T23:32:38+00:00" }, { "id": "23c417285d944ddb9eb7be5119c03a12", "sender": "sipa", "payload": "so if you only need m elements, it's O(n + m*log(n)) work", "action": false, "timestamp": "2020-11-09T23:34:03+00:00" }, { "id": "bd09c0d395374aa2a81ee40dd7497773", "sender": "sipa", "payload": "while full sorting would need O(n*log(n)) work", "action": false, "timestamp": "2020-11-09T23:34:17+00:00" }, { "id": "c7249cb63e464a7abc83040c052ae5b7", "sender": "stevenroose", "payload": "oooh, I'm reading that's just the way a heap works, didn't know that. didn't know it had those properties, fancy", "action": false, "timestamp": "2020-11-09T23:45:37+00:00" }, { "id": "3bd2a12d975f4eea80b23246d3d93f9b", "sender": "sipa", "payload": "yeah, it actually more of a priority queue algorithm than a sorting algorithm", "action": false, "timestamp": "2020-11-09T23:46:10+00:00" }, { "id": "bcb76021a15e471d9099f9f42196a144", "sender": "sipa", "payload": "heapsort is first structuring the input into a heap, and then iteratively extracting the top level, shrinking the heap, and using the new space to put the extracted element", "action": false, "timestamp": "2020-11-09T23:46:55+00:00" }, { "id": "d26e167c81b84aef88d032051eda03b0", "sender": "sipa", "payload": "*top element", "action": false, "timestamp": "2020-11-09T23:47:01+00:00" }, { "id": "1edc1dfda0d84860bf51421fc657fec5", "sender": "meshcollider", "payload": "real_or_random: done ^", "action": false, "timestamp": "2020-11-09T23:50:46+00:00" }, { "id": "c6958b36d61143adb6f2cfd8edc7004d", "sender": "luke-jr", "payload": "wonders where the generational gap is between \"computers take time to do things\" and \"wtf? why isn't it done yet?\"", "action": true, "timestamp": "2020-11-09T23:54:22+00:00" }, { "id": "91e1391466d54b67b06129cc93be1cf1", "sender": "stevenroose", "payload": "sipa: thanks", "action": false, "timestamp": "2020-11-09T23:56:35+00:00" }, { "id": "1ee705bae5ac402aaf2f0d83df035083", "sender": "luke-jr", "payload": "(I didn't learn to care about optimisation until maybe ~18yo or so)", "action": false, "timestamp": "2020-11-09T23:59:00+00:00" }, { "id": "a0dee86987744fadb7b3feacf3d5c178", "sender": "ariard", "payload": "sipa: I guess #20207 is pretty ready modulo jonatack nits :)", "action": false, "timestamp": "2020-11-10T00:17:40+00:00" }, { "id": "06235928f8454a07af48943601d8eb8b", "sender": "gribble", "payload": "https://github.com/bitcoin/bitcoin/issues/20207 | Follow-up extra comments on taproot code and tests by sipa \u00c3\u0082\u00c2\u00b7 Pull Request #20207 \u00c3\u0082\u00c2\u00b7 bitcoin/bitcoin \u00c3\u0082\u00c2\u00b7 GitHub", "action": false, "timestamp": "2020-11-10T00:17:42+00:00" }, { "id": "171ecefcfa08401e82fdc325d1d29913", "sender": "bitcoin-git", "payload": "[bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/1dfe19e2840b...0b69bb90eed3", "action": false, "timestamp": "2020-11-10T06:58:33+00:00" }, { "id": "b1b0b6b55d9348f4a0791657df516df9", "sender": "bitcoin-git", "payload": "bitcoin/master 0e3a78a practicalswift: fuzz: Check for addrv1 compatibility before using addrv1 serializer/deseri...", "action": false, "timestamp": "2020-11-10T06:58:33+00:00" }, { "id": "2ee0efe7736445378856b0809f27561c", "sender": "bitcoin-git", "payload": "bitcoin/master 79b8f8d practicalswift: fuzz: Assert roundtrip equality for both addrv1 and addrv2 versions of CSe...", "action": false, "timestamp": "2020-11-10T06:58:33+00:00" }, { "id": "996b4953a6dd48b09488da24924f9db9", "sender": "bitcoin-git", "payload": "bitcoin/master 0b69bb9 MarcoFalke: Merge #20355: fuzz: Check for addrv1 compatibility before using addrv1 ser...", "action": false, "timestamp": "2020-11-10T06:58:34+00:00" }, { "id": "7739024074654ed5b4c4b5c8a72a789d", "sender": "bitcoin-git", "payload": "[bitcoin] MarcoFalke merged pull request #20355: fuzz: Check for addrv1 compatibility before using addrv1 serializer/deserializer on CSubNet (master...fix-sub_net_deserialize) https://github.com/bitcoin/bitcoin/pull/20355", "action": false, "timestamp": "2020-11-10T06:58:52+00:00" }, { "id": "f9789dda44cb4c70beafccecef08359f", "sender": "bitcoin-git", "payload": "[bitcoin] mateusz-klatt opened pull request #20361: load wallets from entropy (as BIP39) (master...master) https://github.com/bitcoin/bitcoin/pull/20361", "action": false, "timestamp": "2020-11-10T07:37:23+00:00" }, { "id": "3e4db77d02cd44d59e1a3d45f7ee28c8", "sender": "bitcoin-git", "payload": "[bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/0b69bb90eed3...42f950cb27b7", "action": false, "timestamp": "2020-11-10T08:22:39+00:00" }, { "id": "d3c1010a9fdd4da19a73de16bb7710f7", "sender": "bitcoin-git", "payload": "bitcoin/master 4444128 MarcoFalke: test: Fix intermittent issue in wallet_listsinceblock", "action": false, "timestamp": "2020-11-10T08:22:39+00:00" }, { "id": "4d6091b00dfd4876b4eadec58f95bb6f", "sender": "bitcoin-git", "payload": "bitcoin/master 42f950c MarcoFalke: Merge #20322: test: Fix intermittent issue in wallet_listsinceblock", "action": false, "timestamp": "2020-11-10T08:22:40+00:00" }, { "id": "42d0a1abe81f42ddac36a7db91aa06e2", "sender": "bitcoin-git", "payload": "[bitcoin] MarcoFalke merged pull request #20322: test: Fix intermittent issue in wallet_listsinceblock (master...2011-testInt) https://github.com/bitcoin/bitcoin/pull/20322", "action": false, "timestamp": "2020-11-10T08:23:00+00:00" }, { "id": "287bb9cd11cb49178a9431677118a901", "sender": "jonasschnelli", "payload": "core-meetingbot ping", "action": false, "timestamp": "2020-11-10T10:13:35+00:00" }, { "id": "ef4ee6c32ead4b5b83511e5f8ac4e067", "sender": "MarcoFalke", "payload": "jonasschnelli: core-meetingbot needs to be logged in with an freenode account to say something here", "action": false, "timestamp": "2020-11-10T12:34:41+00:00" }, { "id": "46e30b6f200f4df382e5b2604c555199", "sender": "MarcoFalke", "payload": "If you run whois it wounld need to say \"core-meetingbot is logged in as core-meetingbot.\"", "action": false, "timestamp": "2020-11-10T12:35:24+00:00" }, { "id": "47598fc5a72948eb8732275959e1af25", "sender": "MarcoFalke", "payload": "*would", "action": false, "timestamp": "2020-11-10T12:35:29+00:00" }, { "id": "14fb042f5eca4f0c85044451f8479607", "sender": "jonasschnelli", "payload": "MarcoFalke: thanks... I\u00c3\u00a2\u00c2\u0080\u00c2\u0099ll try that.", "action": false, "timestamp": "2020-11-10T12:58:23+00:00" }, { "id": "c684a935eb77438daa75e34d04379257", "sender": "jonasschnelli", "payload": "core-meetingbot ping", "action": false, "timestamp": "2020-11-10T13:33:39+00:00" }, { "id": "49748a44f80d4e6098d9b5a53a5fd1a1", "sender": "core-meetingbot", "payload": "pong", "action": false, "timestamp": "2020-11-10T13:33:39+00:00" }, { "id": "d33a479fb9944b3fb9fa064630e77ac1", "sender": "jonasschnelli", "payload": "#startmeeting", "action": false, "timestamp": "2020-11-10T13:33:42+00:00" }, { "id": "f3b6758ac9674c64b5f041ef9d628047", "sender": "core-meetingbot", "payload": "Meeting started Tue Nov 10 13:33:42 2020 UTC. The chair is jonasschnelli. Information about MeetBot at https://bitcoin.jonasschnelli.ch/ircmeetings.", "action": false, "timestamp": "2020-11-10T13:33:42+00:00" }, { "id": "e8fd21031b7b47c9874fd19369455a8c", "sender": "core-meetingbot", "payload": "Available commands: action commands idea info link nick", "action": false, "timestamp": "2020-11-10T13:33:42+00:00" }, { "id": "e0c1aac3acc7422f8a9396886e9047a2", "sender": "jonasschnelli", "payload": "#endmeeting", "action": false, "timestamp": "2020-11-10T13:33:45+00:00" }, { "id": "e18304827e1b46ad99d9ce7df6f242c6", "sender": "core-meetingbot", "payload": "topic: Bitcoin Core development discussion and commit log | Feel free to watch, but please take commentary and usage questions to #bitcoin | Channel logs: http://www.erisian.com.au/bitcoin-core-dev/, http://gnusha.org/bitcoin-core-dev/ | Meeting topics http://gnusha.org/bitcoin-core-dev/proposedmeetingtopics.txt / http://gnusha.org/bitcoin-core-dev/proposedwalletmeetingtopics.txt", "action": false, "timestamp": "2020-11-10T13:33:45+00:00" }, { "id": "31d4f21947f14727a4ee13b71d450e72", "sender": "core-meetingbot", "payload": "Meeting ended Tue Nov 10 13:33:45 2020 UTC.", "action": false, "timestamp": "2020-11-10T13:33:45+00:00" }, { "id": "344be3fe952e48718f5699be9c366562", "sender": "core-meetingbot", "payload": "Minutes: https://bitcoin.jonasschnelli.ch/ircmeetings/logs/bitcoin-core-dev/2020/bitcoin-core-dev.2020-11-10-13.33.moin.txt", "action": false, "timestamp": "2020-11-10T13:33:45+00:00" }, { "id": "5312253dad7843309e6f48672532847d", "sender": "jonasschnelli", "payload": "ignore my test-meeting...", "action": false, "timestamp": "2020-11-10T13:35:34+00:00" }, { "id": "1ed762dc23f94f8597ee2edf897698f5", "sender": "bitcoin-git", "payload": "[bitcoin] MarcoFalke opened pull request #20362: test: Implicitly sync after generate* to preempt races and intermittent test failures (master...2011-noSync) https://github.com/bitcoin/bitcoin/pull/20362", "action": false, "timestamp": "2020-11-10T14:39:32+00:00" }, { "id": "73094a60a00649f29180dd341cc6893b", "sender": "DeanWeen", "payload": "https://gitlab.com/bitcoin-cash-node/bitcoin-cash-node/-/merge_requests/844 In case they \"forget\" to alert core", "action": false, "timestamp": "2020-11-10T17:19:12+00:00" }, { "id": "381c1aeb6d114a90ad0173baeb10f5f1", "sender": "sipa", "payload": "jnewbery: so if forward/backward compatibility is something to be considered from the perspective of software, it explains my confusion about it: forward compatibility is about making sure downgrading works, backward compatbility is about making sure upgrading works...", "action": false, "timestamp": "2020-11-10T17:51:43+00:00" }, { "id": "31d207ae84154b75a3c87263724548b2", "sender": "bitcoin-git", "payload": "[bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/42f950cb27b7...fa8dd34e918c", "action": false, "timestamp": "2020-11-10T18:52:33+00:00" }, { "id": "c972dc54bfba4de3a757773ac42b89ee", "sender": "bitcoin-git", "payload": "bitcoin/master fa4234d MarcoFalke: test: Mock IBD in net_processing fuzzers", "action": false, "timestamp": "2020-11-10T18:52:33+00:00" }, { "id": "6ad210ea7d804854a49cde5aa2e46c83", "sender": "bitcoin-git", "payload": "bitcoin/master fa8dd34 MarcoFalke: Merge #20332: test: Mock IBD in net_processing fuzzers", "action": false, "timestamp": "2020-11-10T18:52:34+00:00" }, { "id": "4c8fe9543fe041dc89992d5e4f7f2833", "sender": "bitcoin-git", "payload": "[bitcoin] MarcoFalke merged pull request #20332: test: Mock IBD in net_processing fuzzers (master...2011-fuzzNet) https://github.com/bitcoin/bitcoin/pull/20332", "action": false, "timestamp": "2020-11-10T18:52:53+00:00" }, { "id": "8bfa07c21345404bb8593157d4296b1a", "sender": "jnewbery", "payload": "sipa: that's my understanding, yes", "action": false, "timestamp": "2020-11-10T19:43:19+00:00" }, { "id": "60487b656a844b01919e8e66e1720cf7", "sender": "bitcoin-git", "payload": "[bitcoin] troygiorshev opened pull request #20364: Follow-ups to 19107 (master...2020-11-19107-follow-ups) https://github.com/bitcoin/bitcoin/pull/20364", "action": false, "timestamp": "2020-11-10T21:46:19+00:00" }, { "id": "591635a054bc45889e9cd5f0c55d254b", "sender": "brianddk", "payload": "I was trying to build the first few versions of bitcoin (v0.1.5) with MSYS/MinGW (v1.0.11), but I'm failing on the OpenSSL build after applying the readme.txt patches. Anyone recall anything tricky to getting that to work?", "action": false, "timestamp": "2020-11-11T00:04:55+00:00" }, { "id": "3438ef946f4343bc95b467e0efdeab34", "sender": "sipa", "payload": "pretty sure 0", "action": false, "timestamp": "2020-11-11T00:11:58+00:00" }, { "id": "99ea71f06d92456396c92a0f55ae1e1d", "sender": "sipa", "payload": "pretty sure 0.1.5 was only ever intended to work with msvc", "action": false, "timestamp": "2020-11-11T00:12:08+00:00" }, { "id": "14801b14df744c91922ae5bd7247ce4a", "sender": "sipa", "payload": "oh, no!", "action": false, "timestamp": "2020-11-11T00:12:47+00:00" }, { "id": "fb0c923893474cd182f3c8c91dea015b", "sender": "brianddk", "payload": "sipa, yeah the readme lists some build problems with MSVC, and seems to suggest MinGW/MSYS. I'll keep digging", "action": false, "timestamp": "2020-11-11T00:21:26+00:00" }, { "id": "18787b2d51c84072bc564a3630a655e9", "sender": "bitcoin-git", "payload": "[bitcoin] jonatack closed pull request #20305: wallet: introduce fee_rate sat/vB param/option (master...fee_rate_sat_vb) https://github.com/bitcoin/bitcoin/pull/20305", "action": false, "timestamp": "2020-11-11T01:30:41+00:00" }, { "id": "523749ca22154a6ea979cabdf998a3a1", "sender": "bitcoin-git", "payload": "[bitcoin] jonatack reopened pull request #20305: wallet: introduce fee_rate sat/vB param/option (master...fee_rate_sat_vb) https://github.com/bitcoin/bitcoin/pull/20305", "action": false, "timestamp": "2020-11-11T01:30:56+00:00" }, { "id": "f710d5fba00a493f8c4d8ddeada5abf9", "sender": "bitcoin-git", "payload": "[bitcoin] S3RK opened pull request #20365: wallettool: add parameter to create descriptors wallet (master...wallet_tool_create_descriptors) https://github.com/bitcoin/bitcoin/pull/20365", "action": false, "timestamp": "2020-11-11T05:02:20+00:00" }, { "id": "199526710dd94012a30b91bd769b323b", "sender": "luke-jr", "payload": "hey, at least the new Cirrus CI work even if the old/first one doesn't <.<", "action": false, "timestamp": "2020-11-11T05:27:14+00:00" }, { "id": "84e122e5a3744db68c5e1d724d7c5035", "sender": "bitcoin-git", "payload": "[bitcoin] hebasto opened pull request #20366: scripted-diff: Fix includes when secp256k1 is locally installed on macOS (master...201111-incl) https://github.com/bitcoin/bitcoin/pull/20366", "action": false, "timestamp": "2020-11-11T07:36:13+00:00" }, { "id": "d5758598b7a84262bdc8e7b9f40f5cf4", "sender": "bitcoin-git", "payload": "[bitcoin] MarcoFalke opened pull request #20368: ci: Remove redundant valgrind fuzz task (master...2011-ciRemoveHeavyTask) https://github.com/bitcoin/bitcoin/pull/20368", "action": false, "timestamp": "2020-11-11T08:12:33+00:00" }, { "id": "09d2600bc05b4f5fb4987c36ffcdd1cd", "sender": "vasild", "payload": "sipa: jnewbery: \"backward compatibility\" can also be applied to data formats, not just on software. For example wikipedia mentions: \"A data format is said to be backward compatible with its predecessor if...\" (https://en.wikipedia.org/wiki/Backward_compatibility)", "action": false, "timestamp": "2020-11-11T09:11:25+00:00" }, { "id": "ce85ed4f07ec4fbbb77da6a233fe1c4c", "sender": "vasild", "payload": "jnewbery: according to your definition \"software is forward-compatible if it can gracefully read new input formats\" a software version X is forward compatible until version e.g. X+5 introduces a new input format which X cannot read", "action": false, "timestamp": "2020-11-11T09:14:16+00:00" }, { "id": "6c71d41535624c5a88c6371d5c410d55", "sender": "vasild", "payload": "So the same version X can be forward compatible or not, depending on what future versions do, hmm...", "action": false, "timestamp": "2020-11-11T09:15:54+00:00" }, { "id": "230df4df3af3431fa4b9bf0892a12ea2", "sender": "jnewbery", "payload": "in that case we'd say that version X+5 breaks forward compatibility", "action": false, "timestamp": "2020-11-11T09:23:40+00:00" }, { "id": "501fac90533b417785d8377a86b345cb", "sender": "vasild", "payload": "jnewbery: wrt https://github.com/bitcoin/bitcoin/pull/20284#issuecomment-725341208 I guess you have verified that it would fix the link error?", "action": false, "timestamp": "2020-11-11T10:49:25+00:00" }, { "id": "499ec0dcd6b04804a0df7a316ef373ef", "sender": "bitcoin-git", "payload": "[bitcoin] MarcoFalke opened pull request #20370: fuzz: Permission flags in net_processing fuzzers (master...2011-fuzzNetFlags) https://github.com/bitcoin/bitcoin/pull/20370", "action": false, "timestamp": "2020-11-11T13:19:52+00:00" }, { "id": "524d11f4af0f4317a8af98a04c3b96f3", "sender": "bitcoin-git", "payload": "[bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/fa8dd34e918c...155bf91c3b66", "action": false, "timestamp": "2020-11-11T13:23:34+00:00" }, { "id": "6240de2dbe7e461db719658e929ef9af", "sender": "bitcoin-git", "payload": "bitcoin/master fa92cf2 MarcoFalke: ci: Remove redundant valgrind fuzz task", "action": false, "timestamp": "2020-11-11T13:23:35+00:00" }, { "id": "010c6e0b429046f18dbfacf268b2d1f4", "sender": "bitcoin-git", "payload": "bitcoin/master 155bf91 MarcoFalke: Merge #20368: ci: Remove redundant valgrind fuzz task", "action": false, "timestamp": "2020-11-11T13:23:35+00:00" }, { "id": "1683df27379d4407bb32c4098dcb3633", "sender": "bitcoin-git", "payload": "[bitcoin] MarcoFalke merged pull request #20368: ci: Remove redundant valgrind fuzz task (master...2011-ciRemoveHeavyTask) https://github.com/bitcoin/bitcoin/pull/20368", "action": false, "timestamp": "2020-11-11T13:23:54+00:00" }, { "id": "33c3905b8d124088b7234f84543057db", "sender": "jnewbery", "payload": "vasild: very strange. It builds locally for me. One cirrus task links successfully on that commit and another doesn't", "action": false, "timestamp": "2020-11-11T13:57:50+00:00" }, { "id": "54fdb550a0394b1daeb65e99f1ef41f6", "sender": "jnewbery", "payload": "success: https://cirrus-ci.com/task/5345273754943488", "action": false, "timestamp": "2020-11-11T13:57:58+00:00" }, { "id": "58096893b48b4083995a40b7ed5f9557", "sender": "jnewbery", "payload": "fail: https://cirrus-ci.com/task/6471173661786112", "action": false, "timestamp": "2020-11-11T13:58:05+00:00" }, { "id": "f501307495c841d3b787cdf535a28f89", "sender": "vasild", "payload": "yes, strange and everything compiles for me", "action": false, "timestamp": "2020-11-11T13:58:20+00:00" }, { "id": "05c8aff6f1964484b2d0d50865e48dde", "sender": "jnewbery", "payload": "I don't know the cirrus config well enough to know why linking would fail on task 2", "action": false, "timestamp": "2020-11-11T13:59:02+00:00" }, { "id": "f204f019bb474a378b8bdfd7f4b14f3a", "sender": "vasild", "payload": "my guess is that it is running gcc 2.96 on redhat", "action": false, "timestamp": "2020-11-11T13:59:39+00:00" }, { "id": "531587fdb2cc479086eb9b3f3469f14d", "sender": "jnewbery", "payload": "it's clang: https://cirrus-ci.com/task/6471173661786112?command=ci#L3080", "action": false, "timestamp": "2020-11-11T14:01:49+00:00" }, { "id": "1ba87cbdcf544f17a0dbceb699422ffa", "sender": "jnewbery", "payload": "platform is ubuntu:focal", "action": false, "timestamp": "2020-11-11T14:02:14+00:00" }, { "id": "c139b412e92a4474bb50cb1edb4805bd", "sender": "jnewbery", "payload": "it makes me unhappy to merge stuff that we don't understand. I'd prefer just to remove the FILE_FORMAT from that strprintf than add the declaration in addrman.cpp", "action": false, "timestamp": "2020-11-11T14:05:37+00:00" }, { "id": "f1fda672d8d0472f8d84dda197b0e135", "sender": "vasild", "payload": "I wonder if that would compile...", "action": false, "timestamp": "2020-11-11T14:07:38+00:00" }, { "id": "560cd8b22d0d4450b76b20873c65b06d", "sender": "jnewbery", "payload": "I mean just don't include that in the exception string", "action": false, "timestamp": "2020-11-11T14:07:59+00:00" }, { "id": "828c35bc94ef46b19905c51f71063672", "sender": "vasild", "payload": "yes, I got your point, but I am not sure that will compile", "action": false, "timestamp": "2020-11-11T14:08:38+00:00" }, { "id": "ee48a425b44141ff8402ab54e869a297", "sender": "vasild", "payload": "it is unclear which version of clang is it using, but I see \"setting up clang10\" - at least it installed clang10", "action": false, "timestamp": "2020-11-11T14:09:10+00:00" }, { "id": "d7c307cf40164b4582550401f6d6e09a", "sender": "vasild", "payload": "let me try locally with clang10...", "action": false, "timestamp": "2020-11-11T14:09:18+00:00" }, { "id": "8f24f35c031343a7bfa0d57191e565ae", "sender": "jnewbery", "payload": "why wouldn't it? That's the line that's causing link failure, or do you think it'd fail somewhere else too?", "action": false, "timestamp": "2020-11-11T14:09:25+00:00" }, { "id": "0ab18e5a21b64f4887bd50bb3ef3b465", "sender": "vasild", "payload": "yes, see this one: https://cirrus-ci.com/task/6471173661786112?command=ci#L3847", "action": false, "timestamp": "2020-11-11T14:10:00+00:00" }, { "id": "836bf120d989471d8d686345aaa4b137", "sender": "vasild", "payload": "git show 2ed531:src/addrman.h", "action": false, "timestamp": "2020-11-11T14:11:26+00:00" }, { "id": "a689a5f1f7214890933069075399a8f0", "sender": "vasild", "payload": "addrman.h:358", "action": false, "timestamp": "2020-11-11T14:11:40+00:00" }, { "id": "2ff18388ec9348ac9151a6bcee8fb634", "sender": "jnewbery", "payload": "Thanks. That's interesting", "action": false, "timestamp": "2020-11-11T14:21:17+00:00" }, { "id": "55db29b0cd4441ba81b88985555cc737", "sender": "jnewbery", "payload": "vasild: I wonder if this would work: https://github.com/jnewbery/bitcoin/commit/9efadfb942464bba0e5a000fefaa9f4b0a22b8ed", "action": false, "timestamp": "2020-11-11T14:28:51+00:00" }, { "id": "13e2fa286e754ea3b3d31f9c0b1e634c", "sender": "MarcoFalke", "payload": "building locally right now", "action": false, "timestamp": "2020-11-11T14:31:19+00:00" }, { "id": "1652188a458e446ba645a89c4abcfdaf", "sender": "MarcoFalke", "payload": "it is using focal clang with -stdlib=libc++ (depends build)", "action": false, "timestamp": "2020-11-11T14:31:44+00:00" }, { "id": "c0020b40792c42a9828162758a7359cd", "sender": "vasild", "payload": "I don't like it - those constants really belong to private members of CAddrMan, moving them away just to fix a compile error that can also be fixed by 1-liner (define the constant in addrman.cpp)...", "action": false, "timestamp": "2020-11-11T14:32:39+00:00" }, { "id": "276ab308f9e043aa9e5f61883a0171c9", "sender": "vasild", "payload": "I can reproduce the error locally with clang 10", "action": false, "timestamp": "2020-11-11T14:33:15+00:00" }, { "id": "203e134048274805bae0a25751f6ba9a", "sender": "MarcoFalke", "payload": "I think it is a style-question that shoulndn't hold up the release", "action": false, "timestamp": "2020-11-11T14:33:20+00:00" }, { "id": "d590ec61ae83439a8732db9962f08e84", "sender": "vasild", "payload": "+1", "action": false, "timestamp": "2020-11-11T14:33:58+00:00" }, { "id": "9e2649e13fad4b7dbcd6eb0fe016028f", "sender": "jnewbery", "payload": "vasild: can you explain what this line does: https://github.com/bitcoin/bitcoin/pull/20284/files#diff-49d1faa58beca1ee1509a247e0331bb91f8604e30a483a7b2dea813e6cea02e2R74 ? I don't understand how it fixes the build error", "action": false, "timestamp": "2020-11-11T14:36:08+00:00" }, { "id": "fc3990d041ae45ab833c11437f4251da", "sender": "vasild", "payload": "it defines storage for the variable, my guess is that this particular compiler mistreats constexpr", "action": false, "timestamp": "2020-11-11T14:37:41+00:00" }, { "id": "faba5c3346bb4840b78808d39afc082a", "sender": "vasild", "payload": "wait, I am trying something simpler...", "action": false, "timestamp": "2020-11-11T14:38:36+00:00" }, { "id": "36429f3156b0433b95a01954f2ce788d", "sender": "vasild", "payload": "now that I can reproduce locally", "action": false, "timestamp": "2020-11-11T14:38:46+00:00" }, { "id": "3df8eec24e4e4d0d93dbca571dbc4849", "sender": "bitcoin-git", "payload": "[bitcoin] practicalswift opened pull request #20372: Avoid signed integer overflow when loading a mempool.dat file with a malformed time field (master...load-mempool-time-integer-overflow) https://github.com/bitcoin/bitcoin/pull/20372", "action": false, "timestamp": "2020-11-11T14:46:21+00:00" }, { "id": "9d48304e192e480592b12324e9680a17", "sender": "vasild", "payload": "jnewbery: https://bpa.st/MJBA", "action": false, "timestamp": "2020-11-11T14:46:38+00:00" }, { "id": "3a267aea684b447ead1c080197315090", "sender": "vasild", "payload": "that smells like a compiler bug", "action": false, "timestamp": "2020-11-11T14:46:46+00:00" }, { "id": "b63d20fcd1784cc388a5d7f95acefee0", "sender": "vasild", "payload": "uint8_t x; ... use x like static_cast(x) compiles, but change the usage to just \"x\" without the cast and it does not compile", "action": false, "timestamp": "2020-11-11T14:47:52+00:00" }, { "id": "593ec04934384a97b8c98503a72b424a", "sender": "vasild", "payload": "surely the cast from uint8_t to uint8_t shouldn't make a difference", "action": false, "timestamp": "2020-11-11T14:48:45+00:00" }, { "id": "c8158e32f352452296547ff1d0a412a9", "sender": "vasild", "payload": "Do we want the topmost fix from https://bpa.st/MJBA ? It is line line, but MarcoFalke will have to give up the CustomUintFormatter :)", "action": false, "timestamp": "2020-11-11T14:50:04+00:00" }, { "id": "b905d85277da444cb41f236d89d5fd8a", "sender": "MarcoFalke", "payload": "sob", "action": false, "timestamp": "2020-11-11T14:50:18+00:00" }, { "id": "e93dae55392c4398bafe7ed4e5f575c0", "sender": "vasild", "payload": "*It is one line", "action": false, "timestamp": "2020-11-11T14:50:20+00:00" }, { "id": "3d48827c2d4d4f0c9fb7b41bcfa23b9d", "sender": "MarcoFalke", "payload": "Go ahead. We can fight the compiler after branch off", "action": false, "timestamp": "2020-11-11T14:50:38+00:00" }, { "id": "c531e026bc004666952e8c2e7cabb4c6", "sender": "vasild", "payload": "and there is a chance that even though it compiled locally for me with clang 10.0.1 it will break on CI...", "action": false, "timestamp": "2020-11-11T14:50:59+00:00" }, { "id": "83a2bd105228444793cdad3e2a1f59fc", "sender": "vasild", "payload": "jnewbery: ?", "action": false, "timestamp": "2020-11-11T14:51:33+00:00" }, { "id": "8d954e65188b431389c045bae70d7a27", "sender": "jnewbery", "payload": "looks good to me!", "action": false, "timestamp": "2020-11-11T14:52:15+00:00" }, { "id": "ca85e248b4ef494e8be1abae7e044412", "sender": "jnewbery", "payload": "good job tracking it down", "action": false, "timestamp": "2020-11-11T14:52:26+00:00" }, { "id": "c8622212faa14fa4aa2f86b80d840efb", "sender": "aj", "payload": "\"for constexpr (but not for const) you always have to provide out-of-class definition on top of the in-class initializer.\" per https://stackoverflow.com/questions/22172789/passing-a-static-constexpr-variable-by-universal-reference", "action": false, "timestamp": "2020-11-11T14:54:40+00:00" }, { "id": "56062413e52e45ca96b29d79f16e18f4", "sender": "bitcoin-git", "payload": "[bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/155bf91c3b66...179ece42734a", "action": false, "timestamp": "2020-11-11T15:00:16+00:00" }, { "id": "dae6223ef78540b9bb4f6966dd99bf93", "sender": "bitcoin-git", "payload": "bitcoin/master fa949b3 MarcoFalke: test: Suppress epoll_ctl data race", "action": false, "timestamp": "2020-11-11T15:00:16+00:00" }, { "id": "45a75458d58941d6aecdd7c11adbcdb0", "sender": "bitcoin-git", "payload": "bitcoin/master 179ece4 MarcoFalke: Merge #20218: test: Suppress epoll_ctl data race", "action": false, "timestamp": "2020-11-11T15:00:17+00:00" }, { "id": "596bc655cf2d4ffe8a843826e7097524", "sender": "bitcoin-git", "payload": "[bitcoin] MarcoFalke merged pull request #20218: test: Suppress epoll_ctl data race (master...2010-testSuppWalletRace) https://github.com/bitcoin/bitcoin/pull/20218", "action": false, "timestamp": "2020-11-11T15:00:36+00:00" }, { "id": "5ac79d551b094ff1a61394b439fddae6", "sender": "bitcoin-git", "payload": "[bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/179ece42734a...d9f5132736f3", "action": false, "timestamp": "2020-11-11T15:12:20+00:00" }, { "id": "4d63867fb5dd472e9a6e0838d64a6836", "sender": "bitcoin-git", "payload": "bitcoin/master 5e14602 Sebastian Falbesoner: wallet: fix scanning progress calculation for single block range", "action": false, "timestamp": "2020-11-11T15:12:21+00:00" }, { "id": "b6c9b2ac49384de88193ddeaff0f5132", "sender": "bitcoin-git", "payload": "bitcoin/master d9f5132 MarcoFalke: Merge #20344: wallet: fix scanning progress calculation for single block r...", "action": false, "timestamp": "2020-11-11T15:12:22+00:00" }, { "id": "b5c564448c4a4132b3261dd7937e4477", "sender": "bitcoin-git", "payload": "[bitcoin] MarcoFalke merged pull request #20344: wallet: fix scanning progress calculation for single block range (master...20201108-wallet-avoid_div_by_zero_on_single_block_rescan) https://github.com/bitcoin/bitcoin/pull/20344", "action": false, "timestamp": "2020-11-11T15:12:40+00:00" }, { "id": "9a707b7facd74ac79a77ad9499d5c046", "sender": "MarcoFalke", "payload": "vasild: I am running the ci tsan config locally with your \"static_cast(\" patch, but it doesn't compile", "action": false, "timestamp": "2020-11-11T15:14:02+00:00" }, { "id": "48a676b02dee422a8afb9e99743570a1", "sender": "vasild", "payload": "it is on top of 2ed531", "action": false, "timestamp": "2020-11-11T15:15:54+00:00" }, { "id": "90381d46e5784109918ecd60a526faaf", "sender": "vasild", "payload": "did you apply it on top of the latest PR 204678c, or on top of 2ed531?", "action": false, "timestamp": "2020-11-11T15:16:32+00:00" }, { "id": "151bc911c5144478a9cebac2c73ba540", "sender": "MarcoFalke", "payload": "commit 204678cf4258bd59040016a7aac79e05daf30d3c", "action": false, "timestamp": "2020-11-11T15:18:14+00:00" }, { "id": "f8046ed9a2f747c5ba156716fe6247a7", "sender": "vasild", "payload": "on top of that commit the fix is: https://bpa.st/ASDA", "action": false, "timestamp": "2020-11-11T15:19:12+00:00" }, { "id": "aaee1285b5f34a56bce30dfd24d0e8fd", "sender": "vasild", "payload": "I have prepared that and am about to push -f, but will wait for you to confirm that it compiles at your end", "action": false, "timestamp": "2020-11-11T15:19:35+00:00" }, { "id": "f48eb8fda307492cb8bf14549d8c5b46", "sender": "vasild", "payload": "aj: that is only if the member variable is odr-used", "action": false, "timestamp": "2020-11-11T15:19:51+00:00" }, { "id": "dfc3daffd73d42a2ba8211e844b72ac3", "sender": "vasild", "payload": "the static cast makes it non-odr-used, so it needs no out-of-class definition", "action": false, "timestamp": "2020-11-11T15:20:26+00:00" }, { "id": "a69c98cc80e4474980f6483d7a500fd3", "sender": "MarcoFalke", "payload": "ah that seems to compile", "action": false, "timestamp": "2020-11-11T15:21:09+00:00" }, { "id": "8b2d629cf0ab4a1c931aceb58f1f1118", "sender": "vasild", "payload": "pushed!", "action": false, "timestamp": "2020-11-11T15:22:06+00:00" }, { "id": "669667b881be4564bb1107d11ceb1b5f", "sender": "MarcoFalke", "payload": "Using uint8_t{FORMAT} also compiles", "action": false, "timestamp": "2020-11-11T15:23:10+00:00" }, { "id": "47dee9ba263e4ef49ac913d7a2c99bec", "sender": "bitcoin-git", "payload": "[bitcoin] hebasto opened pull request #20373: refactor, net: Increase CNode data member encapsulation (master...201111-cnode) https://github.com/bitcoin/bitcoin/pull/20373", "action": false, "timestamp": "2020-11-11T17:14:11+00:00" }, { "id": "d2a95fbd31b5435c931b99b927c644b7", "sender": "bitcoin-git", "payload": "[gui] hebasto closed pull request #107: Fix main window geometry save/restore (master...201023-geometry) https://github.com/bitcoin-core/gui/pull/107", "action": false, "timestamp": "2020-11-11T19:46:25+00:00" }, { "id": "a5078ce4e75c4f168e2a1a0e2ff303d3", "sender": "bitcoin-git", "payload": "[bitcoin] thomasdane opened pull request #20374: Update README.md (master...patch-1) https://github.com/bitcoin/bitcoin/pull/20374", "action": false, "timestamp": "2020-11-11T20:16:00+00:00" }, { "id": "d09de092a4cd41f785c6a1f9dd607291", "sender": "bitcoin-git", "payload": "[bitcoin] practicalswift closed pull request #20137: tests: Update UBSan suppressions file with suppressions needed for clang 12 (current trunk) (master...clang-12-ubsan-suppressions) https://github.com/bitcoin/bitcoin/pull/20137", "action": false, "timestamp": "2020-11-11T21:52:53+00:00" }, { "id": "b58aff8a398940aa847e64cfcfbf375a", "sender": "bitcoin-git", "payload": "[bitcoin] fanquake closed pull request #20374: Update README.md (master...patch-1) https://github.com/bitcoin/bitcoin/pull/20374", "action": false, "timestamp": "2020-11-11T22:01:44+00:00" }, { "id": "195142636ee84409a29165e7f73e1782", "sender": "bitcoin-git", "payload": "[bitcoin] practicalswift opened pull request #20375: fuzz: Improve coverage for CPartialMerkleTree fuzzing harness (master...fuzzers-2020-11-11) https://github.com/bitcoin/bitcoin/pull/20375", "action": false, "timestamp": "2020-11-11T22:37:51+00:00" }, { "id": "0306126bf864450ebb3f596e2486905e", "sender": "bitcoin-git", "payload": "[bitcoin] meshcollider pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/d9f5132736f3...c2d8ba6265a4", "action": false, "timestamp": "2020-11-12T00:27:14+00:00" }, { "id": "096c897d639b497f8ab8e6a2ad5d2b14", "sender": "bitcoin-git", "payload": "bitcoin/master 69f59af Luke Dashjr: Bugfix: Wallet: Soft-fail exceptions within ListWalletDir file checks", "action": false, "timestamp": "2020-11-12T00:27:15+00:00" }, { "id": "5bc60a33a557463296f3b0b2a19aea22", "sender": "bitcoin-git", "payload": "bitcoin/master 24d2d33 Luke Dashjr: QA: wallet_multiwallet: Check that recursive symlink directory and wallet....", "action": false, "timestamp": "2020-11-12T00:27:15+00:00" }, { "id": "d3ff460e9fc942139905d52405ae29db", "sender": "bitcoin-git", "payload": "bitcoin/master c2d8ba6 Samuel Dobson: Merge #19502: Bugfix: Wallet: Soft-fail exceptions within ListWalletDir fi...", "action": false, "timestamp": "2020-11-12T00:27:16+00:00" }, { "id": "c133347a0a564c29987ac1bb83527184", "sender": "bitcoin-git", "payload": "[bitcoin] meshcollider merged pull request #19502: Bugfix: Wallet: Soft-fail exceptions within ListWalletDir file checks (master...bugfix_listwalletdir_errors) https://github.com/bitcoin/bitcoin/pull/19502", "action": false, "timestamp": "2020-11-12T00:28:09+00:00" }, { "id": "c25e41b64ba545b1b6ee70db83f58c69", "sender": "hebasto", "payload": "it seems merged #19502 resolves all issues of #18095, so the latter could be closed.", "action": false, "timestamp": "2020-11-12T07:52:51+00:00" }, { "id": "7945a0c2acd04571b47dbd0ca7ef9285", "sender": "gribble", "payload": "https://github.com/bitcoin/bitcoin/issues/19502 | Bugfix: Wallet: Soft-fail exceptions within ListWalletDir file checks by luke-jr \u00c3\u0082\u00c2\u00b7 Pull Request #19502 \u00c3\u0082\u00c2\u00b7 bitcoin/bitcoin \u00c3\u0082\u00c2\u00b7 GitHub", "action": false, "timestamp": "2020-11-12T07:52:53+00:00" }, { "id": "6f11bfd7ff65437f822f64354a1e4b5b", "sender": "gribble", "payload": "https://github.com/bitcoin/bitcoin/issues/18095 | Fix crashes and infinite loop in ListWalletDir() by uhliksk \u00c3\u0082\u00c2\u00b7 Pull Request #18095 \u00c3\u0082\u00c2\u00b7 bitcoin/bitcoin \u00c3\u0082\u00c2\u00b7 GitHub", "action": false, "timestamp": "2020-11-12T07:52:55+00:00" }, { "id": "ec4e03c2d21745b6ac2a166d23107456", "sender": "bitcoin-git", "payload": "[bitcoin] fanquake closed pull request #18095: Fix crashes and infinite loop in ListWalletDir() (master...master) https://github.com/bitcoin/bitcoin/pull/18095", "action": false, "timestamp": "2020-11-12T08:04:33+00:00" }, { "id": "b08e8d20b1984f468b50be9d776cd240", "sender": "bitcoin-git", "payload": "[bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/c2d8ba6265a4...bcd142e479fa", "action": false, "timestamp": "2020-11-12T08:34:50+00:00" }, { "id": "40e871a307944cb18fd41ecb78b37c83", "sender": "bitcoin-git", "payload": "bitcoin/master c82336c fanquake: Remove references to CreateWalletFromFile", "action": false, "timestamp": "2020-11-12T08:34:50+00:00" }, { "id": "77f0683ae8504bb4af3b43216da1141a", "sender": "bitcoin-git", "payload": "bitcoin/master bcd142e MarcoFalke: Merge #20285: Remove references to CreateWalletFromFile", "action": false, "timestamp": "2020-11-12T08:34:51+00:00" }, { "id": "591bd7286a3b49d996fc146610b1450e", "sender": "bitcoin-git", "payload": "[bitcoin] MarcoFalke merged pull request #20285: Remove references to CreateWalletFromFile (master...createwalletfromfilenomore) https://github.com/bitcoin/bitcoin/pull/20285", "action": false, "timestamp": "2020-11-12T08:35:09+00:00" }, { "id": "5fe450e4352d470883fbed435dc79293", "sender": "bitcoin-git", "payload": "[bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/bcd142e479fa...027e51f71517", "action": false, "timestamp": "2020-11-12T08:36:44+00:00" }, { "id": "792be798c6d647c0bc7be706d9c7e0fc", "sender": "bitcoin-git", "payload": "bitcoin/master ee11a41 practicalswift: Avoid signed integer overflow when loading a mempool.dat file with a malfo...", "action": false, "timestamp": "2020-11-12T08:36:44+00:00" }, { "id": "96a5b57b80684889a7f93064be8eb39d", "sender": "bitcoin-git", "payload": "bitcoin/master 027e51f MarcoFalke: Merge #20372: Avoid signed integer overflow when loading a mempool.dat fil...", "action": false, "timestamp": "2020-11-12T08:36:45+00:00" }, { "id": "0952de0507394c4db2764a9461370fa8", "sender": "bitcoin-git", "payload": "[bitcoin] MarcoFalke merged pull request #20372: Avoid signed integer overflow when loading a mempool.dat file with a malformed time field (master...load-mempool-time-integer-overflow) https://github.com/bitcoin/bitcoin/pull/20372", "action": false, "timestamp": "2020-11-12T08:37:04+00:00" }, { "id": "2cbef0afc1ef493e82366003ff4df6a5", "sender": "bitcoin-git", "payload": "[bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/027e51f71517...af8ec1d3e576", "action": false, "timestamp": "2020-11-12T08:59:48+00:00" }, { "id": "6df484b011d647569c3e6205f3331c0f", "sender": "bitcoin-git", "payload": "bitcoin/master 3c77b80 practicalswift: fuzz: Improve coverage for CPartialMerkleTree fuzzing harness", "action": false, "timestamp": "2020-11-12T08:59:48+00:00" }, { "id": "9a2a0a3465724be8b08e054ea2441a74", "sender": "bitcoin-git", "payload": "bitcoin/master af8ec1d MarcoFalke: Merge #20375: fuzz: Improve coverage for CPartialMerkleTree fuzzing harnes...", "action": false, "timestamp": "2020-11-12T08:59:49+00:00" }, { "id": "ceec44c4e56742d6a0c6df0511f2eb41", "sender": "bitcoin-git", "payload": "[bitcoin] MarcoFalke merged pull request #20375: fuzz: Improve coverage for CPartialMerkleTree fuzzing harness (master...fuzzers-2020-11-11) https://github.com/bitcoin/bitcoin/pull/20375", "action": false, "timestamp": "2020-11-12T09:00:08+00:00" }, { "id": "794d5f2a62f94a39acb0c08227c05c43", "sender": "bitcoin-git", "payload": "[bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/af8ec1d3e576...8a486158cbc3", "action": false, "timestamp": "2020-11-12T09:09:06+00:00" }, { "id": "0e3a4c05f5f940958d3a1bfcbab971ed", "sender": "bitcoin-git", "payload": "bitcoin/master 79ef832 practicalswift: tests: Add fuzzing harness for CConnman", "action": false, "timestamp": "2020-11-12T09:09:07+00:00" }, { "id": "25276d6062e1469fa78b1075c8d7b9dd", "sender": "bitcoin-git", "payload": "bitcoin/master 8a48615 MarcoFalke: Merge #20188: tests: Add fuzzing harness for CConnman", "action": false, "timestamp": "2020-11-12T09:09:07+00:00" }, { "id": "0c36a0ef799e4cd69c4cbbc602a8c4ab", "sender": "bitcoin-git", "payload": "[bitcoin] MarcoFalke merged pull request #20188: tests: Add fuzzing harness for CConnman (master...fuzzers-connman) https://github.com/bitcoin/bitcoin/pull/20188", "action": false, "timestamp": "2020-11-12T09:09:26+00:00" }, { "id": "9ce08153af064e2986b346f5a4e053eb", "sender": "bitcoin-git", "payload": "[gui] hebasto closed pull request #127: Replace QMetaObject::invokeMethod with atomic operations (master...201102-queued) https://github.com/bitcoin-core/gui/pull/127", "action": false, "timestamp": "2020-11-12T09:24:18+00:00" }, { "id": "7f29f59c18f04cd093190eb4c5f8f737", "sender": "jonatack", "payload": "Sorry to have been reviewing less than usual the past week. After spending time chopping wood on it, #20305 \"wallet: introduce fee_rate sat/vB param/option\" should be ready for final review for 0.21.", "action": false, "timestamp": "2020-11-12T11:02:43+00:00" }, { "id": "3cdeedcf13944fc4a822ac0ac63397c5", "sender": "gribble", "payload": "https://github.com/bitcoin/bitcoin/issues/20305 | wallet: introduce fee_rate sat/vB param/option by jonatack \u00c3\u0082\u00c2\u00b7 Pull Request #20305 \u00c3\u0082\u00c2\u00b7 bitcoin/bitcoin \u00c3\u0082\u00c2\u00b7 GitHub", "action": false, "timestamp": "2020-11-12T11:02:46+00:00" }, { "id": "6bd746c080084146a84fd5f950364485", "sender": "jonatack", "payload": "Thanks to murch and achow101 for reviewing it so far.", "action": false, "timestamp": "2020-11-12T11:05:15+00:00" }, { "id": "6246513d788a45d6b47349b6e2f7e462", "sender": "bitcoin-git", "payload": "[gui] jonasschnelli merged pull request #120: Fix multiwallet transaction notifications (master...2020-10-fix-transaction-notifications) https://github.com/bitcoin-core/gui/pull/120", "action": false, "timestamp": "2020-11-12T11:24:36+00:00" }, { "id": "5c87c89cd1a2478dbfc09938a7c76942", "sender": "bitcoin-git", "payload": "[bitcoin] jonasschnelli pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/8a486158cbc3...9bd131669729", "action": false, "timestamp": "2020-11-12T11:24:52+00:00" }, { "id": "f85c8ef5e79e4ada95d5b0fc9f8f24a8", "sender": "bitcoin-git", "payload": "bitcoin/master 7b3b230 Jo\u00c3\u0083\u00c2\u00a3o Barbosa: move-only: Define TransactionNotification before TransactionTablePriv", "action": false, "timestamp": "2020-11-12T11:24:53+00:00" }, { "id": "c354d70bfb904ce09b92da349f53c2dc", "sender": "bitcoin-git", "payload": "bitcoin/master 989e579 Jo\u00c3\u0083\u00c2\u00a3o Barbosa: qt: Make transaction notification queue wallet specific", "action": false, "timestamp": "2020-11-12T11:24:54+00:00" }, { "id": "7f01035eaeb84913aaf1c0125df84003", "sender": "bitcoin-git", "payload": "bitcoin/master 2414342 Jo\u00c3\u0083\u00c2\u00a3o Barbosa: refactor: qt: Use vQueueNotifications.clear()", "action": false, "timestamp": "2020-11-12T11:24:55+00:00" }, { "id": "cf48fe3fba434f5599a06b7ba63299d2", "sender": "vasild", "payload": "MarcoFalke: one of the test runs on https://github.com/bitcoin/bitcoin/pull/20284 is timing out, I restarted it 2 times, hmm", "action": false, "timestamp": "2020-11-12T12:30:51+00:00" }, { "id": "47d8e80272454d3ca4fa5ab600010ad3", "sender": "MarcoFalke", "payload": "vasild: Can be ignored", "action": false, "timestamp": "2020-11-12T12:32:03+00:00" }, { "id": "70ad70c84a3e48e5bcb6bc00b2fc4084", "sender": "MarcoFalke", "payload": "Fix would be to rebase on current master, but we don't want that", "action": false, "timestamp": "2020-11-12T12:32:11+00:00" }, { "id": "3cfc7a29b16e4ecabbccd50bfcab3482", "sender": "vasild", "payload": "cirrus is not merging the tip of the PR into latest master before testing, like travis?", "action": false, "timestamp": "2020-11-12T12:33:05+00:00" }, { "id": "9ffff94286974976bca994dbd49a0985", "sender": "MarcoFalke", "payload": "not for the config", "action": false, "timestamp": "2020-11-12T12:37:01+00:00" }, { "id": "0f8fe85a91b8482d8979ed382bdfce5e", "sender": "vasild", "payload": "ok", "action": false, "timestamp": "2020-11-12T12:37:08+00:00" }, { "id": "a7b225d5576d426b9954e0939bee219d", "sender": "MarcoFalke", "payload": "Though the code is merged in the merge_base step", "action": false, "timestamp": "2020-11-12T12:37:10+00:00" }, { "id": "264964d8bbaa471c92fdeaf1dc79f265", "sender": "jonasschnelli", "payload": "MarcoFalke: as for the devision by 0 in wallet.cpp, ... any idea why cirrus is not triggering the UndefinedBehaviorSanitizer error?", "action": false, "timestamp": "2020-11-12T13:23:36+00:00" }, { "id": "89536d6f5c654175938ce16fc5612139", "sender": "queip", "payload": "recommended nomenclature for keys is: SK - secret key, PK - public key, HPK - hash of PK, right?", "action": false, "timestamp": "2020-11-12T13:24:51+00:00" }, { "id": "16085a126fe0452aa095c5fdb057c936", "sender": "MarcoFalke", "payload": "jonasschnelli: Nope. How is your config different from ./ci/test/00_setup_env_native_asan.sh ?", "action": false, "timestamp": "2020-11-12T13:44:47+00:00" }, { "id": "0d82c96e405e4eaf8383ad39f467602c", "sender": "MarcoFalke", "payload": "the ci config is running Ubuntu focal", "action": false, "timestamp": "2020-11-12T13:45:44+00:00" }, { "id": "71f64e863ca44ab4ae65cd28a9e52c50", "sender": "jonasschnelli", "payload": "I guess clang 8 (bbb) vs 10 (cirrus) should not make a difference", "action": false, "timestamp": "2020-11-12T13:47:05+00:00" }, { "id": "45f89269444643219ce52537d228a92b", "sender": "jonasschnelli", "payload": "bbb doesn't set -DARENA_DEBUG", "action": false, "timestamp": "2020-11-12T13:47:35+00:00" }, { "id": "c6d5b1d351de4625acd654308b86da01", "sender": "shesek", "payload": "which block validity rules can be validated by spv clients?", "action": false, "timestamp": "2020-11-12T14:17:04+00:00" }, { "id": "5f4324b967984fa3abdc906b6a33e820", "sender": "shesek", "payload": "the ones I have in mind is checking that the previous block hash connects properly, that the nonce matches the target bits, that the target bits match the last difficulty readjustment, that the difficulty readjustments themselves are valid, and the MTP rule. what more am I missing?", "action": false, "timestamp": "2020-11-12T14:17:16+00:00" }, { "id": "133386eaf12b4e048f7b28515946cacd", "sender": "shesek", "payload": "(I got disconnected and didn't see replies if there were any)", "action": false, "timestamp": "2020-11-12T14:37:42+00:00" }, { "id": "54d43b6e667c48c38171548a643e5b8a", "sender": "jonasschnelli", "payload": "shesek: there where non. :)", "action": false, "timestamp": "2020-11-12T15:18:54+00:00" }, { "id": "197d69a8e1c048c9980351808c6c77af", "sender": "jonasschnelli", "payload": "shesek: looks like you have a relatively complete list of what measures you can take when not validating the chain", "action": false, "timestamp": "2020-11-12T15:20:25+00:00" }, { "id": "9cfb4955900745ecbacfb8a3b91188d0", "sender": "Kiminuo", "payload": "shesek, see http://gnusha.org/bitcoin-core-dev/2020-11-12.log", "action": false, "timestamp": "2020-11-12T15:20:39+00:00" }, { "id": "8de78ed4b82d432cb71dbc9f276f1b41", "sender": "jonasschnelli", "payload": "but I recommend to join #bitcoin-dev", "action": false, "timestamp": "2020-11-12T15:20:41+00:00" }, { "id": "39790b24f4fa46aaa70b5080a14dec58", "sender": "jonasschnelli", "payload": "this channel is for bitcoin core development", "action": false, "timestamp": "2020-11-12T15:20:55+00:00" }, { "id": "032e458b6438491dabc11c5a0e60cf51", "sender": "shesek", "payload": "jonasschnelli, of course, apologies for going off topic, will take notice next time", "action": false, "timestamp": "2020-11-12T15:26:13+00:00" }, { "id": "5a96075c304341babea266694cec0cdb", "sender": "shesek", "payload": "honestly I kinda knew it, its just that #bitcoin-dev appears pretty much dead, all my scrollback there is join/part/quit messages", "action": false, "timestamp": "2020-11-12T15:27:21+00:00" }, { "id": "aa3cea4a08214f4890c5bd308fc9a1bb", "sender": "jonasschnelli", "payload": "shesek: yeah.. maybe also #bitcoin can help", "action": false, "timestamp": "2020-11-12T15:27:58+00:00" }, { "id": "c3e779b463dd4ccab20d534348672cf9", "sender": "jonasschnelli", "payload": "luke-jr have made some thought on that AFAIK.", "action": false, "timestamp": "2020-11-12T15:28:09+00:00" }, { "id": "f03f8f8b49ac4914a9cd45d6836a4ca4", "sender": "jonasschnelli", "payload": "(on your SPV question).", "action": false, "timestamp": "2020-11-12T15:28:15+00:00" }, { "id": "be5344bf00ca47e6861b4f8a2c4e0fda", "sender": "pinheadmz", "payload": "#bitcoin is basically /r/bitcoin", "action": false, "timestamp": "2020-11-12T15:28:21+00:00" }, { "id": "9d238eacf9b54f0f9f1940b7c95f6c6b", "sender": "jonasschnelli", "payload": "Also look at BIP180 (https://github.com/bitcoin/bips/blob/master/bip-0180.mediawiki)", "action": false, "timestamp": "2020-11-12T15:28:23+00:00" }, { "id": "b1509a81fd924aa6a5b44a451ba55f8a", "sender": "pinheadmz", "payload": "shesek ive gotten a lot of great help from #bitcoin-core-pr-reviews", "action": false, "timestamp": "2020-11-12T15:28:31+00:00" }, { "id": "6251b686045542568b64b9f6f4aca809", "sender": "bitcoin-git", "payload": "[bitcoin] practicalswift opened pull request #20377: fuzz: Fill various small fuzzing gaps (master...fuzzers-2020-11-12) https://github.com/bitcoin/bitcoin/pull/20377", "action": false, "timestamp": "2020-11-12T15:29:39+00:00" }, { "id": "da6fd4ad77c14a6a9bd3eef247578419", "sender": "shesek", "payload": "pinheadmz, is off topic considered okay there when there isn't a meeting going on?", "action": false, "timestamp": "2020-11-12T15:29:47+00:00" }, { "id": "b9f9456e176b4b9ba85371a0540bcee5", "sender": "pinheadmz", "payload": "yup, get in there", "action": false, "timestamp": "2020-11-12T15:29:59+00:00" }, { "id": "0f7430da026e4db2b691b4b20ee1764f", "sender": "shesek", "payload": "jonasschnelli, iirc luke-jr ended up finding some issue with his proposed weight fraud proof mechanism, no?", "action": false, "timestamp": "2020-11-12T15:30:27+00:00" }, { "id": "422490a7ab304576ade13d82619fe2b8", "sender": "jonasschnelli", "payload": "probably,.. I haven't followed and can't recall", "action": false, "timestamp": "2020-11-12T15:30:49+00:00" }, { "id": "adab58495ee94771bbac734b7f12241f", "sender": "bitcoin-git", "payload": "[bitcoin] jonasschnelli opened pull request #20378: fix potential devision by 0 (master...2020/11/fix_devnull_wallet) https://github.com/bitcoin/bitcoin/pull/20378", "action": false, "timestamp": "2020-11-12T15:39:21+00:00" }, { "id": "2f2e83ec9f104caca336d9f380fed2e8", "sender": "warren", "payload": "jonasschnelli: btw whatever happened to BIP150/151. Looking at BIPs now I don't see a replacement that supersedes them?", "action": false, "timestamp": "2020-11-12T15:57:54+00:00" }, { "id": "ccd67d598a5c4cceab5df3b66d2dad24", "sender": "jonasschnelli", "payload": "warren: BIP324", "action": false, "timestamp": "2020-11-12T15:58:21+00:00" }, { "id": "f2c4027f76fb4fea9c6ce00aef3bb8ba", "sender": "jonasschnelli", "payload": "We are currently altering the AEAD though (make it simpler)", "action": false, "timestamp": "2020-11-12T15:58:26+00:00" }, { "id": "49ec2d7415964a1686bcac682dd845e0", "sender": "warren", "payload": "URL to draft?", "action": false, "timestamp": "2020-11-12T15:58:55+00:00" }, { "id": "212fa0e5237d4303b9028d63534f341e", "sender": "jonasschnelli", "payload": "https://github.com/bitcoin/bips/pull/1024", "action": false, "timestamp": "2020-11-12T15:58:57+00:00" }, { "id": "0fc34133cdac43cb807a827018fa6b02", "sender": "jonasschnelli", "payload": "discussions also here: https://gist.github.com/jonasschnelli/c530ea8421b8d0e80c51486325587c52#ChaCha20Poly1305Bitcoin_Cipher_Suite", "action": false, "timestamp": "2020-11-12T15:59:08+00:00" }, { "id": "7627d175493347fb8022b672b93e9f7d", "sender": "jonasschnelli", "payload": "we're getting there... I hope it will not take another 4 years. :)", "action": false, "timestamp": "2020-11-12T15:59:35+00:00" }, { "id": "0b105b20f11e443ca00fcef98008cbc8", "sender": "warren", "payload": "thanks just had to point at it as an example", "action": false, "timestamp": "2020-11-12T16:05:01+00:00" }, { "id": "9d3343bd3aa24a5a8091dc2bc53ce0a0", "sender": "bitcoin-git", "payload": "[bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/9bd131669729...0bd4929cd00e", "action": false, "timestamp": "2020-11-12T16:06:46+00:00" }, { "id": "22e64d68f3ea43ae8c9056fae99251b5", "sender": "bitcoin-git", "payload": "bitcoin/master 38ada89 Vasil Dimov: addrman: ensure old versions don't parse peers.dat", "action": false, "timestamp": "2020-11-12T16:06:46+00:00" }, { "id": "08b352abf9944424ba965878a5747537", "sender": "bitcoin-git", "payload": "bitcoin/master 0bd4929 Wladimir J. van der Laan: Merge #20284: addrman: ensure old versions don't parse peers.dat", "action": false, "timestamp": "2020-11-12T16:06:47+00:00" }, { "id": "5dd1218a51e14cd88eb8ca67914096ae", "sender": "bitcoin-git", "payload": "[bitcoin] laanwj merged pull request #20284: addrman: ensure old versions don't parse peers.dat (master...peers_dat_format) https://github.com/bitcoin/bitcoin/pull/20284", "action": false, "timestamp": "2020-11-12T16:07:05+00:00" }, { "id": "a9cd13bbbc00466ca2d72edb5f68e405", "sender": "vasild", "payload": "\\o/", "action": false, "timestamp": "2020-11-12T16:07:15+00:00" }, { "id": "4a5c7cc40b854d0497573861a45f5905", "sender": "jnewbery", "payload": "#proposedmeetingtopic limiting C++17 feature usage (see https://github.com/bitcoin/bitcoin/issues/16684#issuecomment-726214696)", "action": false, "timestamp": "2020-11-12T18:32:16+00:00" }, { "id": "589786e903944b87b6e993854fc22f6c", "sender": "ja", "payload": "luke-jr: rhel 8 and fc30 was patched in february according to https://bugs.launchpad.net/ubuntu/+source/glibc/+bug/1864864/comments/2", "action": false, "timestamp": "2020-11-12T18:41:01+00:00" }, { "id": "d2652ca4b5664d50bddf493c346bdd12", "sender": "ja", "payload": "luke-jr: writing you here since the thread is already getting really long and i don't wanna add a comment which is answering a question already answered in a posted link", "action": false, "timestamp": "2020-11-12T18:41:43+00:00" }, { "id": "35eab4ad110b4161b6e7c012d5d2c5bb", "sender": "provoostenator", "payload": "Looks like Btcd is allergic to sendaddrv2: https://github.com/btcsuite/btcd/issues/1661 (cc roasbeef)", "action": false, "timestamp": "2020-11-12T18:46:46+00:00" }, { "id": "706f86990b6b4634aed6f06557a10923", "sender": "provoostenator", "payload": "(I should try an earlier version just to make sure it's not something else...)", "action": false, "timestamp": "2020-11-12T18:48:49+00:00" }, { "id": "004d5cf31ab94bf08b7c9c3039e70ae1", "sender": "ja", "payload": "provoostenator: is your testing setup public? it would be fun to try and connect all kinds of different versions with each other and draw a matrix :D", "action": false, "timestamp": "2020-11-12T18:53:42+00:00" }, { "id": "20cd7951e27547299b8a8f4a8eecf1d8", "sender": "provoostenator", "payload": "It connects fine as of a slightly older commit 1d3ec2a1fda7446323786a52da1fd109c01aa6fb", "action": false, "timestamp": "2020-11-12T18:54:07+00:00" }, { "id": "588df3a288f444b39e1ab863b92e76fc", "sender": "provoostenator", "payload": "ja: it's not unfortunately; you'll have to spin up your own btcd and core machine somewhere.", "action": false, "timestamp": "2020-11-12T18:54:48+00:00" }, { "id": "8c60946d74db4de1b1d7fb4bf9a22771", "sender": "ja", "payload": "i see so many booleans, and i am suspicious. for example https://github.com/bitcoin/bitcoin/commit/1d3ec2a1fda7446323786a52da1fd109c01aa6fb", "action": false, "timestamp": "2020-11-12T19:00:30+00:00" }, { "id": "1c69c43c74874fe795303ae721facd72", "sender": "ja", "payload": "i understand that it would be too much having a custom type for every single case", "action": false, "timestamp": "2020-11-12T19:00:47+00:00" }, { "id": "d407714c29584515ab6a91195dccae86", "sender": "hebasto", "payload": "meeting?", "action": false, "timestamp": "2020-11-12T19:01:02+00:00" }, { "id": "27ebd7ee4b5b4bf8a46936e145def09f", "sender": "achow101", "payload": "meeting?", "action": false, "timestamp": "2020-11-12T19:01:04+00:00" }, { "id": "58e1fdb4e375438ab7dd79e0f88283b0", "sender": "wumpus", "payload": "#startmeeting", "action": false, "timestamp": "2020-11-12T19:01:12+00:00" }, { "id": "6ac03e2b1e9245768b919096e5002b15", "sender": "core-meetingbot", "payload": "Meeting started Thu Nov 12 19:01:12 2020 UTC. The chair is wumpus. Information about MeetBot at https://bitcoin.jonasschnelli.ch/ircmeetings.", "action": false, "timestamp": "2020-11-12T19:01:13+00:00" }, { "id": "2dfb18cd567b44b3991d1db3e1b96603", "sender": "core-meetingbot", "payload": "Available commands: action commands idea info link nick", "action": false, "timestamp": "2020-11-12T19:01:13+00:00" }, { "id": "20f029b486924713ac962a001962bb6f", "sender": "jnewbery", "payload": "hi", "action": false, "timestamp": "2020-11-12T19:01:17+00:00" }, { "id": "767cb56370da4f34bdece84ab8b54c32", "sender": "amiti", "payload": "hi", "action": false, "timestamp": "2020-11-12T19:01:19+00:00" }, { "id": "e5458e2d99fb4082be365c956bb15f64", "sender": "jonatack", "payload": "hi", "action": false, "timestamp": "2020-11-12T19:01:19+00:00" }, { "id": "2812aecd86cd4e039b36d7e61ebe94cd", "sender": "jonasschnelli", "payload": "hi", "action": false, "timestamp": "2020-11-12T19:01:19+00:00" }, { "id": "9458d7b60cda4eaba6462d657ea79a0e", "sender": "emzy", "payload": "hi", "action": false, "timestamp": "2020-11-12T19:01:20+00:00" }, { "id": "fe71d405b5f148618fe6a0ed7151c165", "sender": "luke-jr", "payload": "hi", "action": false, "timestamp": "2020-11-12T19:01:20+00:00" }, { "id": "8d614558fec047e1960c8f5391024981", "sender": "hebasto", "payload": "hi", "action": false, "timestamp": "2020-11-12T19:01:22+00:00" }, { "id": "3a0432bd2e3b4c3682e7f002dfd87429", "sender": "achow101", "payload": "hi", "action": false, "timestamp": "2020-11-12T19:01:24+00:00" }, { "id": "c609a5f0da4c44e6b19d9989aff41db6", "sender": "provoostenator", "payload": "ja: that;s just an arbitary commit, nothing to do with the issue", "action": false, "timestamp": "2020-11-12T19:01:25+00:00" }, { "id": "3c5cb544a49b4739ba6dd82053397296", "sender": "provoostenator", "payload": "hi", "action": false, "timestamp": "2020-11-12T19:01:26+00:00" }, { "id": "975eba656f5a4dfca4f159f36a436050", "sender": "meshcollider", "payload": "hi", "action": false, "timestamp": "2020-11-12T19:01:33+00:00" }, { "id": "ecdfca7697e74bb3804290be93ee1ef5", "sender": "ja", "payload": "provoostenator: i would explain if there wasn't a meeting now ;)", "action": false, "timestamp": "2020-11-12T19:01:36+00:00" }, { "id": "e61f3048a42e48d59d855c72bdb11181", "sender": "fanquake", "payload": "hi", "action": false, "timestamp": "2020-11-12T19:01:44+00:00" }, { "id": "e902a78a53f84e5c9c142d21a265a09b", "sender": "wumpus", "payload": "#bitcoin-core-dev Meeting: achow101 aj amiti ariard bluematt cfields Chris_Stewart_5 digi_james dongcarl elichai2 emilengler fanquake fjahr gleb gmaxwell gwillen hebasto instagibbs jamesob jb55 jeremyrubin jl2012 jnewbery jonasschnelli jonatack jtimon kallewoof kanzure kvaciral lightlike luke-jr maaku marcofalke meshcollider michagogo moneyball morcos nehan NicolasDorier paveljanik", "action": false, "timestamp": "2020-11-12T19:01:48+00:00" }, { "id": "14ce0805077b40779dd00841cce2024a", "sender": "wumpus", "payload": "petertodd phantomcircuit promag provoostenator ryanofsky sdaftuar sipa vasild wumpus", "action": false, "timestamp": "2020-11-12T19:01:50+00:00" }, { "id": "400e45a8d7774adea817d8036b26c346", "sender": "fjahr", "payload": "hi", "action": false, "timestamp": "2020-11-12T19:02:25+00:00" }, { "id": "20b1a66462b240368e302c3e60a1251e", "sender": "wumpus", "payload": "one proposed meeting topic: limiting C++17 feature usage (jnewbery)", "action": false, "timestamp": "2020-11-12T19:02:39+00:00" }, { "id": "873acfee59a149cd93dab19976d03301", "sender": "wumpus", "payload": "I guess the most pressing topic right now is the 0.21.0rc1 release", "action": false, "timestamp": "2020-11-12T19:03:11+00:00" }, { "id": "d06758de8ddf451c9c13bd3098a5a6cc", "sender": "wumpus", "payload": "at least there's only three PRs left on the milestone: https://github.com/bitcoin/bitcoin/pulls?q=is%3Aopen+is%3Apr+milestone%3A0.21.0", "action": false, "timestamp": "2020-11-12T19:03:41+00:00" }, { "id": "faaa9b27063144cda91325ecb8a7b31a", "sender": "provoostenator", "payload": "I'd like to get this in the release if possible: https://github.com/bitcoin-core/gui/pull/96", "action": false, "timestamp": "2020-11-12T19:03:57+00:00" }, { "id": "3b656427af764e0f80a004991ac17a75", "sender": "wumpus", "payload": "jonasschnelli's last minute fix seems trivial", "action": false, "timestamp": "2020-11-12T19:04:00+00:00" }, { "id": "f749b48d6dcd4e25aa200a4f66a280b7", "sender": "jonasschnelli", "payload": "yes. can be merged I guess", "action": false, "timestamp": "2020-11-12T19:04:10+00:00" }, { "id": "bbb674ceab124501abc35e950eaf72fd", "sender": "provoostenator", "payload": "I reverted the string changes, so it's pretty simple now.", "action": false, "timestamp": "2020-11-12T19:04:11+00:00" }, { "id": "8de4e6d9cc4a4e7bb43d5e6b0c58c7fb", "sender": "hebasto", "payload": "will review it tonight", "action": false, "timestamp": "2020-11-12T19:04:45+00:00" }, { "id": "25fc22c9e94e4fad98c17a230aff7978", "sender": "wumpus", "payload": "provoostenator: ok!", "action": false, "timestamp": "2020-11-12T19:04:58+00:00" }, { "id": "ef6a4d291f41405c8db698176a267de1", "sender": "provoostenator", "payload": "thx", "action": false, "timestamp": "2020-11-12T19:05:05+00:00" }, { "id": "6681bf67f74d44ef897ee73a3cd43aaf", "sender": "bitcoin-git", "payload": "[bitcoin] practicalswift opened pull request #20379: tests: Remove no longer needed UBSan suppression (float divide-by-zero in validation.cpp) (master...remove-ubsan-suppressions) https://github.com/bitcoin/bitcoin/pull/20379", "action": false, "timestamp": "2020-11-12T19:05:05+00:00" }, { "id": "ca1c0348baf649038f19e6fb88e01174", "sender": "jonasschnelli", "payload": "I'll look into it,... but was under the impression that we had code freeze already", "action": false, "timestamp": "2020-11-12T19:05:09+00:00" }, { "id": "4ab60419bd5d44c7a0d33d3714b7325a", "sender": "wumpus", "payload": "yes, it's definitely too late for string changes", "action": false, "timestamp": "2020-11-12T19:05:10+00:00" }, { "id": "94c27c4342a3408a8479a3a59882ded0", "sender": "sipa", "payload": "hi", "action": false, "timestamp": "2020-11-12T19:05:21+00:00" }, { "id": "58a2e5a50ef3413da177c09430336480", "sender": "provoostenator", "payload": "The biggest thing that PR does is not recommend encryptino by default", "action": false, "timestamp": "2020-11-12T19:05:36+00:00" }, { "id": "c5bebd37307c4c03827bea11066d1a5c", "sender": "provoostenator", "payload": "Which just seems a recipe for tears for brand new users.", "action": false, "timestamp": "2020-11-12T19:05:51+00:00" }, { "id": "10a7ccf9709442fcbd80ceba6aeaceb9", "sender": "wumpus", "payload": "I agree with that, encryption is torture for new users", "action": false, "timestamp": "2020-11-12T19:06:17+00:00" }, { "id": "03a0547bab7f4ee7b928a72074516d14", "sender": "sipa", "payload": "which PR are you talking about?", "action": false, "timestamp": "2020-11-12T19:06:22+00:00" }, { "id": "a70c6bc0874d46a9b5c6026f52824f7d", "sender": "hebasto", "payload": "https://github.com/bitcoin-core/gui/pull/96", "action": false, "timestamp": "2020-11-12T19:06:35+00:00" }, { "id": "4a4e1989a59c48bf898eec906a6646c6", "sender": "hebasto", "payload": "sipa: ^", "action": true, "timestamp": "2020-11-12T19:07:04+00:00" }, { "id": "c78a955108354a4ea8dc93814a14befc", "sender": "wumpus", "payload": "in any case please help review the last remaining PRs for 0.21: https://github.com/bitcoin/bitcoin/pulls?q=is%3Aopen+is%3Apr+milestone%3A0.21.0 and https://github.com/bitcoin-core/gui/milestone/1", "action": false, "timestamp": "2020-11-12T19:08:55+00:00" }, { "id": "6856d3a1d32d4d7aba39dabd5d5b6a14", "sender": "wumpus", "payload": "#20305 and #18836 are the big ones", "action": false, "timestamp": "2020-11-12T19:10:06+00:00" }, { "id": "540ac5598a624413924664d23e3c65e1", "sender": "gribble", "payload": "https://github.com/bitcoin/bitcoin/issues/20305 | wallet: introduce fee_rate sat/vB param/option by jonatack \u00c3\u0082\u00c2\u00b7 Pull Request #20305 \u00c3\u0082\u00c2\u00b7 bitcoin/bitcoin \u00c3\u0082\u00c2\u00b7 GitHub", "action": false, "timestamp": "2020-11-12T19:10:09+00:00" }, { "id": "ea3a66e5f514413496730b812316f491", "sender": "gribble", "payload": "https://github.com/bitcoin/bitcoin/issues/18836 | wallet: upgradewallet fixes and additional tests by achow101 \u00c3\u0082\u00c2\u00b7 Pull Request #18836 \u00c3\u0082\u00c2\u00b7 bitcoin/bitcoin \u00c3\u0082\u00c2\u00b7 GitHub", "action": false, "timestamp": "2020-11-12T19:10:12+00:00" }, { "id": "b2a92e9cfca844b1a8b5b3182bcd1c16", "sender": "luke-jr", "payload": "20305 should be noted to break RPC compatibility, but in a way that I and others feel is okay", "action": false, "timestamp": "2020-11-12T19:10:47+00:00" }, { "id": "23d075f9ea9743e48b1af64360862206", "sender": "luke-jr", "payload": "if anyone objects, they should speak up", "action": false, "timestamp": "2020-11-12T19:10:57+00:00" }, { "id": "5e3880f92e1448d89edf48fc7c40ddb3", "sender": "luke-jr", "payload": "(see details on PR comments)", "action": false, "timestamp": "2020-11-12T19:11:13+00:00" }, { "id": "073bd3fa56cc4cc2875eb7e5a5c38c6c", "sender": "wumpus", "payload": "versus 0.20? or just versus previous intermediate master releases?", "action": false, "timestamp": "2020-11-12T19:11:13+00:00" }, { "id": "1f2a362a9f3340018e5c95424df9bd43", "sender": "wumpus", "payload": "okay", "action": false, "timestamp": "2020-11-12T19:11:16+00:00" }, { "id": "6af90a7007854e4891f2f9df080aecc3", "sender": "luke-jr", "payload": "wumpus: 0.20", "action": false, "timestamp": "2020-11-12T19:11:19+00:00" }, { "id": "b8a45196c3124b60a4f54917a4c530c5", "sender": "jonatack", "payload": "(for bumpfee)", "action": false, "timestamp": "2020-11-12T19:11:21+00:00" }, { "id": "d27e1fcb08fb42d8b09f8908e426ddf4", "sender": "luke-jr", "payload": "it's complex to explain, but IMO a reasonable concession", "action": false, "timestamp": "2020-11-12T19:11:32+00:00" }, { "id": "17902fd43f8c484fb80f77f160e35c32", "sender": "MarcoFalke", "payload": "That certainly needs release notes, no?", "action": false, "timestamp": "2020-11-12T19:11:42+00:00" }, { "id": "99c9b0d5207345aeb407162fc79181ff", "sender": "jonatack", "payload": "relevant comment by murch on that: \"uckily, this is very benign. In the worst case, someone is going to get upped to the minRelayTxFee silently and sends at 1 sat/vB. Since RBF is on by default, they should be able bump when they notice. +1\"", "action": false, "timestamp": "2020-11-12T19:11:52+00:00" }, { "id": "782db29563e74cad94b80d3279336e3c", "sender": "jonatack", "payload": "https://github.com/bitcoin/bitcoin/pull/20305#discussion_r520231413", "action": false, "timestamp": "2020-11-12T19:12:06+00:00" }, { "id": "42860c6482124ea3b789c34c987bd786", "sender": "luke-jr", "payload": "MarcoFalke: agreed", "action": false, "timestamp": "2020-11-12T19:12:24+00:00" }, { "id": "5f061210108c437887d15ba0d0ec9716", "sender": "jonatack", "payload": "MarcoFalke: yes, definitely, we can edit the wiki.", "action": false, "timestamp": "2020-11-12T19:12:39+00:00" }, { "id": "f12ca7602de543938195ed3ec2fa90e2", "sender": "luke-jr", "payload": "most likely trying to use the old interface will just error; worst case, it's fixable", "action": false, "timestamp": "2020-11-12T19:13:31+00:00" }, { "id": "72f68dc7f824402785a5204f77eb45d0", "sender": "wumpus", "payload": "ok", "action": false, "timestamp": "2020-11-12T19:14:03+00:00" }, { "id": "ae50bdc936504e24bd5f01469efe47de", "sender": "jonatack", "payload": "yes, for the bumpfee change, there's a 1e5 times difference in units in the downward direction", "action": false, "timestamp": "2020-11-12T19:14:15+00:00" }, { "id": "ca9086e02fed415f94ef50dd86858100", "sender": "wumpus", "payload": "yeah downward is the only acceptable direction", "action": false, "timestamp": "2020-11-12T19:14:52+00:00" }, { "id": "4b95b313457b4f869926e23623686910", "sender": "jonatack", "payload": "also added a * WARNING * in the help", "action": false, "timestamp": "2020-11-12T19:15:00+00:00" }, { "id": "38f52ebcb33148ada95a7bf015306036", "sender": "luke-jr", "payload": "oh. just thought of a possible danger", "action": false, "timestamp": "2020-11-12T19:15:18+00:00" }, { "id": "a2faea05b99145fdbc8e04942250fb56", "sender": "luke-jr", "payload": "if someone uses the new interface, with an old version", "action": false, "timestamp": "2020-11-12T19:15:29+00:00" }, { "id": "a589fa47d155456584f2ebd3171d004a", "sender": "provoostenator", "payload": "luke-jr: that's dangerous in general, given some of the other fixes...", "action": false, "timestamp": "2020-11-12T19:16:06+00:00" }, { "id": "5c53bee28e6d477dad39873cd2baedaf", "sender": "luke-jr", "payload": "provoostenator: ?", "action": false, "timestamp": "2020-11-12T19:16:14+00:00" }, { "id": "972f95a0b8a84dce9a312347ed0cee44", "sender": "luke-jr", "payload": "I wonder if the magnitude would trigger the absurd fee warning", "action": false, "timestamp": "2020-11-12T19:16:39+00:00" }, { "id": "68a3cdebe7d1449ebe5343dd686ab684", "sender": "provoostenator", "payload": "#16257", "action": false, "timestamp": "2020-11-12T19:16:46+00:00" }, { "id": "4cf1728317e94314b3669eff01a24eac", "sender": "gribble", "payload": "https://github.com/bitcoin/bitcoin/issues/16257 | [wallet] abort when attempting to fund a transaction above -maxtxfee by Sjors \u00c3\u0082\u00c2\u00b7 Pull Request #16257 \u00c3\u0082\u00c2\u00b7 bitcoin/bitcoin \u00c3\u0082\u00c2\u00b7 GitHub", "action": false, "timestamp": "2020-11-12T19:16:50+00:00" }, { "id": "3693c882e72442069d9a24d9fcd6dac0", "sender": "sipa", "payload": "the default absurd fee threshold is 0.1 BTC or so, no?", "action": false, "timestamp": "2020-11-12T19:17:01+00:00" }, { "id": "51b78759769445e6a9442dc3b4833d90", "sender": "jonatack", "payload": "yes iirc", "action": false, "timestamp": "2020-11-12T19:17:22+00:00" }, { "id": "ab433f6d936d45b587eb98944848d501", "sender": "jonatack", "payload": "per the tests i've added in any case", "action": false, "timestamp": "2020-11-12T19:17:35+00:00" }, { "id": "37741667b0c64efcade40b44e8c87a5c", "sender": "queip", "payload": "so it's decided to go with vB? WU was popular last year", "action": false, "timestamp": "2020-11-12T19:17:41+00:00" }, { "id": "0935af5cde77495c9ad30264e1c6267e", "sender": "provoostenator", "payload": "People are still making payments with 0.1 BTC fees FWIW, quite often", "action": false, "timestamp": "2020-11-12T19:17:56+00:00" }, { "id": "229ade56d6a04cbbab4ab900d4de5789", "sender": "sipa", "payload": "everyone uses sat/vB, afaik", "action": false, "timestamp": "2020-11-12T19:18:08+00:00" }, { "id": "ee310b4685f94b209aaf2f226d9a00c1", "sender": "wumpus", "payload": "`if there's any risk of it causing people to overpay fees it's unacceptable risk", "action": false, "timestamp": "2020-11-12T19:18:24+00:00" }, { "id": "3163ec51e7d3430b8f805afb9cf40018", "sender": "sipa", "payload": "i think WU is dangerous because it can result in a 4x factor off, which isn't enough to be likely to trigger other warning mechanisms", "action": false, "timestamp": "2020-11-12T19:18:55+00:00" }, { "id": "b1d42726d818437d97cd9473e00fc72a", "sender": "jonatack", "payload": "queip: recent twitter poll showed a 20 to 1 preference for sat/vB over BTC/kB, wasn't an option though", "action": false, "timestamp": "2020-11-12T19:19:00+00:00" }, { "id": "f72f9b3ca64d4a41b94216c0bc7e86bf", "sender": "jonatack", "payload": "*WU wasn't an option in the poll tho", "action": false, "timestamp": "2020-11-12T19:19:18+00:00" }, { "id": "065625d38cc645d3ab7a375517956821", "sender": "luke-jr", "payload": "sipa: well, nothing is using sat/vB yet.. so it's a factor of 1e5/4", "action": false, "timestamp": "2020-11-12T19:19:21+00:00" }, { "id": "d6820388115748c3a0a534ce7d136133", "sender": "sipa", "payload": "luke-jr: almost every fee estimation website, most block explorers, ... do", "action": false, "timestamp": "2020-11-12T19:19:46+00:00" }, { "id": "67fe101568ae46109d4736224a8270e8", "sender": "wumpus", "payload": "so is that the case for #20305?", "action": false, "timestamp": "2020-11-12T19:19:54+00:00" }, { "id": "6b27bf1d12614bd3a4041902f961b8c6", "sender": "gribble", "payload": "https://github.com/bitcoin/bitcoin/issues/20305 | wallet: introduce fee_rate sat/vB param/option by jonatack \u00c3\u0082\u00c2\u00b7 Pull Request #20305 \u00c3\u0082\u00c2\u00b7 bitcoin/bitcoin \u00c3\u0082\u00c2\u00b7 GitHub", "action": false, "timestamp": "2020-11-12T19:19:56+00:00" }, { "id": "f55cfb9843344a948fd9103c12de6585", "sender": "meshcollider", "payload": "provoostenator: it's the wrong direction, even if they intended to send at 1btc, they'd end up at 1sat/vB", "action": false, "timestamp": "2020-11-12T19:20:07+00:00" }, { "id": "f0800e37c21340bf8c82d4b5cbe05a89", "sender": "michaelfolkson", "payload": "Slight overpayment -> Risk of slight monetary loss. Slight underpayment -> Risk of not being propagated? I guess it depends on how high the original fee was", "action": false, "timestamp": "2020-11-12T19:20:56+00:00" }, { "id": "98636a59321d47f58f1973d441f835a4", "sender": "luke-jr", "payload": "minimum realistic bumpfee is probably 2sat/vB?", "action": false, "timestamp": "2020-11-12T19:21:02+00:00" }, { "id": "b61bf96aada2459b9d5012aa3a9a17b8", "sender": "meshcollider", "payload": "I don't think there's ever any risk of overpayment here", "action": false, "timestamp": "2020-11-12T19:21:17+00:00" }, { "id": "e0f69e73f1294e9b91a1ed63c6c81e31", "sender": "luke-jr", "payload": "which at BTC/kB is 2 BTC/kB, over the absurd fee cutoff", "action": false, "timestamp": "2020-11-12T19:21:19+00:00" }, { "id": "515c2431057448bf93ba19bd5ed09936", "sender": "jonatack", "payload": "luke-jr: min incremental fee is 1 sat/vB", "action": false, "timestamp": "2020-11-12T19:21:26+00:00" }, { "id": "aafc4253f0fe42b9ae367040e12f3c27", "sender": "sipa", "payload": "luke-jr: good point", "action": false, "timestamp": "2020-11-12T19:21:26+00:00" }, { "id": "d800da637fdb4fcd8385c19ebfb24fc9", "sender": "wumpus", "payload": "underpayment is at least better, could always bump again", "action": false, "timestamp": "2020-11-12T19:21:35+00:00" }, { "id": "b46237d66e844d4cb7ddb6c35a0b89cc", "sender": "luke-jr", "payload": "so I *think* the magnitude is sufficient to avoid any loss in either direction", "action": false, "timestamp": "2020-11-12T19:21:52+00:00" }, { "id": "61fec999d4db44c89732b375228d0bd3", "sender": "luke-jr", "payload": "which only leaves the WU question - but I don't think we have time to do another poll", "action": false, "timestamp": "2020-11-12T19:22:14+00:00" }, { "id": "f2ca4049fb854c6d8564a5b532d78e72", "sender": "luke-jr", "payload": "if people prefer WU and have to divide by 4, it's not the end of the world anywaty", "action": false, "timestamp": "2020-11-12T19:22:25+00:00" }, { "id": "ffcef04aa09547c8a3b695b73fc3bc09", "sender": "jonatack", "payload": "AFAIK sats seem to be far and away what people want", "action": false, "timestamp": "2020-11-12T19:22:43+00:00" }, { "id": "2658bdf01fdf4857885e9d461be34195", "sender": "queip", "payload": "ok just was asking", "action": false, "timestamp": "2020-11-12T19:22:59+00:00" }, { "id": "b7ea7a202ddb4ddbae95a11d06eb86d8", "sender": "michaelfolkson", "payload": "+1", "action": false, "timestamp": "2020-11-12T19:22:59+00:00" }, { "id": "d24d267617f840b3beef5ac0cb5c1ac1", "sender": "luke-jr", "payload": "jonatack: well, I assume it'd be sats/WU in that case", "action": false, "timestamp": "2020-11-12T19:23:01+00:00" }, { "id": "b21aa432961f4a1b8746339e925dba08", "sender": "jonatack", "payload": "found the poll: https://twitter.com/jonatack/status/1318890833131823104?s=20", "action": false, "timestamp": "2020-11-12T19:23:05+00:00" }, { "id": "cb91f9ea79f3445c8b91cbb230ec55cb", "sender": "emzy", "payload": "+1", "action": false, "timestamp": "2020-11-12T19:23:06+00:00" }, { "id": "534cfd79435440f1808b69d3b47f6091", "sender": "sipa", "payload": "i haven't paid attention to the actual solution we're going for now... but would it be easy to add more units later?", "action": false, "timestamp": "2020-11-12T19:24:13+00:00" }, { "id": "9c9f8be5aa734a18b12782e0d9835315", "sender": "luke-jr", "payload": "sipa: no", "action": false, "timestamp": "2020-11-12T19:24:24+00:00" }, { "id": "8245d845eb5647beab1b971e24429d7b", "sender": "meshcollider", "payload": "I don't think it's worth bikeshedding over but I prefer sats/vB honestly", "action": false, "timestamp": "2020-11-12T19:24:28+00:00" }, { "id": "863aa0ce3bbf49d8bb39de20f28e5bdd", "sender": "wumpus", "payload": "no, I think it's better to settle on one unit and one unit only for RPC", "action": false, "timestamp": "2020-11-12T19:24:37+00:00" }, { "id": "af37d6bd30de4d04bf0364f487234101", "sender": "luke-jr", "payload": "sipa: this removes all unit choice, and just uses sat/vB", "action": false, "timestamp": "2020-11-12T19:24:44+00:00" }, { "id": "8229843f4ef84e78bc1acebb078f99c8", "sender": "meshcollider", "payload": "sipa: we're trying to make it simpler :)", "action": false, "timestamp": "2020-11-12T19:24:47+00:00" }, { "id": "e731a20b152349cda7a01f6af9773b42", "sender": "sipa", "payload": "luke-jr: how does that not break compatibility (as earlier releases all use BTC/kvB)?", "action": false, "timestamp": "2020-11-12T19:25:07+00:00" }, { "id": "1746f4b0e7fa4973b382bdffe93ec852", "sender": "wumpus", "payload": "adding a choice of units shouldn't be necesasry, it's a programmatic interface", "action": false, "timestamp": "2020-11-12T19:25:08+00:00" }, { "id": "8c6c833eb85846858018d2f4ffbaffed", "sender": "jonatack", "payload": "right, so people don't have to pass in a choice of units with the estimate_mode param", "action": false, "timestamp": "2020-11-12T19:25:18+00:00" }, { "id": "a816b03d59974193b38f6cac356993a2", "sender": "wumpus", "payload": "just standardize something \u00c3\u00a2\u00c2\u0080\u00c2\u00a6", "action": false, "timestamp": "2020-11-12T19:25:24+00:00" }, { "id": "fd1a433642dd4ffda6ea8816041b0074", "sender": "luke-jr", "payload": "sipa: the field name is different for everything except bumpfee", "action": false, "timestamp": "2020-11-12T19:25:26+00:00" }, { "id": "e915120e54bf47fa871947b730eca747", "sender": "sipa", "payload": "feel free to tell me to just go read the PR", "action": false, "timestamp": "2020-11-12T19:25:27+00:00" }, { "id": "ab332a65998946b383e7656d85061795", "sender": "luke-jr", "payload": "sipa: and bumpfee is protected by the magnitude", "action": false, "timestamp": "2020-11-12T19:25:36+00:00" }, { "id": "385f280824e24b3eaf014a60cf7f22a8", "sender": "luke-jr", "payload": "sipa: the old interface to bumpfee+fee_rate won't *work*, but it won't do damage either", "action": false, "timestamp": "2020-11-12T19:25:56+00:00" }, { "id": "1cc082f72f27412dbd743c2ab88c5c46", "sender": "sipa", "payload": "ok", "action": false, "timestamp": "2020-11-12T19:26:26+00:00" }, { "id": "5482ea08b32f4e77b2a6f7ed7e90de42", "sender": "luke-jr", "payload": "(other RPCs used \"feeRate\" instead of \"fee_rate\")", "action": false, "timestamp": "2020-11-12T19:26:36+00:00" }, { "id": "15402647e9594a5db3e2a5925b0e4cf6", "sender": "luke-jr", "payload": "IIRC only in options objects, so no positional mess (someone should double-check this)", "action": false, "timestamp": "2020-11-12T19:27:07+00:00" }, { "id": "27aa3a6a0751414ba8218d85eb2bbddb", "sender": "jonatack", "payload": "yes. (in fundrawtxn and walletcreatefundedpsbt only)", "action": false, "timestamp": "2020-11-12T19:27:26+00:00" }, { "id": "ed15cb93bdc942ba8118f828dc8d5d8f", "sender": "jonatack", "payload": "feeRate is only an arg, not an option, which we can deprecate as soon as people judge feasible", "action": false, "timestamp": "2020-11-12T19:28:20+00:00" }, { "id": "f6a5bd95a4ab48e7b7e9d20d74d5901d", "sender": "jonatack", "payload": "it's in BTC/kB", "action": false, "timestamp": "2020-11-12T19:28:31+00:00" }, { "id": "cc7a59464d0b448b87ac6222f8ad833d", "sender": "wumpus", "payload": "next topic?", "action": false, "timestamp": "2020-11-12T19:30:59+00:00" }, { "id": "54859396fdac4b119fdea5bfcb6e7b24", "sender": "jonatack", "payload": "(fwiw that PR adds a fair number of RPCExamples in send and sendtoaddress to help people use it)", "action": false, "timestamp": "2020-11-12T19:31:07+00:00" }, { "id": "106ad37171744ece922173ad1f53b021", "sender": "michaelfolkson", "payload": "wumpus: yup", "action": false, "timestamp": "2020-11-12T19:31:41+00:00" }, { "id": "104109163c494b09b4f8ff60f3698f2e", "sender": "wumpus", "payload": "#topic limiting C++17 feature usage (jnewbery)", "action": false, "timestamp": "2020-11-12T19:32:20+00:00" }, { "id": "a7102bd23d8a49d483f9c740161e3487", "sender": "core-meetingbot", "payload": "topic: limiting C++17 feature usage (jnewbery)", "action": false, "timestamp": "2020-11-12T19:32:20+00:00" }, { "id": "0a090faa7a59415eaf541d584054ac3b", "sender": "jnewbery", "payload": "hi", "action": false, "timestamp": "2020-11-12T19:32:38+00:00" }, { "id": "58f5293e01ad42439d8d579e6e95c407", "sender": "wumpus", "payload": "link: https://github.com/bitcoin/bitcoin/issues/16684#issuecomment-726214696", "action": false, "timestamp": "2020-11-12T19:32:39+00:00" }, { "id": "9fdc5a3493044956b5c6dbccfe62016f", "sender": "jnewbery", "payload": "As a reminder, our plan for C++17 is here: https://github.com/bitcoin/bitcoin/issues/16684", "action": false, "timestamp": "2020-11-12T19:32:48+00:00" }, { "id": "078df6e10f704fea8c80088a2f7504db", "sender": "jnewbery", "payload": "Once we branch v0.21 (imminently), we'll be able to start using c++14 and c++17 features.", "action": false, "timestamp": "2020-11-12T19:32:56+00:00" }, { "id": "559b389a229143ce8ecd31100b24cf77", "sender": "jnewbery", "payload": "I expect lots of people have their favorite features that they want to start using.", "action": false, "timestamp": "2020-11-12T19:33:02+00:00" }, { "id": "94ad7b3eec0f43fb8fa04ea93c6dc2b9", "sender": "jnewbery", "payload": "I was wondering whether we should have a project-wide policy on which new features we should allow, or if there are any we should disallow in the project for now.", "action": false, "timestamp": "2020-11-12T19:33:11+00:00" }, { "id": "72cd3f5aba4f446d82cb26972c4fbf94", "sender": "jnewbery", "payload": "Prompted by https://github.com/bitcoin/bitcoin/issues/16684#issuecomment-726214696, where Cory ran into a bug in glibc when using std::shared_mutex.", "action": false, "timestamp": "2020-11-12T19:33:16+00:00" }, { "id": "7d75a2c14f5a4bf3916988a2da177453", "sender": "wumpus", "payload": "so there's a specific feature that triggers a libc bug?", "action": false, "timestamp": "2020-11-12T19:33:17+00:00" }, { "id": "749e68ddbb834342a33fbc3eba05a717", "sender": "jnewbery", "payload": "So std::shared_mutex is one that I think we should avoid, at least until we better understand the bug, but are there others?", "action": false, "timestamp": "2020-11-12T19:33:26+00:00" }, { "id": "cbbfb34d82984fdc82a51cd387849561", "sender": "MarcoFalke", "payload": "std::fs", "action": false, "timestamp": "2020-11-12T19:34:06+00:00" }, { "id": "1d73fb5881424da0877cda624b2d9b16", "sender": "wumpus", "payload": "I'd rather not do that, that for 0.22 full C++17 is allowed, but that is a good reason to disallow that one for now", "action": false, "timestamp": "2020-11-12T19:34:08+00:00" }, { "id": "14362f5aa331436fb58afd8180832f9d", "sender": "hebasto", "payload": "or define minimum libc with fixed bug?", "action": false, "timestamp": "2020-11-12T19:34:18+00:00" }, { "id": "59fc1fc94b824f5ab64b4875b1225938", "sender": "sipa", "payload": "i vaguely remember some issues with trying to use std::filesystem by someone, but i'm not sure if that was because they weren't familiar enough with the build system, or if there were actual problems with it", "action": false, "timestamp": "2020-11-12T19:34:19+00:00" }, { "id": "0dbd406468684f61b668a4df5a9682b9", "sender": "MarcoFalke", "payload": "We can't use std::fs because LTS versions of operating systems don't ship it", "action": false, "timestamp": "2020-11-12T19:34:40+00:00" }, { "id": "e489014fd4344f49bc0c3bdfb875140d", "sender": "sipa", "payload": "well what's the alternative? does boost::shared_mutex not have the same problem?", "action": false, "timestamp": "2020-11-12T19:34:54+00:00" }, { "id": "f4c56c2a229d43f099aac8f5fa918dc4", "sender": "wumpus", "payload": "every specific exclusion makes it more difficult for new contributors etc", "action": false, "timestamp": "2020-11-12T19:34:58+00:00" }, { "id": "4a50932adad64a609e9ac73c645790ab", "sender": "MarcoFalke", "payload": "sipa: We already use boost::shared_mutex", "action": false, "timestamp": "2020-11-12T19:35:11+00:00" }, { "id": "8d0bc46b1f574429970423fcbe60f69e", "sender": "sipa", "payload": "MarcoFalke: right, my concern is that boost, when compiled in c++17 mode, will just go \"oh the STL provides this, just delegate to that\"", "action": false, "timestamp": "2020-11-12T19:35:38+00:00" }, { "id": "6844650c90b34effa60e7859c63a9399", "sender": "wumpus", "payload": "people don't generally consult a list of allowed features before contributing", "action": false, "timestamp": "2020-11-12T19:35:47+00:00" }, { "id": "0e849299a423472db690c1cafe95b49e", "sender": "MarcoFalke", "payload": "ah good point", "action": false, "timestamp": "2020-11-12T19:35:48+00:00" }, { "id": "6c7d4260a47b4971be8553843ba1e480", "sender": "luke-jr", "payload": "hmm", "action": false, "timestamp": "2020-11-12T19:35:50+00:00" }, { "id": "424e4f85bc5c4c3299097ed2637b21c3", "sender": "wumpus", "payload": "though things like \"use boost::shared_mutex instead of std::shared_mutex\" are clear and easy to enforce enough", "action": false, "timestamp": "2020-11-12T19:36:14+00:00" }, { "id": "46a71c39fa904443ba2cad68611c289c", "sender": "wumpus", "payload": "or the fs one", "action": false, "timestamp": "2020-11-12T19:36:21+00:00" }, { "id": "73ffb73c6521461ebcd6790eee0bc396", "sender": "wumpus", "payload": "we have our own fs abstraction anyway", "action": false, "timestamp": "2020-11-12T19:36:29+00:00" }, { "id": "fcb1225551db4631b0e139af6d247534", "sender": "sipa", "payload": "it wouldn't be hard to add a linter to outlaw \"std::filesistem\" and \"std::shared_mutex\" in the codebase or so", "action": false, "timestamp": "2020-11-12T19:36:30+00:00" }, { "id": "4b3e1f0bf9264dbd824c209a46e24235", "sender": "wumpus", "payload": "sipa: yes", "action": false, "timestamp": "2020-11-12T19:36:38+00:00" }, { "id": "bed65cec0c4044f68af95b0f77f6d5f1", "sender": "wumpus", "payload": "those two are easy", "action": false, "timestamp": "2020-11-12T19:36:41+00:00" }, { "id": "d256cea1721143b88300b34b4b4699fd", "sender": "MarcoFalke", "payload": "sipa: The ci would fail if someone tried using std::fs", "action": false, "timestamp": "2020-11-12T19:36:51+00:00" }, { "id": "13f9d53b037449b3b9ae7943ad4eb2d2", "sender": "sipa", "payload": "oh, right", "action": false, "timestamp": "2020-11-12T19:37:00+00:00" }, { "id": "c740d28dc1ef49dda956226ea28644e3", "sender": "MarcoFalke", "payload": "(and gitian)", "action": false, "timestamp": "2020-11-12T19:37:01+00:00" }, { "id": "edc13630b7e2462796674b0022804e36", "sender": "sipa", "payload": "my impression is that all these issues are STL features, not languages features", "action": false, "timestamp": "2020-11-12T19:37:08+00:00" }, { "id": "c51a782af40b484d823baca6d15237d0", "sender": "sipa", "payload": "and i expect that if you use a sufficient compiler version, all languages features will actually work", "action": false, "timestamp": "2020-11-12T19:37:33+00:00" }, { "id": "2eef5612e7254b2fa74f00c3573f87c5", "sender": "jonatack", "payload": "luke-jr: you are right, feeRate is an option", "action": false, "timestamp": "2020-11-12T19:37:40+00:00" }, { "id": "8f1ff15fbabc4d5f805c76c146b552cd", "sender": "sipa", "payload": "so perhaps the policy can be \"you can use all language features, but initially we'll want to whitelist STL features\" ?", "action": false, "timestamp": "2020-11-12T19:38:09+00:00" }, { "id": "4cf25cd2fb6b4a9fb81e2c65688277ab", "sender": "sipa", "payload": "that's probably too restrictive", "action": false, "timestamp": "2020-11-12T19:38:42+00:00" }, { "id": "912a9875a9334976a9bb196b75754062", "sender": "wumpus", "payload": "no,I think it's better to reject specific things if we have a good reason", "action": false, "timestamp": "2020-11-12T19:38:57+00:00" }, { "id": "726cf1c90dd9473c80319f536356b692", "sender": "sipa", "payload": "agree", "action": false, "timestamp": "2020-11-12T19:39:01+00:00" }, { "id": "83908c6422f54db486d06a0ac35d3eb5", "sender": "wumpus", "payload": "and just accept standard C++17 otherwise", "action": false, "timestamp": "2020-11-12T19:39:03+00:00" }, { "id": "e72a11bffdf64fc4bcda6a791916f172", "sender": "sipa", "payload": "i guess the concern is really about things that compile, but are known to not always work", "action": false, "timestamp": "2020-11-12T19:39:14+00:00" }, { "id": "dd7110747f1748269321fd94d12db92d", "sender": "sipa", "payload": "like this shared_mutex thing", "action": false, "timestamp": "2020-11-12T19:39:17+00:00" }, { "id": "cb5d8814c535420cab40d00b6a662f5e", "sender": "wumpus", "payload": "right", "action": false, "timestamp": "2020-11-12T19:39:23+00:00" }, { "id": "d2fbec59035844e6bd3a1849e3ed0fe4", "sender": "ja", "payload": "jnewbery: should std::shared_mutex be avoided even if it is unknown whether boost::shared_mutex is also broken?", "action": false, "timestamp": "2020-11-12T19:39:27+00:00" }, { "id": "1efb9968910d493d857d3a2c1a436a9f", "sender": "sipa", "payload": "and we should just outlaw while necessary... just as with any other compiler/stl bug", "action": false, "timestamp": "2020-11-12T19:39:32+00:00" }, { "id": "b483731386b54091ba2b17b0875cc8bf", "sender": "jnewbery", "payload": "I don't know enough about compilers to know how stable their C++17 stl features are", "action": false, "timestamp": "2020-11-12T19:39:52+00:00" }, { "id": "82eca4fdb02348a88c3229646054ac9b", "sender": "wumpus", "payload": "you would hope it is stable after more then three years", "action": false, "timestamp": "2020-11-12T19:40:11+00:00" }, { "id": "1c562a09cd814cfca1a43344c94c1bf7", "sender": "jnewbery", "payload": "you would, and yet here we are", "action": false, "timestamp": "2020-11-12T19:40:22+00:00" }, { "id": "dcb29c19e2e146338690d2c1ca66b9cd", "sender": "wumpus", "payload": "of course, compiler and c++ librar ybugs happen sometimes", "action": false, "timestamp": "2020-11-12T19:40:26+00:00" }, { "id": "b793a273b6aa490ba3f90f155f8624e7", "sender": "wumpus", "payload": "well yes it's a specific thing", "action": false, "timestamp": "2020-11-12T19:40:32+00:00" }, { "id": "b15a45ee1f094b0ba042f24462ee664d", "sender": "wumpus", "payload": "even memcmp had a bug !!!", "action": false, "timestamp": "2020-11-12T19:40:45+00:00" }, { "id": "78d5ee0224174a108df77fb17e4eeaf6", "sender": "jnewbery", "payload": "we don't know how many other specific things there are", "action": false, "timestamp": "2020-11-12T19:40:49+00:00" }, { "id": "1712142995944f1eb02ceaefbab339da", "sender": "wumpus", "payload": "should we reject c89 featurs now", "action": false, "timestamp": "2020-11-12T19:40:52+00:00" }, { "id": "8ef65e0324494b66be03f655dd12109d", "sender": "sipa", "payload": "haha", "action": false, "timestamp": "2020-11-12T19:40:58+00:00" }, { "id": "2a0e1b5c968243b79af052a6039ad5db", "sender": "MarcoFalke", "payload": "Is there a minimal test case for the shared_mutex thing?", "action": false, "timestamp": "2020-11-12T19:41:03+00:00" }, { "id": "f244d7fabf1647fbbdf4e960cf96f686", "sender": "ja", "payload": "it is still not clear to me which glibc bug it actually is, there are linked two different bugs from the c++17 thread", "action": false, "timestamp": "2020-11-12T19:41:31+00:00" }, { "id": "182013bf30734d25bf47ee81ff7fb9e2", "sender": "ja", "payload": "but glibc has test cases for the pthread primitives", "action": false, "timestamp": "2020-11-12T19:41:45+00:00" }, { "id": "c71da49d1e72455c8b7e128b1c01a18e", "sender": "wumpus", "payload": "it's not possible to guarantee that usage of compiler or library features doesn't have bugs, this is just as true for old features as now ones", "action": false, "timestamp": "2020-11-12T19:41:46+00:00" }, { "id": "ba0855f258db4bf48ede0cf9b77e1b13", "sender": "wumpus", "payload": "this is one of the biggest risks in consensus driven systems isn't it", "action": false, "timestamp": "2020-11-12T19:42:23+00:00" }, { "id": "659f5862e9cd4df6aba74673fb9e23d5", "sender": "jnewbery", "payload": "wumpus: that's doesn't seem like it'd be true. New features are more likely to have bugs", "action": false, "timestamp": "2020-11-12T19:42:25+00:00" }, { "id": "626a8e9bcfd44da993fd390aa8bbbfe3", "sender": "sipa", "payload": "boost 1.71 does not seem to use STL's shared_mutex", "action": false, "timestamp": "2020-11-12T19:42:26+00:00" }, { "id": "b0a2632a7d50439dabad3436a1dabd93", "sender": "wumpus", "payload": "jnewbery: I'm not convinced about that, code rot is a thing", "action": false, "timestamp": "2020-11-12T19:42:42+00:00" }, { "id": "f5aad70e69744d74a6a7d1d1a72aa8a6", "sender": "jnewbery", "payload": "*or uncover existing bugs", "action": false, "timestamp": "2020-11-12T19:42:44+00:00" }, { "id": "ef63e1a966f942cd842234b3a4d6b51a", "sender": "wumpus", "payload": "new features might actually have *more* eyes on them", "action": false, "timestamp": "2020-11-12T19:42:59+00:00" }, { "id": "b5975807c98243f4b55b96763afdf38f", "sender": "luke-jr", "payload": "sipa: unrelease boost might", "action": false, "timestamp": "2020-11-12T19:43:22+00:00" }, { "id": "6dde18c3e2ec4575b6e3d0aeab38e723", "sender": "wumpus", "payload": "this is an abyss without end anyway... we can only calculate in known bugs not potential ones", "action": false, "timestamp": "2020-11-12T19:43:29+00:00" }, { "id": "e059b90190ba4a87bb0392e0873be248", "sender": "luke-jr", "payload": "if every distro has a fix, maybe just a sanity check is in order", "action": false, "timestamp": "2020-11-12T19:44:05+00:00" }, { "id": "3ff12f4711fb47688083b64c8d9fe213", "sender": "MarcoFalke", "payload": "A future release of boost might decay boost::shared_mutex into std::shared_mutex", "action": false, "timestamp": "2020-11-12T19:44:12+00:00" }, { "id": "fd3387a58c214db3a984b05ecd73aca5", "sender": "jnewbery", "payload": "My general point is that we shouldn't rush to use new features unless there's very clear benefit", "action": false, "timestamp": "2020-11-12T19:44:12+00:00" }, { "id": "155028e1290b4d4f9485eaa5bce879ef", "sender": "wumpus", "payload": "MarcoFalke: yep", "action": false, "timestamp": "2020-11-12T19:44:24+00:00" }, { "id": "9f9d84b63f1d4058b9e3d418c6a1b60e", "sender": "luke-jr", "payload": "otoh, isn't it just a deadlock worst case?", "action": false, "timestamp": "2020-11-12T19:44:27+00:00" }, { "id": "5a2c8d74dbb1446ab86b8fdc330fb8d1", "sender": "jnewbery", "payload": "and that if we do that, then we should codify what features can be used at the project level", "action": false, "timestamp": "2020-11-12T19:44:49+00:00" }, { "id": "ca02e79a658c407995d8f4a460cbe459", "sender": "luke-jr", "payload": "I think deadlock is fairly harmless for user-built binaries that simply require an updated OS to fix", "action": false, "timestamp": "2020-11-12T19:44:53+00:00" }, { "id": "fe8716bdb2cf4a938619aa8d90f5cb11", "sender": "wumpus", "payload": "no, I don't think we should make a long list of allowed c++17 features", "action": false, "timestamp": "2020-11-12T19:45:09+00:00" }, { "id": "c9121419b7c14b8291edc921735cedfc", "sender": "ja", "payload": "luke-jr: if you use bitcoin to back a lightning node, a deadlock could be pretty bad, no?", "action": false, "timestamp": "2020-11-12T19:45:10+00:00" }, { "id": "f39d2e29eed04c4280c37dc6d4b20242", "sender": "wumpus", "payload": "only exclude ones that we know to cause problems", "action": false, "timestamp": "2020-11-12T19:45:16+00:00" }, { "id": "edf21ab5a8fe4c4982d7792908678b67", "sender": "luke-jr", "payload": "ja: hmm, maybe - but aren't there supposed to be watchers?", "action": false, "timestamp": "2020-11-12T19:45:32+00:00" }, { "id": "51bc578ccda44d7fa6cce4cd18ab2755", "sender": "wumpus", "payload": "we have already made the decision to use c++17, maybe we should be more careful in consensus code, but that's *always* the case for any change", "action": false, "timestamp": "2020-11-12T19:46:05+00:00" }, { "id": "8ba7b7ae4f8945bda4791b2694274bac", "sender": "ja", "payload": "luke-jr: i don't know how many people are running watchers. it is irrelevant whether there is supposed to be", "action": false, "timestamp": "2020-11-12T19:46:06+00:00" }, { "id": "1466f34d0a474f9980a5c804fa07680f", "sender": "luke-jr", "payload": "point is, that would be a scenario with two user errors", "action": false, "timestamp": "2020-11-12T19:46:43+00:00" }, { "id": "146fb94f64864ccf8775005b700c14bd", "sender": "michaelfolkson", "payload": "Watchtowers only needed if you aren't online 100 percent of time (or for additional protection)", "action": false, "timestamp": "2020-11-12T19:47:09+00:00" }, { "id": "0da52a511a1f4af4a2dd0802a52760d0", "sender": "wumpus", "payload": "and sure, we should take the same care as we did for c++11, don't change things for the sake of changing them", "action": false, "timestamp": "2020-11-12T19:47:26+00:00" }, { "id": "7c4936fb69134819aa71be3c0e131bbf", "sender": "ja", "payload": "michaelfolkson: if you bitcoin node is deadlocked on a shared_mutex, are you online?", "action": false, "timestamp": "2020-11-12T19:47:31+00:00" }, { "id": "463f6a58499949f89aba895c5dc1f44e", "sender": "michaelfolkson", "payload": "I'd guess not ja :)", "action": false, "timestamp": "2020-11-12T19:48:02+00:00" }, { "id": "22d6ffec907e4cb8b92556255ab6a053", "sender": "wumpus", "payload": "that should also be standard policy for the project already, no needless refactors", "action": false, "timestamp": "2020-11-12T19:48:05+00:00" }, { "id": "cd5d52cc44c24341bc9e08f4673f8e4f", "sender": "michaelfolkson", "payload": "But how long would you be deadlocked for?", "action": false, "timestamp": "2020-11-12T19:48:57+00:00" }, { "id": "1e8607b1fe274acc95248f671e48607d", "sender": "ja", "payload": "2 weeks, until you come back from vacation", "action": false, "timestamp": "2020-11-12T19:49:08+00:00" }, { "id": "fe0f84549f634b788848e1da098709f5", "sender": "jnewbery", "payload": "I think only introducing new features as they're needed is the more cautious approach", "action": false, "timestamp": "2020-11-12T19:49:09+00:00" }, { "id": "898c6273e4724d5cbe8bb4a108ad543c", "sender": "luke-jr", "payload": "michaelfolkson: indefinitely", "action": false, "timestamp": "2020-11-12T19:49:12+00:00" }, { "id": "c2212b92e49846c787105eef98a764f2", "sender": "sipa", "payload": "michaelfolkson: the definition of a deadlock implies it's forever", "action": false, "timestamp": "2020-11-12T19:49:18+00:00" }, { "id": "796a3ea1fd794634baf1030757dbb24b", "sender": "michaelfolkson", "payload": "Ok. That is a problem", "action": false, "timestamp": "2020-11-12T19:49:31+00:00" }, { "id": "b4c4fc13dffb4862a926478d60fd9e9c", "sender": "MarcoFalke", "payload": "jnewbery: I don't think C++17 is \"needed\". We could stay with C++11 forever", "action": false, "timestamp": "2020-11-12T19:49:38+00:00" }, { "id": "c3f4972b74ba46fea04d40b25070772f", "sender": "wumpus", "payload": "in new code I think full c++17 should be allowed (apart from what we have labaled as dangerous features)", "action": false, "timestamp": "2020-11-12T19:49:41+00:00" }, { "id": "6c9df4342122446ab509eb336f300c7d", "sender": "luke-jr", "payload": "but the same goes for any DoS vuln", "action": false, "timestamp": "2020-11-12T19:49:44+00:00" }, { "id": "dbd011e751354e319b77f249282f0dc5", "sender": "luke-jr", "payload": "which seem fairly common", "action": false, "timestamp": "2020-11-12T19:49:48+00:00" }, { "id": "a9b6cb1a80fb4adb923f070b69ce6ee1", "sender": "wumpus", "payload": "yes, we could stay in c++11 forever", "action": false, "timestamp": "2020-11-12T19:49:49+00:00" }, { "id": "f5af46c46d3e4a0a9c311b5b35410189", "sender": "wumpus", "payload": "but we've already decided not to", "action": false, "timestamp": "2020-11-12T19:50:24+00:00" }, { "id": "dc9ff94938a74ac589dc971aef8c6aee", "sender": "jnewbery", "payload": "It would be nice if we could have some nuance in these discussions instead of talking about C89 and staying on C++11 forever", "action": false, "timestamp": "2020-11-12T19:50:42+00:00" }, { "id": "77f32508e28a4306a5713fbc6a531e4c", "sender": "wumpus", "payload": "I don't think it would make the project any safer", "action": false, "timestamp": "2020-11-12T19:50:49+00:00" }, { "id": "fcf005d3c46942c48104d55635a85aa2", "sender": "hebasto", "payload": "we coudn't stay on C++11 due to new Qt versions", "action": false, "timestamp": "2020-11-12T19:51:12+00:00" }, { "id": "b85d9761430a47e8bf1d7cda2f638aae", "sender": "luke-jr", "payload": "hebasto: Qt dropped C++11 support? :o", "action": false, "timestamp": "2020-11-12T19:51:31+00:00" }, { "id": "050934d9b3fc47debce8cccbb7860d44", "sender": "wumpus", "payload": "just make an exception for the gui code...", "action": false, "timestamp": "2020-11-12T19:51:32+00:00" }, { "id": "0bdcb7169ed7400b9d7d7cb2f0a1f180", "sender": "sipa", "payload": "waot", "action": false, "timestamp": "2020-11-12T19:51:40+00:00" }, { "id": "7b9e91cb5ca04f959b5a195bf3379af0", "sender": "MarcoFalke", "payload": "Use C++11 code, but compile it with -std=c++17", "action": false, "timestamp": "2020-11-12T19:51:49+00:00" }, { "id": "c9d8741f36114ea79fa5d2fcf75a4ebf", "sender": "sipa", "payload": "this shared_lock thing sounds like a problem in pthread?", "action": false, "timestamp": "2020-11-12T19:51:49+00:00" }, { "id": "1c7ec8fa8fee4befa1662c11dec25b4d", "sender": "sipa", "payload": "which means it would also affect boost?", "action": false, "timestamp": "2020-11-12T19:51:58+00:00" }, { "id": "eeaa28e814414b278239254991fe260b", "sender": "wumpus", "payload": "boost definitely uses pthread (but maybe in a different way?)", "action": false, "timestamp": "2020-11-12T19:52:13+00:00" }, { "id": "4273e12131224b5cbf92c28b8420c1f5", "sender": "hebasto", "payload": "luke-jr: #19716", "action": false, "timestamp": "2020-11-12T19:52:30+00:00" }, { "id": "f549044e8c6c4feaa6777d604706f350", "sender": "gribble", "payload": "https://github.com/bitcoin/bitcoin/issues/19716 | build: Qt 5.15.x by fanquake \u00c3\u0082\u00c2\u00b7 Pull Request #19716 \u00c3\u0082\u00c2\u00b7 bitcoin/bitcoin \u00c3\u0082\u00c2\u00b7 GitHub", "action": false, "timestamp": "2020-11-12T19:52:32+00:00" }, { "id": "239068f03c814c6ca5ae4e4883a2c785", "sender": "michaelfolkson", "payload": "jnewbery: I think the nuance goes when wumpus says new contributors won't consult guides. But agreed I'd guess nuance is the better way to go", "action": false, "timestamp": "2020-11-12T19:52:46+00:00" }, { "id": "27d2e506a1ec4c0dacc96f458d749b40", "sender": "wumpus", "payload": "if it's a general pthread issue then we're already affected and c++17 is unimportant to this", "action": false, "timestamp": "2020-11-12T19:52:50+00:00" }, { "id": "b7c9c187b0d946b59af4761bcbdf55f0", "sender": "sipa", "payload": "indeed", "action": false, "timestamp": "2020-11-12T19:52:56+00:00" }, { "id": "17e5fb05cd264edfa414f7fde0817ac0", "sender": "jonatack", "payload": "At the end of the day, these things are going to come down to code review and incremental adjustments and guidelines as needed.", "action": false, "timestamp": "2020-11-12T19:52:58+00:00" }, { "id": "84c6a5d51b1649f185a6e052cbd7bbde", "sender": "sipa", "payload": "boost has its own shared_lock implementation", "action": false, "timestamp": "2020-11-12T19:53:03+00:00" }, { "id": "95bfb7ff3a50491b934a979d6845d803", "sender": "luke-jr", "payload": "hebasto: that looks like the opposite", "action": false, "timestamp": "2020-11-12T19:53:10+00:00" }, { "id": "10359680d7f0496ab01797f4eb200066", "sender": "sipa", "payload": "and doesn't use pthread's rwlock interface", "action": false, "timestamp": "2020-11-12T19:53:12+00:00" }, { "id": "b8e2dba430f84fbfb56165dd6969502c", "sender": "wumpus", "payload": "great", "action": false, "timestamp": "2020-11-12T19:53:18+00:00" }, { "id": "ef0c982a72114a07b9dd3040c5fabc5d", "sender": "sipa", "payload": "(in 1.71)", "action": false, "timestamp": "2020-11-12T19:53:25+00:00" }, { "id": "43e66b0f374d4468ac814198d1d7552f", "sender": "wumpus", "payload": "michaelfolkson: I don't think we can front-run any compiler or c++ library issues", "action": false, "timestamp": "2020-11-12T19:53:37+00:00" }, { "id": "d4ab6d45ccc24160a4118cc0bc42c4de", "sender": "wumpus", "payload": "avoiding c++17 features would give a false sense of security imo, it's not like it's brand new", "action": false, "timestamp": "2020-11-12T19:54:21+00:00" }, { "id": "bfd2415461a841fcae571d06c63859a7", "sender": "luke-jr", "payload": "I wonder if we ought to add a CI using roconnor's memcmp bug detection", "action": false, "timestamp": "2020-11-12T19:54:31+00:00" }, { "id": "369bac01a3db46ca972b39213c53c5aa", "sender": "wumpus", "payload": "but that's just my opinion", "action": false, "timestamp": "2020-11-12T19:54:36+00:00" }, { "id": "51d581c62e4f4ff3b0ea87e001f40218", "sender": "luke-jr", "payload": "seeing as GCC/distros appear to have a disinterest in actually fixing it", "action": false, "timestamp": "2020-11-12T19:55:03+00:00" }, { "id": "5b14e4b275644e429230aa869f1da7ce", "sender": "fanquake", "payload": "luke-jr: opposite of what? Qt started using C++14 features in its code, and essentially \u00c3\u00a2\u00c2\u0080\u00c2\u009cforgot\u00c3\u00a2\u00c2\u0080\u00c2\u009d that it was still meant to support c++11. An issue was opened but they never did anything to fix the issue.", "action": false, "timestamp": "2020-11-12T19:55:11+00:00" }, { "id": "6dca89446c7e4075b511eb72b7cdc3fe", "sender": "luke-jr", "payload": "fanquake: I don't see that mentioning in the linked issue?", "action": false, "timestamp": "2020-11-12T19:55:57+00:00" }, { "id": "c7f58103af77422aaa98737219ae90be", "sender": "wumpus", "payload": "I'm not sure how more nuanced you want this, I don't think it's useful to evaluate every single c++17 feature in the meeting at least", "action": false, "timestamp": "2020-11-12T19:56:17+00:00" }, { "id": "974fbf8884754d12843d294f3b5548c3", "sender": "wumpus", "payload": "as if we can judge how much risk the compiler or library change is anyway", "action": false, "timestamp": "2020-11-12T19:56:45+00:00" }, { "id": "6c37a07df82f475981bb7ea14c21178e", "sender": "luke-jr", "payload": "fanquake: you can't build Qt with C++14 and then link from C++11 code?", "action": false, "timestamp": "2020-11-12T19:56:49+00:00" }, { "id": "0aee2bf6bb4b457eab8f518ea9366890", "sender": "wumpus", "payload": "could you ever have predicted this?", "action": false, "timestamp": "2020-11-12T19:57:39+00:00" }, { "id": "489b2ec60bfe42528f58c4e259b99776", "sender": "wumpus", "payload": "did std::shared_mutex sound dangerous to you than boost::shared_mutex?", "action": false, "timestamp": "2020-11-12T19:57:53+00:00" }, { "id": "da3343e6ca774e4597b32710bf5f747b", "sender": "wumpus", "payload": "still, here we are", "action": false, "timestamp": "2020-11-12T19:58:15+00:00" }, { "id": "18225e8299aa44c5bf5d93032a4a7a6e", "sender": "jnewbery", "payload": "changing to something new is always dangerous", "action": false, "timestamp": "2020-11-12T19:58:20+00:00" }, { "id": "81b1b54f3494496fb3cff34f67c4d305", "sender": "fanquake", "payload": "luke-jr: I mentioned the details and linked to upstream in #19305", "action": false, "timestamp": "2020-11-12T19:58:31+00:00" }, { "id": "babbf6a389e64c09962145306db537d8", "sender": "gribble", "payload": "https://github.com/bitcoin/bitcoin/issues/19305 | doc: add C++17 release note for 0.21.0 by fanquake \u00c3\u0082\u00c2\u00b7 Pull Request #19305 \u00c3\u0082\u00c2\u00b7 bitcoin/bitcoin \u00c3\u0082\u00c2\u00b7 GitHub", "action": false, "timestamp": "2020-11-12T19:58:34+00:00" }, { "id": "2ac3c5848fd24f23bba65f3f63803da6", "sender": "wumpus", "payload": "okay, so not change to anything new anymore then?", "action": false, "timestamp": "2020-11-12T19:58:39+00:00" }, { "id": "d8d4fb479ccd495785b421299e64f250", "sender": "sipa", "payload": "jnewbery: boost has also had its fair share of bugs though", "action": false, "timestamp": "2020-11-12T19:58:42+00:00" }, { "id": "5af0ea0c9f6f4ec4b9878ea20c64e8b6", "sender": "wumpus", "payload": "would this *specifically* have been risky to you?", "action": false, "timestamp": "2020-11-12T19:58:54+00:00" }, { "id": "1d48440e455349f38b6d56a7c5fc5587", "sender": "sipa", "payload": "and a priori it seems a reasonable assumption that things that make it into the C++ standard have matured enough that they're less risky", "action": false, "timestamp": "2020-11-12T19:59:06+00:00" }, { "id": "489be66f02b347e2ae13a9691a07b745", "sender": "wumpus", "payload": "if not, it would be a blanket reject c++17 features", "action": false, "timestamp": "2020-11-12T19:59:07+00:00" }, { "id": "3550bbb44d63405d9ed10a2cbb90fd98", "sender": "wumpus", "payload": "yes", "action": false, "timestamp": "2020-11-12T19:59:15+00:00" }, { "id": "e73d7c8643a14ef9b98d2578657a3c81", "sender": "wumpus", "payload": "and yes, boost versions have also broken things sometimes", "action": false, "timestamp": "2020-11-12T19:59:35+00:00" }, { "id": "9b6f9c0be5be4114a19ec07edfa761fa", "sender": "wumpus", "payload": "not upgrading boost is dangerous too, though", "action": false, "timestamp": "2020-11-12T19:59:58+00:00" }, { "id": "d43fa1018d1447b294da86d9e1aa7260", "sender": "MarcoFalke", "payload": "With other project upgrading, at some point boost::feature is going to be less tested than std::feature. Code changes inside boost, which we can't anticipate are going to eventually break the feautre", "action": false, "timestamp": "2020-11-12T20:00:55+00:00" }, { "id": "95a95380c08844139c2673908e49fe23", "sender": "jnewbery", "payload": "I don't see any strong arguments against being cautious about new features, but I'm not getting the impression that I've convinced anyone", "action": false, "timestamp": "2020-11-12T20:01:24+00:00" }, { "id": "d6cfc60ef78c49e8b80a9b1c3e20b8bc", "sender": "wumpus", "payload": "I don't think any general principple can be derived from this", "action": false, "timestamp": "2020-11-12T20:01:27+00:00" }, { "id": "6584ca02a13d4d6c8b2cc9f8c34124ba", "sender": "wumpus", "payload": "yes, being cautious is always good", "action": false, "timestamp": "2020-11-12T20:01:46+00:00" }, { "id": "70a9d0df0e884644bfd762e19f12dd71", "sender": "wumpus", "payload": "I hope we already are cautious?", "action": false, "timestamp": "2020-11-12T20:01:49+00:00" }, { "id": "ee05b83af31d44ab80d19a303a17ef2d", "sender": "sipa", "payload": "jnewbery: i think we should always be caution about new features, but i don't think this is very specific to new language/stl features", "action": false, "timestamp": "2020-11-12T20:02:01+00:00" }, { "id": "86b294379cc14939b59d1d908cad8835", "sender": "wumpus", "payload": "do you have any specific suggestion?", "action": false, "timestamp": "2020-11-12T20:02:04+00:00" }, { "id": "68f1dd58a41c405c8e1b688b3cc62031", "sender": "sipa", "payload": "and we do have a review and QA cycle, which are part of the process", "action": false, "timestamp": "2020-11-12T20:02:43+00:00" }, { "id": "2a60064e9d474a1c80b07918364cf432", "sender": "queip", "payload": "as it was mentioned, compiling for old mac os x will break, also related to SDK versions afair. In context of Gitian for example", "action": false, "timestamp": "2020-11-12T20:02:43+00:00" }, { "id": "fd4e6a2279d04933a4936fe4211a5129", "sender": "ja", "payload": "the decision should ideally be derived from usage patterns, not from how new the feature is. a 10 year old language feature that nobody uses can't be relied on. the age of the feature is a proxy for how widely used it is, which is a proxy for how buggy it is", "action": false, "timestamp": "2020-11-12T20:03:00+00:00" }, { "id": "2350eb6ae306446ca7348214ba5b3a05", "sender": "queip", "payload": "that is, c++!7 forces such bump of minimal macosx version", "action": false, "timestamp": "2020-11-12T20:03:10+00:00" }, { "id": "1c27ec405e1b4816adc1333b270bed15", "sender": "jnewbery", "payload": "I didn't think sipa's suggestion of having a list of allowed features was bad. That list would grow over time", "action": false, "timestamp": "2020-11-12T20:03:19+00:00" }, { "id": "acc4c45c4ad34cf3b447e56d1c8013dd", "sender": "wumpus", "payload": "queip: yes, I think that wa calculated in", "action": false, "timestamp": "2020-11-12T20:03:22+00:00" }, { "id": "e4919bacc93d4d2794446b2fdf311669", "sender": "wumpus", "payload": "I don't think that's a good idea", "action": false, "timestamp": "2020-11-12T20:03:29+00:00" }, { "id": "b3a52c6c5eae4e81b3e5b254167f4d52", "sender": "wumpus", "payload": "it's super confusing to new contributors for example", "action": false, "timestamp": "2020-11-12T20:03:58+00:00" }, { "id": "6c23cba42b7e42249ed054a38398cc33", "sender": "michaelfolkson", "payload": "Because of new contributors and because of not knowing what should go on that list wumpus?", "action": false, "timestamp": "2020-11-12T20:04:03+00:00" }, { "id": "95aa0bd658044a61a132d327c28ad9a1", "sender": "sipa", "payload": "i think i agree with wumpus now", "action": false, "timestamp": "2020-11-12T20:04:07+00:00" }, { "id": "fc57b42740284fe69869102800f1e6d1", "sender": "wumpus", "payload": "yes", "action": false, "timestamp": "2020-11-12T20:04:08+00:00" }, { "id": "4ba10cec97324c2aaac8ba0ed0503259", "sender": "luke-jr", "payload": "queip: we typically only guarantee support for the most recent stable version of an OS", "action": false, "timestamp": "2020-11-12T20:04:21+00:00" }, { "id": "9068d6e574784207891274e1f2d802af", "sender": "luke-jr", "payload": "though Windows is apparently an exception", "action": false, "timestamp": "2020-11-12T20:04:28+00:00" }, { "id": "a1e11db0c689453d8f368ec5de08f851", "sender": "sipa", "payload": "what constitutes a \"feature\" even? is a new member function that was added to std::vector a \"feature\" ?", "action": false, "timestamp": "2020-11-12T20:04:35+00:00" }, { "id": "b9833a2cec264b1f9d818eced8a3a196", "sender": "wumpus", "payload": "if we really dislike certain features then we should disallow them, but I don't think it makes sense to partially allow a standard", "action": false, "timestamp": "2020-11-12T20:04:36+00:00" }, { "id": "adf71eb8bf5a48e4808126ae7c80984e", "sender": "wumpus", "payload": "yes", "action": false, "timestamp": "2020-11-12T20:04:43+00:00" }, { "id": "6447f4cb0c63418395ba31e050316141", "sender": "wumpus", "payload": "do we hae to whitelist every function? every class?", "action": false, "timestamp": "2020-11-12T20:04:50+00:00" }, { "id": "2cf20332ad644ac2b3180421e39cb88e", "sender": "MarcoFalke", "payload": "Generally, our insurance against build system bugs are tests", "action": false, "timestamp": "2020-11-12T20:05:05+00:00" }, { "id": "b59e2162f52a4b9ea071f0c8e54637c5", "sender": "wumpus", "payload": "do you even want to maintain this list?", "action": false, "timestamp": "2020-11-12T20:05:16+00:00" }, { "id": "630a8f00b257415fb3a643e2f2721a8f", "sender": "sipa", "payload": "maybe a good question to ask ourselves: if we had started using std::shared_mutex, would we have caught this issue before release?", "action": false, "timestamp": "2020-11-12T20:05:46+00:00" }, { "id": "049dfe5c815e4b1ab58ff819ce89c480", "sender": "wumpus", "payload": "only if we had a test reproducing the issue predictably I think", "action": false, "timestamp": "2020-11-12T20:06:33+00:00" }, { "id": "4a87b56d04904c6d90e1a3e90e1b147b", "sender": "MarcoFalke", "payload": "we should add one", "action": false, "timestamp": "2020-11-12T20:06:56+00:00" }, { "id": "bbe4dfa7d3214d93bbdb65430df6e5eb", "sender": "jnewbery", "payload": "wumpus: I don't think we should be setting our project standards based on what features new contributors might want to use. We have project standards precisely so all contributors write code in a common way", "action": false, "timestamp": "2020-11-12T20:06:58+00:00" }, { "id": "04d27547dace4f3397cfcbde1398a3be", "sender": "sipa", "payload": "yeah, it'd probably depend on how actively shared_mutex was used (and with how much contention...)", "action": false, "timestamp": "2020-11-12T20:06:59+00:00" }, { "id": "5c551cdcd54e43c88294ca2b788deeab", "sender": "wumpus", "payload": "if it causes a random hang in travis, well, peple would think it's just another infrastructure issue", "action": false, "timestamp": "2020-11-12T20:07:06+00:00" }, { "id": "0f00482e4bc54171895951ec7600d2db", "sender": "wumpus", "payload": "jnewbery: okay", "action": false, "timestamp": "2020-11-12T20:07:28+00:00" }, { "id": "e1177878659e4a11b022076a47496b55", "sender": "sipa", "payload": "jnewbery: that conceptually makes sense, but what specifically is your suggestion?", "action": false, "timestamp": "2020-11-12T20:07:31+00:00" }, { "id": "00576ef7ef714335ab5246e60364b45b", "sender": "wumpus", "payload": "jnewbery: feel free to make a list", "action": false, "timestamp": "2020-11-12T20:07:42+00:00" }, { "id": "af43641ceebe4077bedb1b40d8228048", "sender": "wumpus", "payload": "jnewbery: and PR it", "action": false, "timestamp": "2020-11-12T20:07:45+00:00" }, { "id": "fd49f2ec9f4e4aa8a2691dd4bee20b60", "sender": "wumpus", "payload": "jnewbery: I'm not conceptually against it I just do not want to maintain it", "action": false, "timestamp": "2020-11-12T20:07:56+00:00" }, { "id": "ec96d60dd7c441eeb98d09858a4dfaa2", "sender": "MarcoFalke", "payload": "time, btw", "action": false, "timestamp": "2020-11-12T20:07:59+00:00" }, { "id": "3e91ed8cadc24da893aa9deb4d916e75", "sender": "michaelfolkson", "payload": "The new contributor argument I don't think is particularly convincing. But the problems of constructing a list is more convincing to me", "action": false, "timestamp": "2020-11-12T20:08:00+00:00" }, { "id": "7f665c6665234ed2a4862458768261fa", "sender": "luke-jr", "payload": "\"Travis failed, can someone restart it for me?\"", "action": false, "timestamp": "2020-11-12T20:08:00+00:00" }, { "id": "82829b2e94af4c3cb09fc0a46250f04a", "sender": "queip", "payload": "apparently not popular opinion, but a white list of allowed free functions, and classes, would make it easier to guard against someone using obscure function that happens to be buggy. Though also a review can anyway guard against it - \"why not use the more common solution to this problem\". Either way read list of, probably 20 recommended classes and functions, is not that hard for new developer", "action": false, "timestamp": "2020-11-12T20:08:10+00:00" }, { "id": "b8e4377d4756467aa3d646ba356c54e1", "sender": "wumpus", "payload": "queip: again, feel free to maintian such a thing", "action": false, "timestamp": "2020-11-12T20:08:24+00:00" }, { "id": "923570ccca2b4380b3f4649b92f993bf", "sender": "jnewbery", "payload": "queip: that seems easier to me than arguing on each PR what is and isn't acceptable", "action": false, "timestamp": "2020-11-12T20:08:38+00:00" }, { "id": "850c03c7e742413a93418bb36db2733e", "sender": "wumpus", "payload": "I'm done with this (both the meeting and the discussion)", "action": false, "timestamp": "2020-11-12T20:08:59+00:00" }, { "id": "931af06ca0a94999bbd87be486e147c3", "sender": "wumpus", "payload": "#endmeeting", "action": false, "timestamp": "2020-11-12T20:09:00+00:00" } ], "events": [ { "event_type": "START_MEETING", "message": { "id": "f59b3bb95514471c9e3a00524d99ea34", "sender": "wumpus", "payload": "#startmeeting", "action": false, "timestamp": "2020-11-05T19:00:12+00:00" }, "operand": null, "id": "f59b3bb95514471c9e3a00524d99ea34", "timestamp": "2020-11-05T19:00:12+00:00" }, { "event_type": "LINK", "message": { "id": "d5bbb45008ca40bbb5e26683d0d39d9d", "sender": "gribble", "payload": "https://github.com/bitcoin/bitcoin/issues/20250 | Bugfix: RPC/Wallet: Make BTC/kB and sat/B fee modes work sanely by luke-jr \u00c3\u0082\u00c2\u00b7 Pull Request #20250 \u00c3\u0082\u00c2\u00b7 bitcoin/bitcoin \u00c3\u0082\u00c2\u00b7 GitHub", "action": false, "timestamp": "2020-11-05T19:02:49+00:00" }, "operand": "https://github.com/bitcoin/bitcoin/issues/20250", "id": "d5bbb45008ca40bbb5e26683d0d39d9d", "timestamp": "2020-11-05T19:02:49+00:00" }, { "event_type": "LINK", "message": { "id": "9d01e919fd19497eae5f75044abf209a", "sender": "wumpus", "payload": "https://github.com/bitcoin/bitcoin/issues?q=is%3Aopen+is%3Aissue+milestone%3A0.21.0", "action": false, "timestamp": "2020-11-05T19:02:59+00:00" }, "operand": "https://github.com/bitcoin/bitcoin/issues?q=is%3Aopen+is%3Aissue+milestone%3A0.21.0", "id": "9d01e919fd19497eae5f75044abf209a", "timestamp": "2020-11-05T19:02:59+00:00" }, { "event_type": "LINK", "message": { "id": "8532cdb091024014b969e7cac35c5f23", "sender": "MarcoFalke", "payload": "https://github.com/bitcoin/bitcoin/milestone/45 has 16 items", "action": false, "timestamp": "2020-11-05T19:03:26+00:00" }, "operand": "https://github.com/bitcoin/bitcoin/milestone/45", "id": "8532cdb091024014b969e7cac35c5f23", "timestamp": "2020-11-05T19:03:26+00:00" }, { "event_type": "LINK", "message": { "id": "ee94d8123aa5447cb2edc93d229cf077", "sender": "gribble", "payload": "https://github.com/bitcoin/bitcoin/issues/20250 | Bugfix: RPC/Wallet: Make BTC/kB and sat/B fee modes work sanely by luke-jr \u00c3\u0082\u00c2\u00b7 Pull Request #20250 \u00c3\u0082\u00c2\u00b7 bitcoin/bitcoin \u00c3\u0082\u00c2\u00b7 GitHub", "action": false, "timestamp": "2020-11-05T19:05:13+00:00" }, "operand": "https://github.com/bitcoin/bitcoin/issues/20250", "id": "ee94d8123aa5447cb2edc93d229cf077", "timestamp": "2020-11-05T19:05:13+00:00" }, { "event_type": "LINK", "message": { "id": "9865a4957a7245f586bab3ffbae9df94", "sender": "gribble", "payload": "https://github.com/bitcoin/bitcoin/issues/20305 | wallet: introduce fee_rate_sat_vb param/option by jonatack \u00c3\u0082\u00c2\u00b7 Pull Request #20305 \u00c3\u0082\u00c2\u00b7 bitcoin/bitcoin \u00c3\u0082\u00c2\u00b7 GitHub", "action": false, "timestamp": "2020-11-05T19:05:14+00:00" }, "operand": "https://github.com/bitcoin/bitcoin/issues/20305", "id": "9865a4957a7245f586bab3ffbae9df94", "timestamp": "2020-11-05T19:05:14+00:00" }, { "event_type": "LINK", "message": { "id": "8d28cbd3bd9e4081bf777c9521540549", "sender": "gribble", "payload": "https://github.com/bitcoin/bitcoin/issues/20234 | net: dont extra bind for Tor if binds are restricted by vasild \u00c3\u0082\u00c2\u00b7 Pull Request #20234 \u00c3\u0082\u00c2\u00b7 bitcoin/bitcoin \u00c3\u0082\u00c2\u00b7 GitHub", "action": false, "timestamp": "2020-11-05T19:05:44+00:00" }, "operand": "https://github.com/bitcoin/bitcoin/issues/20234", "id": "8d28cbd3bd9e4081bf777c9521540549", "timestamp": "2020-11-05T19:05:44+00:00" }, { "event_type": "LINK", "message": { "id": "4d0400a5f5b04319b03d9afd51827fed", "sender": "gribble", "payload": "https://github.com/bitcoin/bitcoin/issues/20284 | addrman: ensure old versions dont parse peers.dat by vasild \u00c3\u0082\u00c2\u00b7 Pull Request #20284 \u00c3\u0082\u00c2\u00b7 bitcoin/bitcoin \u00c3\u0082\u00c2\u00b7 GitHub", "action": false, "timestamp": "2020-11-05T19:07:22+00:00" }, "operand": "https://github.com/bitcoin/bitcoin/issues/20284", "id": "4d0400a5f5b04319b03d9afd51827fed", "timestamp": "2020-11-05T19:07:22+00:00" }, { "event_type": "LINK", "message": { "id": "9678e329ddbe4287b0d00e1e32e8c8dd", "sender": "gribble", "payload": "https://github.com/bitcoin/bitcoin/issues/20205 | wallet: Properly support a wallet id by achow101 \u00c3\u0082\u00c2\u00b7 Pull Request #20205 \u00c3\u0082\u00c2\u00b7 bitcoin/bitcoin \u00c3\u0082\u00c2\u00b7 GitHub", "action": false, "timestamp": "2020-11-05T19:08:36+00:00" }, "operand": "https://github.com/bitcoin/bitcoin/issues/20205", "id": "9678e329ddbe4287b0d00e1e32e8c8dd", "timestamp": "2020-11-05T19:08:36+00:00" }, { "event_type": "LINK", "message": { "id": "3e12d88f9f7b463090cb0d8497653207", "sender": "gribble", "payload": "https://github.com/bitcoin/bitcoin/issues/20318 | build: Ensure source tarball has leading directory name by MarcoFalke \u00c3\u0082\u00c2\u00b7 Pull Request #20318 \u00c3\u0082\u00c2\u00b7 bitcoin/bitcoin \u00c3\u0082\u00c2\u00b7 GitHub", "action": false, "timestamp": "2020-11-05T19:10:53+00:00" }, "operand": "https://github.com/bitcoin/bitcoin/issues/20318", "id": "3e12d88f9f7b463090cb0d8497653207", "timestamp": "2020-11-05T19:10:53+00:00" }, { "event_type": "LINK", "message": { "id": "12c071d6579f42e183a16f7a4361c949", "sender": "gribble", "payload": "https://github.com/bitcoin/bitcoin/issues/20292 | test: Fix intermittent feature_taproot issue by MarcoFalke \u00c3\u0082\u00c2\u00b7 Pull Request #20292 \u00c3\u0082\u00c2\u00b7 bitcoin/bitcoin \u00c3\u0082\u00c2\u00b7 GitHub", "action": false, "timestamp": "2020-11-05T19:10:54+00:00" }, "operand": "https://github.com/bitcoin/bitcoin/issues/20292", "id": "12c071d6579f42e183a16f7a4361c949", "timestamp": "2020-11-05T19:10:54+00:00" }, { "event_type": "LINK", "message": { "id": "7c1ad76f2bd74e669f1be50db68e189b", "sender": "gribble", "payload": "https://github.com/bitcoin/bitcoin/issues/19502 | Bugfix: Wallet: Soft-fail exceptions within ListWalletDir file checks by luke-jr \u00c3\u0082\u00c2\u00b7 Pull Request #19502 \u00c3\u0082\u00c2\u00b7 bitcoin/bitcoin \u00c3\u0082\u00c2\u00b7 GitHub", "action": false, "timestamp": "2020-11-05T19:11:32+00:00" }, "operand": "https://github.com/bitcoin/bitcoin/issues/19502", "id": "7c1ad76f2bd74e669f1be50db68e189b", "timestamp": "2020-11-05T19:11:32+00:00" }, { "event_type": "LINK", "message": { "id": "fe691f26598247c38a668975170219f2", "sender": "gribble", "payload": "https://github.com/bitcoin/bitcoin/issues/20120 | net, rpc, test, bugfix: update GetNetworkName, GetNetworksInfo, regression tests by jonatack \u00c3\u0082\u00c2\u00b7 Pull Request #20120 \u00c3\u0082\u00c2\u00b7 bitcoin/bitcoin \u00c3\u0082\u00c2\u00b7 GitHub", "action": false, "timestamp": "2020-11-05T19:11:49+00:00" }, "operand": "https://github.com/bitcoin/bitcoin/issues/20120", "id": "fe691f26598247c38a668975170219f2", "timestamp": "2020-11-05T19:11:49+00:00" }, { "event_type": "LINK", "message": { "id": "08f129505d85419ea84dc869b9b0108d", "sender": "gribble", "payload": "https://github.com/bitcoin/bitcoin/issues/20120 | net, rpc, test, bugfix: update GetNetworkName, GetNetworksInfo, regression tests by jonatack \u00c3\u0082\u00c2\u00b7 Pull Request #20120 \u00c3\u0082\u00c2\u00b7 bitcoin/bitcoin \u00c3\u0082\u00c2\u00b7 GitHub", "action": false, "timestamp": "2020-11-05T19:13:09+00:00" }, "operand": "https://github.com/bitcoin/bitcoin/issues/20120", "id": "08f129505d85419ea84dc869b9b0108d", "timestamp": "2020-11-05T19:13:09+00:00" }, { "event_type": "LINK", "message": { "id": "eb2ec084dc674cd6ad4ce4f26c899282", "sender": "gribble", "payload": "https://github.com/bitcoin/bitcoin/issues/19502 | Bugfix: Wallet: Soft-fail exceptions within ListWalletDir file checks by luke-jr \u00c3\u0082\u00c2\u00b7 Pull Request #19502 \u00c3\u0082\u00c2\u00b7 bitcoin/bitcoin \u00c3\u0082\u00c2\u00b7 GitHub", "action": false, "timestamp": "2020-11-05T19:13:23+00:00" }, "operand": "https://github.com/bitcoin/bitcoin/issues/19502", "id": "eb2ec084dc674cd6ad4ce4f26c899282", "timestamp": "2020-11-05T19:13:23+00:00" }, { "event_type": "LINK", "message": { "id": "211b4382de8b4ffeaa8a0aeaa3e5d5c1", "sender": "gribble", "payload": "https://github.com/bitcoin/bitcoin/issues/20266 | wallet: fix change detection of imported internal descriptors by achow101 \u00c3\u0082\u00c2\u00b7 Pull Request #20266 \u00c3\u0082\u00c2\u00b7 bitcoin/bitcoin \u00c3\u0082\u00c2\u00b7 GitHub", "action": false, "timestamp": "2020-11-05T19:15:23+00:00" }, "operand": "https://github.com/bitcoin/bitcoin/issues/20266", "id": "211b4382de8b4ffeaa8a0aeaa3e5d5c1", "timestamp": "2020-11-05T19:15:23+00:00" }, { "event_type": "LINK", "message": { "id": "a7c63da553334a5db9bf6b225f5d318e", "sender": "gribble", "payload": "https://github.com/bitcoin/bitcoin/issues/18836 | wallet: upgradewallet fixes and additional tests by achow101 \u00c3\u0082\u00c2\u00b7 Pull Request #18836 \u00c3\u0082\u00c2\u00b7 bitcoin/bitcoin \u00c3\u0082\u00c2\u00b7 GitHub", "action": false, "timestamp": "2020-11-05T19:16:11+00:00" }, "operand": "https://github.com/bitcoin/bitcoin/issues/18836", "id": "a7c63da553334a5db9bf6b225f5d318e", "timestamp": "2020-11-05T19:16:11+00:00" }, { "event_type": "LINK", "message": { "id": "0b2d006eb3ec406ea5b6ef74a655e366", "sender": "gribble", "payload": "https://github.com/bitcoin/bitcoin/issues/20153 | wallet: do not import a descriptor with hardened derivations into a watch-only wallet by S3RK \u00c3\u0082\u00c2\u00b7 Pull Request #20153 \u00c3\u0082\u00c2\u00b7 bitcoin/bitcoin \u00c3\u0082\u00c2\u00b7 GitHub", "action": false, "timestamp": "2020-11-05T19:19:08+00:00" }, "operand": "https://github.com/bitcoin/bitcoin/issues/20153", "id": "0b2d006eb3ec406ea5b6ef74a655e366", "timestamp": "2020-11-05T19:19:08+00:00" }, { "event_type": "LINK", "message": { "id": "e22249129aa94622b9db105d55a0b7ab", "sender": "gribble", "payload": "https://github.com/bitcoin/bitcoin/issues/18818 | Fix release tarball generated by gitian by luke-jr \u00c3\u0082\u00c2\u00b7 Pull Request #18818 \u00c3\u0082\u00c2\u00b7 bitcoin/bitcoin \u00c3\u0082\u00c2\u00b7 GitHub", "action": false, "timestamp": "2020-11-05T19:20:33+00:00" }, "operand": "https://github.com/bitcoin/bitcoin/issues/18818", "id": "e22249129aa94622b9db105d55a0b7ab", "timestamp": "2020-11-05T19:20:33+00:00" }, { "event_type": "LINK", "message": { "id": "09f12461131f46afa27778c04337745e", "sender": "gribble", "payload": "https://github.com/bitcoin/bitcoin/issues/20305 | wallet: introduce fee_rate_sat_vb param/option by jonatack \u00c3\u0082\u00c2\u00b7 Pull Request #20305 \u00c3\u0082\u00c2\u00b7 bitcoin/bitcoin \u00c3\u0082\u00c2\u00b7 GitHub", "action": false, "timestamp": "2020-11-05T19:21:42+00:00" }, "operand": "https://github.com/bitcoin/bitcoin/issues/20305", "id": "09f12461131f46afa27778c04337745e", "timestamp": "2020-11-05T19:21:42+00:00" }, { "event_type": "LINK", "message": { "id": "516c286817084c0f987ba43a439df4d1", "sender": "gribble", "payload": "https://github.com/bitcoin/bitcoin/issues/20250 | Bugfix: RPC/Wallet: Make BTC/kB and sat/B fee modes work sanely by luke-jr \u00c3\u0082\u00c2\u00b7 Pull Request #20250 \u00c3\u0082\u00c2\u00b7 bitcoin/bitcoin \u00c3\u0082\u00c2\u00b7 GitHub", "action": false, "timestamp": "2020-11-05T19:21:44+00:00" }, "operand": "https://github.com/bitcoin/bitcoin/issues/20250", "id": "516c286817084c0f987ba43a439df4d1", "timestamp": "2020-11-05T19:21:44+00:00" }, { "event_type": "LINK", "message": { "id": "c2be7eb4306145b2a53c7260402e61ea", "sender": "gribble", "payload": "https://github.com/bitcoin/bitcoin/issues/20318 | build: Ensure source tarball has leading directory name by MarcoFalke \u00c3\u0082\u00c2\u00b7 Pull Request #20318 \u00c3\u0082\u00c2\u00b7 bitcoin/bitcoin \u00c3\u0082\u00c2\u00b7 GitHub", "action": false, "timestamp": "2020-11-05T19:21:55+00:00" }, "operand": "https://github.com/bitcoin/bitcoin/issues/20318", "id": "c2be7eb4306145b2a53c7260402e61ea", "timestamp": "2020-11-05T19:21:55+00:00" }, { "event_type": "LINK", "message": { "id": "240cc5ee73c44ec59f5e658bf6533914", "sender": "gribble", "payload": "https://github.com/bitcoin/bitcoin/issues/19502 | Bugfix: Wallet: Soft-fail exceptions within ListWalletDir file checks by luke-jr \u00c3\u0082\u00c2\u00b7 Pull Request #19502 \u00c3\u0082\u00c2\u00b7 bitcoin/bitcoin \u00c3\u0082\u00c2\u00b7 GitHub", "action": false, "timestamp": "2020-11-06T04:35:53+00:00" }, "operand": "https://github.com/bitcoin/bitcoin/issues/19502", "id": "240cc5ee73c44ec59f5e658bf6533914", "timestamp": "2020-11-06T04:35:53+00:00" }, { "event_type": "LINK", "message": { "id": "d916ea9867224df58f1da999d3ec6751", "sender": "gribble", "payload": "https://github.com/bitcoin/bitcoin/issues/20305 | wallet: introduce fee_rate_sat_vb param/option by jonatack \u00c3\u0082\u00c2\u00b7 Pull Request #20305 \u00c3\u0082\u00c2\u00b7 bitcoin/bitcoin \u00c3\u0082\u00c2\u00b7 GitHub", "action": false, "timestamp": "2020-11-06T08:01:01+00:00" }, "operand": "https://github.com/bitcoin/bitcoin/issues/20305", "id": "d916ea9867224df58f1da999d3ec6751", "timestamp": "2020-11-06T08:01:01+00:00" }, { "event_type": "LINK", "message": { "id": "31a34e0a726345bf83c5ba60357d79b2", "sender": "gribble", "payload": "https://github.com/bitcoin/bitcoin/issues/20250 | Bugfix: RPC/Wallet: Make BTC/kB and sat/B fee modes work sanely by luke-jr \u00c3\u0082\u00c2\u00b7 Pull Request #20250 \u00c3\u0082\u00c2\u00b7 bitcoin/bitcoin \u00c3\u0082\u00c2\u00b7 GitHub", "action": false, "timestamp": "2020-11-06T08:01:03+00:00" }, "operand": "https://github.com/bitcoin/bitcoin/issues/20250", "id": "31a34e0a726345bf83c5ba60357d79b2", "timestamp": "2020-11-06T08:01:03+00:00" }, { "event_type": "LINK", "message": { "id": "2458f889ca2243d9a0237dcae3c89b98", "sender": "gribble", "payload": "https://github.com/bitcoin/bitcoin/issues/20250 | Bugfix: RPC/Wallet: Make BTC/kB and sat/B fee modes work sanely by luke-jr \u00c3\u0082\u00c2\u00b7 Pull Request #20250 \u00c3\u0082\u00c2\u00b7 bitcoin/bitcoin \u00c3\u0082\u00c2\u00b7 GitHub", "action": false, "timestamp": "2020-11-06T19:02:40+00:00" }, "operand": "https://github.com/bitcoin/bitcoin/issues/20250", "id": "2458f889ca2243d9a0237dcae3c89b98", "timestamp": "2020-11-06T19:02:40+00:00" }, { "event_type": "LINK", "message": { "id": "4ea7577d826b4bff99dea1637560c664", "sender": "gribble", "payload": "https://github.com/bitcoin/bitcoin/issues/20305 | wallet: introduce fee_rate_sat_vb param/option by jonatack \u00c3\u0082\u00c2\u00b7 Pull Request #20305 \u00c3\u0082\u00c2\u00b7 bitcoin/bitcoin \u00c3\u0082\u00c2\u00b7 GitHub", "action": false, "timestamp": "2020-11-06T19:02:41+00:00" }, "operand": "https://github.com/bitcoin/bitcoin/issues/20305", "id": "4ea7577d826b4bff99dea1637560c664", "timestamp": "2020-11-06T19:02:41+00:00" }, { "event_type": "LINK", "message": { "id": "0c5d2b66fae54b208bbf1c73d4846b2e", "sender": "gribble", "payload": "https://github.com/bitcoin/bitcoin/issues/19543 | Normalize fee units for RPC (\"BTC/kB\" and \"sat/B) \u00c3\u0082\u00c2\u00b7 Issue #19543 \u00c3\u0082\u00c2\u00b7 bitcoin/bitcoin \u00c3\u0082\u00c2\u00b7 GitHub", "action": false, "timestamp": "2020-11-06T19:11:38+00:00" }, "operand": "https://github.com/bitcoin/bitcoin/issues/19543", "id": "0c5d2b66fae54b208bbf1c73d4846b2e", "timestamp": "2020-11-06T19:11:38+00:00" }, { "event_type": "LINK", "message": { "id": "946f8e5f1761479c91239c703997a260", "sender": "jonatack", "payload": "https://twitter.com/jonatack/status/1318890833131823104?s=20", "action": false, "timestamp": "2020-11-06T19:14:42+00:00" }, "operand": "https://twitter.com/jonatack/status/1318890833131823104?s=20", "id": "946f8e5f1761479c91239c703997a260", "timestamp": "2020-11-06T19:14:42+00:00" }, { "event_type": "LINK", "message": { "id": "3d36c7e8687444d1887de4c270f7f5de", "sender": "gribble", "payload": "https://github.com/bitcoin/bitcoin/issues/18836 | wallet: upgradewallet fixes and additional tests by achow101 \u00c3\u0082\u00c2\u00b7 Pull Request #18836 \u00c3\u0082\u00c2\u00b7 bitcoin/bitcoin \u00c3\u0082\u00c2\u00b7 GitHub", "action": false, "timestamp": "2020-11-06T19:14:57+00:00" }, "operand": "https://github.com/bitcoin/bitcoin/issues/18836", "id": "3d36c7e8687444d1887de4c270f7f5de", "timestamp": "2020-11-06T19:14:57+00:00" }, { "event_type": "LINK", "message": { "id": "8da2f03ed82346a1993f67342afe3609", "sender": "emzy", "payload": "https://dashjr.org/ works vor me in Firefox.", "action": false, "timestamp": "2020-11-08T20:32:24+00:00" }, "operand": "https://dashjr.org/", "id": "8da2f03ed82346a1993f67342afe3609", "timestamp": "2020-11-08T20:32:24+00:00" }, { "event_type": "LINK", "message": { "id": "a6a14ac1bc5a4ccf89ce1b5d01025958", "sender": "gribble", "payload": "https://github.com/bitcoin/bitcoin/issues/17458 | Refactor OutputGroup effective value calculations and filtering to occur within the struct by achow101 \u00c3\u0082\u00c2\u00b7 Pull Request #17458 \u00c3\u0082\u00c2\u00b7 bitcoin/bitcoin \u00c3\u0082\u00c2\u00b7 GitHub", "action": false, "timestamp": "2020-11-08T21:39:54+00:00" }, "operand": "https://github.com/bitcoin/bitcoin/issues/17458", "id": "a6a14ac1bc5a4ccf89ce1b5d01025958", "timestamp": "2020-11-08T21:39:54+00:00" }, { "event_type": "LINK", "message": { "id": "06235928f8454a07af48943601d8eb8b", "sender": "gribble", "payload": "https://github.com/bitcoin/bitcoin/issues/20207 | Follow-up extra comments on taproot code and tests by sipa \u00c3\u0082\u00c2\u00b7 Pull Request #20207 \u00c3\u0082\u00c2\u00b7 bitcoin/bitcoin \u00c3\u0082\u00c2\u00b7 GitHub", "action": false, "timestamp": "2020-11-10T00:17:42+00:00" }, "operand": "https://github.com/bitcoin/bitcoin/issues/20207", "id": "06235928f8454a07af48943601d8eb8b", "timestamp": "2020-11-10T00:17:42+00:00" }, { "event_type": "LINK", "message": { "id": "73094a60a00649f29180dd341cc6893b", "sender": "DeanWeen", "payload": "https://gitlab.com/bitcoin-cash-node/bitcoin-cash-node/-/merge_requests/844 In case they \"forget\" to alert core", "action": false, "timestamp": "2020-11-10T17:19:12+00:00" }, "operand": "https://gitlab.com/bitcoin-cash-node/bitcoin-cash-node/-/merge_requests/844", "id": "73094a60a00649f29180dd341cc6893b", "timestamp": "2020-11-10T17:19:12+00:00" }, { "event_type": "LINK", "message": { "id": "7945a0c2acd04571b47dbd0ca7ef9285", "sender": "gribble", "payload": "https://github.com/bitcoin/bitcoin/issues/19502 | Bugfix: Wallet: Soft-fail exceptions within ListWalletDir file checks by luke-jr \u00c3\u0082\u00c2\u00b7 Pull Request #19502 \u00c3\u0082\u00c2\u00b7 bitcoin/bitcoin \u00c3\u0082\u00c2\u00b7 GitHub", "action": false, "timestamp": "2020-11-12T07:52:53+00:00" }, "operand": "https://github.com/bitcoin/bitcoin/issues/19502", "id": "7945a0c2acd04571b47dbd0ca7ef9285", "timestamp": "2020-11-12T07:52:53+00:00" }, { "event_type": "LINK", "message": { "id": "6f11bfd7ff65437f822f64354a1e4b5b", "sender": "gribble", "payload": "https://github.com/bitcoin/bitcoin/issues/18095 | Fix crashes and infinite loop in ListWalletDir() by uhliksk \u00c3\u0082\u00c2\u00b7 Pull Request #18095 \u00c3\u0082\u00c2\u00b7 bitcoin/bitcoin \u00c3\u0082\u00c2\u00b7 GitHub", "action": false, "timestamp": "2020-11-12T07:52:55+00:00" }, "operand": "https://github.com/bitcoin/bitcoin/issues/18095", "id": "6f11bfd7ff65437f822f64354a1e4b5b", "timestamp": "2020-11-12T07:52:55+00:00" }, { "event_type": "LINK", "message": { "id": "3cdeedcf13944fc4a822ac0ac63397c5", "sender": "gribble", "payload": "https://github.com/bitcoin/bitcoin/issues/20305 | wallet: introduce fee_rate sat/vB param/option by jonatack \u00c3\u0082\u00c2\u00b7 Pull Request #20305 \u00c3\u0082\u00c2\u00b7 bitcoin/bitcoin \u00c3\u0082\u00c2\u00b7 GitHub", "action": false, "timestamp": "2020-11-12T11:02:46+00:00" }, "operand": "https://github.com/bitcoin/bitcoin/issues/20305", "id": "3cdeedcf13944fc4a822ac0ac63397c5", "timestamp": "2020-11-12T11:02:46+00:00" }, { "event_type": "LINK", "message": { "id": "212fa0e5237d4303b9028d63534f341e", "sender": "jonasschnelli", "payload": "https://github.com/bitcoin/bips/pull/1024", "action": false, "timestamp": "2020-11-12T15:58:57+00:00" }, "operand": "https://github.com/bitcoin/bips/pull/1024", "id": "212fa0e5237d4303b9028d63534f341e", "timestamp": "2020-11-12T15:58:57+00:00" }, { "event_type": "LINK", "message": { "id": "a70c6bc0874d46a9b5c6026f52824f7d", "sender": "hebasto", "payload": "https://github.com/bitcoin-core/gui/pull/96", "action": false, "timestamp": "2020-11-12T19:06:35+00:00" }, "operand": "https://github.com/bitcoin-core/gui/pull/96", "id": "a70c6bc0874d46a9b5c6026f52824f7d", "timestamp": "2020-11-12T19:06:35+00:00" }, { "event_type": "LINK", "message": { "id": "540ac5598a624413924664d23e3c65e1", "sender": "gribble", "payload": "https://github.com/bitcoin/bitcoin/issues/20305 | wallet: introduce fee_rate sat/vB param/option by jonatack \u00c3\u0082\u00c2\u00b7 Pull Request #20305 \u00c3\u0082\u00c2\u00b7 bitcoin/bitcoin \u00c3\u0082\u00c2\u00b7 GitHub", "action": false, "timestamp": "2020-11-12T19:10:09+00:00" }, "operand": "https://github.com/bitcoin/bitcoin/issues/20305", "id": "540ac5598a624413924664d23e3c65e1", "timestamp": "2020-11-12T19:10:09+00:00" }, { "event_type": "LINK", "message": { "id": "ea3a66e5f514413496730b812316f491", "sender": "gribble", "payload": "https://github.com/bitcoin/bitcoin/issues/18836 | wallet: upgradewallet fixes and additional tests by achow101 \u00c3\u0082\u00c2\u00b7 Pull Request #18836 \u00c3\u0082\u00c2\u00b7 bitcoin/bitcoin \u00c3\u0082\u00c2\u00b7 GitHub", "action": false, "timestamp": "2020-11-12T19:10:12+00:00" }, "operand": "https://github.com/bitcoin/bitcoin/issues/18836", "id": "ea3a66e5f514413496730b812316f491", "timestamp": "2020-11-12T19:10:12+00:00" }, { "event_type": "LINK", "message": { "id": "782db29563e74cad94b80d3279336e3c", "sender": "jonatack", "payload": "https://github.com/bitcoin/bitcoin/pull/20305#discussion_r520231413", "action": false, "timestamp": "2020-11-12T19:12:06+00:00" }, "operand": "https://github.com/bitcoin/bitcoin/pull/20305#discussion_r520231413", "id": "782db29563e74cad94b80d3279336e3c", "timestamp": "2020-11-12T19:12:06+00:00" }, { "event_type": "LINK", "message": { "id": "4cf1728317e94314b3669eff01a24eac", "sender": "gribble", "payload": "https://github.com/bitcoin/bitcoin/issues/16257 | [wallet] abort when attempting to fund a transaction above -maxtxfee by Sjors \u00c3\u0082\u00c2\u00b7 Pull Request #16257 \u00c3\u0082\u00c2\u00b7 bitcoin/bitcoin \u00c3\u0082\u00c2\u00b7 GitHub", "action": false, "timestamp": "2020-11-12T19:16:50+00:00" }, "operand": "https://github.com/bitcoin/bitcoin/issues/16257", "id": "4cf1728317e94314b3669eff01a24eac", "timestamp": "2020-11-12T19:16:50+00:00" }, { "event_type": "LINK", "message": { "id": "6b27bf1d12614bd3a4041902f961b8c6", "sender": "gribble", "payload": "https://github.com/bitcoin/bitcoin/issues/20305 | wallet: introduce fee_rate sat/vB param/option by jonatack \u00c3\u0082\u00c2\u00b7 Pull Request #20305 \u00c3\u0082\u00c2\u00b7 bitcoin/bitcoin \u00c3\u0082\u00c2\u00b7 GitHub", "action": false, "timestamp": "2020-11-12T19:19:56+00:00" }, "operand": "https://github.com/bitcoin/bitcoin/issues/20305", "id": "6b27bf1d12614bd3a4041902f961b8c6", "timestamp": "2020-11-12T19:19:56+00:00" }, { "event_type": "TOPIC", "message": { "id": "104109163c494b09b4f8ff60f3698f2e", "sender": "wumpus", "payload": "#topic limiting C++17 feature usage (jnewbery)", "action": false, "timestamp": "2020-11-12T19:32:20+00:00" }, "operand": "limiting C++17 feature usage (jnewbery)", "id": "104109163c494b09b4f8ff60f3698f2e", "timestamp": "2020-11-12T19:32:20+00:00" }, { "event_type": "LINK", "message": { "id": "f549044e8c6c4feaa6777d604706f350", "sender": "gribble", "payload": "https://github.com/bitcoin/bitcoin/issues/19716 | build: Qt 5.15.x by fanquake \u00c3\u0082\u00c2\u00b7 Pull Request #19716 \u00c3\u0082\u00c2\u00b7 bitcoin/bitcoin \u00c3\u0082\u00c2\u00b7 GitHub", "action": false, "timestamp": "2020-11-12T19:52:32+00:00" }, "operand": "https://github.com/bitcoin/bitcoin/issues/19716", "id": "f549044e8c6c4feaa6777d604706f350", "timestamp": "2020-11-12T19:52:32+00:00" }, { "event_type": "LINK", "message": { "id": "babbf6a389e64c09962145306db537d8", "sender": "gribble", "payload": "https://github.com/bitcoin/bitcoin/issues/19305 | doc: add C++17 release note for 0.21.0 by fanquake \u00c3\u0082\u00c2\u00b7 Pull Request #19305 \u00c3\u0082\u00c2\u00b7 bitcoin/bitcoin \u00c3\u0082\u00c2\u00b7 GitHub", "action": false, "timestamp": "2020-11-12T19:58:34+00:00" }, "operand": "https://github.com/bitcoin/bitcoin/issues/19305", "id": "babbf6a389e64c09962145306db537d8", "timestamp": "2020-11-12T19:58:34+00:00" }, { "event_type": "END_MEETING", "message": { "id": "931af06ca0a94999bbd87be486e147c3", "sender": "wumpus", "payload": "#endmeeting", "action": false, "timestamp": "2020-11-12T20:09:00+00:00" }, "operand": null, "id": "931af06ca0a94999bbd87be486e147c3", "timestamp": "2020-11-12T20:09:00+00:00" } ], "aliases": {}, "vote_in_progress": false, "motion_index": null }