{
  "founder": "meshcollider",
  "channel": "#bitcoin-core-dev",
  "network": "freenode",
  "id": "d7bf894633624f09976826d3b296fccd",
  "name": "#bitcoin-core-dev",
  "chair": "meshcollider",
  "chairs": [
    "meshcollider"
  ],
  "nicks": {
    "meshcollider": 18,
    "lightningbot": 2,
    "provoostenator": 24,
    "jnewbery": 17,
    "fanquake": 1,
    "instagibbs": 28,
    "digi_james": 1,
    "achow101": 19,
    "BlueMatt": 6,
    "gribble": 5,
    "bitcoin-git": 5,
    "ryanofsky": 12,
    "sipa": 2,
    "MarcoFalke": 2,
    "JeremyCrookshank": 3
  },
  "start_time": "2019-10-25T19:00:21+00:00",
  "end_time": "2019-10-25T19:41:15+00:00",
  "active": false,
  "original_topic": "Bitcoin Core development discussion and commit log | This is the channel for developing Bitcoin Core. Feel free to watch, but please take commentary and usage questions to #bitcoin | Channel logs: http://www.erisian.com.au/bitcoin-core-dev/, http://gnusha.org/bitcoin-core-dev/ | Meeting topics https://gist.github.com/moneyball/071d608fdae217c2a6d7c35955881d8a",
  "current_topic": "SPKM PR #16341 (jnewbery)",
  "messages": [
    {
      "id": "2738701a6be84880a8e7ee9198bb763b",
      "sender": "meshcollider",
      "payload": "#startmeeting",
      "action": false,
      "timestamp": "2019-10-25T19:00:21+00:00"
    },
    {
      "id": "ce7a7cba11dc4998bc67cd3627072988",
      "sender": "lightningbot",
      "payload": "Meeting started Fri Oct 25 19:00:21 2019 UTC.  The chair is meshcollider. Information about MeetBot at http://wiki.debian.org/MeetBot.",
      "action": false,
      "timestamp": "2019-10-25T19:00:21+00:00"
    },
    {
      "id": "4b0ef0614fd7450689be813414946435",
      "sender": "lightningbot",
      "payload": "Useful Commands: #action #agreed #help #info #idea #link #topic.",
      "action": false,
      "timestamp": "2019-10-25T19:00:21+00:00"
    },
    {
      "id": "dcc66b25a2ee49dcb25df6f3e2f96289",
      "sender": "provoostenator",
      "payload": "wallet meeting?",
      "action": false,
      "timestamp": "2019-10-25T19:00:23+00:00"
    },
    {
      "id": "f1add7399ce14e518b6f80f158887dd6",
      "sender": "jnewbery",
      "payload": "hi",
      "action": false,
      "timestamp": "2019-10-25T19:00:23+00:00"
    },
    {
      "id": "b4b485ab537e4feb9c31b66e1e28bb79",
      "sender": "provoostenator",
      "payload": "hi",
      "action": false,
      "timestamp": "2019-10-25T19:00:26+00:00"
    },
    {
      "id": "a55ce908a7404a30b791a081c6ca002e",
      "sender": "meshcollider",
      "payload": "#bitcoin-core-dev Wallet Meeting: wumpus sipa gmaxwell jonasschnelli morcos luke-jr sdaftuar jtimon cfields petertodd kanzure bluematt instagibbs phantomcircuit codeshark michagogo marcofalke paveljanik NicolasDorier jl2012 achow101 meshcollider jnewbery maaku fanquake promag provoostenator aj Chris_Stewart_5 dongcarl gwillen jamesob ken281221 ryanofsky gleb moneyball",
      "action": false,
      "timestamp": "2019-10-25T19:00:27+00:00"
    },
    {
      "id": "490c0f4c878444bca476aabed655c9a3",
      "sender": "fanquake",
      "payload": "hi",
      "action": false,
      "timestamp": "2019-10-25T19:00:46+00:00"
    },
    {
      "id": "3ed8a74bcc4c4d939aa27d88ffec3967",
      "sender": "instagibbs",
      "payload": "hi",
      "action": false,
      "timestamp": "2019-10-25T19:00:47+00:00"
    },
    {
      "id": "c6352d36625f4b5d84d5f5db226df46c",
      "sender": "meshcollider",
      "payload": "Topics?",
      "action": false,
      "timestamp": "2019-10-25T19:00:56+00:00"
    },
    {
      "id": "be9d7fd001de4084821fe73c3bdccb83",
      "sender": "digi_james",
      "payload": "hi",
      "action": false,
      "timestamp": "2019-10-25T19:00:58+00:00"
    },
    {
      "id": "5cbc654f2cc64b53bcb5c589bac85850",
      "sender": "achow101",
      "payload": "hi",
      "action": false,
      "timestamp": "2019-10-25T19:01:40+00:00"
    },
    {
      "id": "7b9e2ae939ad47e7a2cdf587f19b7bd6",
      "sender": "provoostenator",
      "payload": "Not really. Lots of review work out there, just do it :-)",
      "action": false,
      "timestamp": "2019-10-25T19:01:44+00:00"
    },
    {
      "id": "a6fdcc2ed36241538cd137565d67eeba",
      "sender": "BlueMatt",
      "payload": "<suggestor> now that bitcoin core is defaulting to segwit more, I wonder if it would make sense to change the default on spending unconfirmed change to not spend non-segwit unconfirmed change due to malleability.",
      "action": false,
      "timestamp": "2019-10-25T19:01:44+00:00"
    },
    {
      "id": "7563bd6a5a4e451fba04b6b5e107fde6",
      "sender": "instagibbs",
      "payload": "BlueMatt, hmm",
      "action": false,
      "timestamp": "2019-10-25T19:02:12+00:00"
    },
    {
      "id": "bfecdb5a8eb24ccca0c9cd8f667c2b21",
      "sender": "instagibbs",
      "payload": "achow101, you mentioned something about wanting to work on coin selection again, if you want to mention it here? (I don't know what you were thinking)",
      "action": false,
      "timestamp": "2019-10-25T19:02:40+00:00"
    },
    {
      "id": "3ea1cbd7c9f248c5913e9107d122d139",
      "sender": "provoostenator",
      "payload": "Coin selection already prefers confirmed coins, so that seems a bit overkill.",
      "action": false,
      "timestamp": "2019-10-25T19:02:44+00:00"
    },
    {
      "id": "021e243951484915bd3f1b873989f698",
      "sender": "instagibbs",
      "payload": "true, it heavily tries deeply-then-shallow-confirmed",
      "action": false,
      "timestamp": "2019-10-25T19:02:59+00:00"
    },
    {
      "id": "f4a64b1e6a264a3faf35664f508a6544",
      "sender": "achow101",
      "payload": "instagibbs: yes, planning on doing some coin selection stuff and reviving SRD",
      "action": false,
      "timestamp": "2019-10-25T19:02:59+00:00"
    },
    {
      "id": "2609a2d8c7f248a599fadfddb931e6d4",
      "sender": "meshcollider",
      "payload": "Thanks to everyone who has been reviewing #16341, it's getting very close now which is awesome :)",
      "action": false,
      "timestamp": "2019-10-25T19:03:23+00:00"
    },
    {
      "id": "c24098ad83c042868b3ab1d5ebc85f57",
      "sender": "gribble",
      "payload": "https://github.com/bitcoin/bitcoin/issues/16341 | Introduce ScriptPubKeyMan interface and use it for key and script management (aka wallet boxes) by achow101 \u00c3\u0082\u00c2\u00b7 Pull Request #16341 \u00c3\u0082\u00c2\u00b7 bitcoin/bitcoin \u00c3\u0082\u00c2\u00b7 GitHub",
      "action": false,
      "timestamp": "2019-10-25T19:03:26+00:00"
    },
    {
      "id": "11d9341a812049a4a0829b0a11c652a9",
      "sender": "provoostenator",
      "payload": "I went down the coin selection rabbit hole yesterday. Happy to review attemps by others :-)",
      "action": false,
      "timestamp": "2019-10-25T19:03:29+00:00"
    },
    {
      "id": "614efc845aea457fb3ed37b4e32781ac",
      "sender": "instagibbs",
      "payload": "Sorry I haven't had time to re-review SPKM PR :/",
      "action": false,
      "timestamp": "2019-10-25T19:03:43+00:00"
    },
    {
      "id": "7ea032cd69a243a8b2c4e065d089fb04",
      "sender": "instagibbs",
      "payload": "Honestly knapsack has to die",
      "action": false,
      "timestamp": "2019-10-25T19:04:30+00:00"
    },
    {
      "id": "f107824db7a141e2a78019782cc61caf",
      "sender": "achow101",
      "payload": "BlueMatt: would there even be non-segwit unconfirmed change unless the wallet is configured to addresstype=legacy?",
      "action": false,
      "timestamp": "2019-10-25T19:04:32+00:00"
    },
    {
      "id": "9f84a7bad6bd4005b7b46e4bd003e1c0",
      "sender": "instagibbs",
      "payload": "Previously I had tried working on the wallet again, and threw my hands up in dispair because of the knapsack loop behavior",
      "action": false,
      "timestamp": "2019-10-25T19:05:01+00:00"
    },
    {
      "id": "8299275863114421aedcd5a06341caff",
      "sender": "achow101",
      "payload": "errr changetype=legacy.. I don't think we make non-segwit change anymore?",
      "action": false,
      "timestamp": "2019-10-25T19:05:06+00:00"
    },
    {
      "id": "eb932e0b2bf048879a42b17ddc6e1ec3",
      "sender": "BlueMatt",
      "payload": "achow101: no, you need to avoid spending any change that came from a transaction with non-segwit inputs",
      "action": false,
      "timestamp": "2019-10-25T19:05:20+00:00"
    },
    {
      "id": "162dc7c7fa8141b981a287e870c6d271",
      "sender": "BlueMatt",
      "payload": "cause that underlying tx is malleable",
      "action": false,
      "timestamp": "2019-10-25T19:05:41+00:00"
    },
    {
      "id": "1f72d6c781a84eef916f23474e5e0be9",
      "sender": "achow101",
      "payload": "oh right",
      "action": false,
      "timestamp": "2019-10-25T19:05:46+00:00"
    },
    {
      "id": "ce19aab7fa684aa895694f15a62608de",
      "sender": "instagibbs",
      "payload": "achow101, so personally speaking, I'd strong concept ACK killing off knapsack if the UTXO simulation story doesn't look awful",
      "action": false,
      "timestamp": "2019-10-25T19:06:11+00:00"
    },
    {
      "id": "8b8066226e75404782a08fff77937070",
      "sender": "instagibbs",
      "payload": "imo it's limped along by fear of removing the current UTXO vacuum(that doesn't benefit small wallets anyways!)",
      "action": false,
      "timestamp": "2019-10-25T19:06:43+00:00"
    },
    {
      "id": "597f56d9f807424fbf98b9bd87983f56",
      "sender": "bitcoin-git",
      "payload": "[bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/693e40090ae7...25d7e2e78137",
      "action": false,
      "timestamp": "2019-10-25T19:08:27+00:00"
    },
    {
      "id": "68c135e83a1e46488498f3d068883c15",
      "sender": "bitcoin-git",
      "payload": "bitcoin/master 04dbdd6 Sjors Provoost: [net] SocketHandler: log peer id for close and disconnect",
      "action": false,
      "timestamp": "2019-10-25T19:08:28+00:00"
    },
    {
      "id": "aa2d50638ef84c0a8a7a466ad299b25a",
      "sender": "bitcoin-git",
      "payload": "bitcoin/master 25d7e2e fanquake: Merge #17251: net: SocketHandler logs peer id for close and disconnect",
      "action": false,
      "timestamp": "2019-10-25T19:08:28+00:00"
    },
    {
      "id": "c2bf76836f1b487e9f46d51591628eac",
      "sender": "provoostenator",
      "payload": "Yeah that loop is horrible. It doesnt' even really start at the top: splitting the fee amongst outputs is done at the top, based on the last iteration.",
      "action": false,
      "timestamp": "2019-10-25T19:08:32+00:00"
    },
    {
      "id": "5bbbea298d0a4d0ab250ac29fc58f574",
      "sender": "bitcoin-git",
      "payload": "[bitcoin] fanquake merged pull request #17251: net: SocketHandler logs peer id for close and disconnect (master...2019/10/net-socket-peer) https://github.com/bitcoin/bitcoin/pull/17251",
      "action": false,
      "timestamp": "2019-10-25T19:08:47+00:00"
    },
    {
      "id": "1b194a737f5d4efa9488369d44fc6f2d",
      "sender": "provoostenator",
      "payload": "^ yolo merge, before Travis ready :-)",
      "action": false,
      "timestamp": "2019-10-25T19:08:49+00:00"
    },
    {
      "id": "52e867bec26d4335b84a24810a788ea7",
      "sender": "instagibbs",
      "payload": "It makes improvements to the wallet basically impossible :(",
      "action": false,
      "timestamp": "2019-10-25T19:08:54+00:00"
    },
    {
      "id": "2ae6f74a6ad04b67943d9aaa2df6429d",
      "sender": "instagibbs",
      "payload": "some improvements*",
      "action": false,
      "timestamp": "2019-10-25T19:08:59+00:00"
    },
    {
      "id": "1afef74280f947c5a8883b4ac18f77d1",
      "sender": "bitcoin-git",
      "payload": "[bitcoin] adamjonas opened pull request #17258: Fix issue with conflicted mempool tx in listsinceblock (master...listsinceblock-filter-conflicts) https://github.com/bitcoin/bitcoin/pull/17258",
      "action": false,
      "timestamp": "2019-10-25T19:09:07+00:00"
    },
    {
      "id": "a66296dd86014f27ab6d682c1d9b7002",
      "sender": "instagibbs",
      "payload": "anyways, stepping off soapbox",
      "action": false,
      "timestamp": "2019-10-25T19:09:12+00:00"
    },
    {
      "id": "f2a705659cd8457896ee723afb04bd5a",
      "sender": "instagibbs",
      "payload": "f.e., having the wallet implicitly CPFP",
      "action": false,
      "timestamp": "2019-10-25T19:09:42+00:00"
    },
    {
      "id": "ee71720b3ea44a45838336f228e1dfc3",
      "sender": "provoostenator",
      "payload": "instagibbs: you'll like #17246",
      "action": false,
      "timestamp": "2019-10-25T19:10:02+00:00"
    },
    {
      "id": "4863340d3797430084484ed7ce3730e2",
      "sender": "gribble",
      "payload": "https://github.com/bitcoin/bitcoin/issues/17246 | wallet: avoid knapsack when theres no change by Sjors \u00c3\u0082\u00c2\u00b7 Pull Request #17246 \u00c3\u0082\u00c2\u00b7 bitcoin/bitcoin \u00c3\u0082\u00c2\u00b7 GitHub",
      "action": false,
      "timestamp": "2019-10-25T19:10:04+00:00"
    },
    {
      "id": "5b150a4786b340688272c6cd3ad6be64",
      "sender": "achow101",
      "payload": "BlueMatt: I suppose that idea is reasonable. but, on the topic of unconfirmed change, how do we handle fee bumping a tx from which we've spent the unconfirmed change?",
      "action": false,
      "timestamp": "2019-10-25T19:10:05+00:00"
    },
    {
      "id": "e4ae21ad3d854555af8b52107f656872",
      "sender": "provoostenator",
      "payload": "(or some variant thereof)",
      "action": false,
      "timestamp": "2019-10-25T19:10:12+00:00"
    },
    {
      "id": "93b15399cc05433c89080548bdd1d9d3",
      "sender": "instagibbs",
      "payload": "provoostenator, right, CPFP would have worked for me... only for CPFP case :)",
      "action": false,
      "timestamp": "2019-10-25T19:10:17+00:00"
    },
    {
      "id": "d342c4d897444ef5836f55e6fbc252ad",
      "sender": "BlueMatt",
      "payload": "you dont",
      "action": false,
      "timestamp": "2019-10-25T19:10:18+00:00"
    },
    {
      "id": "25636a1417c64ee5827a9950f7169b74",
      "sender": "BlueMatt",
      "payload": "you bump the next one up",
      "action": false,
      "timestamp": "2019-10-25T19:10:21+00:00"
    },
    {
      "id": "1c920790befa479b9c852a33bb46b678",
      "sender": "BlueMatt",
      "payload": "cpfp :)",
      "action": false,
      "timestamp": "2019-10-25T19:10:24+00:00"
    },
    {
      "id": "1d0f0ea7f277475bbccfa18c5713a7e8",
      "sender": "instagibbs",
      "payload": "but I felt that wasn't worth it",
      "action": false,
      "timestamp": "2019-10-25T19:10:25+00:00"
    },
    {
      "id": "25fdaa5b866643cd93110a5ddd048e51",
      "sender": "jnewbery",
      "payload": "topic request: #16341",
      "action": false,
      "timestamp": "2019-10-25T19:11:14+00:00"
    },
    {
      "id": "61099d52b6984f79af77b8499593c340",
      "sender": "gribble",
      "payload": "https://github.com/bitcoin/bitcoin/issues/16341 | Introduce ScriptPubKeyMan interface and use it for key and script management (aka wallet boxes) by achow101 \u00c3\u0082\u00c2\u00b7 Pull Request #16341 \u00c3\u0082\u00c2\u00b7 bitcoin/bitcoin \u00c3\u0082\u00c2\u00b7 GitHub",
      "action": false,
      "timestamp": "2019-10-25T19:11:16+00:00"
    },
    {
      "id": "c902e94852714567a9077d00907c2ee8",
      "sender": "achow101",
      "payload": "BlueMatt: true. I was about to suggest that maybe we shouldn't allow unconfirmed change at all",
      "action": false,
      "timestamp": "2019-10-25T19:12:06+00:00"
    },
    {
      "id": "c6c88c05bf724389a41e311be6142559",
      "sender": "achow101",
      "payload": "And with upcoming more complex scripts, maybe we shouldn't, because we aren't necessarily the sole owner of those outputs",
      "action": false,
      "timestamp": "2019-10-25T19:12:50+00:00"
    },
    {
      "id": "33d2d0f825eb4839a5a25e74f6c45f93",
      "sender": "provoostenator",
      "payload": "Instead of spending unconfirmed change, we could RBF and add an output?",
      "action": false,
      "timestamp": "2019-10-25T19:13:58+00:00"
    },
    {
      "id": "8c0f5e06e3bf481d9f9bf2eb9bb6869a",
      "sender": "provoostenator",
      "payload": "That would be a nice fee saving UX improvment.",
      "action": false,
      "timestamp": "2019-10-25T19:14:09+00:00"
    },
    {
      "id": "8140d3302c39420eb31027d367233587",
      "sender": "provoostenator",
      "payload": "(though non trivial if the pre-RBF transactions gets mined)",
      "action": false,
      "timestamp": "2019-10-25T19:14:47+00:00"
    },
    {
      "id": "3761ca20932d46dcaaa0f0b4e0511916",
      "sender": "instagibbs",
      "payload": "that's the sticky part",
      "action": false,
      "timestamp": "2019-10-25T19:14:57+00:00"
    },
    {
      "id": "25803a1ce78f4566b939ab468c7037a0",
      "sender": "provoostenator",
      "payload": "You can sign two variants and start broadcasting the fallback if needed.",
      "action": false,
      "timestamp": "2019-10-25T19:15:25+00:00"
    },
    {
      "id": "d396b213a17f456a93ff9f2c1696490c",
      "sender": "provoostenator",
      "payload": "But that's less of a set-and-forget than we have now.",
      "action": false,
      "timestamp": "2019-10-25T19:15:38+00:00"
    },
    {
      "id": "1b79c7f665374084a8db7568397f8e39",
      "sender": "instagibbs",
      "payload": "our wallet is very \"transactional\" i nthe wrong sense currently",
      "action": false,
      "timestamp": "2019-10-25T19:15:44+00:00"
    },
    {
      "id": "4fe8dc2d2a3e4347871c4820fe6a2f6c",
      "sender": "provoostenator",
      "payload": "set-and-quit-and-forget I mean",
      "action": false,
      "timestamp": "2019-10-25T19:15:51+00:00"
    },
    {
      "id": "a733b8e137a3454984539f39227cbea8",
      "sender": "instagibbs",
      "payload": "transaction as in CTransaction rather than logical transaction :)",
      "action": false,
      "timestamp": "2019-10-25T19:15:57+00:00"
    },
    {
      "id": "f5e7b4e86e85435d8edf09d2f75bdc7a",
      "sender": "achow101",
      "payload": "next topic?",
      "action": false,
      "timestamp": "2019-10-25T19:18:14+00:00"
    },
    {
      "id": "a107ec6f01db4ef78db5ac09f15ce86c",
      "sender": "meshcollider",
      "payload": "#topic SPKM PR #16341 (jnewbery)",
      "action": false,
      "timestamp": "2019-10-25T19:18:19+00:00"
    },
    {
      "id": "5559b13f42a9407bbd45cafbd8a70f8d",
      "sender": "gribble",
      "payload": "https://github.com/bitcoin/bitcoin/issues/16341 | Introduce ScriptPubKeyMan interface and use it for key and script management (aka wallet boxes) by achow101 \u00c3\u0082\u00c2\u00b7 Pull Request #16341 \u00c3\u0082\u00c2\u00b7 bitcoin/bitcoin \u00c3\u0082\u00c2\u00b7 GitHub",
      "action": false,
      "timestamp": "2019-10-25T19:18:22+00:00"
    },
    {
      "id": "28c28ef84d804a00a518c41315f18fba",
      "sender": "achow101",
      "payload": "ack 'n merge pls",
      "action": false,
      "timestamp": "2019-10-25T19:18:33+00:00"
    },
    {
      "id": "229d714280524a39ad449d33e1f4a4b5",
      "sender": "meshcollider",
      "payload": "Go and bug sipa first, he said he wanted to review it",
      "action": false,
      "timestamp": "2019-10-25T19:18:59+00:00"
    },
    {
      "id": "a13fb0a656b44beeb102db461aa82ac9",
      "sender": "jnewbery",
      "payload": "I'd like to help but there's no way I have time to review the PR in the way that it's structured",
      "action": false,
      "timestamp": "2019-10-25T19:19:00+00:00"
    },
    {
      "id": "bfbec9a80025468da44b2ee53d531c54",
      "sender": "provoostenator",
      "payload": "jnewbery: did you also look at ryanofsky's variant, with the same end result?",
      "action": false,
      "timestamp": "2019-10-25T19:19:27+00:00"
    },
    {
      "id": "993cd4309919495280081e7b1fb027fd",
      "sender": "jnewbery",
      "payload": "I'm particularly concerned about ryanofsky's comment here: https://github.com/bitcoin/bitcoin/pull/16341#issuecomment-541330425",
      "action": false,
      "timestamp": "2019-10-25T19:19:30+00:00"
    },
    {
      "id": "b3bf4247cd8841079ad39363e489564b",
      "sender": "achow101",
      "payload": "jnewbery: do you want me to use ryanofsky's structure?",
      "action": false,
      "timestamp": "2019-10-25T19:19:36+00:00"
    },
    {
      "id": "183d797c06574647b7f73dcdb7d8d887",
      "sender": "provoostenator",
      "payload": "I found it useful to review achow101's version first, and then ryanofsky's version",
      "action": false,
      "timestamp": "2019-10-25T19:19:43+00:00"
    },
    {
      "id": "bea52f664ea54cd3927df09ba7b07fc9",
      "sender": "jnewbery",
      "payload": "provoostenator achow101: I haven't looked at Russ's version yet",
      "action": false,
      "timestamp": "2019-10-25T19:19:57+00:00"
    },
    {
      "id": "43427b1688cb45afa16c0127f46e7300",
      "sender": "jnewbery",
      "payload": "it's mostly about the volume of changes",
      "action": false,
      "timestamp": "2019-10-25T19:20:21+00:00"
    },
    {
      "id": "3e1955070abb4e129ee34a537552b2f6",
      "sender": "provoostenator",
      "payload": "But I wouldn't either is ideal. Russ' version does a _lot_ of stuff in big increments in the beginning. But his later commits are perhaps better.",
      "action": false,
      "timestamp": "2019-10-25T19:20:37+00:00"
    },
    {
      "id": "92ed5afa091249bf9cf8b8931f2604f4",
      "sender": "jnewbery",
      "payload": "I know it'd take me at least a week to review so much code and satisfy myself that there aren't bugs",
      "action": false,
      "timestamp": "2019-10-25T19:20:56+00:00"
    },
    {
      "id": "7a969ce12e1e49059adeb6fc41228b6b",
      "sender": "provoostenator",
      "payload": "It's a huge PR indeed. But it's not obvious how to refactor the giant ball of spaghetti in multiple steps",
      "action": false,
      "timestamp": "2019-10-25T19:21:19+00:00"
    },
    {
      "id": "f4c00ff4f0064abb87cd6bdd9a4f37f0",
      "sender": "ryanofsky",
      "payload": "just catching up but my branch has two big commits at the beginning. one is 100% moveonly. one is a bunch of renames",
      "action": false,
      "timestamp": "2019-10-25T19:21:46+00:00"
    },
    {
      "id": "89ed4c7a79ec4e4fa6b2991c3c1df875",
      "sender": "ryanofsky",
      "payload": "every other commit is small",
      "action": false,
      "timestamp": "2019-10-25T19:21:56+00:00"
    },
    {
      "id": "4228a056b20f40caac3116fec6487e22",
      "sender": "meshcollider",
      "payload": "Yeah this has come up in discussion a few times, noone has come up with an alternative to either this or more massive commits",
      "action": false,
      "timestamp": "2019-10-25T19:22:17+00:00"
    },
    {
      "id": "addf99653b8145a1a43bae532706f751",
      "sender": "jnewbery",
      "payload": "ryanofsky: would only merging those first two commits leave us in a bad state (would it be possible to slice those off in their own PR)?",
      "action": false,
      "timestamp": "2019-10-25T19:22:38+00:00"
    },
    {
      "id": "f5cf3d53fcba42628fdc8247919d31dc",
      "sender": "jnewbery",
      "payload": "I can definitely review move-only/rename commits",
      "action": false,
      "timestamp": "2019-10-25T19:23:00+00:00"
    },
    {
      "id": "61f25e3251034a53935d799eff51ecab",
      "sender": "ryanofsky",
      "payload": "merging those two commits would be fine, as far as i know",
      "action": false,
      "timestamp": "2019-10-25T19:23:06+00:00"
    },
    {
      "id": "1feca0ab6e5d477e8ac2fc3cc6228c4e",
      "sender": "jnewbery",
      "payload": "achow101: what do you think about that approach?",
      "action": false,
      "timestamp": "2019-10-25T19:23:27+00:00"
    },
    {
      "id": "beb6e9bc56114c86b46c29ed5bdce322",
      "sender": "meshcollider",
      "payload": "If we are going to split this PR up a bit, maybe we should feature-freeze the wallet until all the parts are in to avoid things getting messy half way",
      "action": false,
      "timestamp": "2019-10-25T19:24:19+00:00"
    },
    {
      "id": "10bff6ea6a3c497c8df8e2b9bc2614d8",
      "sender": "achow101",
      "payload": "jnewbery: I haven't looked at russ's branch in detail",
      "action": false,
      "timestamp": "2019-10-25T19:24:46+00:00"
    },
    {
      "id": "694747dab5cf4451a92b286d46b2bed7",
      "sender": "provoostenator",
      "payload": "Maybe the \"Refactor: Split up CWallet and LegacyScriptPubKeyMan and classes\" can split into one commit that introduces the class, and one that moves the methods over?",
      "action": false,
      "timestamp": "2019-10-25T19:24:51+00:00"
    },
    {
      "id": "9a7264d6e5aa4d23a758a7ad0bf7b0fb",
      "sender": "instagibbs",
      "payload": "that's the other thing true, you're going to force people to rebase 2+ times",
      "action": false,
      "timestamp": "2019-10-25T19:24:53+00:00"
    },
    {
      "id": "48fe6364a7ae4e14bfdd167d89ea7653",
      "sender": "instagibbs",
      "payload": "in serious ways",
      "action": false,
      "timestamp": "2019-10-25T19:24:59+00:00"
    },
    {
      "id": "ccb0879bb61f483581492c8aef443601",
      "sender": "meshcollider",
      "payload": "Well they can just wait til it's all in ^",
      "action": false,
      "timestamp": "2019-10-25T19:25:25+00:00"
    },
    {
      "id": "892350540da74f7bad2a507219072bff",
      "sender": "ryanofsky",
      "payload": "just to clarify my github comment from a few weeks ago, i'm fine if achow's pr is merged as is, i just wouldn't want my ack to be a deciding factor",
      "action": false,
      "timestamp": "2019-10-25T19:25:26+00:00"
    },
    {
      "id": "1111945ab8c344fbb85e014df19283de",
      "sender": "ryanofsky",
      "payload": "it's too many scattered changes that i don't fully understand to be confident about all of them",
      "action": false,
      "timestamp": "2019-10-25T19:26:12+00:00"
    },
    {
      "id": "84ef0229368446169e6e3fadbc2b4b6c",
      "sender": "jnewbery",
      "payload": "That's my main concern (separate from not being able to review it myself):I'm worried that due to the size of this PR, other people who have reviewed it haven't been able to do so in sufficient detail to avoid merging bugs",
      "action": false,
      "timestamp": "2019-10-25T19:26:35+00:00"
    },
    {
      "id": "7e08413a899b45a69b25e602d9144acc",
      "sender": "achow101",
      "payload": "ryanofsky: I think the only reason acks came in quickly after yours is because they were just waiting for you to be done asking for changes before commenting",
      "action": false,
      "timestamp": "2019-10-25T19:26:37+00:00"
    },
    {
      "id": "f54aa568efb444579da73f3d1f24c2c3",
      "sender": "meshcollider",
      "payload": "Yeah it is enormous, I'm feeling the same way",
      "action": false,
      "timestamp": "2019-10-25T19:26:43+00:00"
    },
    {
      "id": "d376f6462c2e4a309129923b2f85e2a1",
      "sender": "ryanofsky",
      "payload": "achow101, yes you're right i probably misinterpreted the timing",
      "action": false,
      "timestamp": "2019-10-25T19:27:15+00:00"
    },
    {
      "id": "1c99460eba6445cf8181de10a1f1ad47",
      "sender": "meshcollider",
      "payload": "That's why I want to merge it early on in the 0.20 release cycle so we have plenty of time to identify bugs before we get close to a release",
      "action": false,
      "timestamp": "2019-10-25T19:27:25+00:00"
    },
    {
      "id": "1ada188c6b94490da0752510a7afe278",
      "sender": "instagibbs",
      "payload": "Yes, I had reviewed once, then waited for velocity to stop, then reviewed the diff between the version I'd reviewed and tip. That said, it deserves more eyes",
      "action": false,
      "timestamp": "2019-10-25T19:27:53+00:00"
    },
    {
      "id": "2020ad172a61447293d6a66ceefc8f96",
      "sender": "meshcollider",
      "payload": "Smaller PRs would definitely encourage more reviews too",
      "action": false,
      "timestamp": "2019-10-25T19:28:29+00:00"
    },
    {
      "id": "cae54614c7a14bc79beab53c5d88f9cf",
      "sender": "ryanofsky",
      "payload": "meshcollider, i don't think this has to be an all or nothing thing merged early in the release cycle. you could merge the moves early, and then let all the little behavior changes get reviewed as normal",
      "action": false,
      "timestamp": "2019-10-25T19:28:48+00:00"
    },
    {
      "id": "ce890154f2624c87bfd8bde4f4a58289",
      "sender": "provoostenator",
      "payload": "For release cycle it doesn't matter much if we wait another week or two for proof-of-newbery",
      "action": false,
      "timestamp": "2019-10-25T19:28:50+00:00"
    },
    {
      "id": "219f929fa8c44e95915eb471ce8a59e5",
      "sender": "jnewbery",
      "payload": "I'm raising it because I'm not getting the sense from any of the reviewers who have ACKed that they're super confident",
      "action": false,
      "timestamp": "2019-10-25T19:29:15+00:00"
    },
    {
      "id": "f43b865b6fc24669b2362ea164fbe48f",
      "sender": "achow101",
      "payload": "I can try to break it up further based on ryanofsky's branch as it seems like people are okay with some big moveonlys and renames",
      "action": false,
      "timestamp": "2019-10-25T19:29:40+00:00"
    },
    {
      "id": "0f504cedc30d4995bc3395982b0fe4ad",
      "sender": "jnewbery",
      "payload": "achow101: thanks! I'll also try to take a look at ryanofsky's version next week",
      "action": false,
      "timestamp": "2019-10-25T19:30:18+00:00"
    },
    {
      "id": "7ec5124cc507485cbaa9863fb2b4d99c",
      "sender": "achow101",
      "payload": "if we want to do it in smaller prs, then I think we should feature freeze the wallet",
      "action": false,
      "timestamp": "2019-10-25T19:30:23+00:00"
    },
    {
      "id": "b646533285174537935241217b5e0782",
      "sender": "sipa",
      "payload": "(speaking as someone who has not looked at the changes in detail, but plans to)  big moveonlys are still fairly mechanically verifiable, regardless of size",
      "action": false,
      "timestamp": "2019-10-25T19:30:34+00:00"
    },
    {
      "id": "c6c294ed6a4245d0ac570449e9611daf",
      "sender": "ryanofsky",
      "payload": "yeah i think the first big commit which is completely moveonly is basically trivial",
      "action": false,
      "timestamp": "2019-10-25T19:31:19+00:00"
    },
    {
      "id": "08c25ba34d15405b9b16fdf39063e1b6",
      "sender": "achow101",
      "payload": "(now I just need to find ryanofsky's branch, I seem to be clikcing all the wrong \"Load more comments..\")",
      "action": false,
      "timestamp": "2019-10-25T19:31:40+00:00"
    },
    {
      "id": "a0ce8de07c1c48ddbc70cddb4921a847",
      "sender": "ryanofsky",
      "payload": "the second big commit which is the \"rename\" commit is kind of eyeglazing but still boring and reviewable i think",
      "action": false,
      "timestamp": "2019-10-25T19:31:51+00:00"
    },
    {
      "id": "b14caf8b3c23493eaf598fc465d3bc5f",
      "sender": "MarcoFalke",
      "payload": "Can this channel be opened again or at least mention in the title that log in is required?",
      "action": false,
      "timestamp": "2019-10-25T19:31:52+00:00"
    },
    {
      "id": "40898e93985947a099d48789e04e9583",
      "sender": "MarcoFalke",
      "payload": "People keep running into this issue",
      "action": false,
      "timestamp": "2019-10-25T19:31:59+00:00"
    },
    {
      "id": "84f9993192c1434990c80623e5370428",
      "sender": "meshcollider",
      "payload": "achow101: I'm happy to do that for a while because otherwise this is going to take forever to get in",
      "action": false,
      "timestamp": "2019-10-25T19:32:39+00:00"
    },
    {
      "id": "9ecc0935983b4761a3ede6c5a7e577e4",
      "sender": "provoostenator",
      "payload": "achow101: https://github.com/ryanofsky/bitcoin/commits/pr/keyman",
      "action": false,
      "timestamp": "2019-10-25T19:33:17+00:00"
    },
    {
      "id": "c84e2df8d0a54c4b8d8e5db99d22924a",
      "sender": "instagibbs",
      "payload": "if feature freeze is the plan, I think people should be allowed a window to squeeze in near-merged features :)",
      "action": false,
      "timestamp": "2019-10-25T19:33:46+00:00"
    },
    {
      "id": "07edfbd4592440b6b6d2418444cfedb8",
      "sender": "instagibbs",
      "payload": "with heads up",
      "action": false,
      "timestamp": "2019-10-25T19:33:49+00:00"
    },
    {
      "id": "93f1e231f44e41a68502137c641ae682",
      "sender": "instagibbs",
      "payload": "unless the freeze is like... a week",
      "action": false,
      "timestamp": "2019-10-25T19:34:10+00:00"
    },
    {
      "id": "6323a60591bb4c57a664fdccc68c7f50",
      "sender": "achow101",
      "payload": "I think some large-ish changes could also become scripted-diffs, so that will help review",
      "action": false,
      "timestamp": "2019-10-25T19:34:25+00:00"
    },
    {
      "id": "d39a25f6835f4caca327f743d200c79c",
      "sender": "ryanofsky",
      "payload": "i'm fine with a feature freeze, but not sure what a feature freeze would be doing...",
      "action": false,
      "timestamp": "2019-10-25T19:34:36+00:00"
    },
    {
      "id": "d99304592aed4bb4ab5fbc45229569ab",
      "sender": "jnewbery",
      "payload": "If ryanofsky's branch really is two big commits (that become the first PR) and then a bunch of small commits, I also don't understand the need for a feature freeze",
      "action": false,
      "timestamp": "2019-10-25T19:35:16+00:00"
    },
    {
      "id": "7d4152ac3ae34967b757070031bfaedc",
      "sender": "jnewbery",
      "payload": "it sounds like the disruptive rebasey part would be those first two commits",
      "action": false,
      "timestamp": "2019-10-25T19:35:28+00:00"
    },
    {
      "id": "1ec94a1571ad4dcab34fab65a50d6d02",
      "sender": "sipa",
      "payload": "i think it's simpler to have reviewers lined up for a \"it will be merged on day X\", and then the PR author can rebase that day exactly, everyone give a final ack, and it's merged",
      "action": false,
      "timestamp": "2019-10-25T19:35:33+00:00"
    },
    {
      "id": "99553242f3f8458fba2f7488bf65b9da",
      "sender": "jnewbery",
      "payload": "and once they're in they're in",
      "action": false,
      "timestamp": "2019-10-25T19:35:34+00:00"
    },
    {
      "id": "2b01e2a32cee4d76ad0448663c67e9d6",
      "sender": "ryanofsky",
      "payload": "yeah exactly all the commits are small and normal except 2",
      "action": false,
      "timestamp": "2019-10-25T19:35:43+00:00"
    },
    {
      "id": "365b803c054f40b99b86c01eb1d85528",
      "sender": "instagibbs",
      "payload": "ok provided you think it's only 1 painful break, fine",
      "action": false,
      "timestamp": "2019-10-25T19:37:02+00:00"
    },
    {
      "id": "9f7fd06c7b784a088b10cff18634bdc1",
      "sender": "ryanofsky",
      "payload": "if the concern is difficulty rebasing the 2 big commits, i've done than several times, and it hasn't been a big deal. can continue to do it if desired",
      "action": false,
      "timestamp": "2019-10-25T19:37:11+00:00"
    },
    {
      "id": "c14fb1ce72a34a25b38559612f17d982",
      "sender": "instagibbs",
      "payload": "let's just do that",
      "action": false,
      "timestamp": "2019-10-25T19:37:15+00:00"
    },
    {
      "id": "851a545c7b00404db01533609299ed87",
      "sender": "meshcollider",
      "payload": "Alright achow101 happy?",
      "action": false,
      "timestamp": "2019-10-25T19:37:21+00:00"
    },
    {
      "id": "6d42602aa6a24c6a83d8418bd4cba5e8",
      "sender": "achow101",
      "payload": "ok",
      "action": false,
      "timestamp": "2019-10-25T19:37:33+00:00"
    },
    {
      "id": "b0a9eb9f5e5547fca7111b9f295d855e",
      "sender": "meshcollider",
      "payload": "Sweet, any other topics?",
      "action": false,
      "timestamp": "2019-10-25T19:38:02+00:00"
    },
    {
      "id": "40e94a549c4c43f892a22f5bb20d39cf",
      "sender": "provoostenator",
      "payload": "achow101: if you're replacing the branch, please make a new PR...",
      "action": false,
      "timestamp": "2019-10-25T19:38:07+00:00"
    },
    {
      "id": "4ff03b009ae34dfbbf446fd1e0c2b1c8",
      "sender": "achow101",
      "payload": "yes, new prs will be opened",
      "action": false,
      "timestamp": "2019-10-25T19:38:18+00:00"
    },
    {
      "id": "01ea353bd7e94ca8866b381d807fdfdc",
      "sender": "jnewbery",
      "payload": "thanks!",
      "action": false,
      "timestamp": "2019-10-25T19:38:38+00:00"
    },
    {
      "id": "8eb2173d33e6496fbec727076e50acf3",
      "sender": "provoostenator",
      "payload": "Great, so I don't have to write a Chrome plugin to auto-click \"Load More...\"",
      "action": false,
      "timestamp": "2019-10-25T19:38:41+00:00"
    },
    {
      "id": "22441d0137c54fdebbad3266d373ad40",
      "sender": "meshcollider",
      "payload": "Please do that anyway :p",
      "action": false,
      "timestamp": "2019-10-25T19:38:54+00:00"
    },
    {
      "id": "3aa2d5782d994180a1bf374dbd65722d",
      "sender": "JeremyCrookshank",
      "payload": "Hello?",
      "action": false,
      "timestamp": "2019-10-25T19:39:56+00:00"
    },
    {
      "id": "db0b5f83999440a0ab0b86649db5fc56",
      "sender": "instagibbs",
      "payload": "since #16944 got un-scope-creeped, I think it's close to merge (selfish reminder)",
      "action": false,
      "timestamp": "2019-10-25T19:40:00+00:00"
    },
    {
      "id": "ddeec06382904784a26313c6680816be",
      "sender": "gribble",
      "payload": "https://github.com/bitcoin/bitcoin/issues/16944 | gui: create PSBT with watch-only wallet by Sjors \u00c3\u0082\u00c2\u00b7 Pull Request #16944 \u00c3\u0082\u00c2\u00b7 bitcoin/bitcoin \u00c3\u0082\u00c2\u00b7 GitHub",
      "action": false,
      "timestamp": "2019-10-25T19:40:03+00:00"
    },
    {
      "id": "119465bb948d4b65a3e0b3319b2def37",
      "sender": "instagibbs",
      "payload": "JeremyCrookshank, pong",
      "action": false,
      "timestamp": "2019-10-25T19:40:33+00:00"
    },
    {
      "id": "1d9504d032a24d1ab19e178ae1ba16dd",
      "sender": "JeremyCrookshank",
      "payload": "Oh thankgod people can see my messages now",
      "action": false,
      "timestamp": "2019-10-25T19:40:42+00:00"
    },
    {
      "id": "6910c274bdfe4e8995af3aa109945cb4",
      "sender": "JeremyCrookshank",
      "payload": ":)",
      "action": false,
      "timestamp": "2019-10-25T19:40:45+00:00"
    },
    {
      "id": "8d6f91648f3c4f08846e5d5df7eef4a7",
      "sender": "meshcollider",
      "payload": "Yep I'm going to take a look at that today instagibbs",
      "action": false,
      "timestamp": "2019-10-25T19:41:05+00:00"
    },
    {
      "id": "ed3547c95f8446b88aaf8e519f75cc57",
      "sender": "meshcollider",
      "payload": "#endmeeting",
      "action": false,
      "timestamp": "2019-10-25T19:41:15+00:00"
    }
  ],
  "events": [
    {
      "event_type": "START_MEETING",
      "message": {
        "id": "2738701a6be84880a8e7ee9198bb763b",
        "sender": "meshcollider",
        "payload": "#startmeeting",
        "action": false,
        "timestamp": "2019-10-25T19:00:21+00:00"
      },
      "operand": null,
      "id": "2738701a6be84880a8e7ee9198bb763b",
      "timestamp": "2019-10-25T19:00:21+00:00"
    },
    {
      "event_type": "LINK",
      "message": {
        "id": "c24098ad83c042868b3ab1d5ebc85f57",
        "sender": "gribble",
        "payload": "https://github.com/bitcoin/bitcoin/issues/16341 | Introduce ScriptPubKeyMan interface and use it for key and script management (aka wallet boxes) by achow101 \u00c3\u0082\u00c2\u00b7 Pull Request #16341 \u00c3\u0082\u00c2\u00b7 bitcoin/bitcoin \u00c3\u0082\u00c2\u00b7 GitHub",
        "action": false,
        "timestamp": "2019-10-25T19:03:26+00:00"
      },
      "operand": "https://github.com/bitcoin/bitcoin/issues/16341",
      "id": "c24098ad83c042868b3ab1d5ebc85f57",
      "timestamp": "2019-10-25T19:03:26+00:00"
    },
    {
      "event_type": "LINK",
      "message": {
        "id": "4863340d3797430084484ed7ce3730e2",
        "sender": "gribble",
        "payload": "https://github.com/bitcoin/bitcoin/issues/17246 | wallet: avoid knapsack when theres no change by Sjors \u00c3\u0082\u00c2\u00b7 Pull Request #17246 \u00c3\u0082\u00c2\u00b7 bitcoin/bitcoin \u00c3\u0082\u00c2\u00b7 GitHub",
        "action": false,
        "timestamp": "2019-10-25T19:10:04+00:00"
      },
      "operand": "https://github.com/bitcoin/bitcoin/issues/17246",
      "id": "4863340d3797430084484ed7ce3730e2",
      "timestamp": "2019-10-25T19:10:04+00:00"
    },
    {
      "event_type": "LINK",
      "message": {
        "id": "61099d52b6984f79af77b8499593c340",
        "sender": "gribble",
        "payload": "https://github.com/bitcoin/bitcoin/issues/16341 | Introduce ScriptPubKeyMan interface and use it for key and script management (aka wallet boxes) by achow101 \u00c3\u0082\u00c2\u00b7 Pull Request #16341 \u00c3\u0082\u00c2\u00b7 bitcoin/bitcoin \u00c3\u0082\u00c2\u00b7 GitHub",
        "action": false,
        "timestamp": "2019-10-25T19:11:16+00:00"
      },
      "operand": "https://github.com/bitcoin/bitcoin/issues/16341",
      "id": "61099d52b6984f79af77b8499593c340",
      "timestamp": "2019-10-25T19:11:16+00:00"
    },
    {
      "event_type": "TOPIC",
      "message": {
        "id": "a107ec6f01db4ef78db5ac09f15ce86c",
        "sender": "meshcollider",
        "payload": "#topic SPKM PR #16341 (jnewbery)",
        "action": false,
        "timestamp": "2019-10-25T19:18:19+00:00"
      },
      "operand": "SPKM PR #16341 (jnewbery)",
      "id": "a107ec6f01db4ef78db5ac09f15ce86c",
      "timestamp": "2019-10-25T19:18:19+00:00"
    },
    {
      "event_type": "LINK",
      "message": {
        "id": "5559b13f42a9407bbd45cafbd8a70f8d",
        "sender": "gribble",
        "payload": "https://github.com/bitcoin/bitcoin/issues/16341 | Introduce ScriptPubKeyMan interface and use it for key and script management (aka wallet boxes) by achow101 \u00c3\u0082\u00c2\u00b7 Pull Request #16341 \u00c3\u0082\u00c2\u00b7 bitcoin/bitcoin \u00c3\u0082\u00c2\u00b7 GitHub",
        "action": false,
        "timestamp": "2019-10-25T19:18:22+00:00"
      },
      "operand": "https://github.com/bitcoin/bitcoin/issues/16341",
      "id": "5559b13f42a9407bbd45cafbd8a70f8d",
      "timestamp": "2019-10-25T19:18:22+00:00"
    },
    {
      "event_type": "LINK",
      "message": {
        "id": "ddeec06382904784a26313c6680816be",
        "sender": "gribble",
        "payload": "https://github.com/bitcoin/bitcoin/issues/16944 | gui: create PSBT with watch-only wallet by Sjors \u00c3\u0082\u00c2\u00b7 Pull Request #16944 \u00c3\u0082\u00c2\u00b7 bitcoin/bitcoin \u00c3\u0082\u00c2\u00b7 GitHub",
        "action": false,
        "timestamp": "2019-10-25T19:40:03+00:00"
      },
      "operand": "https://github.com/bitcoin/bitcoin/issues/16944",
      "id": "ddeec06382904784a26313c6680816be",
      "timestamp": "2019-10-25T19:40:03+00:00"
    },
    {
      "event_type": "END_MEETING",
      "message": {
        "id": "ed3547c95f8446b88aaf8e519f75cc57",
        "sender": "meshcollider",
        "payload": "#endmeeting",
        "action": false,
        "timestamp": "2019-10-25T19:41:15+00:00"
      },
      "operand": null,
      "id": "ed3547c95f8446b88aaf8e519f75cc57",
      "timestamp": "2019-10-25T19:41:15+00:00"
    }
  ],
  "aliases": {},
  "vote_in_progress": false,
  "motion_index": null
}